swebb2066 merged PR #495:
URL: https://github.com/apache/logging-log4cxx/pull/495
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr
swebb2066 commented on PR #495:
URL: https://github.com/apache/logging-log4cxx/pull/495#issuecomment-2815290095
Please also change the .cpp files so building with `LOG4CXX_ABI_VER=16` works
```
diff --git a/src/main/cpp/aprserversocket.cpp
b/src/main/cpp/aprserversocket.cpp
index 53
swebb2066 commented on PR #495:
URL: https://github.com/apache/logging-log4cxx/pull/495#issuecomment-2814831567
To assist with the migration to the next ABI version, could you please also
test the LOG4CXX_ABI_VERSION. For example:
```
diff --git a/src/main/include/log4cxx/helpers/serve
swebb2066 commented on PR #495:
URL: https://github.com/apache/logging-log4cxx/pull/495#issuecomment-2814673206
Also, to fix an existing test case fragility:
```
diff --git a/src/test/cpp/net/socketappendertestcase.cpp
b/src/test/cpp/net/socketappendertestcase.cpp
index 2d5accdd..60
swebb2066 commented on PR #495:
URL: https://github.com/apache/logging-log4cxx/pull/495#issuecomment-2814499951
Could you also add to the telnetappender unit test please
```
diff --git a/src/test/cpp/net/telnetappendertestcase.cpp
b/src/test/cpp/net/telnetappendertestcase.cpp
index
michieldwitte commented on PR #495:
URL: https://github.com/apache/logging-log4cxx/pull/495#issuecomment-2813301614
Made the default `false` as to keep consistency with the previous behavior
as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, p
rm5248 commented on code in PR #495:
URL: https://github.com/apache/logging-log4cxx/pull/495#discussion_r2049170842
##
src/main/include/log4cxx/private/aprserversocket.h:
##
@@ -31,7 +31,7 @@ namespace helpers
class LOG4CXX_EXPORT APRServerSocket : public helpers::ServerSocket
michieldwitte commented on PR #495:
URL: https://github.com/apache/logging-log4cxx/pull/495#issuecomment-2812831699
Made some edits as we need to be able to set the option before
`apr_socket_bind`.
I opted to pass it to the constructor, let me know if there are other edits
required.
T
michieldwitte closed pull request #495: Add SO_REUSEADDR to APRServerSocket
URL: https://github.com/apache/logging-log4cxx/pull/495
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific commen
swebb2066 commented on code in PR #495:
URL: https://github.com/apache/logging-log4cxx/pull/495#discussion_r2048844621
##
src/main/cpp/telnetappender.cpp:
##
@@ -135,6 +137,10 @@ void TelnetAppender::setOption(const LogString& option,
{
setEncoding(value)
swebb2066 commented on PR #495:
URL: https://github.com/apache/logging-log4cxx/pull/495#issuecomment-2812715162
> I would prefer "ReuseAddress"
The option name is not super important to me, as any single word is
inadequate.
The most important thing to do is ensure the document
michieldwitte commented on PR #495:
URL: https://github.com/apache/logging-log4cxx/pull/495#issuecomment-2812132739
Not much a fan of "QuickReconnect", I would prefer "ReuseAddress" as this
will be much more recognizable for anyone who has dealt with sockets.
--
This is an automated messa
swebb2066 commented on PR #495:
URL: https://github.com/apache/logging-log4cxx/pull/495#issuecomment-2811587276
Given [the uncertainty around this socket
option](https://stackoverflow.com/questions/3229860/what-is-the-meaning-of-so-reuseaddr-setsockopt-option-linux),
could you also add a Al
swebb2066 commented on PR #495:
URL: https://github.com/apache/logging-log4cxx/pull/495#issuecomment-2811361715
Are you using the telnet appender?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
michieldwitte opened a new pull request, #495:
URL: https://github.com/apache/logging-log4cxx/pull/495
Setting SO_REUSEADDR by default allows server applications to restart and
bind to the same address and port without waiting for the OS to fully clean up
previous connections. This avoids t
15 matches
Mail list logo
