ppkarwasz commented on issue #3336:
URL:
https://github.com/apache/logging-log4j2/issues/3336#issuecomment-2951766099
Hi @jhl221123,
> I'd be grateful if you could take a look when you have a moment. Thanks!
Thanks so much for your PR—and apologies for the delay in reviewing it
jhl221123 commented on issue #3336:
URL:
https://github.com/apache/logging-log4j2/issues/3336#issuecomment-2949633820
Hi @ppkarwasz,
I came across #3176. Noticing the previous pull request had been closed,
I've now opened a new PR to address this.
I'd be grateful if you could
Suvrat1629 commented on issue #3336:
URL:
https://github.com/apache/logging-log4j2/issues/3336#issuecomment-2589242095
Yes you can assign it to me, also can you guide me with the test cases
changes as the ScriptFilterTest.java seems to be consistent with my code is
there any file that i ne
ppkarwasz commented on issue #3336:
URL:
https://github.com/apache/logging-log4j2/issues/3336#issuecomment-2589161735
@Suvrat1629,
Yes, if you want to contribute the fix, you should add some tests. See the
[PR
template](https://github.com/apache/logging-log4j2/blob/2.x/.github/pull_
Suvrat1629 commented on issue #3336:
URL:
https://github.com/apache/logging-log4j2/issues/3336#issuecomment-2589135387
Ok, I did make the changes as you suggested by using the start() method.
What more changes do i need to make now? Do i need to change the testcases or
anything?
--
This
ppkarwasz commented on issue #3336:
URL:
https://github.com/apache/logging-log4j2/issues/3336#issuecomment-2588194067
The fix must be done in code.
The basic problem is that the resolution of script references is done in
constructors or factory methods of script-enabled components. F
Suvrat1629 commented on issue #3336:
URL:
https://github.com/apache/logging-log4j2/issues/3336#issuecomment-2588101559
(I am new to open source contribution and trying to understand the code)
Are the changes mentioned in the issue to be made in the log4j2.xml file or
the log4j2.json?
-
