Re: [I] Add API to List Supported Configuration File Locations [logging-log4j2]

2025-07-19 Thread via GitHub
ppkarwasz commented on issue #3775: URL: https://github.com/apache/logging-log4j2/issues/3775#issuecomment-3092156782 Hi @yybmion, > ```java > public static String[] getSupportedConfigurationExtensions() { > final List extensions = new ArrayList<>(); > for (final Conf

[I] Bugwards incompatibility in Log4j2 properties config parsing since 2.25.0 [logging-log4j2]

2025-07-18 Thread via GitHub
rschmitt opened a new issue, #3836: URL: https://github.com/apache/logging-log4j2/issues/3836 ## Description A bad Log4j2 properties file will cause an exception to be thrown from `PropertiesConfigurationBuilder`, whereas previous versions would fall back to the default logging confi

[I] Regression in default logging configuration since 2.25.0 [logging-log4j2]

2025-07-18 Thread via GitHub
rschmitt opened a new issue, #3835: URL: https://github.com/apache/logging-log4j2/issues/3835 ## Description The default logging configuration in `log4j-core` has clearly regressed, with newlines no longer being emitted. ## Configuration **Version:** 2.25.0 and 2.25.1

Re: [PR] Bump jackson.version from 2.19.1 to 2.19.2 [logging-log4j-transform]

2025-07-18 Thread via GitHub
github-actions[bot] merged PR #209: URL: https://github.com/apache/logging-log4j-transform/pull/209 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: noti

Re: [PR] Bump com.fasterxml.jackson:jackson-bom from 2.19.1 to 2.19.2 [logging-log4j-transform]

2025-07-18 Thread via GitHub
github-actions[bot] merged PR #208: URL: https://github.com/apache/logging-log4j-transform/pull/208 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: noti

Re: [PR] Correct log message format in `AbstractDriverManagerConnectionSource` [logging-log4j2]

2025-07-18 Thread via GitHub
jhl221123 commented on PR #3831: URL: https://github.com/apache/logging-log4j2/pull/3831#issuecomment-308978 Hi @ppkarwasz, Thank you for the feedback and the very kind words! I've added the changelog entry as requested. I'm honored by the offer to connect and discuss getti

Re: [I] Produce single file (logging-log4net)

2025-07-18 Thread via GitHub
ringchenhao commented on issue #263: URL: https://github.com/apache/logging-log4net/issues/263#issuecomment-3088810169 > Hi, I can try. Can you upload the code and binaries for repro? Help~~~ -- This is an automated message from the Apache Git Service. To respond to the message, pl

[PR] Maven: Repro for issue 3834 [logging-log4j-samples]

2025-07-18 Thread via GitHub
rob975 opened a new pull request, #352: URL: https://github.com/apache/logging-log4j-samples/pull/352 This is a PR that addresses https://github.com/apache/logging-log4j2/issues/3834#issuecomment-3085025523. Command: ``` mvn -X package -pl :log4j-assembly-test -am ``` will sho

Re: [I] Add API to List Supported Configuration File Locations [logging-log4j2]

2025-07-18 Thread via GitHub
yybmion commented on issue #3775: URL: https://github.com/apache/logging-log4j2/issues/3775#issuecomment-3088337699 Thanks for guidance @ppkarwasz! Based on the discussion above, I'm proposing to add this static method to ConfigurationFactory ```java /** * Returns configuration

Re: [I] Failed to build parent project for org.apache.logging.log4j:log4j-api:jar:2.25.1 [logging-log4j2]

2025-07-17 Thread via GitHub
ppkarwasz commented on issue #3834: URL: https://github.com/apache/logging-log4j2/issues/3834#issuecomment-3085025523 Hi @rob975, It turns out the fix for the `error_prone` issue was ineffective due to an oversight on my part (see #3822). The core problem is that we don’t currentl

Re: [I] Add Support for Custom Headers in SMTP Appender [logging-log4j2]

2025-07-17 Thread via GitHub
ppkarwasz commented on issue #3704: URL: https://github.com/apache/logging-log4j2/issues/3704#issuecomment-3084857545 Hi @sidhantmourya, > I'm now looking at how to implement PatternLayout support for headers similar to how SubjectSerializer works. > https://github.com/apache/l

[I] Failed to build parent project for org.apache.logging.log4j:log4j-api:jar:2.25.1 [logging-log4j2]

2025-07-17 Thread via GitHub
rob975 opened a new issue, #3834: URL: https://github.com/apache/logging-log4j2/issues/3834 ## Description Last week I opened issue #3813 and tested the release candidate for version `2.25.1` as suggested. It worked fine. Today I upgraded to version `2.25.1` and the issue is not so

Re: [I] Add Support for Custom Headers in SMTP Appender [logging-log4j2]

2025-07-17 Thread via GitHub
sidhantmourya commented on issue #3704: URL: https://github.com/apache/logging-log4j2/issues/3704#issuecomment-3084605338 Hi @ppkarwasz, After reading through the documentation, I've updated the header handling to properly encode and fold values per RFC 5322 requirements. The current im

Re: [PR] Correct log message format in `AbstractDriverManagerConnectionSource` [logging-log4j2]

2025-07-17 Thread via GitHub
ppkarwasz commented on PR #3831: URL: https://github.com/apache/logging-log4j2/pull/3831#issuecomment-3084175593 Hi @jhl221123, Could you please add a changelog entry to this PR? While it's just a one-liner, it addresses a concrete issue reported by a user and deserves to be document

[I] Create a standalone artifact for non-internal test fixtures [logging-log4j2]

2025-07-16 Thread via GitHub
ppkarwasz opened a new issue, #3832: URL: https://github.com/apache/logging-log4j2/issues/3832 The current `log4j-core-test` module includes a variety of test fixtures primarily designed to test Log4j Core itself and its internal plugins. These fixtures assume that: * Static loggers

Re: [I] Produce single file (logging-log4net)

2025-07-16 Thread via GitHub
ringchenhao commented on issue #263: URL: https://github.com/apache/logging-log4net/issues/263#issuecomment-3082626734 Create a .NET 8.0 console application with the following main code, then publish the program with the "Generate single file" option enabled. When executing the published p

Re: [I] Produce single file (logging-log4net)

2025-07-16 Thread via GitHub
ringchenhao commented on issue #263: URL: https://github.com/apache/logging-log4net/issues/263#issuecomment-3082620760 App.config :

Re: [I] Produce single file (logging-log4net)

2025-07-16 Thread via GitHub
ringchenhao commented on issue #263: URL: https://github.com/apache/logging-log4net/issues/263#issuecomment-3082612491 using log4net; using log4net.Config; [assembly: XmlConfigurator(Watch = true)] namespace Log4NetExample { internal class Program {

Re: [PR] Prevent potential deadlock on shutdown when using AsyncAppender [logging-log4cxx]

2025-07-16 Thread via GitHub
swebb2066 merged PR #511: URL: https://github.com/apache/logging-log4cxx/pull/511 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr

Re: [PR] Correct log message format in `AbstractDriverManagerConnectionSource` [logging-log4j2]

2025-07-16 Thread via GitHub
github-actions[bot] commented on PR #3831: URL: https://github.com/apache/logging-log4j2/pull/3831#issuecomment-3080201580 Job Requested goals Build Tool Version Build Outcome Build Scan® build-

Re: [PR] Bump maven.version from 3.9.10 to 3.9.11 [logging-log4j-transform]

2025-07-16 Thread via GitHub
github-actions[bot] merged PR #207: URL: https://github.com/apache/logging-log4j-transform/pull/207 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: noti

Re: [I] Add Support for Custom Headers in SMTP Appender [logging-log4j2]

2025-07-16 Thread via GitHub
ppkarwasz commented on issue #3704: URL: https://github.com/apache/logging-log4j2/issues/3704#issuecomment-3080017458 Hi @sidhantmourya, Thanks for digging into this! I must admit that when I introduced the Jakarta version of the SMTP appender, I only added a minimal abstracti

Re: [I] Missing property in the log4j-parent pom file in version 2.25.0 [logging-log4j2]

2025-07-16 Thread via GitHub
ppkarwasz commented on issue #3779: URL: https://github.com/apache/logging-log4j2/issues/3779#issuecomment-3079567495 Hi @recaph, Thanks for reporting this! The message you're seeing appears to be generated by the [Spring Dependency Management Plugin](https://docs.spring.io/s

Re: [I] Add Support for Custom Headers in SMTP Appender [logging-log4j2]

2025-07-16 Thread via GitHub
sidhantmourya commented on issue #3704: URL: https://github.com/apache/logging-log4j2/issues/3704#issuecomment-3079210657 @ppkarwasz I'm adding custom header support to the SMTP appender similar to the HTTP appender, but need guidance on handling the javax.mail vs jakarta.mail MimeMessage

Re: [I] Missing property in the log4j-parent pom file in version 2.25.0 [logging-log4j2]

2025-07-16 Thread via GitHub
recaph commented on issue #3779: URL: https://github.com/apache/logging-log4j2/issues/3779#issuecomment-3078816844 getting similar error with log4j 2.25.1 and Spring Boot 2.7 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[PR] Correct log message format in `AbstractDriverManagerConnectionSource` [logging-log4j2]

2025-07-16 Thread via GitHub
jhl221123 opened a new pull request, #3831: URL: https://github.com/apache/logging-log4j2/pull/3831 The debug log message in `AbstractDriverManagerConnectionSource` had 4 placeholders but was supplied with 5 arguments. This corrects the format string to match the argument count, resolving t

Re: [I] Produce single file (logging-log4net)

2025-07-16 Thread via GitHub
ringchenhao closed issue #263: Produce single file URL: https://github.com/apache/logging-log4net/issues/263 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-m

Re: [I] Produce single file (logging-log4net)

2025-07-16 Thread via GitHub
ringchenhao commented on issue #263: URL: https://github.com/apache/logging-log4net/issues/263#issuecomment-3077336674 I have identified that this issue is related to another third-party library, SystemCore. When using log4net alone, the verification passes successfully, and logs are gener

Re: [I] Produce single file (logging-log4net)

2025-07-15 Thread via GitHub
gdziadkiewicz commented on issue #263: URL: https://github.com/apache/logging-log4net/issues/263#issuecomment-3076717649 Hi, I can try. Can you upload the code and binaries for repro? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] Prevent potential deadlock on shutdown when using AsyncAppender [logging-log4cxx]

2025-07-15 Thread via GitHub
swebb2066 commented on code in PR #511: URL: https://github.com/apache/logging-log4cxx/pull/511#discussion_r2209155149 ## src/examples/cpp/MyApp1.cpp: ## @@ -20,5 +20,6 @@ int main(int argc, char **argv) { LOG4CXX_INFO(logger, "Entering application."); foo();

Re: [PR] Prevent potential deadlock on shutdown when using AsyncAppender [logging-log4cxx]

2025-07-15 Thread via GitHub
swebb2066 commented on code in PR #511: URL: https://github.com/apache/logging-log4cxx/pull/511#discussion_r2209155149 ## src/examples/cpp/MyApp1.cpp: ## @@ -20,5 +20,6 @@ int main(int argc, char **argv) { LOG4CXX_INFO(logger, "Entering application."); foo();

Re: [PR] Prevent potential deadlock on shutdown when using AsyncAppender [logging-log4cxx]

2025-07-15 Thread via GitHub
swebb2066 commented on code in PR #511: URL: https://github.com/apache/logging-log4cxx/pull/511#discussion_r2209109613 ## src/examples/cpp/MyApp1.cpp: ## @@ -20,5 +20,6 @@ int main(int argc, char **argv) { LOG4CXX_INFO(logger, "Entering application."); foo();

Re: [PR] Prevent potential deadlock on shutdown when using AsyncAppender [logging-log4cxx]

2025-07-15 Thread via GitHub
swebb2066 commented on code in PR #511: URL: https://github.com/apache/logging-log4cxx/pull/511#discussion_r2209107114 ## src/examples/cpp/MyApp1.cpp: ## @@ -1,11 +1,11 @@ -#include +#include #include -static auto logger = log4cxx::Logger::getLogger("MyApp"); Review Comme

Re: [PR] Prevent potential deadlock on shutdown when using AsyncAppender [logging-log4cxx]

2025-07-15 Thread via GitHub
rm5248 commented on code in PR #511: URL: https://github.com/apache/logging-log4cxx/pull/511#discussion_r2209095595 ## src/examples/cpp/MyApp1.cpp: ## @@ -1,11 +1,11 @@ -#include +#include #include -static auto logger = log4cxx::Logger::getLogger("MyApp"); Review Comment:

[I] Produce single file (logging-log4net)

2025-07-15 Thread via GitHub
ringchenhao opened a new issue, #263: URL: https://github.com/apache/logging-log4net/issues/263 When publishing a C# application with .NET 8.0 framework, if the "Produce single file" option is enabled in the publish settings, testing the generated EXE reveals that neither the log folder nor

Re: [I] Short-lived macOS program with MultiprocessRollingFileAppender and AsyncAppender hangs upon exit with EXC_BAD_ACCESS in a worker thread [logging-log4cxx]

2025-07-15 Thread via GitHub
swebb2066 commented on issue #510: URL: https://github.com/apache/logging-log4cxx/issues/510#issuecomment-3076461698 Your application must call `LogManager::shutdown` when it exits to prevent undefined behaviour when using this appender. I have updated the documentation in #511 -

Re: [PR] Upgrade Jackson from 2.x to 3.0.0-rc5 [logging-log4j2]

2025-07-15 Thread via GitHub
kurtostfeld commented on PR #3701: URL: https://github.com/apache/logging-log4j2/pull/3701#issuecomment-3075170184 @ppkarwasz awesome. I suspected it was a flaky test. thank you. If there are issues with the Jackson 3.0 upgrade, I'd like to help investigate and resolve them. I use log4j on

[I] Badly formatted status msg in AbstractDriverManagerConnectionSource [logging-log4j2]

2025-07-15 Thread via GitHub
ppkarwasz opened a new issue, #3828: URL: https://github.com/apache/logging-log4j2/issues/3828 ### Discussed in https://github.com/apache/logging-log4j2/discussions/3827 Originally posted by **RichMacDonald** July 15, 2025 Version 2.24.3 org.apache.logging.log4j.core.ap

Re: [PR] Gradle: Add `buildSrc` to the sample project [logging-log4j-samples]

2025-07-15 Thread via GitHub
MartyIX commented on PR #350: URL: https://github.com/apache/logging-log4j-samples/pull/350#issuecomment-3074490645 That's great insight! I opened #351 which reports the error. I'm closing this PR. -- This is an automated message from the Apache Git Service. To respond to the mess

Re: [PR] Gradle: Add `buildSrc` to the sample project [logging-log4j-samples]

2025-07-15 Thread via GitHub
MartyIX closed pull request #350: Gradle: Add `buildSrc` to the sample project URL: https://github.com/apache/logging-log4j-samples/pull/350 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[PR] Gradle: Repro for issue 3779 [logging-log4j-samples]

2025-07-15 Thread via GitHub
MartyIX opened a new pull request, #351: URL: https://github.com/apache/logging-log4j-samples/pull/351 This is a PR that addresses https://github.com/apache/logging-log4j-samples/pull/350#issuecomment-3069913098. Now, this command ``` export LOG4J_VERSION=2.25.1; ./gradlew :

[PR] Prevent potential deadlock on shutdown when using AsyncAppender [logging-log4cxx]

2025-07-15 Thread via GitHub
swebb2066 opened a new pull request, #511: URL: https://github.com/apache/logging-log4cxx/pull/511 When the application does not call LogManager::shutdown before program exit, the single LogLog instance is destroyed before AsynAppender terminates. Undefined behaviour (use-after-free) arises

Re: [PR] Gradle: Add `buildSrc` to the sample project [logging-log4j-samples]

2025-07-14 Thread via GitHub
ppkarwasz commented on PR #350: URL: https://github.com/apache/logging-log4j-samples/pull/350#issuecomment-3069913098 Hi @MartyIX, Thanks again for digging into this — even negative results are valuable, as they help us identify what might be missing in the test project. Based

Re: [PR] Bump org.apache.logging.log4j:log4j-bom from 2.25.0 to 2.25.1 [logging-log4j-audit-sample]

2025-07-14 Thread via GitHub
github-actions[bot] merged PR #81: URL: https://github.com/apache/logging-log4j-audit-sample/pull/81 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: not

[PR] Bump org.apache.logging.log4j:log4j-bom from 2.25.0 to 2.25.1 [logging-log4j-audit-sample]

2025-07-14 Thread via GitHub
dependabot[bot] opened a new pull request, #81: URL: https://github.com/apache/logging-log4j-audit-sample/pull/81 [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=org.apache.logging.log4j:log4j-bom&package-manager=m

Re: [I] Missing property in the log4j-parent pom file in version 2.25.0 [logging-log4j2]

2025-07-14 Thread via GitHub
MartyIX commented on issue #3779: URL: https://github.com/apache/logging-log4j2/issues/3779#issuecomment-3069541792 I created https://github.com/apache/logging-log4j-samples/pull/350 but anyone who understand Gradle better than is likely needed to finish it. -- This is an automated messa

[PR] Gradle: Add `buildSrc` to the sample project [logging-log4j-samples]

2025-07-14 Thread via GitHub
MartyIX opened a new pull request, #350: URL: https://github.com/apache/logging-log4j-samples/pull/350 This is an attempt to add `buildSrc` for https://github.com/apache/logging-log4j2/issues/3822 to address https://github.com/apache/logging-log4j2/issues/3779#issuecomment-3064916603.

Re: [I] Using log4j-to-slf4j in a web application incorrectly sets a value in a ThreadLocal in org.apache.logging.slf4j.SLF4JLogger [logging-log4j2]

2025-07-14 Thread via GitHub
gmiscione commented on issue #3819: URL: https://github.com/apache/logging-log4j2/issues/3819#issuecomment-3069416278 Code looks ok and now the ThreadLocal is properly gated. Thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log o

Re: [I] Using log4j-to-slf4j in a web application incorrectly sets a value in a ThreadLocal in org.apache.logging.slf4j.SLF4JLogger [logging-log4j2]

2025-07-14 Thread via GitHub
ppkarwasz commented on issue #3819: URL: https://github.com/apache/logging-log4j2/issues/3819#issuecomment-3069173172 > I don't know if Logback has support for something similar to this pooling that can help in similar cases. Logback does **not** support object pooling in this contex

[PR] fix: Prevent `LogBuilder` memory leak in Log4j API to Logback bridge [logging-log4j2]

2025-07-14 Thread via GitHub
ppkarwasz opened a new pull request, #3824: URL: https://github.com/apache/logging-log4j2/pull/3824 This change fixes a potential memory leak in the `log4j-to-slf4j` module (Logback Log4j API binding) caused by the use of a thread-local `LogBuilder` pool. The leak occurred because th

Re: [I] v3.1.0 does not allow empty file names anymore for RollingFileAppender (logging-log4net)

2025-07-14 Thread via GitHub
mordio commented on issue #260: URL: https://github.com/apache/logging-log4net/issues/260#issuecomment-3069116897 FYI: I am using `.NET Framework v4.8` for the project using log4net. So I can confirm it works for that version. -- This is an automated message from the Apache Git Service.

Re: [I] Using log4j-to-slf4j in a web application incorrectly sets a value in a ThreadLocal in org.apache.logging.slf4j.SLF4JLogger [logging-log4j2]

2025-07-14 Thread via GitHub
gmiscione commented on issue #3819: URL: https://github.com/apache/logging-log4j2/issues/3819#issuecomment-3068154118 I am no expert in low latency programming, but the use case you are describing makes perfect sense. I don't know if Logback has support for something similar to this poolin

Re: [I] Short-lived macOS program with MultiprocessRollingFileAppender and AsyncAppender hangs upon exit with EXC_BAD_ACCESS in a worker thread [logging-log4cxx]

2025-07-13 Thread via GitHub
RK-BFX commented on issue #510: URL: https://github.com/apache/logging-log4cxx/issues/510#issuecomment-3068025007 I'll submit a PR with a fix soon. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[I] Short-lived macOS program with MultiprocessRollingFileAppender and AsyncAppender hangs upon exit with EXC_BAD_ACCESS in a worker thread [logging-log4cxx]

2025-07-13 Thread via GitHub
RK-BFX opened a new issue, #510: URL: https://github.com/apache/logging-log4cxx/issues/510 **General:** I build Log4cxx from sources in macOS with `LOG4CXX_MULTIPROCESS_ROLLING_FILE_APPENDER=on` with all dependencies linked statically in order to avoid adding any dylib (DSO) dependencies, b

Re: [I] Using log4j-to-slf4j in a web application incorrectly sets a value in a ThreadLocal in org.apache.logging.slf4j.SLF4JLogger [logging-log4j2]

2025-07-13 Thread via GitHub
ppkarwasz commented on issue #3819: URL: https://github.com/apache/logging-log4j2/issues/3819#issuecomment-3067246866 > Just out of curiosity, what is exactly the use case for the pooling of those builders? When are they supposed to be used? We have some users in latency-sensitive do

Re: [I] Add Support for Custom Headers in SMTP Appender [logging-log4j2]

2025-07-13 Thread via GitHub
ppkarwasz commented on issue #3704: URL: https://github.com/apache/logging-log4j2/issues/3704#issuecomment-3067242002 Hi @sidhantmourya, Thanks for volunteering! We really appreciate contributions — all issues are open for community help, especially since we receive more requests tha

Re: [I] Add Support for Custom Headers in SMTP Appender [logging-log4j2]

2025-07-13 Thread via GitHub
sidhantmourya commented on issue #3704: URL: https://github.com/apache/logging-log4j2/issues/3704#issuecomment-3067226687 Hello @ppkarwasz , I'd like to contribute to this enhancement. Is this issue currently open for contribution? If so, could you please guide me on where to

Re: [I] Using log4j-to-slf4j in a web application incorrectly sets a value in a ThreadLocal in org.apache.logging.slf4j.SLF4JLogger [logging-log4j2]

2025-07-13 Thread via GitHub
gmiscione commented on issue #3819: URL: https://github.com/apache/logging-log4j2/issues/3819#issuecomment-3067120765 Hi, @ppkarwasz, first of all, thank you for having acknowledged the issue. I have to be honest and admit that I am no expert in the Logback world, I am just a user of th

Re: [I] DirectWriteRolloverStrategy and SizeBasedTriggeringPolicy [logging-log4j2]

2025-07-13 Thread via GitHub
ppkarwasz commented on issue #3697: URL: https://github.com/apache/logging-log4j2/issues/3697#issuecomment-3067064984 Hi @Class-New, Apologies for the delayed response — we're doing our best to respond to all issues despite limited time, but occasionally some slip through the cracks.

Re: [I] Missing property in the log4j-parent pom file in version 2.25.0 [logging-log4j2]

2025-07-13 Thread via GitHub
ppkarwasz commented on issue #3779: URL: https://github.com/apache/logging-log4j2/issues/3779#issuecomment-3067057529 > I can try to carve out some time but my understanding of Gradle and its dependency system is pretty basic. That would be very much appreciated! As you can probably

Re: [I] Using log4j-to-slf4j in a web application incorrectly sets a value in a ThreadLocal in org.apache.logging.slf4j.SLF4JLogger [logging-log4j2]

2025-07-13 Thread via GitHub
ppkarwasz commented on issue #3819: URL: https://github.com/apache/logging-log4j2/issues/3819#issuecomment-3067054551 Hi @gmiscione, Great catch — thanks for reporting this! :100: I see two possible approaches to address the issue: 1. **Fix the misuse of `ThreadLocal`**

Re: [PR] Make `StatusLogger` self-contained and testable [logging-log4j2]

2025-07-13 Thread via GitHub
ppkarwasz commented on PR #2249: URL: https://github.com/apache/logging-log4j2/pull/2249#issuecomment-3067027459 Hi @vy, It looks like this change isn't mentioned in the [2.23.0 release notes](https://logging.apache.org/log4j/2.x/release-notes.html#release-notes-2-23-0), even though—

Re: [PR] Feature/2.x/enumerating and exposing named patters [logging-log4j2]

2025-07-13 Thread via GitHub
ppkarwasz commented on PR #3789: URL: https://github.com/apache/logging-log4j2/pull/3789#issuecomment-3066741660 > @ppkarwasz, consider users having their custom instant formatters, some might even be relying on `{Fixed,Fast}DateFormat`. They will get excited about `NamedInstantPattern`, wi

Re: [PR] Feature/2.x/enumerating and exposing named patters [logging-log4j2]

2025-07-13 Thread via GitHub
ppkarwasz commented on code in PR #3789: URL: https://github.com/apache/logging-log4j2/pull/3789#discussion_r2203224449 ## log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/NamedInstantPattern.java: ## @@ -0,0 +1,163 @@ +/* + * Licensed to the Apache Software Founda

Re: [I] Missing property in the log4j-parent pom file in version 2.25.0 [logging-log4j2]

2025-07-12 Thread via GitHub
MartyIX commented on issue #3779: URL: https://github.com/apache/logging-log4j2/issues/3779#issuecomment-3065627433 > Since this issue cannot be detected by our current [Gradle Integration Test](https://github.com/apache/logging-log4j-samples/tree/main/log4j-samples-gradle-metadata), would

Re: [I] Missing property in the log4j-parent pom file in version 2.25.0 [logging-log4j2]

2025-07-12 Thread via GitHub
ppkarwasz commented on issue #3779: URL: https://github.com/apache/logging-log4j2/issues/3779#issuecomment-3065139812 Hi @MartyIX, Thank you for the detailed feedback. The resolution of the `com.google.errorprone:error_prone_annotations` dependency in the **consumer** POM (as

[I] Ineffective fix of #3779 [logging-log4j2]

2025-07-12 Thread via GitHub
ppkarwasz opened a new issue, #3822: URL: https://github.com/apache/logging-log4j2/issues/3822 Unfortunately, PR #3785 did **not** resolve #3779. I mistakenly applied the new `error-prone-annotations.version` property only to the Gradle Module Metadata plugin configuration: https://

Re: [PR] fix: Define version of `error_prone_annotations` in parent POM [logging-log4j2]

2025-07-12 Thread via GitHub
ppkarwasz commented on PR #3785: URL: https://github.com/apache/logging-log4j2/pull/3785#issuecomment-3065118310 Unfortunately, this PR did **not** resolve #3779. I mistakenly applied the new `error-prone-annotations.version` property only to the Gradle Module Metadata plugin configuration:

Re: [I] Missing property in the log4j-parent pom file in version 2.25.0 [logging-log4j2]

2025-07-12 Thread via GitHub
MartyIX commented on issue #3779: URL: https://github.com/apache/logging-log4j2/issues/3779#issuecomment-3064916603 I tried upgrading to 2.25.1 (released today) and I still see ``` > Task :buildSrc:jar Errors occurred while building effective model from /Users/myuser/.gradle/c

Re: [PR] Escape '&' and '"' in html attribute data [logging-log4cxx]

2025-07-11 Thread via GitHub
swebb2066 merged PR #509: URL: https://github.com/apache/logging-log4cxx/pull/509 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr

Re: [PR] Bump org.apache.logging.log4j:log4j-bom from 2.25.0 to 2.25.1 [logging-log4j-transform]

2025-07-11 Thread via GitHub
github-actions[bot] merged PR #206: URL: https://github.com/apache/logging-log4j-transform/pull/206 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: noti

Re: [PR] Bump org.apache.logging.log4j:log4j-core from 2.25.0 to 2.25.1 [logging-log4j-jmx-gui]

2025-07-11 Thread via GitHub
github-actions[bot] merged PR #46: URL: https://github.com/apache/logging-log4j-jmx-gui/pull/46 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifica

[PR] Merge release `2.25.1` back into `2.x` [logging-log4j2]

2025-07-11 Thread via GitHub
ppkarwasz opened a new pull request, #3820: URL: https://github.com/apache/logging-log4j2/pull/3820 This change merges the changelog changes performed during the release of `2.25.1` back into the `2.x` branch. -- This is an automated message from the Apache Git Service. To respond to the

[I] Using log4j-to-slf4j in a web application incorrectly sets a value in a ThreadLocal in org.apache.logging.slf4j.SLF4JLogger [logging-log4j2]

2025-07-11 Thread via GitHub
gmiscione opened a new issue, #3819: URL: https://github.com/apache/logging-log4j2/issues/3819 ## Description We have a web application packaged as a .war file deployed in Tomcat 11. The web application uses logback as the main logger and slf4j as a facade. Then we use log4j-to-slf4j

Re: [I] `InstantPatternLegacyFormatter` computes precision incorrectly [logging-log4j2]

2025-07-11 Thread via GitHub
ppkarwasz commented on issue #3816: URL: https://github.com/apache/logging-log4j2/issues/3816#issuecomment-3062039237 Hi @vy, > As reported by [@ppkarwasz](https://github.com/ppkarwasz) (see [the review discussion](https://github.com/apache/logging-log4j2/pull/3789#discussion_r219787

Re: [PR] Feature/2.x/enumerating and exposing named patters [logging-log4j2]

2025-07-11 Thread via GitHub
vy commented on code in PR #3789: URL: https://github.com/apache/logging-log4j2/pull/3789#discussion_r2200247276 ## log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/NamedInstantPattern.java: ## @@ -0,0 +1,163 @@ +/* + * Licensed to the Apache Software Foundation (A

Re: [PR] Feature/2.x/enumerating and exposing named patters [logging-log4j2]

2025-07-11 Thread via GitHub
vy commented on PR #3789: URL: https://github.com/apache/logging-log4j2/pull/3789#issuecomment-3061510068 @ppkarwasz, consider users having their custom instant formatters, some might even be relying on `{Fixed,Fast}DateFormat`. They will get excited about `NamedInstantPattern`, will try to

Re: [PR] Feature/2.x/enumerating and exposing named patters [logging-log4j2]

2025-07-11 Thread via GitHub
vy commented on code in PR #3789: URL: https://github.com/apache/logging-log4j2/pull/3789#discussion_r2200140855 ## log4j-core/src/main/java/org/apache/logging/log4j/core/util/internal/instant/InstantPatternLegacyFormatter.java: ## @@ -46,7 +46,10 @@ final class InstantPatternLe

[I] `InstantPatternLegacyFormatter` computes precision incorrectly [logging-log4j2]

2025-07-11 Thread via GitHub
vy opened a new issue, #3816: URL: https://github.com/apache/logging-log4j2/issues/3816 `InstantPatternLegacyFormatter` uses `InstantPatternDynamicFormatter` to determine the precision of the *legacy* date & time pattern it receives. As reported by @ppkarwasz (see [the review discussion](h

Re: [PR] Asynchronous Sending for RemoteSyslogAppender in log4net (logging-log4net)

2025-07-10 Thread via GitHub
yogitasingh001 commented on PR #253: URL: https://github.com/apache/logging-log4net/pull/253#issuecomment-3060179923 Ok @FreeAndNil i will test and update. Sorry for the late response -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[PR] Emit '"' instead of '"' in XML and html attributes [logging-log4cxx]

2025-07-10 Thread via GitHub
swebb2066 opened a new pull request, #509: URL: https://github.com/apache/logging-log4cxx/pull/509 This PR applies [this stack overflow advise](https://stackoverflow.com/questions/3961505/how-can-i-escape-double-quotes-in-xml-attributes-values/47534887#47534887) when replacing a double quot

Re: [PR] Bump org.apache.commons:commons-lang3 from 3.17.0 to 3.18.0 [logging-log4j-transform]

2025-07-10 Thread via GitHub
github-actions[bot] merged PR #205: URL: https://github.com/apache/logging-log4j-transform/pull/205 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: noti

Re: [I] No Spring Boot logging output with Log4J 2.25.0 [logging-log4j2]

2025-07-10 Thread via GitHub
ppkarwasz commented on issue #3770: URL: https://github.com/apache/logging-log4j2/issues/3770#issuecomment-3058064656 Hi @mmoayyed, Please see #3766, I will likely close the vote tomorrow, so there is still a chance to check the release candidate before the official release. -- Th

Re: [I] No Spring Boot logging output with Log4J 2.25.0 [logging-log4j2]

2025-07-10 Thread via GitHub
mmoayyed commented on issue #3770: URL: https://github.com/apache/logging-log4j2/issues/3770#issuecomment-3058017667 Hello all, apologies for resurrecting this thread; is this fix still planned for 2.25.1? I see the milestone date was set to July 6th, and the release is 4 days due. This i

Re: [PR] Feature/2.x/enumerating and exposing named patters [logging-log4j2]

2025-07-10 Thread via GitHub
ppkarwasz commented on code in PR #3789: URL: https://github.com/apache/logging-log4j2/pull/3789#discussion_r2197893975 ## log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/NamedInstantPattern.java: ## @@ -0,0 +1,163 @@ +/* + * Licensed to the Apache Software Founda

Re: [PR] Feature/2.x/enumerating and exposing named patters [logging-log4j2]

2025-07-10 Thread via GitHub
ppkarwasz commented on code in PR #3789: URL: https://github.com/apache/logging-log4j2/pull/3789#discussion_r2197874778 ## log4j-core/src/main/java/org/apache/logging/log4j/core/util/internal/instant/InstantPatternLegacyFormatter.java: ## @@ -46,7 +46,10 @@ final class InstantPa

Re: [PR] Feature/2.x/enumerating and exposing named patters [logging-log4j2]

2025-07-10 Thread via GitHub
vy commented on code in PR #3789: URL: https://github.com/apache/logging-log4j2/pull/3789#discussion_r2197547461 ## log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/NamedInstantPattern.java: ## @@ -0,0 +1,163 @@ +/* + * Licensed to the Apache Software Foundation (A

Re: [I] failed to build parent project warning [logging-log4j2]

2025-07-10 Thread via GitHub
ppkarwasz closed issue #3813: failed to build parent project warning URL: https://github.com/apache/logging-log4j2/issues/3813 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

Re: [I] failed to build parent project warning [logging-log4j2]

2025-07-10 Thread via GitHub
ppkarwasz commented on issue #3813: URL: https://github.com/apache/logging-log4j2/issues/3813#issuecomment-3056347491 Hi @rob975, Thanks for reporting this. The issue you're encountering is most likely caused by #3758 and #3779. We’ve prepared a release candidate for `2.25.1`,

Re: [PR] Feature/2.x/enumerating and exposing named patters [logging-log4j2]

2025-07-10 Thread via GitHub
ppkarwasz commented on code in PR #3789: URL: https://github.com/apache/logging-log4j2/pull/3789#discussion_r2196942219 ## log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/DatePatternConverter.java: ## @@ -109,40 +109,19 @@ private static String readPattern(@Nullab

[I] failed to build parent project warning [logging-log4j2]

2025-07-10 Thread via GitHub
rob975 opened a new issue, #3813: URL: https://github.com/apache/logging-log4j2/issues/3813 ## Description When running maven-assembly-plugin we get these warnings ``` [WARNING] Failed to build parent project for org.apache.logging.log4j:log4j-layout-template-json:jar:2.25.0

Re: [PR] Feature/2.x/enumerating and exposing named patters [logging-log4j2]

2025-07-10 Thread via GitHub
ppkarwasz commented on code in PR #3789: URL: https://github.com/apache/logging-log4j2/pull/3789#discussion_r2196829985 ## log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/DatePatternConverter.java: ## @@ -109,40 +109,19 @@ private static String readPattern(@Nullab

Re: [I] v3.1.0 does not allow empty file names anymore for RollingFileAppender (logging-log4net)

2025-07-10 Thread via GitHub
ringchenhao commented on issue #260: URL: https://github.com/apache/logging-log4net/issues/260#issuecomment-3055976305 i have faced the same problem with mordio, it is ok with the platform .net 8.0, but with platform .net 4.6.2, it shows the same error print like mordio -- This is an aut

Re: [PR] Feature/2.x/enumerating and exposing named patters [logging-log4j2]

2025-07-10 Thread via GitHub
vy commented on code in PR #3789: URL: https://github.com/apache/logging-log4j2/pull/3789#discussion_r2196798155 ## log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/DatePatternConverter.java: ## @@ -109,40 +109,19 @@ private static String readPattern(@Nullable fina

Re: [PR] Feature/2.x/enumerating and exposing named patters [logging-log4j2]

2025-07-09 Thread via GitHub
ppkarwasz commented on code in PR #3789: URL: https://github.com/apache/logging-log4j2/pull/3789#discussion_r2196109011 ## log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/DatePatternConverter.java: ## @@ -109,40 +109,19 @@ private static String readPattern(@Nullab

Re: [PR] Respect `log4j1.compatibility` for programmatic configuration [logging-log4j2]

2025-07-09 Thread via GitHub
github-actions[bot] commented on PR #3812: URL: https://github.com/apache/logging-log4j2/pull/3812#issuecomment-3054240664 Job Requested goals Build Tool Version Build Outcome Build Scan® build-

Re: [PR] Feature/2.x/enumerating and exposing named patters [logging-log4j2]

2025-07-09 Thread via GitHub
vy commented on code in PR #3789: URL: https://github.com/apache/logging-log4j2/pull/3789#discussion_r2196059297 ## log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/DatePatternConverter.java: ## @@ -109,40 +109,19 @@ private static String readPattern(@Nullable fina

Re: [PR] Feature/2.x/enumerating and exposing named patters [logging-log4j2]

2025-07-09 Thread via GitHub
ppkarwasz commented on PR #3789: URL: https://github.com/apache/logging-log4j2/pull/3789#issuecomment-3053765302 > In its current state, deprecated formatters are an island – no programmatic connections from anywhere. We can safely delete them, yet keep the legacy formatters configuration k

Re: [I] ThrowablePatternConverter deprecated constructors refer to a package private constructor [logging-log4j2]

2025-07-09 Thread via GitHub
vy closed issue #3809: ThrowablePatternConverter deprecated constructors refer to a package private constructor URL: https://github.com/apache/logging-log4j2/issues/3809 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [I] ThrowablePatternConverter deprecated constructors refer to a package private constructor [logging-log4j2]

2025-07-09 Thread via GitHub
vy commented on issue #3809: URL: https://github.com/apache/logging-log4j2/issues/3809#issuecomment-3053684326 @snicoll, submitted spring-projects/spring-boot#46372, closing this issue. Please feel free to comment and/or re-open if you have further concerns. -- This is an automated messa

  1   2   3   4   5   6   7   8   9   10   >