ppkarwasz commented on code in PR #3789:
URL: https://github.com/apache/logging-log4j2/pull/3789#discussion_r2196109011
##
log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/DatePatternConverter.java:
##
@@ -109,40 +109,19 @@ private static String readPattern(@Nullab
github-actions[bot] commented on PR #3812:
URL: https://github.com/apache/logging-log4j2/pull/3812#issuecomment-3054240664
Job
Requested goals
Build Tool Version
Build Outcome
Build Scan®
build-
vy commented on code in PR #3789:
URL: https://github.com/apache/logging-log4j2/pull/3789#discussion_r2196059297
##
log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/DatePatternConverter.java:
##
@@ -109,40 +109,19 @@ private static String readPattern(@Nullable fina
ppkarwasz commented on PR #3789:
URL: https://github.com/apache/logging-log4j2/pull/3789#issuecomment-3053765302
> In its current state, deprecated formatters are an island – no
programmatic connections from anywhere. We can safely delete them, yet keep the
legacy formatters configuration k
vy closed issue #3809: ThrowablePatternConverter deprecated constructors refer
to a package private constructor
URL: https://github.com/apache/logging-log4j2/issues/3809
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
vy commented on issue #3809:
URL:
https://github.com/apache/logging-log4j2/issues/3809#issuecomment-3053684326
@snicoll, submitted spring-projects/spring-boot#46372, closing this issue.
Please feel free to comment and/or re-open if you have further concerns.
--
This is an automated messa
ppkarwasz commented on issue #3809:
URL:
https://github.com/apache/logging-log4j2/issues/3809#issuecomment-3053462603
Hi @vy,
The implementation looks good overall. However, you should also override
[`LogEventPatternConverter#handlesThrowable()`](https://logging.apache.org/log4j/2.x/
vy commented on PR #3789:
URL: https://github.com/apache/logging-log4j2/pull/3789#issuecomment-3053423599
> > @ashr123, no, absolutely not. They should not be used anywhere in Log4j.
In `2.25.0` we put great effort into deprecating them – see [the release
notes](https://logging.apache.org/l
jhl221123 opened a new pull request, #3812:
URL: https://github.com/apache/logging-log4j2/pull/3812
This PR addresses issue #3667 by adding guard logic to methods in `Category`
and `LogManager` that can modify the configuration. These changes ensure that
programmatic configuration using the
github-actions[bot] commented on PR #3810:
URL: https://github.com/apache/logging-log4j2/pull/3810#issuecomment-3053174257
Job
Requested goals
Build Tool Version
Build Outcome
Build Scan®
build-
ppkarwasz commented on PR #3789:
URL: https://github.com/apache/logging-log4j2/pull/3789#issuecomment-3053034368
> > @vy should I use `FixedDateFormat.FixedFormat#getPattern` in case of
`InstantPatternFormatter.LEGACY_FORMATTERS_ENABLED` is `true`?
>
> @ashr123, no, absolutely not. Th
vy commented on issue #3809:
URL:
https://github.com/apache/logging-log4j2/issues/3809#issuecomment-3052824395
> > could you use composition instead?
>
> I am not sure we can use composition considering we're overriding
`ThrowablePatternConverter#format`. Perhaps you can have a look
ashr123 commented on PR #3789:
URL: https://github.com/apache/logging-log4j2/pull/3789#issuecomment-3052709896
@vy so what should I do? use
`InstantPatternFormatter.LEGACY_FORMATTERS_ENABLED` as I did before? (which
@ppkarwasz doesn't like)
--
This is an automated message from the Apache
vy commented on PR #3789:
URL: https://github.com/apache/logging-log4j2/pull/3789#issuecomment-3052700892
> @vy should I use `FixedDateFormat.FixedFormat#getPattern` in case of
`InstantPatternFormatter.LEGACY_FORMATTERS_ENABLED` is `true`?
@ashr123, no, absolutely not. They should not
ashr123 commented on PR #3789:
URL: https://github.com/apache/logging-log4j2/pull/3789#issuecomment-3052681117
@ppkarwasz can you add the JavaDoc yourself? I'm using another computer and
I have a bit of trouble regarding the signature
--
This is an automated message from the Apache Git Se
ashr123 commented on code in PR #3789:
URL: https://github.com/apache/logging-log4j2/pull/3789#discussion_r2194983126
##
log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/NamedInstantPattern.java:
##
@@ -0,0 +1,78 @@
+/*
+ * Licensed to the Apache Software Foundatio
ashr123 commented on code in PR #3789:
URL: https://github.com/apache/logging-log4j2/pull/3789#discussion_r2194969525
##
log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/NamedDatePattern.java:
##
@@ -0,0 +1,114 @@
+/*
+ * Licensed to the Apache Software Foundation
ppkarwasz commented on code in PR #3789:
URL: https://github.com/apache/logging-log4j2/pull/3789#discussion_r2194968468
##
log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/NamedInstantPattern.java:
##
@@ -0,0 +1,78 @@
+/*
+ * Licensed to the Apache Software Foundat
ppkarwasz commented on code in PR #3789:
URL: https://github.com/apache/logging-log4j2/pull/3789#discussion_r2194962920
##
log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/NamedDatePattern.java:
##
@@ -0,0 +1,114 @@
+/*
+ * Licensed to the Apache Software Foundatio
ashr123 commented on code in PR #3789:
URL: https://github.com/apache/logging-log4j2/pull/3789#discussion_r2194921907
##
log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/DatePatternConverter.java:
##
@@ -109,84 +109,11 @@ private static String readPattern(@Nullable
ppkarwasz commented on code in PR #3789:
URL: https://github.com/apache/logging-log4j2/pull/3789#discussion_r2194912642
##
log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/DatePatternConverter.java:
##
@@ -109,84 +109,11 @@ private static String readPattern(@Nullab
ashr123 commented on PR #3789:
URL: https://github.com/apache/logging-log4j2/pull/3789#issuecomment-3052379119
@vy should I use `FixedDateFormat.FixedFormat` in case of
`InstantPatternFormatter.LEGACY_FORMATTERS_ENABLED` is `true`?
--
This is an automated message from the Apache Git Servi
vy commented on PR #3789:
URL: https://github.com/apache/logging-log4j2/pull/3789#issuecomment-3052340939
> @vy ok, no problem, what else should I do for this PR to be approved?
Nothing more, AFAICT. (Note that the changelog needs to be updated after the
rename.)
--
This is an auto
ashr123 commented on PR #3789:
URL: https://github.com/apache/logging-log4j2/pull/3789#issuecomment-3052324132
@vy ok, no problem, what else should I do for this PR to be approved?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitH
vy commented on PR #3789:
URL: https://github.com/apache/logging-log4j2/pull/3789#issuecomment-3052319657
> > 2. Shall we rename the class from `NamedDatePattern` to
`NamedInstantPattern` in line with our recent wordsmithing efforts in _"instant
formatting"_?
>
> That could be a sens
ashr123 commented on code in PR #3789:
URL: https://github.com/apache/logging-log4j2/pull/3789#discussion_r2194755794
##
log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/DatePatternConverter.java:
##
@@ -109,84 +109,11 @@ private static String readPattern(@Nullable
ppkarwasz commented on code in PR #3789:
URL: https://github.com/apache/logging-log4j2/pull/3789#discussion_r2194740184
##
log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/DatePatternConverter.java:
##
@@ -109,84 +109,11 @@ private static String readPattern(@Nullab
maedula commented on issue #250:
URL:
https://github.com/apache/logging-log4net/issues/250#issuecomment-3052120352
@FreeAndNil latest preview is fixing my reported issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
yybmion opened a new pull request, #3810:
URL: https://github.com/apache/logging-log4j2/pull/3810
Implements custom `ThreadContextStack` injection capability as requested in
#1507.
Users can now inject custom `ThreadContextStack` implementations just like
`ThreadContextMap`.
#
ashr123 commented on code in PR #3789:
URL: https://github.com/apache/logging-log4j2/pull/3789#discussion_r2194372738
##
log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/DatePatternConverter.java:
##
@@ -109,84 +109,11 @@ private static String readPattern(@Nullable
ppkarwasz commented on code in PR #3789:
URL: https://github.com/apache/logging-log4j2/pull/3789#discussion_r2194345347
##
log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/DatePatternConverter.java:
##
@@ -109,84 +109,11 @@ private static String readPattern(@Nullab
ppkarwasz commented on issue #2769:
URL:
https://github.com/apache/logging-log4j2/issues/2769#issuecomment-3051462889
Hi @snicoll,
> > If you’d prefer to keep it package-private, you can suppress the warning
using:
>
> I saw the suggestion, I don't want to do that as it's repo
snicoll commented on issue #2769:
URL:
https://github.com/apache/logging-log4j2/issues/2769#issuecomment-3051413436
> If you’d prefer to keep it package-private, you can suppress the warning
using:
I saw the suggestion, I don't want to do that as it's reporting the problem
down the
33 matches
Mail list logo
