Re: [PR] Fix typo in LoggerConfig.RootLogger.Builder#withtFilter (#3369) [logging-log4j2]

2025-06-16 Thread via GitHub
norrisjeremy commented on PR #3372: URL: https://github.com/apache/logging-log4j2/pull/3372#issuecomment-2978994220 > @norrisjeremy, > > The overall goal is to transition all withers to setters in version 3.x, as described in #1206. Since the builders are mutable, the purpose is to us

Re: [PR] Fix typo in LoggerConfig.RootLogger.Builder#withtFilter (#3369) [logging-log4j2]

2025-06-16 Thread via GitHub
ppkarwasz commented on PR #3372: URL: https://github.com/apache/logging-log4j2/pull/3372#issuecomment-2978919225 @norrisjeremy, The overall goal is to transition all withers to setters in version 3.x, as described in #1206. Since the builders are mutable, the purpose is to use a nami

Re: [PR] Bump apache/logging-parent/.github/workflows/deploy-site-reusable.yaml@rel/12.1.0 from 12.1.0 to 12.1.1 [logging-log4j-jmx-gui]

2025-06-16 Thread via GitHub
github-actions[bot] merged PR #42: URL: https://github.com/apache/logging-log4j-jmx-gui/pull/42 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifica

Re: [PR] Bump apache/logging-parent/.github/workflows/deploy-release-reusable.yaml@rel/12.1.0 from 12.1.0 to 12.1.1 [logging-log4j-jmx-gui]

2025-06-16 Thread via GitHub
github-actions[bot] merged PR #40: URL: https://github.com/apache/logging-log4j-jmx-gui/pull/40 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifica

Re: [PR] Fix typo in LoggerConfig.RootLogger.Builder#withtFilter (#3369) [logging-log4j2]

2025-06-16 Thread via GitHub
norrisjeremy commented on PR #3372: URL: https://github.com/apache/logging-log4j2/pull/3372#issuecomment-2978292816 > We should use `setFilter` instead of `withFilter`. > > I also noticed that **none** of our tests use the `LoggerConfig` builder and they call the deprecated `LoggerCon

Re: [PR] Bump com.fasterxml.jackson:jackson-bom from 2.19.0 to 2.19.1 [logging-log4j-transform]

2025-06-16 Thread via GitHub
github-actions[bot] merged PR #198: URL: https://github.com/apache/logging-log4j-transform/pull/198 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: noti

Re: [PR] Bump apache/logging-parent/.github/workflows/deploy-release-reusable.yaml@rel/12.1.0 from 12.1.0 to 12.1.1 [logging-log4j-transform]

2025-06-16 Thread via GitHub
github-actions[bot] merged PR #201: URL: https://github.com/apache/logging-log4j-transform/pull/201 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: noti

Re: [PR] Bump apache/logging-parent/.github/workflows/merge-dependabot-reusable.yaml@rel/12.1.0 from 12.1.0 to 12.1.1 [logging-log4j-transform]

2025-06-16 Thread via GitHub
github-actions[bot] merged PR #200: URL: https://github.com/apache/logging-log4j-transform/pull/200 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: noti

Re: [PR] Bump org.apache.logging.log4j:log4j-bom from 2.24.3 to 2.25.0 [logging-log4j-transform]

2025-06-16 Thread via GitHub
github-actions[bot] merged PR #199: URL: https://github.com/apache/logging-log4j-transform/pull/199 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: noti

Re: [PR] Bump jackson.version from 2.19.0 to 2.19.1 [logging-log4j-transform]

2025-06-16 Thread via GitHub
github-actions[bot] merged PR #196: URL: https://github.com/apache/logging-log4j-transform/pull/196 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: noti

Re: [PR] Bump apache/logging-parent/.github/workflows/codeql-analysis-reusable.yaml@rel/12.1.0 from 12.1.0 to 12.1.1 [logging-log4j-transform]

2025-06-16 Thread via GitHub
github-actions[bot] merged PR #197: URL: https://github.com/apache/logging-log4j-transform/pull/197 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: noti

Re: [PR] Bump apache/logging-parent/.github/workflows/codeql-analysis-reusable.yaml@rel/12.1.0 from 12.1.0 to 12.1.1 [logging-log4j-jmx-gui]

2025-06-16 Thread via GitHub
github-actions[bot] merged PR #44: URL: https://github.com/apache/logging-log4j-jmx-gui/pull/44 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifica

[PR] Remove `publish.profile` from production site [logging-log4j2]

2025-06-16 Thread via GitHub
ppkarwasz opened a new pull request, #3749: URL: https://github.com/apache/logging-log4j2/pull/3749 There is no `publish.profile` property in the `.asf.yaml` schema. Fixes #3598 -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] Bump apache/logging-parent/.github/workflows/merge-dependabot-reusable.yaml@rel/12.1.0 from 12.1.0 to 12.1.1 [logging-log4j-jmx-gui]

2025-06-16 Thread via GitHub
github-actions[bot] merged PR #41: URL: https://github.com/apache/logging-log4j-jmx-gui/pull/41 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifica

[PR] Start new development cycle (`2.26.0`) [logging-log4j2]

2025-06-16 Thread via GitHub
ppkarwasz opened a new pull request, #3748: URL: https://github.com/apache/logging-log4j2/pull/3748 Start development of version `2.26.0`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] feat: add `process-dependabot-reusable` workflow [logging-parent]

2025-06-16 Thread via GitHub
ppkarwasz commented on code in PR #418: URL: https://github.com/apache/logging-parent/pull/418#discussion_r2150406600 ## .github/actions/generate-dependabot-changelog/src/maven.test.ts: ## @@ -0,0 +1,83 @@ +// SPDX-License-Identifier: Apache-2.0 +import { getProjectVersion } fro

Re: [PR] feat: add `process-dependabot-reusable` workflow [logging-parent]

2025-06-16 Thread via GitHub
ppkarwasz commented on code in PR #418: URL: https://github.com/apache/logging-parent/pull/418#discussion_r2150406188 ## .github/actions/generate-dependabot-changelog/src/pull_request.test.ts: ## @@ -0,0 +1,102 @@ +// SPDX-License-Identifier: Apache-2.0 +import { getAssociatedPu

Re: [PR] feat: add `process-dependabot-reusable` workflow [logging-parent]

2025-06-16 Thread via GitHub
Copilot commented on code in PR #418: URL: https://github.com/apache/logging-parent/pull/418#discussion_r2150388464 ## .github/actions/generate-dependabot-changelog/src/pull_request.test.ts: ## @@ -0,0 +1,102 @@ +// SPDX-License-Identifier: Apache-2.0 +import { getAssociatedPull

[PR] feat: add `process-dependabot-reusable` workflow [logging-parent]

2025-06-16 Thread via GitHub
ppkarwasz opened a new pull request, #418: URL: https://github.com/apache/logging-parent/pull/418 Adds a reusable GitHub Actions workflow (`process-dependabot-reusable`) to streamline handling of Dependabot PRs across repositories. * **Generates changelog entries** for each updated de

[I] Adapt `merge-dependabot-reusable` to support RTC workflow [logging-parent]

2025-06-16 Thread via GitHub
ppkarwasz opened a new issue, #417: URL: https://github.com/apache/logging-parent/issues/417 With the introduction of the **Review-to-Commit** process, the current `merge-dependabot-reusable` GitHub Actions workflow needs to be revised. The RTC policy introduces new constraints that directl

Re: [PR] Enforce explicit names for global scripts and refine script id handling [logging-log4j2]

2025-06-16 Thread via GitHub
jhl221123 commented on PR #3691: URL: https://github.com/apache/logging-log4j2/pull/3691#issuecomment-2976528605 Hi @ppkarwasz, Thanks for the thorough review! I've addressed all feedback. It was a great learning experience. Let me know if any further changes are needed. --

Re: [PR] Enforce explicit names for global scripts and refine script id handling [logging-log4j2]

2025-06-16 Thread via GitHub
ppkarwasz commented on PR #3691: URL: https://github.com/apache/logging-log4j2/pull/3691#issuecomment-2976589203 @jhl221123, I'll merge this PR as soon as `2.25.0` is out. BTW: thanks for contributing to my coffee fund! -- This is an automated message from the Apache Git Serv

Re: [PR] Shutdown: Unsubscribe from AppDomain event handlers (logging-log4net)

2025-06-16 Thread via GitHub
FreeAndNil merged PR #256: URL: https://github.com/apache/logging-log4net/pull/256 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubsc

Re: [PR] Bump com.fasterxml.jackson:jackson-bom from 2.19.0 to 2.19.1 [logging-log4j-audit-sample]

2025-06-16 Thread via GitHub
github-actions[bot] merged PR #76: URL: https://github.com/apache/logging-log4j-audit-sample/pull/76 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: not

Re: [PR] Bump org.apache.logging:logging-parent from 12.1.0 to 12.1.1 [logging-log4j-audit-sample]

2025-06-16 Thread via GitHub
github-actions[bot] merged PR #75: URL: https://github.com/apache/logging-log4j-audit-sample/pull/75 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: not

[PR] Bump com.fasterxml.jackson:jackson-bom from 2.19.0 to 2.19.1 [logging-log4j-audit-sample]

2025-06-16 Thread via GitHub
dependabot[bot] opened a new pull request, #76: URL: https://github.com/apache/logging-log4j-audit-sample/pull/76 Bumps [com.fasterxml.jackson:jackson-bom](https://github.com/FasterXML/jackson-bom) from 2.19.0 to 2.19.1. Commits https://github.com/FasterXML/jackson-bom/commit/

[PR] Bump org.apache.logging:logging-parent from 12.1.0 to 12.1.1 [logging-log4j-audit-sample]

2025-06-16 Thread via GitHub
dependabot[bot] opened a new pull request, #75: URL: https://github.com/apache/logging-log4j-audit-sample/pull/75 Bumps [org.apache.logging:logging-parent](https://github.com/apache/logging-parent) from 12.1.0 to 12.1.1. Release notes Sourced from https://github.com/apache/logging

Re: [PR] fix toString() method in configuration implementations (apache#3599) [logging-log4j2]

2025-06-16 Thread via GitHub
ppkarwasz commented on PR #3658: URL: https://github.com/apache/logging-log4j2/pull/3658#issuecomment-2976250721 Hi @anindita-sarkarArray, I discussed this with @garydgregory, and I agree that the `toString()` methods should remain unchanged to preserve a better debugging experience

Re: [PR] Correct script resolution order dependency [logging-log4j2]

2025-06-16 Thread via GitHub
github-actions[bot] commented on PR #3718: URL: https://github.com/apache/logging-log4j2/pull/3718#issuecomment-2976207257 Job Requested goals Build Tool Version Build Outcome Build ScanĀ® build-

Re: [PR] Enforce explicit names for global scripts and refine script id handling [logging-log4j2]

2025-06-16 Thread via GitHub
ppkarwasz commented on code in PR #3691: URL: https://github.com/apache/logging-log4j2/pull/3691#discussion_r2149663867 ## log4j-core-test/src/test/java/org/apache/logging/log4j/core/config/ScriptsPluginTest.java: ## @@ -0,0 +1,79 @@ +/* + * Licensed to the Apache Software Found