jhl221123 commented on issue #3430:
URL:
https://github.com/apache/logging-log4j2/issues/3430#issuecomment-2893161780
Hi @vy,
I've taken a look at issue #3430 and PR #3474.
If @Suvrat1629 is not currently working on this, I would be interested in
contributing to move it forwar
rschmitt commented on PR #3676:
URL: https://github.com/apache/logging-log4j2/pull/3676#issuecomment-2892312400
@ppkarwasz I tried that first. The fix isn't available yet in any released
version of the wrapper plugin.
--
This is an automated message from the Apache Git Service.
To respond
rschmitt commented on PR #3675:
URL: https://github.com/apache/logging-log4j2/pull/3675#issuecomment-2892317246
@vy OK
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
jesmith17 commented on PR #3322:
URL: https://github.com/apache/logging-log4j2/pull/3322#issuecomment-2892308594
Doesn't appear to have. I did a fresh pull before I did the
```spotless:apply``` and that would have included the new file, but I still got
the same error.
--
This is
ppkarwasz commented on PR #3322:
URL: https://github.com/apache/logging-log4j2/pull/3322#issuecomment-2892302449
> So the ./mvnw command never works for me.
Did #3676 fix it for you?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log o
jesmith17 commented on PR #3322:
URL: https://github.com/apache/logging-log4j2/pull/3322#issuecomment-2892282856
@vy
So the ./mvnw command never works for me. It tells me that my maven version
has an issue with the distributionSha256Sum property. I have reported this
before, but it
vy closed issue #3214: ArrayIndexOutOfBoundsException on invocation of
org.apache.logging.log4j.message.Message.getFormattedMessage()
URL: https://github.com/apache/logging-log4j2/issues/3214
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
vy commented on issue #3214:
URL:
https://github.com/apache/logging-log4j2/issues/3214#issuecomment-2892240742
Fixed by #3655.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific commen
vy commented on PR #3655:
URL: https://github.com/apache/logging-log4j2/pull/3655#issuecomment-2892235695
@PAX523, thanks so much.
> What's the expected workflow now?
Maintainers finding time to check the commits are not tampered, kick CI, and
get it merged upon success.
--
vy merged PR #3655:
URL: https://github.com/apache/logging-log4j2/pull/3655
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@lo
ppkarwasz merged PR #394:
URL: https://github.com/apache/logging-parent/pull/394
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr.
ppkarwasz merged PR #393:
URL: https://github.com/apache/logging-parent/pull/393
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr.
ppkarwasz commented on PR #3676:
URL: https://github.com/apache/logging-log4j2/pull/3676#issuecomment-2892212391
I would rather update the whole `mvnw` file to a new version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
vy merged PR #3676:
URL: https://github.com/apache/logging-log4j2/pull/3676
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@lo
vy commented on PR #3322:
URL: https://github.com/apache/logging-log4j2/pull/3322#issuecomment-2892197233
@jesmith17, CI is failing due to linting issues. Would you mind running
`./mvnw spotless:apply`, committing the suggested changes, and pushing those
commits, please?
You can loca
vy commented on PR #3675:
URL: https://github.com/apache/logging-log4j2/pull/3675#issuecomment-2892173764
Wouldn't it be better to
1. `ReadOnlyStringMapUtil` *internal* class such that
* It contains a static `equals(ReadOnlyStringMap,ReadOnlyStringMap)`
method
* It contain
ppkarwasz merged PR #384:
URL: https://github.com/apache/logging-parent/pull/384
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr.
ppkarwasz merged PR #380:
URL: https://github.com/apache/logging-parent/pull/380
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr.
ppkarwasz merged PR #387:
URL: https://github.com/apache/logging-parent/pull/387
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr.
ppkarwasz merged PR #383:
URL: https://github.com/apache/logging-parent/pull/383
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr.
ppkarwasz merged PR #386:
URL: https://github.com/apache/logging-parent/pull/386
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr.
ppkarwasz merged PR #385:
URL: https://github.com/apache/logging-parent/pull/385
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr.
ppkarwasz merged PR #382:
URL: https://github.com/apache/logging-parent/pull/382
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr.
ppkarwasz merged PR #381:
URL: https://github.com/apache/logging-parent/pull/381
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr.
ppkarwasz merged PR #391:
URL: https://github.com/apache/logging-parent/pull/391
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr.
vy commented on PR #3501:
URL: https://github.com/apache/logging-log4j2/pull/3501#issuecomment-2892136479
@MichaelMorrisEst, would you mind giving me write access to your fork,
please? I want to push some changes and get this merged for `2.25.0`, which we
will be releasing in 1-2 weeks.
-
ppkarwasz merged PR #392:
URL: https://github.com/apache/logging-parent/pull/392
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr.
ppkarwasz merged PR #379:
URL: https://github.com/apache/logging-parent/pull/379
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr.
ppkarwasz merged PR #390:
URL: https://github.com/apache/logging-parent/pull/390
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr.
github-actions[bot] commented on PR #3676:
URL: https://github.com/apache/logging-log4j2/pull/3676#issuecomment-2892029017
Job
Requested goals
Build Tool Version
Build Outcome
Build Scan®
build-
ppkarwasz opened a new pull request, #392:
URL: https://github.com/apache/logging-parent/pull/392
This removes the temporary testing site used in PR #367.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
ppkarwasz merged PR #367:
URL: https://github.com/apache/logging-parent/pull/367
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr.
ppkarwasz commented on code in PR #367:
URL: https://github.com/apache/logging-parent/pull/367#discussion_r2096313003
##
pom.xml:
##
@@ -1576,6 +1575,10 @@
npm
pre-site
+
+ install
github:apa
ppkarwasz commented on code in PR #367:
URL: https://github.com/apache/logging-parent/pull/367#discussion_r2096312765
##
.github/workflows/deploy-site-reusable.yaml:
##
@@ -115,6 +105,12 @@ jobs:
git config user.name "ASF Logging Services RM"
git config use
rschmitt opened a new pull request, #3676:
URL: https://github.com/apache/logging-log4j2/pull/3676
This change pulls in a fix from a newer version of the maven-wrapper-plugin
that fixes a bug in verifying the distributionSha256Sum using the version of
`sha256sum` that ships with macOS Sequo
ppkarwasz commented on PR #379:
URL: https://github.com/apache/logging-parent/pull/379#issuecomment-2891932963
> could you fix the documentation too, please? (Maybe point to the
`logging-parent` usage of `log4j-tools` instead?)
Done in
https://github.com/apache/logging-parent/pull/37
github-actions[bot] commented on PR #3675:
URL: https://github.com/apache/logging-log4j2/pull/3675#issuecomment-2891910253
Job
Requested goals
Build Tool Version
Build Outcome
Build Scan®
build-
ppkarwasz merged PR #3672:
URL: https://github.com/apache/logging-log4j2/pull/3672
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubsc
ppkarwasz opened a new pull request, #390:
URL: https://github.com/apache/logging-parent/pull/390
Similarly to apache/logging-log4j2#3662, this pull request enables the
"Auto-merge" and "Update branch" buttons on PRs.
--
This is an automated message from the Apache Git Service.
To respond
ppkarwasz commented on code in PR #389:
URL: https://github.com/apache/logging-parent/pull/389#discussion_r2096153221
##
pom.xml:
##
@@ -362,6 +363,12 @@
${maven-artifact-plugin.version}
+
Review Comment:
We usually add each plugin to the **Plu
ppkarwasz merged PR #3673:
URL: https://github.com/apache/logging-log4j2/pull/3673
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubsc
Copilot commented on code in PR #389:
URL: https://github.com/apache/logging-parent/pull/389#discussion_r2096140617
##
pom.xml:
##
@@ -362,6 +363,12 @@
${maven-artifact-plugin.version}
+
Review Comment:
The Mimír plugin is defined twice in this
ppkarwasz merged PR #3674:
URL: https://github.com/apache/logging-log4j2/pull/3674
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubsc
ppkarwasz opened a new pull request, #3670:
URL: https://github.com/apache/logging-log4j2/pull/3670
The `github.del_branch_on_merge` setting was renamed to
`github.pull_requests.del_branch_on_merge`, which causes an error message:
> An error occurred while processing the github featur
moeash commented on issue #244:
URL:
https://github.com/apache/logging-log4net/issues/244#issuecomment-2891540404
This should solve the issue:
private void InitializeFromOneFile(string baseFile, string curFileName)
{
curFileName = curFileName.ToLowerInvariant();
b
moeash commented on issue #244:
URL:
https://github.com/apache/logging-log4net/issues/244#issuecomment-2891531082
The issue is probably due to Path.GetDirectoryName("") throwing an exception
in .NET Framework 4.6.2.
--
This is an automated message from the Apache Git Service.
To respond
jberg7 commented on issue #245:
URL:
https://github.com/apache/logging-log4net/issues/245#issuecomment-2891495291
Thanks for the super quick turnaround! From the tests in your PR it looks
like this would fix my problem :)
I'll keep an eye out for 3.1.1.
--
This is an automated message
FreeAndNil commented on issue #245:
URL:
https://github.com/apache/logging-log4net/issues/245#issuecomment-2891414826
@jberg7 thanks for reporting.
I've created #246.
Does that fix you problem?
You are right, there is currently no other replacement in log4net.
--
This is an a
FreeAndNil opened a new pull request, #246:
URL: https://github.com/apache/logging-log4net/pull/246
fixes #244
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscri
ppkarwasz commented on PR #389:
URL: https://github.com/apache/logging-parent/pull/389#issuecomment-2891382212
I am marking this as draft, since there are still some details of
`actions/cache` I need to work on. The ultimate goal is to have a single cache
that is updated when new dependency
ppkarwasz opened a new pull request, #389:
URL: https://github.com/apache/logging-parent/pull/389
This pull request replaces the use of the Maven local repository cache with
[Mimír](https://maveniverse.eu/docs/mimir/), a specialized, immutable cache for
remote Maven repositories.
###
jberg7 opened a new issue, #245:
URL: https://github.com/apache/logging-log4net/issues/245
It looks like
https://github.com/apache/logging-log4net/commit/b5f6ea2df90372cbe3bc679e6fffa07b984fdb6e
broke NDC.Inherit(). By way of example:
```c#
var context = NDC.CloneStack();
NDC.I
jesmith17 commented on PR #3322:
URL: https://github.com/apache/logging-log4j2/pull/3322#issuecomment-2890823168
@vy all of the requested changes have been made. I updated the pom.xml to
remove the configuration section and committed that to this same PR.
Are there additional chang
PAX523 commented on PR #3655:
URL: https://github.com/apache/logging-log4j2/pull/3655#issuecomment-2890118047
Good morning @vy. What's the expected workflow now? When will this PR be
merged?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
ppkarwasz opened a new issue, #388:
URL: https://github.com/apache/logging-parent/issues/388
## Description
On Windows, many Maven plugins—including the CycloneDX Maven Plugin—emit
files with `CRLF` line endings. Despite this, the
`verify-reproducibility-reusable` workflow sometimes
ppkarwasz merged PR #3671:
URL: https://github.com/apache/logging-log4j2/pull/3671
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubsc
ppkarwasz closed pull request #3603: Adapt `merge-dependabot` to RTC
URL: https://github.com/apache/logging-log4j2/pull/3603
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
ppkarwasz commented on PR #3603:
URL: https://github.com/apache/logging-log4j2/pull/3603#issuecomment-2890109128
I am closing this, since it will be implemented in `logging-parent`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
ppkarwasz closed pull request #3624: Disable (temporarily) Dependabot updates
URL: https://github.com/apache/logging-log4j2/pull/3624
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
ppkarwasz merged PR #3670:
URL: https://github.com/apache/logging-log4j2/pull/3670
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubsc
ppkarwasz merged PR #3662:
URL: https://github.com/apache/logging-log4j2/pull/3662
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubsc
vy commented on PR #3322:
URL: https://github.com/apache/logging-log4j2/pull/3322#issuecomment-2889922398
Hey @jesmith17! Are you still working on this issue? We are about to release
`2.25.0` and we would really appreciate having this PR merged before the
release.
--
This is an automated
vy commented on PR #3624:
URL: https://github.com/apache/logging-log4j2/pull/3624#issuecomment-2889932953
@ppkarwasz, can we close this issue since [we agreed on a forward path to
make this
work](https://lists.apache.org/thread/m9dp8j1tmw10ldjlqjl8ljw7zrjl8qyb)?
--
This is an automated m
vy commented on PR #3668:
URL: https://github.com/apache/logging-log4j2/pull/3668#issuecomment-2889914223
@ppkarwasz, IIRC, you had tweaked `.gitattributes` (and some other changes
which I cannot recall right now) to support reproducible builds on Windows. Do
we need to revert/adapt them?
64 matches
Mail list logo
