Re: [PR] Improve performance and avoid memory consumption if logging primitive arrays as parameters [logging-log4j2]

2025-05-05 Thread via GitHub
ppkarwasz commented on code in PR #3645: URL: https://github.com/apache/logging-log4j2/pull/3645#discussion_r2074830063 ## log4j-perf-test/src/main/java/org/apache/logging/log4j/message/ParameterFormatterBenchmark.java: ## @@ -81,4 +95,38 @@ private static int latencyParams(fina

Re: [I] NPE when using `rootLogger` shorthand properties notation [logging-log4j2]

2025-05-05 Thread via GitHub
ppkarwasz commented on issue #3206: URL: https://github.com/apache/logging-log4j2/issues/3206#issuecomment-2853403673 @jhl221123, Go ahead, thanks! > Since it's in 'To triage', please let me know if it's available for contribution. I introduced the [Log4j bug tracker](

Re: [I] NPE when using `rootLogger` shorthand properties notation [logging-log4j2]

2025-05-05 Thread via GitHub
jhl221123 commented on issue #3206: URL: https://github.com/apache/logging-log4j2/issues/3206#issuecomment-2853133660 Hi @ppkarwasz, I'd like to work on this `good first issue` regarding the NPE. Since it's in 'To triage', please let me know if it's available for contribution.

Re: [I] High CPU usage in async mode with Log4j2 [logging-log4j2]

2025-05-05 Thread via GitHub
will-zdu closed issue #3635: High CPU usage in async mode with Log4j2 URL: https://github.com/apache/logging-log4j2/issues/3635 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] Improve performance and avoid memory consumption if logging primitive arrays as parameters [logging-log4j2]

2025-05-05 Thread via GitHub
magicwerk commented on PR #3645: URL: https://github.com/apache/logging-log4j2/pull/3645#issuecomment-2852490150 I tried to sign the commits by executing your command - is it ok now? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

Re: [PR] Improve performance and avoid memory consumption if logging primitive arrays as parameters [logging-log4j2]

2025-05-05 Thread via GitHub
magicwerk commented on PR #3645: URL: https://github.com/apache/logging-log4j2/pull/3645#issuecomment-2852485691 I have added benchmarks to ParameterFormatterBenchmark. I was not quite sure how you would like to implement old vs new as the old implementation is obviously gone, have a look

Re: [PR] Improve performance and avoid memory consumption if logging primitive arrays as parameters [logging-log4j2]

2025-05-05 Thread via GitHub
magicwerk commented on code in PR #3645: URL: https://github.com/apache/logging-log4j2/pull/3645#discussion_r2074288290 ## log4j-api/src/main/java/org/apache/logging/log4j/message/ParameterFormatter.java: ## @@ -643,4 +643,212 @@ static String identityToString(final Object obj)

Re: [PR] Improve performance and avoid memory consumption if logging primitive arrays as parameters [logging-log4j2]

2025-05-05 Thread via GitHub
magicwerk commented on code in PR #3645: URL: https://github.com/apache/logging-log4j2/pull/3645#discussion_r2074287153 ## log4j-api/src/main/java/org/apache/logging/log4j/message/ParameterFormatter.java: ## @@ -643,4 +643,212 @@ static String identityToString(final Object obj)

Re: [PR] Improve performance and avoid memory consumption if logging primitive arrays as parameters [logging-log4j2]

2025-05-05 Thread via GitHub
magicwerk commented on code in PR #3645: URL: https://github.com/apache/logging-log4j2/pull/3645#discussion_r2074285211 ## log4j-api-test/src/test/java/org/apache/logging/log4j/message/ParameterFormatterTest.java: ## @@ -183,4 +183,52 @@ void testIdentityToString() { fi

[PR] doc(architecture): update the ordering of vertical and horizontal headers in the statement [logging-log4j2]

2025-05-05 Thread via GitHub
vaishnavyogesh opened a new pull request, #3649: URL: https://github.com/apache/logging-log4j2/pull/3649 The line [here](https://logging.apache.org/log4j/3.x/manual/architecture.html#:~:text=In%20the%20table%2C%20the%20vertical%20header%20shows%20the%20Level%20of%20the%20LogEvent%2C%20while%

Re: [PR] Improve performance and avoid memory consumption if logging primitive arrays as parameters [logging-log4j2]

2025-05-05 Thread via GitHub
ppkarwasz commented on code in PR #3645: URL: https://github.com/apache/logging-log4j2/pull/3645#discussion_r2073521659 ## log4j-api/src/main/java/org/apache/logging/log4j/message/ParameterFormatter.java: ## @@ -643,4 +643,212 @@ static String identityToString(final Object obj)

Re: [PR] Improve performance and avoid memory consumption if logging primitive arrays as parameters [logging-log4j2]

2025-05-05 Thread via GitHub
magicwerk commented on code in PR #3645: URL: https://github.com/apache/logging-log4j2/pull/3645#discussion_r2073455721 ## log4j-api/src/main/java/org/apache/logging/log4j/message/ParameterFormatter.java: ## @@ -643,4 +643,212 @@ static String identityToString(final Object obj)

Re: [PR] Bump com.github.luben:zstd-jni from 1.5.7-2 to 1.5.7-3 [logging-log4j2]

2025-05-05 Thread via GitHub
ppkarwasz merged PR #3647: URL: https://github.com/apache/logging-log4j2/pull/3647 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubsc

[I] lost log files under high load (using .gz) [logging-log4j2]

2025-05-05 Thread via GitHub
dasvex opened a new issue, #3648: URL: https://github.com/apache/logging-log4j2/issues/3648 ## Description In our production, entries in log files are lost under high load. It is possible that this is due to the archiving process. It seems that if the file archiving of one fi

Re: [PR] Improve performance and avoid memory consumption if logging primitive arrays as parameters [logging-log4j2]

2025-05-05 Thread via GitHub
ppkarwasz commented on PR #3645: URL: https://github.com/apache/logging-log4j2/pull/3645#issuecomment-2850297004 @magicwerk, All commits in this PR must have verified signatures, so you need to: - [Add a GPG key to your GitHub account](https://docs.github.com/en/authentication/

Re: [PR] Improve performance and avoid memory consumption if logging primitive arrays as parameters [logging-log4j2]

2025-05-05 Thread via GitHub
ppkarwasz commented on code in PR #3645: URL: https://github.com/apache/logging-log4j2/pull/3645#discussion_r2073036752 ## log4j-api/src/main/java/org/apache/logging/log4j/message/ParameterFormatter.java: ## @@ -643,4 +643,212 @@ static String identityToString(final Object obj)