[PR] Fix deployment of test artifacts [logging-parent]

2025-03-21 Thread via GitHub
ppkarwasz opened a new pull request, #360: URL: https://github.com/apache/logging-parent/pull/360 Due to a difference between plugins used, if the `deploy` profile is activated, artifacts with `maven.deploy.skip` are being **deployed**. This change fixes it. -- This is an automated messa

Re: [PR] Fix shutdownDisable not taking effect(#2614) [logging-log4j2]

2025-03-21 Thread via GitHub
ppkarwasz merged PR #3508: URL: https://github.com/apache/logging-log4j2/pull/3508 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubsc

Re: [PR] Bump mongodb.version from 5.3.1 to 5.4.0 [logging-log4j2]

2025-03-21 Thread via GitHub
github-actions[bot] merged PR #3564: URL: https://github.com/apache/logging-log4j2/pull/3564 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

Re: [PR] Fix ArrayIndexOutOfBoundsException on StatusData#getFormattedStatus [logging-log4j2]

2025-03-21 Thread via GitHub
bjlaub commented on PR #3563: URL: https://github.com/apache/logging-log4j2/pull/3563#issuecomment-2744108969 > Can you add a changelog entry in `src/changelog/.2.x.x`? yep, added! -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [I] Unwanted logging "Starting configuration...", "Start watching for changes to...", etc) after update. [logging-log4j2]

2025-03-21 Thread via GitHub
ppkarwasz closed issue #3566: Unwanted logging "Starting configuration...", "Start watching for changes to...", etc) after update. URL: https://github.com/apache/logging-log4j2/issues/3566 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [I] Unwanted logging "Starting configuration...", "Start watching for changes to...", etc) after update. [logging-log4j2]

2025-03-21 Thread via GitHub
ppkarwasz commented on issue #3566: URL: https://github.com/apache/logging-log4j2/issues/3566#issuecomment-2743977370 @Fariusz, > ```xml > > > ... > > ``` You receive those messages, because you configure [`status` configuration attribute](https://logging.apa

Re: [PR] Add option to provide URIs to monitor in addition to the config file [logging-log4j2]

2025-03-21 Thread via GitHub
MichaelMorrisEst commented on PR #3501: URL: https://github.com/apache/logging-log4j2/pull/3501#issuecomment-2742983773 Thanks for your comments @vy. The comment to use a dedicated element instead of an attribute changes the implementation quiet a bit. Please take a look when you have time,

Re: [PR] Add option to provide URIs to monitor in addition to the config file [logging-log4j2]

2025-03-21 Thread via GitHub
MichaelMorrisEst commented on code in PR #3501: URL: https://github.com/apache/logging-log4j2/pull/3501#discussion_r2007307793 ## log4j-core/src/main/java/org/apache/logging/log4j/core/config/AbstractConfiguration.java: ## @@ -275,6 +275,14 @@ protected void initializeWatchers(

Re: [PR] Add option to provide URIs to monitor in addition to the config file [logging-log4j2]

2025-03-21 Thread via GitHub
MichaelMorrisEst commented on code in PR #3501: URL: https://github.com/apache/logging-log4j2/pull/3501#discussion_r2007307225 ## log4j-core/src/main/java/org/apache/logging/log4j/core/config/builder/impl/BuiltConfiguration.java: ## @@ -148,9 +154,28 @@ public void setShutdownTi

Re: [PR] Add option to provide URIs to monitor in addition to the config file [logging-log4j2]

2025-03-21 Thread via GitHub
MichaelMorrisEst commented on code in PR #3501: URL: https://github.com/apache/logging-log4j2/pull/3501#discussion_r2007305722 ## log4j-core/src/main/java/org/apache/logging/log4j/core/config/builder/api/package-info.java: ## @@ -20,7 +20,7 @@ * @since 2.4 */ @Export -@Vers

Re: [PR] Add option to provide URIs to monitor in addition to the config file [logging-log4j2]

2025-03-21 Thread via GitHub
MichaelMorrisEst commented on code in PR #3501: URL: https://github.com/apache/logging-log4j2/pull/3501#discussion_r2007305170 ## log4j-core-test/src/test/resources/log4j-test2.xml: ## @@ -15,7 +15,7 @@ ~ See the License for the specific language governing permissions and

Re: [PR] Add option to provide URIs to monitor in addition to the config file [logging-log4j2]

2025-03-21 Thread via GitHub
MichaelMorrisEst commented on code in PR #3501: URL: https://github.com/apache/logging-log4j2/pull/3501#discussion_r2007304343 ## log4j-core-test/src/test/java/org/apache/logging/log4j/core/PropertiesFileConfigTest.java: ## @@ -64,4 +64,25 @@ void testReconfiguration(final Logge

Re: [PR] Add option to provide URIs to monitor in addition to the config file [logging-log4j2]

2025-03-21 Thread via GitHub
MichaelMorrisEst commented on code in PR #3501: URL: https://github.com/apache/logging-log4j2/pull/3501#discussion_r2007304033 ## log4j-core-test/src/test/java/org/apache/logging/log4j/core/LoggerTest.java: ## @@ -544,6 +544,30 @@ void testReconfiguration(final LoggerContext con

Re: [PR] Deterministic UUID option for PatternLayout [logging-log4j2]

2025-03-21 Thread via GitHub
vy closed pull request #3532: Deterministic UUID option for PatternLayout URL: https://github.com/apache/logging-log4j2/pull/3532 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] docs: Improve String concatenation best practice [logging-log4j2]

2025-03-21 Thread via GitHub
vy commented on code in PR #3553: URL: https://github.com/apache/logging-log4j2/pull/3553#discussion_r2007102679 ## src/site/antora/modules/ROOT/partials/manual/api-best-practice-dont-use-string-concat.adoc: ## @@ -34,3 +29,10 @@ Imagine `userId` being provided by the user with

Re: [PR] Fix ArrayIndexOutOfBoundsException on StatusData#getFormattedStatus [logging-log4j2]

2025-03-21 Thread via GitHub
ppkarwasz commented on PR #3563: URL: https://github.com/apache/logging-log4j2/pull/3563#issuecomment-2742591700 @bjlaub, Thank you! Can you add a changelog entry in `src/changelog/.2.x.x`? -- This is an automated message from the Apache Git Service. To respond to the message, pleas

Re: [PR] Add references to Copernik.eu Log4j components [logging-log4j2]

2025-03-21 Thread via GitHub
ppkarwasz commented on code in PR #3534: URL: https://github.com/apache/logging-log4j2/pull/3534#discussion_r2007029550 ## src/site/antora/modules/ROOT/pages/manual/lookups.adoc: ## @@ -966,7 +966,10 @@ include::partial$features/servlet-support.adoc[] [#third-party] == Third-p

Re: [PR] Proofread CVE fix versions [logging-site]

2025-03-21 Thread via GitHub
ppkarwasz commented on code in PR #6: URL: https://github.com/apache/logging-site/pull/6#discussion_r2007074657 ## _vulnerabilities.adoc: ## @@ -32,8 +32,8 @@ We only extend this mathematical notation with set union operator (i.e., `∪`) |Summary |JDBC appender is vulnerable to

Re: [PR] Add all active team members as developers [logging-parent]

2025-03-21 Thread via GitHub
vy commented on PR #351: URL: https://github.com/apache/logging-parent/pull/351#issuecomment-2742644550 @ppkarwasz, I am against this change: 1. Roles come and go. Why do we follow a role-based ordering? (Want to appear at the top?) 2. My organization is not ASF and I don't want to

Re: [PR] Add references to Copernik.eu Log4j components [logging-log4j2]

2025-03-21 Thread via GitHub
ppkarwasz merged PR #3534: URL: https://github.com/apache/logging-log4j2/pull/3534 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubsc

Re: [PR] Add references to Copernik.eu Log4j components [logging-log4j2]

2025-03-21 Thread via GitHub
vy commented on code in PR #3534: URL: https://github.com/apache/logging-log4j2/pull/3534#discussion_r2007025486 ## src/site/antora/modules/ROOT/pages/manual/lookups.adoc: ## @@ -966,7 +966,10 @@ include::partial$features/servlet-support.adoc[] [#third-party] == Third-party lo

Re: [I] Possible Memory Leak in StatusLogger’s ConcurrentLinkedQueue [logging-log4j2]

2025-03-21 Thread via GitHub
ByteExceptionM closed issue #3511: Possible Memory Leak in StatusLogger’s ConcurrentLinkedQueue URL: https://github.com/apache/logging-log4j2/issues/3511 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go