[I] DefaultFilterComponentBuilder creates builder attributes for onMatch/onMismatch without performing null checks. (logging-log4j2)

2025-02-12 Thread via GitHub
JWT007 opened a new issue, #3464: URL: https://github.com/apache/logging-log4j2/issues/3464 Log4j 2.24.3 --- When using a configuration builder and adding a FilterComponentBuilder, generating XML from the ConfigurationBuilder causes exception when the filter is defined with a null OnM

[jira] [Closed] (LOG4J2-3624) NoClassDefFoundError initializing PropertiesUtil in Servlet 2.5 container

2025-02-12 Thread Piotr Karwasz (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3624?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Karwasz closed LOG4J2-3624. - > NoClassDefFoundError initializing PropertiesUtil in Servlet 2.5 container > --

[jira] [Commented] (LOG4J2-3624) NoClassDefFoundError initializing PropertiesUtil in Servlet 2.5 container

2025-02-12 Thread Nicholas Sushkin (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17926577#comment-17926577 ] Nicholas Sushkin commented on LOG4J2-3624: -- [~pkarwasz], Confirming the issue

Re: [PR] Add `collectionName/databaseName` attributes to MongoDB provider (logging-log4j2)

2025-02-12 Thread via GitHub
vy commented on PR #3322: URL: https://github.com/apache/logging-log4j2/pull/3322#issuecomment-2654624711 I will take care of this tomorrow afternoon. > Message ID: ***@***.***> > -- This is an automated message from the Apache Git Service. To respond to the message, please l

Re: [PR] Make copy of appender list when removing all, for increased thread-safety (logging-log4net)

2025-02-12 Thread via GitHub
tmct commented on PR #222: URL: https://github.com/apache/logging-log4net/pull/222#issuecomment-2654535460 Hi @FreeAndNil, I'm not sure, sorry. I will try to though. Apologies - work became busy. -- This is an automated message from the Apache Git Service. To respond to the message, pleas

Re: [I] Incorrect warning about message factories mismatch (logging-log4j2)

2025-02-12 Thread via GitHub
vy commented on issue #3461: URL: https://github.com/apache/logging-log4j2/issues/3461#issuecomment-2653963402 @kostya-sh, I am not able to reproduce the issue using the most recent version, i.e., `2.24.3`: ```java public class Issue3461 { public static void main(String[] a

Re: [I] Fix `RegexFilter` pattern flags (logging-log4j2)

2025-02-12 Thread via GitHub
JWT007 commented on issue #3086: URL: https://github.com/apache/logging-log4j2/issues/3086#issuecomment-2653675510 @ppkarwasz - added another new PR. Please review if OK how I deprecated old pluginFactory and created new one. -- This is an automated message from the Apache Git Serv

[PR] Removed @PluginAttribute 'patternFlags' argument from @PluginFactory for RegexFilter. (#3086) (logging-log4j2)

2025-02-12 Thread via GitHub
JWT007 opened a new pull request, #3463: URL: https://github.com/apache/logging-log4j2/pull/3463 (#3086) Removed @PluginAttribute 'patternFlags' argument from @PluginFactory for RegexFilter. Actually created new @PluginFactory without the argument and deprecated old 'createFil

Re: [I] make SocketAppender support server list (logging-log4j2)

2025-02-12 Thread via GitHub
lu-xiaoshuang commented on issue #3442: URL: https://github.com/apache/logging-log4j2/issues/3442#issuecomment-2653507527 > 1. in your personal or company repo under Apache-2.0. Good idea. -- This is an automated message from the Apache Git Service. To respond to the message, pleas

Re: [I] StringMatchFilter would return NPE if configured programmatically with 'null' text. (logging-log4j2)

2025-02-12 Thread via GitHub
JWT007 commented on issue #3153: URL: https://github.com/apache/logging-log4j2/issues/3153#issuecomment-2653500795 @ppkarwasz - seems the PR for this one was merged too. Close as done? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [I] Missing/Faulty Logic in AbstractConfiguration for addLoggerAppender / addLoggerFilter / setLoggerAdditive (logging-log4j2)

2025-02-12 Thread via GitHub
JWT007 commented on issue #3155: URL: https://github.com/apache/logging-log4j2/issues/3155#issuecomment-2653492506 NOTE: The only "in-library" problem with making getAppenders() return an immutable map is in two unit tests: - ThreadContextBenchmark2#LogBaselineState - ThreadContex

Re: [I] LoggerConfig - make LoggerConfig#clearAppenders() public? (logging-log4j2)

2025-02-12 Thread via GitHub
JWT007 closed issue #3157: LoggerConfig - make LoggerConfig#clearAppenders() public? URL: https://github.com/apache/logging-log4j2/issues/3157 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

Re: [I] LoggerConfig - make LoggerConfig#clearAppenders() public? (logging-log4j2)

2025-02-12 Thread via GitHub
JWT007 commented on issue #3157: URL: https://github.com/apache/logging-log4j2/issues/3157#issuecomment-2653456318 @ppkarwasz - my use-case has changed - I don't need this workaround anymore. Since I go no feedback on whether or not it was a good idea I am closing this issue (for now

Re: [I] AsyncWaitStrategyFactoryConfig - potential NPE when creating programatically (logging-log4j2)

2025-02-12 Thread via GitHub
JWT007 commented on issue #3159: URL: https://github.com/apache/logging-log4j2/issues/3159#issuecomment-2653423129 @ppkarwasz - recreated the PR based on current code base -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[PR] Improve validation for AsyncWaitStrategyFactoryConfig for null/empty 'factoryClassName'. (#3159) (logging-log4j2)

2025-02-12 Thread via GitHub
JWT007 opened a new pull request, #3462: URL: https://github.com/apache/logging-log4j2/pull/3462 (#3159) This should fix a potential NPE in AsyncWaitStrategyFactoryConfig if the builder 'class' field is not set or set to null/empty string. - added notEmpty assert to Builder se

[I] Incorrect warning about message factories mismatch (logging-log4j2)

2025-02-12 Thread via GitHub
kostya-sh opened a new issue, #3461: URL: https://github.com/apache/logging-log4j2/issues/3461 ## Description It appears that AbstractLogger.checkMessageFactory expects the default message factory to be ParameterizedMessageFactory (https://github.com/apache/logging-log4j2/blob/c59fdd

Re: [PR] Implements an event service and demonstrates its use for sending/receiving SSL key/trust store changes (logging-log4j2)

2025-02-12 Thread via GitHub
vy commented on PR #3378: URL: https://github.com/apache/logging-log4j2/pull/3378#issuecomment-2653089884 Instead of a fully-blown event bus that is publicly exposed, can we make this private and as small as possible, please? I agree with @ppkarwasz that we shall seek to use existing file w

Re: [PR] Add `collectionName/databaseName` attributes to MongoDB provider (logging-log4j2)

2025-02-12 Thread via GitHub
ppkarwasz commented on PR #3322: URL: https://github.com/apache/logging-log4j2/pull/3322#issuecomment-2653008386 @garydgregory, @vy, Could you review this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] Add `collectionName/databaseName` attributes to MongoDB provider (logging-log4j2)

2025-02-12 Thread via GitHub
github-actions[bot] commented on PR #3322: URL: https://github.com/apache/logging-log4j2/pull/3322#issuecomment-2653041829 Job Requested goals Build Tool Version Build Outcome Build ScanĀ® build-