Re: [I] Replace field injection with setter injection in `3.x` (logging-log4j2)

2024-11-13 Thread via GitHub
jaykataria commented on issue #2769: URL: https://github.com/apache/logging-log4j2/issues/2769#issuecomment-2475544830 Hi @ppkarwasz, trying to understand this statement better: >The source code of the OpenRewrite rule should be published. If not in OpenRewrite itself, at least

Re: [I] Replace field injection with setter injection in `3.x` (logging-log4j2)

2024-11-13 Thread via GitHub
jaykataria commented on issue #2769: URL: https://github.com/apache/logging-log4j2/issues/2769#issuecomment-2475496860 @timtebeek, regarding this: > @timtebeek, do you have any recommendations on how to rewrite: > > public static class Builder implements Supplier { >

Re: [PR] Bump co.elastic.clients:elasticsearch-java from 8.15.3 to 8.16.0 (logging-log4j2)

2024-11-13 Thread via GitHub
github-actions[bot] merged PR #3200: URL: https://github.com/apache/logging-log4j2/pull/3200 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

Re: [I] log4j-api 2.24.1 causes getLogger() to return null when using log4j-core 2.24.0 (logging-log4j2)

2024-11-13 Thread via GitHub
ppkarwasz commented on issue #3196: URL: https://github.com/apache/logging-log4j2/issues/3196#issuecomment-2474843612 @centic9, > E.g. I am looking at it as commiter of the Apache POI library. We upgraded log4j-api to 2.24.1 and plan to roll a release. > > As Apache POI is jus

Re: [PR] Bump co.elastic.clients:elasticsearch-java from 8.15.3 to 8.16.0 (logging-log4j2)

2024-11-13 Thread via GitHub
github-actions[bot] merged PR #3201: URL: https://github.com/apache/logging-log4j2/pull/3201 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

Re: [PR] Bump co.elastic.clients:elasticsearch-java from 8.15.3 to 8.16.0 (logging-log4j2)

2024-11-13 Thread via GitHub
ppkarwasz commented on PR #3201: URL: https://github.com/apache/logging-log4j2/pull/3201#issuecomment-2474692993 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] Bump co.elastic.clients:elasticsearch-java from 8.15.3 to 8.16.0 (logging-log4j2)

2024-11-13 Thread via GitHub
ppkarwasz commented on PR #3200: URL: https://github.com/apache/logging-log4j2/pull/3200#issuecomment-2474704204 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[jira] [Commented] (LOG4J2-1721) Composite configuration using log4jConfiguration context parameter

2024-11-13 Thread Claudia Pastor Ramirez (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-1721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17897999#comment-17897999 ] Claudia Pastor Ramirez commented on LOG4J2-1721: Hello, This feature is

[jira] [Comment Edited] (LOG4J2-1721) Composite configuration using log4jConfiguration context parameter

2024-11-13 Thread Claudia Pastor Ramirez (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-1721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17897999#comment-17897999 ] Claudia Pastor Ramirez edited comment on LOG4J2-1721 at 11/13/24 5:24 PM:

Re: [I] Loading text based log file is extremely slow [logging-chainsaw]

2024-11-13 Thread via GitHub
vy commented on issue #28: URL: https://github.com/apache/logging-chainsaw/issues/28#issuecomment-2474092072 @tarekahf, [Chainsaw is in dormant status](https://logging.apache.org/dormant.html), and hence, is unmaintained. Such that, its maintainers did not bother to update the website and

Re: [PR] Removes weak references from `LoggerRepository` (logging-log4j2)

2024-11-13 Thread via GitHub
ppkarwasz commented on PR #3199: URL: https://github.com/apache/logging-log4j2/pull/3199#issuecomment-2474162178 > > `LoggerRepository#computeIfAbsent` is a new method added in `2.25.0`. There is no BC to preserve. > > Isn't it released with `2.24.1`? No, the backport of #2936

Re: [PR] Removes weak references from `LoggerRepository` (logging-log4j2)

2024-11-13 Thread via GitHub
vy commented on PR #3199: URL: https://github.com/apache/logging-log4j2/pull/3199#issuecomment-2474150260 > `LoggerRepository#computeIfAbsent` is a new method added in `2.25.0`. There is no BC to preserve. Isn't it released with `2.24.1`? ![image](https://github.com/user-attac

Re: [PR] Removes weak references from `LoggerRepository` (logging-log4j2)

2024-11-13 Thread via GitHub
vy commented on code in PR #3199: URL: https://github.com/apache/logging-log4j2/pull/3199#discussion_r1840646776 ## log4j-api/src/main/java/org/apache/logging/log4j/spi/LoggerRegistry.java: ## @@ -43,7 +41,7 @@ @NullMarked public class LoggerRegistry { -private final Map

Re: [PR] Removes weak references from `LoggerRepository` (logging-log4j2)

2024-11-13 Thread via GitHub
ppkarwasz commented on PR #3199: URL: https://github.com/apache/logging-log4j2/pull/3199#issuecomment-2474029132 > > In order to preserve backward compatibility and allow `Logger`s to be garbage-collected, I will: > > > > * [ ] Remove the new methods in `LoggerRepository` in the ori

Re: [I] [Feature Request]: ECS compliant logs support in log4cxx [logging-log4cxx]

2024-11-13 Thread via GitHub
rm5248 commented on issue #428: URL: https://github.com/apache/logging-log4cxx/issues/428#issuecomment-2473623058 There is noting currently in progress for ECS logs, as it is not a feature that anybody has asked for. If you are interested in trying to add it yourself, take a look at

Re: [PR] Removes weak references from `LoggerRepository` (logging-log4j2)

2024-11-13 Thread via GitHub
vy commented on PR #3199: URL: https://github.com/apache/logging-log4j2/pull/3199#issuecomment-2473998699 > In order to preserve backward compatibility and allow `Logger`s to be garbage-collected, I will: > > * [ ] Remove the new methods in `LoggerRepository` in the original class.

Re: [I] [Feature Request]: ECS compliant logs support in log4cxx [logging-log4cxx]

2024-11-13 Thread via GitHub
rkay-dev commented on issue #428: URL: https://github.com/apache/logging-log4cxx/issues/428#issuecomment-2473675429 > There is noting currently in progress for ECS logs, as it is not a feature that anybody has asked for. > > If you are interested in trying to add it yourself, take a

Re: [PR] Bump org.apache.activemq:activemq-broker from 6.1.3 to 6.1.4 (logging-log4j2)

2024-11-13 Thread via GitHub
github-actions[bot] merged PR #3204: URL: https://github.com/apache/logging-log4j2/pull/3204 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

Re: [PR] Bump github/codeql-action from 3.27.1 to 3.27.3 [logging-parent]

2024-11-13 Thread via GitHub
github-actions[bot] merged PR #284: URL: https://github.com/apache/logging-parent/pull/284 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications

Re: [I] Replace field injection with setter injection in `3.x` (logging-log4j2)

2024-11-13 Thread via GitHub
ppkarwasz commented on issue #2769: URL: https://github.com/apache/logging-log4j2/issues/2769#issuecomment-2472799453 > > We will apply the rule as a one off operation. > > Yeah, so run the rule locally, and just not add dependency file changes in the commit? I would say that