Re: [I] SIGSEV in log4cxx::helpers::Class::toString() [logging-log4cxx]

2024-10-24 Thread via GitHub
dingetje commented on issue #420: URL: https://github.com/apache/logging-log4cxx/issues/420#issuecomment-2435655654 With the shared log4cxx library, all tests are pass. The SIGSEV still happens though, so I'm at a loss -- This is an automated message from the Apache Git Service

Re: [PR] Bump net.bytebuddy:byte-buddy from 1.15.5 to 1.15.7 (logging-log4j2)

2024-10-24 Thread via GitHub
github-actions[bot] merged PR #3116: URL: https://github.com/apache/logging-log4j2/pull/3116 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

[PR] Allow for a FMT layout configuration when log4cxx is statically linked [logging-log4cxx]

2024-10-24 Thread via GitHub
swebb2066 opened a new pull request, #422: URL: https://github.com/apache/logging-log4cxx/pull/422 This PR prevents the fault: `log4cxx: Could not instantiate class [org.apache.log4j.FMTLayout].` when loading a configuration that uses FMTLayout and the application was linked to a Log4c

[PR] Simplify the Class interface in the next ABI [logging-log4cxx]

2024-10-24 Thread via GitHub
swebb2066 opened a new pull request, #421: URL: https://github.com/apache/logging-log4cxx/pull/421 This Pr remove the internal (unused) Class::toString() method in the next ABI version -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

Re: [I] SIGSEV in log4cxx::helpers::Class::toString() [logging-log4cxx]

2024-10-24 Thread via GitHub
swebb2066 commented on issue #420: URL: https://github.com/apache/logging-log4cxx/issues/420#issuecomment-2436770492 > #0 0x769d5638 in log4cxx::helpers::Class::toString() const () from /home/antoinem/projects/log4cxx/apache-log4cxx-1.3.0/build/log4cxx/src/main/cpp/liblog4cxx.so.1

Re: [PR] Fix empty string received by .NET 8 users on Linux on userName (logging-log4net)

2024-10-24 Thread via GitHub
gdziadkiewicz commented on code in PR #199: URL: https://github.com/apache/logging-log4net/pull/199#discussion_r1815747496 ## src/log4net/Core/LoggingEvent.cs: ## @@ -742,15 +742,27 @@ private static string ReviseThreadName(string? threadName) { if (_platformDoesNotSuppo

Re: [PR] Bump spring-boot.version from 3.3.4 to 3.3.5 [logging-log4j-samples]

2024-10-24 Thread via GitHub
github-actions[bot] merged PR #209: URL: https://github.com/apache/logging-log4j-samples/pull/209 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifi

Re: [PR] Fix empty string received by .NET 8 users on Linux on userName (logging-log4net)

2024-10-24 Thread via GitHub
gdziadkiewicz commented on code in PR #199: URL: https://github.com/apache/logging-log4net/pull/199#discussion_r1815767811 ## src/log4net/Core/LoggingEvent.cs: ## @@ -774,12 +783,17 @@ private static string ReviseThreadName(string? threadName) } private string? _cachedWi

Re: [PR] Fix empty string received by .NET 8 users on Linux on userName (logging-log4net)

2024-10-24 Thread via GitHub
gdziadkiewicz commented on PR #199: URL: https://github.com/apache/logging-log4net/pull/199#issuecomment-2436449916 @FreeAndNil I'm wondering about two parts of the code. One is the: ```csharp catch { return null; } ``` Should it really be the only place

Re: [PR] Fix empty string received by .NET 8 users on Linux on userName (logging-log4net)

2024-10-24 Thread via GitHub
gdziadkiewicz commented on PR #199: URL: https://github.com/apache/logging-log4net/pull/199#issuecomment-2436440148 My plan was to find the answers alone, without using your time :D Thank you for the research! > Do you mean switching from net462 to net471 or adding a comment in the c

Re: [PR] Fix empty string received by .NET 8 users on Linux on userName (logging-log4net)

2024-10-24 Thread via GitHub
gdziadkiewicz commented on code in PR #199: URL: https://github.com/apache/logging-log4net/pull/199#discussion_r1815767370 ## src/log4net/Core/LoggingEvent.cs: ## @@ -742,15 +742,27 @@ private static string ReviseThreadName(string? threadName) { if (_platformDoesNotSuppo

Re: [PR] Fix empty string received by .NET 8 users on Linux on userName (logging-log4net)

2024-10-24 Thread via GitHub
gdziadkiewicz commented on PR #199: URL: https://github.com/apache/logging-log4net/pull/199#issuecomment-2436440550 I added the unit test and tested on Windows. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

Re: [PR] Fix empty string received by .NET 8 users on Linux on userName (logging-log4net)

2024-10-24 Thread via GitHub
gdziadkiewicz commented on code in PR #199: URL: https://github.com/apache/logging-log4net/pull/199#discussion_r1815746788 ## src/log4net/Core/LoggingEvent.cs: ## @@ -742,15 +742,27 @@ private static string ReviseThreadName(string? threadName) { if (_platformDoesNotSuppo

Re: [PR] Fix empty string received by .NET 8 users on Linux on userName (logging-log4net)

2024-10-24 Thread via GitHub
gdziadkiewicz commented on code in PR #199: URL: https://github.com/apache/logging-log4net/pull/199#discussion_r1815747143 ## src/log4net/Core/LoggingEvent.cs: ## @@ -742,15 +742,27 @@ private static string ReviseThreadName(string? threadName) { if (_platformDoesNotSuppo

Re: [I] SIGSEV in log4cxx::helpers::Class::toString() [logging-log4cxx]

2024-10-24 Thread via GitHub
rm5248 commented on issue #420: URL: https://github.com/apache/logging-log4cxx/issues/420#issuecomment-2436213853 Line 101 is [the definition of the function](https://github.com/apache/logging-log4cxx/blob/0ff3c8a454bd2de1bd911293af8febe42ab25b70/src/main/cpp/class.cpp#L101), which is odd.

Re: [I] SIGSEV in log4cxx::helpers::Class::toString() [logging-log4cxx]

2024-10-24 Thread via GitHub
dingetje commented on issue #420: URL: https://github.com/apache/logging-log4cxx/issues/420#issuecomment-2435596860 I've build using static APR and APU libraries because there are already older versions installed: ~/projects/cmake/cmake-3.13.5-Linux-x86_64/bin/cmake -B build/

[I] SIGSEV in log4cxx::helpers::Class::toString() [logging-log4cxx]

2024-10-24 Thread via GitHub
dingetje opened a new issue, #420: URL: https://github.com/apache/logging-log4cxx/issues/420 I have build log4cxx 1.3.0 from source using CMake on RHEL7 with devtools-11 All tests are pass, But when I link this log4cpp into my own shared library the application crashes immedia

Re: [PR] Create `DefaultLayout` independent of `PatternLayout` (logging-log4j2)

2024-10-24 Thread via GitHub
ppkarwasz commented on code in PR #3118: URL: https://github.com/apache/logging-log4j2/pull/3118#discussion_r1814743047 ## log4j-core/src/main/java/org/apache/logging/log4j/core/config/DefaultConfiguration.java: ## @@ -49,4 +61,60 @@ public DefaultConfiguration() { @Overr

Re: [PR] Create `DefaultLayout` independent of `PatternLayout` (logging-log4j2)

2024-10-24 Thread via GitHub
ppkarwasz commented on code in PR #3118: URL: https://github.com/apache/logging-log4j2/pull/3118#discussion_r1814744252 ## log4j-core/src/main/java/org/apache/logging/log4j/core/config/DefaultConfiguration.java: ## @@ -49,4 +61,60 @@ public DefaultConfiguration() { @Overr

Re: [PR] Bump actions/checkout from 4.2.1 to 4.2.2 [logging-parent]

2024-10-24 Thread via GitHub
github-actions[bot] merged PR #278: URL: https://github.com/apache/logging-parent/pull/278 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications

Re: [I] CompositeFilter doesn't work with multiple MarkerFilters (logging-log4j2)

2024-10-24 Thread via GitHub
mgaceanu closed issue #3104: CompositeFilter doesn't work with multiple MarkerFilters URL: https://github.com/apache/logging-log4j2/issues/3104 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

Re: [PR] file scoped namespaces and CA warnings fixed in examples (logging-log4net)

2024-10-24 Thread via GitHub
FreeAndNil merged PR #202: URL: https://github.com/apache/logging-log4net/pull/202 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubsc

Re: [PR] Add separate reproducibility check workflow [logging-parent]

2024-10-24 Thread via GitHub
ppkarwasz commented on PR #271: URL: https://github.com/apache/logging-parent/pull/271#issuecomment-2434636374 Before reviewing this, please check #270 on which this PR is based. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] Run integration tests after each deployment (logging-log4j2)

2024-10-24 Thread via GitHub
ppkarwasz commented on PR #3105: URL: https://github.com/apache/logging-log4j2/pull/3105#issuecomment-2434613030 This workflow completed the reproducibility tests in this PR correctly: https://github.com/apache/logging-log4j2/actions/runs/11386725748 -- This is an automated message from t

Re: [PR] Create `DefaultLayout` independent of `PatternLayout` (logging-log4j2)

2024-10-24 Thread via GitHub
vy commented on code in PR #3118: URL: https://github.com/apache/logging-log4j2/pull/3118#discussion_r1814490921 ## log4j-core/src/main/java/org/apache/logging/log4j/core/config/DefaultConfiguration.java: ## @@ -49,4 +61,60 @@ public DefaultConfiguration() { @Override

Re: [PR] Enable Microsoft.CodeAnalysis.NetAnalyzers (logging-log4net)

2024-10-24 Thread via GitHub
FreeAndNil commented on code in PR #201: URL: https://github.com/apache/logging-log4net/pull/201#discussion_r1814398417 ## src/log4net.Tests/Appender/AdoNet/Log4NetCommand.cs: ## @@ -24,7 +24,7 @@ namespace log4net.Tests.Appender.AdoNet; -public class Log4NetCommand : IDbCo

Re: [PR] Enable Microsoft.CodeAnalysis.NetAnalyzers (logging-log4net)

2024-10-24 Thread via GitHub
ppkarwasz commented on code in PR #201: URL: https://github.com/apache/logging-log4net/pull/201#discussion_r1814394802 ## src/log4net.Tests/Appender/AdoNet/Log4NetCommand.cs: ## @@ -24,7 +24,7 @@ namespace log4net.Tests.Appender.AdoNet; -public class Log4NetCommand : IDbCom

Re: [PR] Enable Microsoft.CodeAnalysis.NetAnalyzers (logging-log4net)

2024-10-24 Thread via GitHub
FreeAndNil merged PR #201: URL: https://github.com/apache/logging-log4net/pull/201 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubsc

Re: [PR] Avoid levels like `INFO#org.apache.log4j.Level` (logging-log4j2)

2024-10-24 Thread via GitHub
ppkarwasz commented on PR #3085: URL: https://github.com/apache/logging-log4j2/pull/3085#issuecomment-2434469644 @jonasrutishauser, Thank You for your contribution! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

Re: [PR] Avoid levels like `INFO#org.apache.log4j.Level` (logging-log4j2)

2024-10-24 Thread via GitHub
ppkarwasz merged PR #3085: URL: https://github.com/apache/logging-log4j2/pull/3085 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubsc