Re: [PR] Provide guidelines and templates for the release process [logging-log4cxx]

2024-10-09 Thread via GitHub
ppkarwasz commented on PR #413: URL: https://github.com/apache/logging-log4cxx/pull/413#issuecomment-2404141765 Hi Stephen, > > Commit everything to the dev subversion repository. > > What will we use to trigger this? I do not believe we should to do it on every commit.

Re: [PR] Provide guidelines and templates for the release process [logging-log4cxx]

2024-10-09 Thread via GitHub
swebb2066 commented on PR #413: URL: https://github.com/apache/logging-log4cxx/pull/413#issuecomment-2403705759 > Commit everything to the dev subversion repository. What will we use to trigger this? I do not believe we should to do it on every commit. -- This is an automated messa

Re: [PR] Fix Android-related issues in Log4j Core (logging-log4j2)

2024-10-09 Thread via GitHub
ppkarwasz commented on code in PR #3071: URL: https://github.com/apache/logging-log4j2/pull/3071#discussion_r1794184423 ## log4j-core/src/main/java/org/apache/logging/log4j/core/lookup/JmxRuntimeInputArgumentsLookup.java: ## @@ -31,17 +34,16 @@ @Plugin(name = "jvmrunargs", cate

Re: [PR] Enable automatic Android tests [logging-log4j-samples]

2024-10-09 Thread via GitHub
ppkarwasz commented on code in PR #198: URL: https://github.com/apache/logging-log4j-samples/pull/198#discussion_r1794180099 ## log4j-samples-android/gradlew: ## @@ -17,67 +17,101 @@ # ## -## -## G

Re: [PR] Provide guidelines and templates for the release process [logging-log4cxx]

2024-10-09 Thread via GitHub
ppkarwasz commented on code in PR #413: URL: https://github.com/apache/logging-log4cxx/pull/413#discussion_r1794137931 ## admin/releasing.md: ## @@ -0,0 +1,68 @@ +Releasing a Log4cxx version +=== + +This document lists the steps that must be performed to release

Re: [PR] Use a random `${test:logging.path}` (logging-log4j2)

2024-10-09 Thread via GitHub
ppkarwasz commented on code in PR #2954: URL: https://github.com/apache/logging-log4j2/pull/2954#discussion_r1794131668 ## log4j-api-test/src/main/java/org/apache/logging/log4j/test/junit/TempLoggingDirectory.java: ## @@ -135,6 +132,29 @@ private PathHolder createLoggingPath(fin

Re: [PR] Document GraalVM usage with Log4j (logging-log4j2)

2024-10-09 Thread via GitHub
ppkarwasz merged PR #3054: URL: https://github.com/apache/logging-log4j2/pull/3054 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubsc

Re: [PR] Upgrades JUnit to version `5.11.2` (logging-log4j2)

2024-10-09 Thread via GitHub
ppkarwasz commented on code in PR #3069: URL: https://github.com/apache/logging-log4j2/pull/3069#discussion_r1794129224 ## log4j-core-test/src/main/java/org/apache/logging/log4j/core/test/junit/package-info.java: ## @@ -20,7 +20,7 @@ * @see org.junit.rules.TestRule */ @Expo

[PR] Prefix stack traces with a newline in Pattern Layout (logging-log4j2)

2024-10-09 Thread via GitHub
vy opened a new pull request, #3073: URL: https://github.com/apache/logging-log4j2/pull/3073 Ports #3045 to `main`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

Re: [PR] Prefix stack traces with a newline in Pattern Layout (logging-log4j2)

2024-10-09 Thread via GitHub
vy merged PR #3045: URL: https://github.com/apache/logging-log4j2/pull/3045 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@lo

Re: [PR] Prefix stack traces with a newline in Pattern Layout (logging-log4j2)

2024-10-09 Thread via GitHub
vy commented on code in PR #3045: URL: https://github.com/apache/logging-log4j2/pull/3045#discussion_r1793563712 ## log4j-core-test/src/test/java/org/apache/logging/log4j/core/EventParameterMemoryLeakTest.java: ## @@ -64,20 +63,15 @@ public void testParametersAreNotLeaked() thro

Re: [PR] Prefix stack traces with a newline in Pattern Layout (logging-log4j2)

2024-10-09 Thread via GitHub
ppkarwasz commented on code in PR #3045: URL: https://github.com/apache/logging-log4j2/pull/3045#discussion_r1793558443 ## log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/ThrowableStackTraceRendererFactory.java: ## @@ -0,0 +1,33 @@ +/* + * Licensed to the Apache S

Re: [PR] Prefix stack traces with a newline in Pattern Layout (logging-log4j2)

2024-10-09 Thread via GitHub
ppkarwasz commented on code in PR #3045: URL: https://github.com/apache/logging-log4j2/pull/3045#discussion_r179381 ## log4j-core-test/src/test/java/org/apache/logging/log4j/core/EventParameterMemoryLeakTest.java: ## @@ -64,20 +63,15 @@ public void testParametersAreNotLeaked

Re: [PR] Fix Android-related issues in Log4j Core (logging-log4j2)

2024-10-09 Thread via GitHub
vy commented on code in PR #3071: URL: https://github.com/apache/logging-log4j2/pull/3071#discussion_r1793523300 ## log4j-core/src/main/java/org/apache/logging/log4j/core/lookup/JmxRuntimeInputArgumentsLookup.java: ## @@ -31,17 +34,16 @@ @Plugin(name = "jvmrunargs", category =

Re: [PR] Enable automatic Android tests [logging-log4j-samples]

2024-10-09 Thread via GitHub
vy commented on code in PR #198: URL: https://github.com/apache/logging-log4j-samples/pull/198#discussion_r1793507975 ## log4j-samples-android/gradlew: ## @@ -17,67 +17,101 @@ # ## -## -## Gradle s

Re: [PR] Extract Nexus URL using `nexus-staging-maven-plugin` [logging-parent]

2024-10-09 Thread via GitHub
vy merged PR #246: URL: https://github.com/apache/logging-parent/pull/246 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logg

Re: [PR] Provide guidelines and templates for the release process [logging-log4cxx]

2024-10-09 Thread via GitHub
rm5248 commented on code in PR #413: URL: https://github.com/apache/logging-log4cxx/pull/413#discussion_r1793397109 ## admin/releasing.md: ## @@ -0,0 +1,68 @@ +Releasing a Log4cxx version +=== + +This document lists the steps that must be performed to release Log

Re: [PR] Provide guidelines and templates for the release process [logging-log4cxx]

2024-10-09 Thread via GitHub
rm5248 commented on PR #413: URL: https://github.com/apache/logging-log4cxx/pull/413#issuecomment-2402127948 Are these the review instructions you're talking about? https://lists.apache.org/thread/4vr3k0jfdn8rtl2ck1p0gw9y2gj6tckv -- This is an automated message from the Apache Git Service

Re: [PR] Document GraalVM usage with Log4j (logging-log4j2)

2024-10-09 Thread via GitHub
vy commented on code in PR #3054: URL: https://github.com/apache/logging-log4j2/pull/3054#discussion_r1793361891 ## src/site/antora/modules/ROOT/pages/graalvm.adoc: ## @@ -0,0 +1,128 @@ + + Licensed to the Apache Software Foundation (ASF) under one or more + contributor lice

Re: [PR] Use a random `${test:logging.path}` (logging-log4j2)

2024-10-09 Thread via GitHub
vy commented on code in PR #2954: URL: https://github.com/apache/logging-log4j2/pull/2954#discussion_r1793353005 ## log4j-api-test/src/main/java/org/apache/logging/log4j/test/junit/TempLoggingDirectory.java: ## @@ -135,6 +132,29 @@ private PathHolder createLoggingPath(final Ext

Re: [PR] Upgrades JUnit to version `5.11.2` (logging-log4j2)

2024-10-09 Thread via GitHub
vy commented on code in PR #3069: URL: https://github.com/apache/logging-log4j2/pull/3069#discussion_r1793343038 ## log4j-core-test/src/main/java/org/apache/logging/log4j/core/test/junit/package-info.java: ## @@ -20,7 +20,7 @@ * @see org.junit.rules.TestRule */ @Export -@Ve

Re: [PR] Prefix stack traces with a newline in Pattern Layout (logging-log4j2)

2024-10-09 Thread via GitHub
vy commented on code in PR #3045: URL: https://github.com/apache/logging-log4j2/pull/3045#discussion_r1793337694 ## log4j-core-test/src/test/java/org/apache/logging/log4j/core/layout/PatternLayoutDefaultExceptionHandlerTest.java: ## @@ -0,0 +1,66 @@ +/* + * Licensed to the Apach

Re: [PR] Prefix stack traces with a newline in Pattern Layout (logging-log4j2)

2024-10-09 Thread via GitHub
vy commented on code in PR #3045: URL: https://github.com/apache/logging-log4j2/pull/3045#discussion_r1793337368 ## log4j-core-test/src/test/java/org/apache/logging/log4j/core/impl/NestedLoggingFromThrowableMessageTest.java: ## @@ -80,14 +80,15 @@ public void testNestedLoggingIn

Re: [PR] Prefix stack traces with a newline in Pattern Layout (logging-log4j2)

2024-10-09 Thread via GitHub
vy commented on code in PR #3045: URL: https://github.com/apache/logging-log4j2/pull/3045#discussion_r1793335685 ## log4j-core-test/src/test/java/org/apache/logging/log4j/core/EventParameterMemoryLeakTest.java: ## @@ -64,20 +63,15 @@ public void testParametersAreNotLeaked() thro

Re: [PR] Prefix stack traces with a newline in Pattern Layout (logging-log4j2)

2024-10-09 Thread via GitHub
vy commented on code in PR #3045: URL: https://github.com/apache/logging-log4j2/pull/3045#discussion_r1793313669 ## log4j-layout-template-json/src/main/java/org/apache/logging/log4j/layout/template/json/JsonTemplateLayoutDefaults.java: ## @@ -93,7 +95,7 @@ public static String g

Re: [PR] Prefix stack traces with a newline in Pattern Layout (logging-log4j2)

2024-10-09 Thread via GitHub
vy commented on code in PR #3045: URL: https://github.com/apache/logging-log4j2/pull/3045#discussion_r1793306440 ## log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/ThrowablePropertyRendererFactory.java: ## @@ -0,0 +1,120 @@ +/* + * Licensed to the Apache Software

Re: [PR] Prefix stack traces with a newline in Pattern Layout (logging-log4j2)

2024-10-09 Thread via GitHub
vy commented on code in PR #3045: URL: https://github.com/apache/logging-log4j2/pull/3045#discussion_r1793306069 ## log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/ThrowableStackTraceRendererFactory.java: ## @@ -0,0 +1,33 @@ +/* + * Licensed to the Apache Software

Re: [PR] Bump site-logback.version from 1.4.14 to 1.5.9 (logging-log4j2)

2024-10-09 Thread via GitHub
github-actions[bot] merged PR #3072: URL: https://github.com/apache/logging-log4j2/pull/3072 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

Re: [PR] Bump actions/cache from 4.1.0 to 4.1.1 [logging-parent]

2024-10-09 Thread via GitHub
github-actions[bot] merged PR #263: URL: https://github.com/apache/logging-parent/pull/263 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications

[PR] Enable automatic Android tests [logging-log4j-samples]

2024-10-09 Thread via GitHub
ppkarwasz opened a new pull request, #198: URL: https://github.com/apache/logging-log4j-samples/pull/198 This PR is a work in progress to enable automatic tests of Log4j Core on Android. -- This is an automated message from the Apache Git Service. To respond to the message, please log on