Re: [PR] Fix building with mingw-w64-gcc [logging-log4cxx]

2024-07-09 Thread via GitHub
MehdiChinoune commented on code in PR #389: URL: https://github.com/apache/logging-log4cxx/pull/389#discussion_r1671562294 ## CMakeLists.txt: ## @@ -170,35 +170,33 @@ IF(MSVC AND BUILD_SHARED_LIBS AND LOG4CXX_INSTALL_PDB) ) ENDIF() -if(UNIX) - # Support for pkg-config in

Re: [PR] Bump org.assertj:assertj-bom from 3.26.0 to 3.26.3 [logging-log4j-samples]

2024-07-09 Thread via GitHub
github-actions[bot] closed pull request #155: Bump org.assertj:assertj-bom from 3.26.0 to 3.26.3 URL: https://github.com/apache/logging-log4j-samples/pull/155 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] Fix building with mingw-w64-gcc [logging-log4cxx]

2024-07-09 Thread via GitHub
rm5248 commented on code in PR #389: URL: https://github.com/apache/logging-log4cxx/pull/389#discussion_r1671389085 ## CMakeLists.txt: ## @@ -170,35 +170,33 @@ IF(MSVC AND BUILD_SHARED_LIBS AND LOG4CXX_INSTALL_PDB) ) ENDIF() -if(UNIX) - # Support for pkg-config in consumi

Re: [PR] Bump org.assertj:assertj-core from 3.26.0 to 3.26.3 [logging-log4j-transform]

2024-07-09 Thread via GitHub
github-actions[bot] closed pull request #112: Bump org.assertj:assertj-core from 3.26.0 to 3.26.3 URL: https://github.com/apache/logging-log4j-transform/pull/112 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

Re: [PR] Consolidate stack trace rendering in Pattern Layout (logging-log4j2)

2024-07-09 Thread via GitHub
rgoers commented on PR #2691: URL: https://github.com/apache/logging-log4j2/pull/2691#issuecomment-2218458104 I do like Piotr's proposal of configuring the stack trace as a sub-element. However, I would do that as a separate follow-on item. The work being proposed here is already fairly inv

Re: [I] SimpleLayout in log4j-1.2-api does not log anything (logging-log4j2)

2024-07-09 Thread via GitHub
kojinoguchi commented on issue #2722: URL: https://github.com/apache/logging-log4j2/issues/2722#issuecomment-2218438839 > When a Log4j 1 configuration is read, SimpleLayout component will be replaced with a PatternLayout > Aaah, I see. In that case, I would have preferred if this em

Re: [I] SimpleLayout in log4j-1.2-api does not log anything (logging-log4j2)

2024-07-09 Thread via GitHub
vy closed issue #2722: SimpleLayout in log4j-1.2-api does not log anything URL: https://github.com/apache/logging-log4j2/issues/2722 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

Re: [I] SimpleLayout in log4j-1.2-api does not log anything (logging-log4j2)

2024-07-09 Thread via GitHub
vy commented on issue #2722: URL: https://github.com/apache/logging-log4j2/issues/2722#issuecomment-2218431608 @kojinoguchi, `SimpleLayout` is by design a no-op. When a Log4j 1 configuration is read, `SimpleLayout` component will be replaced with a `PatternLayout` – see `SimpleLayoutBuilde

Re: [I] Cache LoggerContext in log4j-slf4j-impl (logging-log4j2)

2024-07-09 Thread via GitHub
vy closed issue #2720: Cache LoggerContext in log4j-slf4j-impl URL: https://github.com/apache/logging-log4j2/issues/2720 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[PR] Fix building with mingw-w64-gcc [logging-log4cxx]

2024-07-09 Thread via GitHub
MehdiChinoune opened a new pull request, #389: URL: https://github.com/apache/logging-log4cxx/pull/389 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

Re: [I] Fails to build with mingw-w64-gcc [logging-log4cxx]

2024-07-09 Thread via GitHub
MehdiChinoune commented on issue #388: URL: https://github.com/apache/logging-log4cxx/issues/388#issuecomment-2217982734 > > In MSYS2 we have many environments/variants > > So what macros are provided to determine the default threading backend? That's what I am asking the maint

Re: [I] Cache LoggerContext in log4j-slf4j-impl (logging-log4j2)

2024-07-09 Thread via GitHub
ppkarwasz commented on issue #2720: URL: https://github.com/apache/logging-log4j2/issues/2720#issuecomment-2217954069 @blaghed, > After receiving your feedback and going again through the mentioned code, I can't really find a nice way to "cache" the `LoggerContext` in order to preve

Re: [I] Cache LoggerContext in log4j-slf4j-impl (logging-log4j2)

2024-07-09 Thread via GitHub
blaghed commented on issue #2720: URL: https://github.com/apache/logging-log4j2/issues/2720#issuecomment-2217835213 Thanks for having a look. After receiving your feedback and going again through the mentioned code, I can't really find a nice way to "cache" the `LoggerContext` in order t

Re: [I] `StrSubstitutor` cannot parse nested braces (logging-log4j2)

2024-07-09 Thread via GitHub
ngocnhan-tran1996 commented on issue #2679: URL: https://github.com/apache/logging-log4j2/issues/2679#issuecomment-2217727929 I am looking forward to log4j2 new version, so many things have to done :D -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [I] Fails to build with mingw-w64-gcc [logging-log4cxx]

2024-07-09 Thread via GitHub
swebb2066 commented on issue #388: URL: https://github.com/apache/logging-log4cxx/issues/388#issuecomment-2217522030 > In MSYS2 we have many environments/variants So what macros are provided to determine the default threading backend? -- This is an automated message from the Apache

Re: [I] `StrSubstitutor` cannot parse nested braces (logging-log4j2)

2024-07-09 Thread via GitHub
ppkarwasz commented on issue #2679: URL: https://github.com/apache/logging-log4j2/issues/2679#issuecomment-2217263541 After discussing in with @vy on Slack, I believe we should coherently use `$` as escape character, with the following rules: 1. The escape character `$` only applies

Re: [PR] StrSubstitutor cannot parse nested braces (logging-log4j2)

2024-07-09 Thread via GitHub
ngocnhan-tran1996 closed pull request #2712: StrSubstitutor cannot parse nested braces URL: https://github.com/apache/logging-log4j2/pull/2712 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

Re: [PR] StrSubstitutor cannot parse nested braces (logging-log4j2)

2024-07-09 Thread via GitHub
ngocnhan-tran1996 commented on PR #2712: URL: https://github.com/apache/logging-log4j2/pull/2712#issuecomment-2217232851 @ppkarwasz I see, thanks for your help. I will close this PR -- This is an automated message from the Apache Git Service. To respond to the message, please log o

Re: [I] `PatternResolver` does not support substitution (logging-log4j2)

2024-07-09 Thread via GitHub
ppkarwasz commented on issue #2666: URL: https://github.com/apache/logging-log4j2/issues/2666#issuecomment-2217034113 **Remark**: You can easily workaround the problem with the evaluation of `${env:TZ:-%d{-MM-dd HH:mm:ss.SSS}{UTC+07}}` by: * either defining a `TZ` configuration p

Re: [I] Fails to build with mingw-w64-gcc [logging-log4cxx]

2024-07-09 Thread via GitHub
MehdiChinoune commented on issue #388: URL: https://github.com/apache/logging-log4cxx/issues/388#issuecomment-2216922014 You don't understand In MSYS2 we have many environments/variants https://www.msys2.org/docs/environments/ In MINGW64 libstdc++ is the default c++ library and It's u

Re: [I] Fails to build with mingw-w64-gcc [logging-log4cxx]

2024-07-09 Thread via GitHub
swebb2066 commented on issue #388: URL: https://github.com/apache/logging-log4cxx/issues/388#issuecomment-2216901619 > If you try to use one with the other It won't work. Using the following code ``` #include #include int main(){ pthread_t tid = pthread_self(

Re: [I] Fails to build with mingw-w64-gcc [logging-log4cxx]

2024-07-09 Thread via GitHub
MehdiChinoune commented on issue #388: URL: https://github.com/apache/logging-log4cxx/issues/388#issuecomment-2216843317 > > The issue is about detecting the C++ threading backend on MinGW. > > It seems pthread and Win32 threading are available. We need to pick one. No, that's

Re: [PR] Bump com.fasterxml.jackson:jackson-bom from 2.17.1 to 2.17.2 (logging-log4j2)

2024-07-09 Thread via GitHub
github-actions[bot] closed pull request #2718: Bump com.fasterxml.jackson:jackson-bom from 2.17.1 to 2.17.2 URL: https://github.com/apache/logging-log4j2/pull/2718 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

Re: [PR] StrSubstitutor cannot parse nested braces (logging-log4j2)

2024-07-09 Thread via GitHub
ppkarwasz commented on PR #2712: URL: https://github.com/apache/logging-log4j2/pull/2712#issuecomment-2216804216 > IMHO `StrLookup` should be aware of the existence and syntax of pattern specifiers `%{...}`, it should just count the number of `{` and `}`. We also need to have a mechanism to