Re: [PR] Update XmlLayoutSchemaLog4j.cs to set writer.Namespaces = true for NETSTANDARD (logging-log4net)

2024-06-14 Thread via GitHub
FreeAndNil commented on PR #151: URL: https://github.com/apache/logging-log4net/pull/151#issuecomment-2168667973 Hi Marc, thanks for your contribution. Can you please - rebase your branch onto [Feature/111-Dropping-support-for-older-runtimes](https://github.com/apache/lo

Re: [PR] Create "Migrate from Log4j 2" page (logging-log4j2)

2024-06-14 Thread via GitHub
ppkarwasz commented on code in PR #2654: URL: https://github.com/apache/logging-log4j2/pull/2654#discussion_r1640136895 ## src/site/antora/modules/ROOT/pages/manual/migration.adoc: ## @@ -16,5 +16,247 @@ Licensed to the Apache Software Foundation (ASF) under one or more

Re: [PR] Create "Migrate from Log4j 2" page (logging-log4j2)

2024-06-14 Thread via GitHub
ppkarwasz commented on code in PR #2654: URL: https://github.com/apache/logging-log4j2/pull/2654#discussion_r1640135951 ## src/site/antora/modules/ROOT/pages/manual/migration.adoc: ## @@ -16,5 +16,247 @@ Licensed to the Apache Software Foundation (ASF) under one or more

Re: [PR] Create "Migrate from Log4j 2" page (logging-log4j2)

2024-06-14 Thread via GitHub
ppkarwasz commented on code in PR #2654: URL: https://github.com/apache/logging-log4j2/pull/2654#discussion_r1640135454 ## src/site/antora/modules/ROOT/pages/manual/migration.adoc: ## @@ -16,5 +16,247 @@ Licensed to the Apache Software Foundation (ASF) under one or more

Re: [PR] Create "Migrate from Log4j 2" page (logging-log4j2)

2024-06-14 Thread via GitHub
ppkarwasz commented on code in PR #2654: URL: https://github.com/apache/logging-log4j2/pull/2654#discussion_r1640136244 ## src/site/antora/modules/ROOT/pages/manual/migration.adoc: ## @@ -16,5 +16,247 @@ Licensed to the Apache Software Foundation (ASF) under one or more

Re: [PR] Split "Configuration" page (`2.x` branch) (logging-log4j2)

2024-06-14 Thread via GitHub
ppkarwasz merged PR #2658: URL: https://github.com/apache/logging-log4j2/pull/2658 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubsc

Re: [PR] Add Logback example to "Markers" page (logging-log4j2)

2024-06-14 Thread via GitHub
ppkarwasz commented on code in PR #2660: URL: https://github.com/apache/logging-log4j2/pull/2660#discussion_r1640116313 ## src/site/antora/modules/ROOT/examples/manual/markers/log4j2.xml: ## @@ -25,16 +25,14 @@ +

Re: [PR] Add Logback example to "Markers" page (logging-log4j2)

2024-06-14 Thread via GitHub
ppkarwasz commented on code in PR #2660: URL: https://github.com/apache/logging-log4j2/pull/2660#discussion_r1640114681 ## src/site/antora/modules/ROOT/pages/manual/markers.adoc: ## @@ -61,88 +61,110 @@ include::example$manual/markers/marker-filtering.log[tag=use-marker] A mar

Re: [PR] Fix `flowtracing.adoc` examples (logging-log4j2)

2024-06-14 Thread via GitHub
ppkarwasz commented on code in PR #2662: URL: https://github.com/apache/logging-log4j2/pull/2662#discussion_r1640060322 ## src/site/antora/modules/ROOT/pages/manual/flowtracing.adoc: ## @@ -14,109 +14,94 @@ See the License for the specific language governing permissions and

Re: [PR] Improve documentation on structured logging (logging-log4j2)

2024-06-14 Thread via GitHub
ppkarwasz commented on code in PR #2665: URL: https://github.com/apache/logging-log4j2/pull/2665#discussion_r1640008495 ## src/changelog/.2.x.x/deprecate_EventLogger.xml: ## @@ -0,0 +1,7 @@ + +http://www.w3.org/2001/XMLSchema-instance"; + xmlns="https://logging.apache.org/

[PR] Update XmlLayoutSchemaLog4j.cs to set writer.Namespaces = true for NETSTANDARD (logging-log4net)

2024-06-14 Thread via GitHub
MarcWeintraub opened a new pull request, #151: URL: https://github.com/apache/logging-log4net/pull/151 Formatting is off when using .NET 6+ when outing in Log2Console. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[I] Log4j2 TemplateLayout will support Property Substitution or Lookups? (logging-log4j2)

2024-06-14 Thread via GitHub
ngocnhan-tran1996 opened a new issue, #2666: URL: https://github.com/apache/logging-log4j2/issues/2666 I have an application use log4j2 template layout with below config File `EcsLayout.json` ```json { "message1": { "$resolver": "pattern", "pattern": "${env:TZ:

[PR] Improve documentation on structured logging (logging-log4j2)

2024-06-14 Thread via GitHub
vy opened a new pull request, #2665: URL: https://github.com/apache/logging-log4j2/pull/2665 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-

Re: [I] The `append` option in file appender doesn't work properly (logging-log4j2)

2024-06-14 Thread via GitHub
taylorThunderbolt commented on issue #2661: URL: https://github.com/apache/logging-log4j2/issues/2661#issuecomment-2168115153 @ppkarwasz @rgoers got you guys point, thanks a lot ^_^ -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

Re: [PR] Bump spring-framework.version from 6.1.8 to 6.1.9 (logging-log4j2)

2024-06-14 Thread via GitHub
github-actions[bot] merged PR #2664: URL: https://github.com/apache/logging-log4j2/pull/2664 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

Re: [PR] Bump org.elasticsearch.client:elasticsearch-rest-high-level-client from 7.17.21 to 7.17.22 (logging-log4j2)

2024-06-14 Thread via GitHub
github-actions[bot] merged PR #2663: URL: https://github.com/apache/logging-log4j2/pull/2663 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

Re: [PR] Bump github/codeql-action from 3.25.9 to 3.25.10 [logging-parent]

2024-06-14 Thread via GitHub
github-actions[bot] merged PR #193: URL: https://github.com/apache/logging-parent/pull/193 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications

Re: [PR] Add Logback example to "Markers" page (logging-log4j2)

2024-06-14 Thread via GitHub
vy commented on code in PR #2660: URL: https://github.com/apache/logging-log4j2/pull/2660#discussion_r1639471208 ## src/site/antora/modules/ROOT/examples/manual/markers/log4j2.xml: ## @@ -25,16 +25,14 @@ + >, you'll see the following log statement on your con

[PR] Fix `flowtracing.adoc` examples (logging-log4j2)

2024-06-14 Thread via GitHub
vy opened a new pull request, #2662: URL: https://github.com/apache/logging-log4j2/pull/2662 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-

Re: [PR] Create "Migrate from Log4j 2" page (logging-log4j2)

2024-06-14 Thread via GitHub
vy commented on code in PR #2654: URL: https://github.com/apache/logging-log4j2/pull/2654#discussion_r1639410871 ## src/site/antora/modules/ROOT/pages/manual/migration.adoc: ## @@ -16,5 +16,247 @@ Licensed to the Apache Software Foundation (ASF) under one or more = Mig