Re: [PR] Create a `Migrating from Log4j 1 to Log4j 2` guide (logging-log4j2)

vy commented on code in PR #2649: URL: https://github.com/apache/logging-log4j2/pull/2649#discussion_r1633793065 ## src/site/antora/modules/ROOT/partials/manual/systemproperties/properties-log4j-12-api.adoc: ## @@ -0,0 +1,55 @@ + +Licensed to the Apache Software Foundati

Re: [I] OutOfMemoryException because WatchManager isn't garbage collected (logging-log4j2)

rgoers commented on issue #2640: URL: https://github.com/apache/logging-log4j2/issues/2640#issuecomment-2159218799 We would need to see the logic you use to "close" the file at the end of the step. For your example it is also unclear what will happen if you have multiple instances of the

Re: [PR] Revamp the `Layouts` page (logging-log4j2)

vy commented on PR #2645: URL: https://github.com/apache/logging-log4j2/pull/2645#issuecomment-2159201471 > We could also include a link to the plugin reference, whenever we deal with a plugin, so that users can find the errors in the documentation themselves. @ppkarwasz, added in 0c

Re: [PR] Revamp the `Layouts` page (logging-log4j2)

vy commented on code in PR #2645: URL: https://github.com/apache/logging-log4j2/pull/2645#discussion_r1633740014 ## src/site/antora/modules/ROOT/pages/manual/json-template-layout.adoc: ## @@ -16,422 +16,479 @@ = JSON Template Layout -`JsonTemplateLayout` is a customizab

Re: [PR] Revamp the `Layouts` page (logging-log4j2)

vy commented on code in PR #2645: URL: https://github.com/apache/logging-log4j2/pull/2645#discussion_r1633739365 ## src/site/antora/modules/ROOT/pages/manual/json-template-layout.adoc: ## @@ -16,422 +16,479 @@ = JSON Template Layout -`JsonTemplateLayout` is a customizab

Re: [PR] Revamp the `Layouts` page (logging-log4j2)

vy commented on code in PR #2645: URL: https://github.com/apache/logging-log4j2/pull/2645#discussion_r1633738384 ## src/site/antora/modules/ROOT/pages/manual/json-template-layout.adoc: ## @@ -1983,10 +2046,10 @@ To get the most out of it, mind the following checklist: [#faq-loo

Re: [PR] Revamp the `Layouts` page (logging-log4j2)

vy commented on code in PR #2645: URL: https://github.com/apache/logging-log4j2/pull/2645#discussion_r1633707216 ## src/site/antora/modules/ROOT/pages/manual/pattern-layout.adoc: ## @@ -0,0 +1,1719 @@ + +Licensed to the Apache Software Foundation (ASF) under one or more

Re: [PR] Revamp the `Layouts` page (logging-log4j2)

vy commented on code in PR #2645: URL: https://github.com/apache/logging-log4j2/pull/2645#discussion_r1633701810 ## src/site/antora/modules/ROOT/pages/manual/pattern-layout.adoc: ## @@ -0,0 +1,1719 @@ + +Licensed to the Apache Software Foundation (ASF) under one or more

Re: [PR] Revamp the `Layouts` page (logging-log4j2)

vy commented on code in PR #2645: URL: https://github.com/apache/logging-log4j2/pull/2645#discussion_r1633701037 ## src/site/antora/modules/ROOT/pages/manual/pattern-layout.adoc: ## @@ -0,0 +1,1719 @@ + +Licensed to the Apache Software Foundation (ASF) under one or more

Re: [PR] Revamp the `Layouts` page (logging-log4j2)

vy commented on code in PR #2645: URL: https://github.com/apache/logging-log4j2/pull/2645#discussion_r1633693734 ## src/site/antora/modules/ROOT/pages/manual/pattern-layout.adoc: ## @@ -0,0 +1,1719 @@ + +Licensed to the Apache Software Foundation (ASF) under one or more

Re: [PR] Revamp the `Layouts` page (logging-log4j2)

vy commented on code in PR #2645: URL: https://github.com/apache/logging-log4j2/pull/2645#discussion_r1633692148 ## src/site/antora/modules/ROOT/pages/manual/pattern-layout.adoc: ## @@ -0,0 +1,1719 @@ + +Licensed to the Apache Software Foundation (ASF) under one or more

Re: [PR] Revamp the `Layouts` page (logging-log4j2)

vy commented on code in PR #2645: URL: https://github.com/apache/logging-log4j2/pull/2645#discussion_r1633691789 ## src/site/antora/modules/ROOT/pages/manual/layouts.adoc: ## @@ -14,2120 +14,863 @@ See the License for the specific language governing permissions and lim

Re: [PR] Revamp the `Layouts` page (logging-log4j2)

vy commented on code in PR #2645: URL: https://github.com/apache/logging-log4j2/pull/2645#discussion_r1633691523 ## src/site/antora/modules/ROOT/pages/manual/pattern-layout.adoc: ## @@ -0,0 +1,1719 @@ + +Licensed to the Apache Software Foundation (ASF) under one or more

Re: [PR] Revamp the `Layouts` page (logging-log4j2)

ppkarwasz commented on code in PR #2645: URL: https://github.com/apache/logging-log4j2/pull/2645#discussion_r1632747641 ## src/site/antora/modules/ROOT/pages/manual/layouts.adoc: ## @@ -14,2120 +14,863 @@ See the License for the specific language governing permissions and

[PR] Create a `Migrating from Log4j 1 to Log4j 2` guide (logging-log4j2)

ppkarwasz opened a new pull request, #2649: URL: https://github.com/apache/logging-log4j2/pull/2649 Closes #2519. We restructure the pages related to migration between Log4j 1 and Log4j 2 to provide a new "Step by step" guide on migrating between the two major version. The new