Re: [PR] Bump net.bytebuddy:byte-buddy from 1.14.15 to 1.14.16 [logging-log4j-samples]

2024-05-22 Thread via GitHub
github-actions[bot] merged PR #142: URL: https://github.com/apache/logging-log4j-samples/pull/142 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifi

Re: [PR] Bump org.springframework:spring-framework-bom from 6.1.7 to 6.1.8 [logging-log4j-jakarta]

2024-05-22 Thread via GitHub
github-actions[bot] merged PR #32: URL: https://github.com/apache/logging-log4j-jakarta/pull/32 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifica

Re: [PR] Rewrote manual intro (logging-log4j2)

2024-05-22 Thread via GitHub
grobmeier commented on code in PR #2581: URL: https://github.com/apache/logging-log4j2/pull/2581#discussion_r1610609691 ## src/site/antora/modules/ROOT/pages/manual/index.adoc: ## @@ -16,122 +16,52 @@ = Manual -== Welcome to Log4j! - -Almost every large application incl

Re: [I] Revamp the manual introduction (logging-log4j2)

2024-05-22 Thread via GitHub
grobmeier commented on issue #1468: URL: https://github.com/apache/logging-log4j2/issues/1468#issuecomment-2125447811 Port to 3.x: ca978bfcc71ee8303bd7c0e32ce44257a22515dc -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

Re: [PR] Move `ThreadContextMap` implementations to `log4j-core` (logging-log4j2)

2024-05-22 Thread via GitHub
rgoers commented on PR #2593: URL: https://github.com/apache/logging-log4j2/pull/2593#issuecomment-2125395381 @jengebr Thanks. I personally would love your feedback on ScopedContext and if there is anything it might be missing that would make it easier to support your use case. I would gen

Re: [PR] rewrote Markers (logging-log4j2)

2024-05-22 Thread via GitHub
grobmeier merged PR #2584: URL: https://github.com/apache/logging-log4j2/pull/2584 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubsc

Re: [PR] Move `ThreadContextMap` implementations to `log4j-core` (logging-log4j2)

2024-05-22 Thread via GitHub
jengebr commented on PR #2593: URL: https://github.com/apache/logging-log4j2/pull/2593#issuecomment-2125341002 I agree that it looks good, but the current api meets our needs, especially once perf improves via `StringArrayThreadContextMap`. There's no upside to modifying our existing appli

Re: [PR] Move `ThreadContextMap` implementations to `log4j-core` (logging-log4j2)

2024-05-22 Thread via GitHub
rgoers commented on PR #2593: URL: https://github.com/apache/logging-log4j2/pull/2593#issuecomment-2125235668 @jengebr I would suggest you look at ScopedContext that I recently added to Log4j-API. It is a much better way to manage a short-lived context. -- This is an automated message fro

Re: [PR] Move `ThreadContextMap` implementations to `log4j-core` (logging-log4j2)

2024-05-22 Thread via GitHub
jengebr commented on PR #2593: URL: https://github.com/apache/logging-log4j2/pull/2593#issuecomment-2125164934 @rgoers thank you for explaining. Unfortunately I support several applications that rely on CloseableThreadContext to track short-lived context, and those operations trigger copie

Re: [PR] Move `ThreadContextMap` implementations to `log4j-core` (logging-log4j2)

2024-05-22 Thread via GitHub
rgoers commented on PR #2593: URL: https://github.com/apache/logging-log4j2/pull/2593#issuecomment-212514 @jengebr ThreadContextDataInjector was doing all the copying into the LogEvent by making a copy of the current ThreadContextMap and then passing that copy so the fields could be inc

Re: [PR] Move `ThreadContextMap` implementations to `log4j-core` (logging-log4j2)

2024-05-22 Thread via GitHub
jengebr commented on PR #2593: URL: https://github.com/apache/logging-log4j2/pull/2593#issuecomment-2125135528 > Question: With the changes I recently made are these alternative implementations really of value to anything? The primary motivation for them seemed to be to reduce the number of

Re: [PR] Move `ThreadContextMap` implementations to `log4j-core` (logging-log4j2)

2024-05-22 Thread via GitHub
rgoers commented on PR #2593: URL: https://github.com/apache/logging-log4j2/pull/2593#issuecomment-2124969306 Question: With the changes I recently made are these alternative implementations really of value to anything? The primary motivation for them seemed to be to reduce the number of g

Re: [PR] Improve `api.adoc` et al. (logging-log4j2)

2024-05-22 Thread via GitHub
ppkarwasz commented on code in PR #2604: URL: https://github.com/apache/logging-log4j2/pull/2604#discussion_r1610040517 ## src/site/antora/modules/ROOT/partials/manual/api-intro.adoc: ## @@ -0,0 +1,72 @@ + +Licensed to the Apache Software Foundation (ASF) under one or mo

[PR] Improve `api.adoc` et al. (logging-log4j2)

2024-05-22 Thread via GitHub
vy opened a new pull request, #2604: URL: https://github.com/apache/logging-log4j2/pull/2604 Fixes following tickets: - #2535 - #1460 - #1918 ### Reviewer notes * Reviewers are recommended to checkout the branch locally, build, and view it. * Except trivial typo/gr

Re: [PR] Bump log4j-docgen.version from 0.8.0 to 0.9.0 (logging-log4j2)

2024-05-22 Thread via GitHub
github-actions[bot] merged PR #2579: URL: https://github.com/apache/logging-log4j2/pull/2579 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

Re: [PR] Rewrote manual intro (logging-log4j2)

2024-05-22 Thread via GitHub
Chealer commented on code in PR #2581: URL: https://github.com/apache/logging-log4j2/pull/2581#discussion_r1609806030 ## src/site/antora/modules/ROOT/pages/manual/index.adoc: ## @@ -16,122 +16,52 @@ = Manual -== Welcome to Log4j! - -Almost every large application includ

Re: [PR] Rewrote manual intro (logging-log4j2)

2024-05-22 Thread via GitHub
Chealer commented on code in PR #2581: URL: https://github.com/apache/logging-log4j2/pull/2581#discussion_r1609806030 ## src/site/antora/modules/ROOT/pages/manual/index.adoc: ## @@ -16,122 +16,52 @@ = Manual -== Welcome to Log4j! - -Almost every large application includ

Re: [PR] Rewrote manual intro (logging-log4j2)

2024-05-22 Thread via GitHub
Chealer commented on code in PR #2581: URL: https://github.com/apache/logging-log4j2/pull/2581#discussion_r1609800039 ## src/site/antora/modules/ROOT/partials/log4j-features.adoc: ## @@ -0,0 +1,47 @@ + +Licensed to the Apache Software Foundation (ASF) under one or more +

Re: [PR] rewrote Markers (logging-log4j2)

2024-05-22 Thread via GitHub
ppkarwasz commented on code in PR #2584: URL: https://github.com/apache/logging-log4j2/pull/2584#discussion_r1609795346 ## src/site/antora/modules/ROOT/examples/manual/markers/log4j2.xml: ## @@ -15,25 +15,29 @@ ~ See the License for the specific language governing permissions

Re: [PR] Rewrote manual intro (logging-log4j2)

2024-05-22 Thread via GitHub
Chealer commented on code in PR #2581: URL: https://github.com/apache/logging-log4j2/pull/2581#discussion_r1609789697 ## src/site/antora/modules/ROOT/pages/manual/index.adoc: ## @@ -16,122 +16,52 @@ = Manual -== Welcome to Log4j! - -Almost every large application includ

Re: [PR] Bump org.mockito:mockito-bom from 5.11.0 to 5.12.0 (logging-log4j2)

2024-05-22 Thread via GitHub
github-actions[bot] merged PR #2575: URL: https://github.com/apache/logging-log4j2/pull/2575 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

Re: [PR] Bump org.eclipse.persistence:org.eclipse.persistence.jpa from 2.7.14 to 2.7.15 (logging-log4j2)

2024-05-22 Thread via GitHub
github-actions[bot] merged PR #2602: URL: https://github.com/apache/logging-log4j2/pull/2602 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

Re: [PR] Bump org.codehaus.mojo:exec-maven-plugin from 3.2.0 to 3.3.0 [logging-parent]

2024-05-22 Thread via GitHub
github-actions[bot] merged PR #185: URL: https://github.com/apache/logging-parent/pull/185 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications

Re: [PR] Bump org.mockito:mockito-bom from 5.11.0 to 5.12.0 (logging-log4j2)

2024-05-22 Thread via GitHub
ppkarwasz commented on PR #2575: URL: https://github.com/apache/logging-log4j2/pull/2575#issuecomment-2124435871 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] rewrote Markers (logging-log4j2)

2024-05-22 Thread via GitHub
ppkarwasz commented on code in PR #2584: URL: https://github.com/apache/logging-log4j2/pull/2584#discussion_r1609690056 ## src/site/antora/modules/ROOT/pages/manual/markers.adoc: ## @@ -16,85 +16,111 @@ = Markers -One of the primary purpose of a logging framework is to

Re: [PR] rewrote Markers (logging-log4j2)

2024-05-22 Thread via GitHub
ppkarwasz commented on code in PR #2584: URL: https://github.com/apache/logging-log4j2/pull/2584#discussion_r1609689008 ## src/site/antora/modules/ROOT/pages/manual/markers.adoc: ## @@ -16,85 +16,115 @@ = Markers -One of the primary purpose of a logging framework is to

Re: [PR] Bump org.codehaus.mojo:exec-maven-plugin from 3.2.0 to 3.3.0 [logging-log4j-kotlin]

2024-05-22 Thread via GitHub
github-actions[bot] merged PR #75: URL: https://github.com/apache/logging-log4j-kotlin/pull/75 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificat

Re: [PR] Bump net.bytebuddy:byte-buddy from 1.14.14 to 1.14.15 (logging-log4j2)

2024-05-22 Thread via GitHub
github-actions[bot] merged PR #2571: URL: https://github.com/apache/logging-log4j2/pull/2571 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

Re: [PR] Bump log4j-docgen.version from 0.8.0 to 0.9.0 (logging-log4j2)

2024-05-22 Thread via GitHub
github-actions[bot] merged PR #2578: URL: https://github.com/apache/logging-log4j2/pull/2578 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

Re: [PR] Bump org.apache.tomcat:tomcat-juli from 10.1.23 to 10.1.24 (logging-log4j2)

2024-05-22 Thread via GitHub
ppkarwasz commented on PR #2580: URL: https://github.com/apache/logging-log4j2/pull/2580#issuecomment-2124059187 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] Bump log4j-docgen.version from 0.8.0 to 0.9.0 (logging-log4j2)

2024-05-22 Thread via GitHub
ppkarwasz commented on PR #2579: URL: https://github.com/apache/logging-log4j2/pull/2579#issuecomment-2124058872 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] Bump log4j-docgen.version from 0.8.0 to 0.9.0 (logging-log4j2)

2024-05-22 Thread via GitHub
ppkarwasz commented on PR #2578: URL: https://github.com/apache/logging-log4j2/pull/2578#issuecomment-2124058539 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] Bump net.bytebuddy:byte-buddy from 1.14.14 to 1.14.15 (logging-log4j2)

2024-05-22 Thread via GitHub
ppkarwasz commented on PR #2571: URL: https://github.com/apache/logging-log4j2/pull/2571#issuecomment-2124057384 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] Bump com.fasterxml.jackson:jackson-bom from 2.17.0 to 2.17.1 (logging-log4j2)

2024-05-22 Thread via GitHub
github-actions[bot] merged PR #2567: URL: https://github.com/apache/logging-log4j2/pull/2567 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

Re: [I] A problem with an abnormal log output location. (logging-log4j2)

2024-05-22 Thread via GitHub
vy closed issue #2582: A problem with an abnormal log output location. URL: https://github.com/apache/logging-log4j2/issues/2582 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [I] A problem with an abnormal log output location. (logging-log4j2)

2024-05-22 Thread via GitHub
vy commented on issue #2582: URL: https://github.com/apache/logging-log4j2/issues/2582#issuecomment-2124027437 @FrankCy, thanks for the update. I am closing the issue. Feel free to re-open it when you manage to create the minimal reproduction code that I asked for. -- This is an automat