Re: [PR] Rewrote Messages (logging-log4j2)

2024-05-16 Thread via GitHub
vy commented on PR #2591: URL: https://github.com/apache/logging-log4j2/pull/2591#issuecomment-2116863768 @grobmeier, I once started rewriting this, and back then drafted the following intro: ``` Although Log4j provides `Logger` methods that accept a formatting pattern of type `St

Re: [PR] Condition internal debug logging on its enabled state [logging-log4cxx]

2024-05-16 Thread via GitHub
swebb2066 merged PR #384: URL: https://github.com/apache/logging-log4cxx/pull/384 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr

Re: [PR] Bump org.springframework:spring-framework-bom from 5.3.34 to 5.3.35 [logging-log4j-samples]

2024-05-16 Thread via GitHub
github-actions[bot] merged PR #138: URL: https://github.com/apache/logging-log4j-samples/pull/138 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifi

Re: [PR] Bump org.eclipse.jetty:jetty-maven-plugin from 10.0.20 to 10.0.21 [logging-log4j-samples]

2024-05-16 Thread via GitHub
github-actions[bot] merged PR #137: URL: https://github.com/apache/logging-log4j-samples/pull/137 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifi

[PR] Rewrote Messages (logging-log4j2)

2024-05-16 Thread via GitHub
grobmeier opened a new pull request, #2591: URL: https://github.com/apache/logging-log4j2/pull/2591 Messages - draft, work in progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

Re: [PR] Bump org.springframework:spring-framework-bom from 6.1.5 to 6.1.7 [logging-log4j-jakarta]

2024-05-16 Thread via GitHub
github-actions[bot] merged PR #30: URL: https://github.com/apache/logging-log4j-jakarta/pull/30 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifica

Re: [PR] rewrote Markers (logging-log4j2)

2024-05-16 Thread via GitHub
ppkarwasz commented on code in PR #2584: URL: https://github.com/apache/logging-log4j2/pull/2584#discussion_r1603928334 ## src/site/antora/modules/ROOT/pages/manual/markers.adoc: ## @@ -16,85 +16,111 @@ = Markers -One of the primary purpose of a logging framework is to

Re: [PR] Port system properties documentation to `main` (logging-log4j2)

2024-05-16 Thread via GitHub
ppkarwasz commented on code in PR #2590: URL: https://github.com/apache/logging-log4j2/pull/2590#discussion_r1603916609 ## src/site/antora/modules/ROOT/pages/manual/systemproperties.adoc: ## @@ -14,895 +14,272 @@ See the License for the specific language governing permissio

[PR] Port system properties documentation to `main` (logging-log4j2)

2024-05-16 Thread via GitHub
ppkarwasz opened a new pull request, #2590: URL: https://github.com/apache/logging-log4j2/pull/2590 Ports to `main` the changes introduced in #2552 . Part of #2525 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] rewrote Markers (logging-log4j2)

2024-05-16 Thread via GitHub
vy commented on code in PR #2584: URL: https://github.com/apache/logging-log4j2/pull/2584#discussion_r1603860707 ## src/site/antora/modules/ROOT/pages/manual/markers.adoc: ## @@ -16,85 +16,111 @@ = Markers -One of the primary purpose of a logging framework is to provide

Re: [PR] rewrote Markers (logging-log4j2)

2024-05-16 Thread via GitHub
grobmeier commented on code in PR #2584: URL: https://github.com/apache/logging-log4j2/pull/2584#discussion_r1603815471 ## src/site/antora/modules/ROOT/pages/manual/markers.adoc: ## @@ -16,85 +16,111 @@ = Markers -One of the primary purpose of a logging framework is to

Re: [PR] rewrote Markers (logging-log4j2)

2024-05-16 Thread via GitHub
grobmeier commented on code in PR #2584: URL: https://github.com/apache/logging-log4j2/pull/2584#discussion_r1603808549 ## src/site/antora/modules/ROOT/pages/manual/markers.adoc: ## @@ -16,85 +16,111 @@ = Markers -One of the primary purpose of a logging framework is to

Re: [I] The `log4j2.messageFactory` property is ignored since 2.23.0 (logging-log4j2)

2024-05-16 Thread via GitHub
lizongbo commented on issue #2379: URL: https://github.com/apache/logging-log4j2/issues/2379#issuecomment-2115798857 > @lizongbo, > > Did you check the `2.24.0-SNAPSHOT`? Volkan's patch is not contained in version 2.23.1. Thank fo your reply, When I use 2.24.0-SNAPSHOT from h

Re: [PR] Revamp the `Asynchronous logging` page (logging-log4j2)

2024-05-16 Thread via GitHub
ppkarwasz commented on code in PR #2577: URL: https://github.com/apache/logging-log4j2/pull/2577#discussion_r1603624102 ## src/site/antora/modules/ROOT/pages/manual/async.adoc: ## @@ -14,525 +14,375 @@ See the License for the specific language governing permissions and

Re: [PR] rewrote Markers (logging-log4j2)

2024-05-16 Thread via GitHub
vy commented on code in PR #2584: URL: https://github.com/apache/logging-log4j2/pull/2584#discussion_r1603281548 ## src/site/antora/modules/ROOT/pages/manual/markers.adoc: ## @@ -16,85 +16,111 @@ = Markers -One of the primary purpose of a logging framework is to provide

Re: [PR] rewrote Markers (logging-log4j2)

2024-05-16 Thread via GitHub
vy commented on code in PR #2584: URL: https://github.com/apache/logging-log4j2/pull/2584#discussion_r1603263563 ## src/site/antora/modules/ROOT/pages/manual/markers.adoc: ## @@ -16,85 +16,111 @@ = Markers -One of the primary purpose of a logging framework is to provide

Re: [PR] Bump org.springframework:spring-framework-bom from 5.3.34 to 5.3.35 [logging-log4j-audit-sample]

2024-05-16 Thread via GitHub
github-actions[bot] closed pull request #47: Bump org.springframework:spring-framework-bom from 5.3.34 to 5.3.35 URL: https://github.com/apache/logging-log4j-audit-sample/pull/47 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

Re: [PR] Rewrote manual intro (logging-log4j2)

2024-05-16 Thread via GitHub
vy commented on PR #2581: URL: https://github.com/apache/logging-log4j2/pull/2581#issuecomment-2115010393 @grobmeier, I reused common content between `/index.adoc` and `manual/index.adoc` in 8d47758e5c3de70dc46b83dd2f2ee16e84eaaae0. I don't prefer pushing commits to other people's PR branch

[PR] Bump org.springframework:spring-framework-bom from 5.3.34 to 5.3.35 [logging-log4j-audit-sample]

2024-05-16 Thread via GitHub
dependabot[bot] opened a new pull request, #47: URL: https://github.com/apache/logging-log4j-audit-sample/pull/47 Bumps [org.springframework:spring-framework-bom](https://github.com/spring-projects/spring-framework) from 5.3.34 to 5.3.35. Release notes Sourced from https://github.

Re: [PR] Bump commons-logging:commons-logging from 1.3.1 to 1.3.2 (logging-log4j2)

2024-05-16 Thread via GitHub
github-actions[bot] merged PR #2589: URL: https://github.com/apache/logging-log4j2/pull/2589 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

Re: [PR] Bump spring-framework.version from 5.3.34 to 5.3.35 (logging-log4j2)

2024-05-16 Thread via GitHub
github-actions[bot] merged PR #2588: URL: https://github.com/apache/logging-log4j2/pull/2588 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

Re: [PR] Rewrote manual intro (logging-log4j2)

2024-05-16 Thread via GitHub
vy commented on code in PR #2581: URL: https://github.com/apache/logging-log4j2/pull/2581#discussion_r1603176421 ## src/site/antora/modules/ROOT/pages/manual/index.adoc: ## @@ -16,122 +16,57 @@ = Manual -== Welcome to Log4j! - -Almost every large application includes it

Re: [PR] Rewrote manual intro (logging-log4j2)

2024-05-16 Thread via GitHub
grobmeier commented on code in PR #2581: URL: https://github.com/apache/logging-log4j2/pull/2581#discussion_r1603126942 ## src/site/antora/modules/ROOT/pages/manual/index.adoc: ## @@ -16,122 +16,57 @@ = Manual -== Welcome to Log4j! - -Almost every large application incl

Re: [PR] Rewrote manual intro (logging-log4j2)

2024-05-16 Thread via GitHub
grobmeier commented on code in PR #2581: URL: https://github.com/apache/logging-log4j2/pull/2581#discussion_r1603124193 ## src/site/antora/modules/ROOT/pages/manual/index.adoc: ## Review Comment: I tried it, but it is a horrible mess and extremely hard for the author to wr

Re: [PR] Revamp `Configuration` page (logging-log4j2)

2024-05-16 Thread via GitHub
ppkarwasz merged PR #2574: URL: https://github.com/apache/logging-log4j2/pull/2574 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubsc

Re: [I] Revamp the `Configuration` page (logging-log4j2)

2024-05-16 Thread via GitHub
ppkarwasz closed issue #2525: Revamp the `Configuration` page URL: https://github.com/apache/logging-log4j2/issues/2525 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

Re: [PR] Rewrote manual intro (logging-log4j2)

2024-05-16 Thread via GitHub
vy commented on code in PR #2581: URL: https://github.com/apache/logging-log4j2/pull/2581#discussion_r1602715319 ## src/site/antora/modules/ROOT/pages/manual/index.adoc: ## @@ -16,122 +16,57 @@ = Manual -== Welcome to Log4j! - -Almost every large application includes it