Re: [PR] Bump org.mockito:mockito-bom from 5.11.0 to 5.12.0 [logging-log4j-jakarta]

2024-05-13 Thread via GitHub
github-actions[bot] merged PR #28: URL: https://github.com/apache/logging-log4j-jakarta/pull/28 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifica

Re: [PR] Revamp `Configuration` page (logging-log4j2)

2024-05-13 Thread via GitHub
grobmeier commented on code in PR #2574: URL: https://github.com/apache/logging-log4j2/pull/2574#discussion_r1598987120 ## src/site/antora/modules/ROOT/pages/manual/filters.adoc: ## @@ -14,32 +14,77 @@ See the License for the specific language governing permissions and

Re: [PR] Upgrade LMAX Disruptor to version `4.0.0` [logging-log4j-samples]

2024-05-13 Thread via GitHub
vy merged PR #136: URL: https://github.com/apache/logging-log4j-samples/pull/136 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr.

Re: [PR] Upgrade LMAX Disruptor to version `4.0.0` [logging-log4j-samples]

2024-05-13 Thread via GitHub
sullis commented on PR #136: URL: https://github.com/apache/logging-log4j-samples/pull/136#issuecomment-2108439592 I just pushed another update. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] Revamp `Configuration` page (logging-log4j2)

2024-05-13 Thread via GitHub
vy commented on code in PR #2574: URL: https://github.com/apache/logging-log4j2/pull/2574#discussion_r1598823140 ## src/site/antora/modules/ROOT/pages/manual/configuration.adoc: ## @@ -14,1856 +14,1024 @@ See the License for the specific language governing permissions and

Re: [PR] Revamp `Configuration` page (logging-log4j2)

2024-05-13 Thread via GitHub
vy commented on code in PR #2574: URL: https://github.com/apache/logging-log4j2/pull/2574#discussion_r1598823140 ## src/site/antora/modules/ROOT/pages/manual/configuration.adoc: ## @@ -14,1856 +14,1024 @@ See the License for the specific language governing permissions and

Re: [PR] Upgrade LMAX Disruptor to version `4.0.0` [logging-log4j-samples]

2024-05-13 Thread via GitHub
vy commented on PR #136: URL: https://github.com/apache/logging-log4j-samples/pull/136#issuecomment-2108312362 @sullis, I think you used `-s` instead of `-S` I shared. I cannot see commit signatures, but a sign-off comment. (Sorry for the trouble. As you know, I could have implemente

Re: [PR] Upgrade LMAX Disruptor to version `4.0.0` [logging-log4j-samples]

2024-05-13 Thread via GitHub
sullis commented on PR #136: URL: https://github.com/apache/logging-log4j-samples/pull/136#issuecomment-2108169629 Force pushed my latest update. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [I] Revamp the `Appenders` page (logging-log4j2)

2024-05-13 Thread via GitHub
ppkarwasz commented on issue #2528: URL: https://github.com/apache/logging-log4j2/issues/2528#issuecomment-2108162517 While restructuring the "Appenders" page we should explain the meaning of the `immediateFlush` option. Looking at #2023, #2025 and other discussions, users often think th

Re: [I] The `immediateFlush` option in both rolling file appenders is ignored (logging-log4j2)

2024-05-13 Thread via GitHub
ppkarwasz commented on issue #2025: URL: https://github.com/apache/logging-log4j2/issues/2025#issuecomment-2108131274 Actually there is another usage of `immediateFlush`: resource managers use a `ByteBuffer` to format each log event. If `immediateFlush` is `true`, the byte buffer is

Re: [PR] Upgrade LMAX Disruptor to version `4.0.0` [logging-log4j-samples]

2024-05-13 Thread via GitHub
vy commented on PR #136: URL: https://github.com/apache/logging-log4j-samples/pull/136#issuecomment-2107573938 @sullis, you need to sign your commits too: ``` git reset HEAD~2 git commit -a -S -m 'Upgrade LMAX Disruptor to version 4.0.0 (#136)' git push -f origin ``` --

Re: [PR] Upgrade LMAX Disruptor to version `4.0.0` [logging-log4j-samples]

2024-05-13 Thread via GitHub
sullis commented on PR #136: URL: https://github.com/apache/logging-log4j-samples/pull/136#issuecomment-2107523029 > @sullis, could you remove [this dependabot ignore rule](https://github.com/apache/logging-log4j-samples/blob/44c3348906d2d160e6affd152e63eaa0c0554d76/.github/dependabot.yaml#