[PR] Improve AsyncAppender throughput [logging-log4cxx]

2024-04-27 Thread via GitHub
swebb2066 opened a new pull request, #377: URL: https://github.com/apache/logging-log4cxx/pull/377 This PR enables a higher rate at which logging events to be sent through AsyncAppender by avoiding some lock contention inside the `bufferNotEmpty` [std::condition_variable](https://en.cpprefe

[PR] AsyncAppender's queue length not being output on Windows [logging-log4cxx]

2024-04-27 Thread via GitHub
swebb2066 opened a new pull request, #376: URL: https://github.com/apache/logging-log4cxx/pull/376 This PR ensures AsyncAppender::close is called before Windows terminates the AsyncAppender::dispatch thread -- This is an automated message from the Apache Git Service. To respond to the mes

[PR] Add a simple termination test using AsyncAppender [logging-log4cxx]

2024-04-27 Thread via GitHub
swebb2066 opened a new pull request, #375: URL: https://github.com/apache/logging-log4cxx/pull/375 This PR adds a test (initially failing on Windows) that uses AsyncAppender -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [I] log4j-core: Name/description not so clear (logging-log4j2)

2024-04-27 Thread via GitHub
Chealer commented on issue #1475: URL: https://github.com/apache/logging-log4j2/issues/1475#issuecomment-2081189175 Thank you very much for all this information as well as for starting that most interesting, albeit unfortunate thread @ppkarwasz . It's a shame if renaming the artifact ident

Re: [I] log4j-core: Name/description not so clear (logging-log4j2)

2024-04-27 Thread via GitHub
ppkarwasz commented on issue #1475: URL: https://github.com/apache/logging-log4j2/issues/1475#issuecomment-2081116610 > I cannot make sense of the name "core" if it isn't for these extensions. I guess the fundamental problem here is that the meaning of "core" is not documented anywhere.

Re: [I] log4j-slf4j[2]-impl: Misleading and unclear names/descriptions (logging-log4j2)

2024-04-27 Thread via GitHub
Chealer commented on issue #1462: URL: https://github.com/apache/logging-log4j2/issues/1462#issuecomment-2080890583 Thank you @ppkarwasz and @vy The revised names and descriptions and much less misleading and clearer. I suggested tweakings to descriptions via comments in d7917eb.

Re: [I] Delay/pause/crash in LogManager::shutdown() [logging-log4cxx]

2024-04-27 Thread via GitHub
hordi commented on issue #373: URL: https://github.com/apache/logging-log4cxx/issues/373#issuecomment-2080848928 Yes, I have one more running thread which I can't turn off, that is intel-TBB thread that I can't control (no API provided to completely shutdown TBB, but no active work there d

Re: [I] log4j-core: Name/description not so clear (logging-log4j2)

2024-04-27 Thread via GitHub
Chealer commented on issue #1475: URL: https://github.com/apache/logging-log4j2/issues/1475#issuecomment-2080701907 @rgoers I am sorry for replying so late. Thank you for your reply. > As such, I don't really see anything wrong with its name. Calling it the "implementation core" is m

Re: [I] log4j-core: Name/description not so clear (logging-log4j2)

2024-04-27 Thread via GitHub
Chealer commented on issue #1475: URL: https://github.com/apache/logging-log4j2/issues/1475#issuecomment-2080655652 My pleasure @vy, thank you very much for this great improvement. Here is a suggestion based on your version: > This package contains the core of the Log4j API's referen

Re: [I] log4j-core: Name/description not so clear (logging-log4j2)

2024-04-27 Thread via GitHub
Chealer commented on issue #1475: URL: https://github.com/apache/logging-log4j2/issues/1475#issuecomment-2080597175 @rgoers this was not just about the name, but you are right about the name. My suggestion was wrong. The name should either be left alone or removed. I suggest to seriously c