Re: [PR] Make statistics on the AsyncAppender's queue length available [logging-log4cxx]

2024-04-26 Thread via GitHub
swebb2066 merged PR #374: URL: https://github.com/apache/logging-log4cxx/pull/374 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr

Re: [I] (doc) Clarify the usage of parameterized logging in `Log4j 2 API` page (logging-log4j2)

2024-04-26 Thread via GitHub
Chealer commented on issue #1918: URL: https://github.com/apache/logging-log4j2/issues/1918#issuecomment-2080326340 > * parameterized logging and string concatenation should **not** be mixed, e.g.: > // This is discouraged, but fine: > logger.info("Hello " + name + "!"

Re: [PR] Add links to Logging Services support, security and download pages [logging-log4cxx]

2024-04-26 Thread via GitHub
swebb2066 merged PR #372: URL: https://github.com/apache/logging-log4cxx/pull/372 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr

Re: [I] log4j-api: Incomplete/unclear description (simple implementation) (logging-log4j2)

2024-04-26 Thread via GitHub
Chealer commented on issue #1474: URL: https://github.com/apache/logging-log4j2/issues/1474#issuecomment-2080305252 Thanks to you @vy I commented the change and would suggest a small tuning: > This package contains 2 components of the Apache Log4j project's API, through which app

Re: [PR] Prevent `log4j2.isWebapp` from overriding other constants (logging-log4j2)

2024-04-26 Thread via GitHub
ppkarwasz merged PR #2517: URL: https://github.com/apache/logging-log4j2/pull/2517 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubsc

Re: [PR] Deprecate `log4j2.defaultStatusLevel` property (logging-log4j2)

2024-04-26 Thread via GitHub
ppkarwasz merged PR #2481: URL: https://github.com/apache/logging-log4j2/pull/2481 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubsc

Re: [PR] Bump com.github.luben:zstd-jni from 1.5.6-2 to 1.5.6-3 (logging-log4j2)

2024-04-26 Thread via GitHub
ppkarwasz commented on PR #2501: URL: https://github.com/apache/logging-log4j2/pull/2501#issuecomment-2079972323 @dependabot recreate -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [I] Consider removing accessors from `MDC <-> ThreadContext` bridges (logging-log4j2)

2024-04-26 Thread via GitHub
ppkarwasz commented on issue #2499: URL: https://github.com/apache/logging-log4j2/issues/2499#issuecomment-2079800141 @rgoers, The problem this tries to solve is to prevent context propagators from copying both `MDC#getCopyOfContextMap()` and `ThreadContext#getImmutableMapOrNull()`

Re: [PR] Bump com.github.luben:zstd-jni from 1.5.6-2 to 1.5.6-3 (logging-log4j2)

2024-04-26 Thread via GitHub
ppkarwasz commented on PR #2501: URL: https://github.com/apache/logging-log4j2/pull/2501#issuecomment-2079689715 @dependabot recreate -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Bump com.github.luben:zstd-jni from 1.5.6-2 to 1.5.6-3 (logging-log4j2)

2024-04-26 Thread via GitHub
ppkarwasz commented on PR #2501: URL: https://github.com/apache/logging-log4j2/pull/2501#issuecomment-2079682423 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] Bump net.bytebuddy:byte-buddy from 1.14.13 to 1.14.14 (logging-log4j2)

2024-04-26 Thread via GitHub
github-actions[bot] merged PR #2503: URL: https://github.com/apache/logging-log4j2/pull/2503 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

Re: [PR] Bump net.bytebuddy:byte-buddy from 1.14.13 to 1.14.14 (logging-log4j2)

2024-04-26 Thread via GitHub
ppkarwasz commented on PR #2503: URL: https://github.com/apache/logging-log4j2/pull/2503#issuecomment-2079495522 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] Bump com.github.luben:zstd-jni from 1.5.6-2 to 1.5.6-3 (logging-log4j2)

2024-04-26 Thread via GitHub
ppkarwasz commented on PR #2501: URL: https://github.com/apache/logging-log4j2/pull/2501#issuecomment-2079495197 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] Fix MacOS build (logging-log4j2)

2024-04-26 Thread via GitHub
ppkarwasz merged PR #2524: URL: https://github.com/apache/logging-log4j2/pull/2524 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubsc

Re: [I] log4j-core: Name/description not so clear (logging-log4j2)

2024-04-26 Thread via GitHub
vy commented on issue #1475: URL: https://github.com/apache/logging-log4j2/issues/1475#issuecomment-2079463963 Thanks for the heads up @Chealer! :bow: Please keep these feedback coming! :100: I have improved the artifact description in f4da84f8004519bbe43a8ecf7655d735a13fcbe1. We will furt

Re: [I] log4j-core: Name/description not so clear (logging-log4j2)

2024-04-26 Thread via GitHub
vy closed issue #1475: log4j-core: Name/description not so clear URL: https://github.com/apache/logging-log4j2/issues/1475 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [I] log4j-api: Incomplete/unclear description (simple implementation) (logging-log4j2)

2024-04-26 Thread via GitHub
vy closed issue #1474: log4j-api: Incomplete/unclear description (simple implementation) URL: https://github.com/apache/logging-log4j2/issues/1474 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [I] Consider removing accessors from `MDC <-> ThreadContext` bridges (logging-log4j2)

2024-04-26 Thread via GitHub
ppkarwasz commented on issue #2499: URL: https://github.com/apache/logging-log4j2/issues/2499#issuecomment-2079311501 > @ppkarwasz, this is the core problem this problem is attacking to, right? That is, avoiding redundant propagation when a particular bridge is in play. Yes, my main

[I] Create a `Troubleshooting` page (logging-log4j2)

2024-04-26 Thread via GitHub
vy opened a new issue, #2532: URL: https://github.com/apache/logging-log4j2/issues/2532 As agreed in [the site structure document](https://docs.google.com/document/d/10Fu7oqDzdM_D6LbexzwX9arh51Tic7AGvkWTQrL6jjQ/edit), create a `Troubleshooting` page such that - Outline: - Common

[I] Revamp the `Filters` page (logging-log4j2)

2024-04-26 Thread via GitHub
vy opened a new issue, #2529: URL: https://github.com/apache/logging-log4j2/issues/2529 As agreed in [the site structure document](https://docs.google.com/document/d/10Fu7oqDzdM_D6LbexzwX9arh51Tic7AGvkWTQrL6jjQ/edit), revamp the `Filters` page such that - Outline: - What is a fi

[I] Revamp the `Appenders` page (logging-log4j2)

2024-04-26 Thread via GitHub
vy opened a new issue, #2528: URL: https://github.com/apache/logging-log4j2/issues/2528 As agreed in [the site structure document](https://docs.google.com/document/d/10Fu7oqDzdM_D6LbexzwX9arh51Tic7AGvkWTQrL6jjQ/edit), revamp the `Appenders` page such that - Outline: - What is an

Re: [PR] Temporary MacOS fixup [logging-parent]

2024-04-26 Thread via GitHub
ppkarwasz commented on PR #169: URL: https://github.com/apache/logging-parent/pull/169#issuecomment-2079295172 It seems that switching from Temurin to Zulu is enough for now. Zulu is not cached on the runners, so let us wait to see how the environment of macOS 14 runners will evolve.

[I] Revamp the `Layouts` page (logging-log4j2)

2024-04-26 Thread via GitHub
vy opened a new issue, #2527: URL: https://github.com/apache/logging-log4j2/issues/2527 As agreed in [the site structure document](https://docs.google.com/document/d/10Fu7oqDzdM_D6LbexzwX9arh51Tic7AGvkWTQrL6jjQ/edit), create a _"Layouts"_ page such that - Outline: - What is a la

[I] Revamp the `Lookups` page (logging-log4j2)

2024-04-26 Thread via GitHub
vy opened a new issue, #2526: URL: https://github.com/apache/logging-log4j2/issues/2526 As agreed in [the site structure document](https://docs.google.com/document/d/10Fu7oqDzdM_D6LbexzwX9arh51Tic7AGvkWTQrL6jjQ/edit), revampt the _"Development"_ page such that - Outline: - What

[I] Revamp the `Configuration` page (logging-log4j2)

2024-04-26 Thread via GitHub
vy opened a new issue, #2525: URL: https://github.com/apache/logging-log4j2/issues/2525 As agreed in [the site structure document](https://docs.google.com/document/d/10Fu7oqDzdM_D6LbexzwX9arh51Tic7AGvkWTQrL6jjQ/edit), revamp the _"Configuration"_ page such that - Outline: - Supp

[PR] Temporary MacOS fixup [logging-parent]

2024-04-26 Thread via GitHub
ppkarwasz opened a new pull request, #169: URL: https://github.com/apache/logging-parent/pull/169 This branch contains temporary fix-ups for MacOS runners and is used by the `logging-log4j2` builds. We should follow actions/setup-java#625 to see what the definitive solution will be.

Re: [PR] Bump actions/checkout from 4.1.3 to 4.1.4 [logging-parent]

2024-04-26 Thread via GitHub
github-actions[bot] merged PR #167: URL: https://github.com/apache/logging-parent/pull/167 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications

Re: [PR] Bump github/codeql-action from 3.25.1 to 3.25.3 [logging-parent]

2024-04-26 Thread via GitHub
github-actions[bot] merged PR #168: URL: https://github.com/apache/logging-parent/pull/168 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications

Re: [PR] Prevent `log4j2.isWebapp` from overriding other constants (logging-log4j2)

2024-04-26 Thread via GitHub
vy commented on code in PR #2517: URL: https://github.com/apache/logging-log4j2/pull/2517#discussion_r1580860904 ## log4j-api/src/main/java/org/apache/logging/log4j/spi/Provider.java: ## Review Comment: > https://github.com/apache/logging-log4j2/blob/cc876ae7c629b698b92414

Re: [PR] Prevent `log4j2.isWebapp` from overriding other constants (logging-log4j2)

2024-04-26 Thread via GitHub
ppkarwasz commented on code in PR #2517: URL: https://github.com/apache/logging-log4j2/pull/2517#discussion_r1580844634 ## log4j-api/src/main/java/org/apache/logging/log4j/spi/Provider.java: ## Review Comment: On the contrary: you pointed out a valid concern. After l

Re: [PR] Prevent `log4j2.isWebapp` from overriding other constants (logging-log4j2)

2024-04-26 Thread via GitHub
vy commented on code in PR #2517: URL: https://github.com/apache/logging-log4j2/pull/2517#discussion_r1580556072 ## log4j-api/src/main/java/org/apache/logging/log4j/spi/Provider.java: ## Review Comment: Giving it a second thought, I think I pointed you in the wrong directio