Re: [I] Consider removing accessors from `MDC <-> ThreadContext` bridges (logging-log4j2)

2024-04-25 Thread via GitHub
vy commented on issue #2499: URL: https://github.com/apache/logging-log4j2/issues/2499#issuecomment-2078730673 _[I am not much familiar with the part of the code base you are talking about, hence apologies in advance if I say something stupid.]_ > will prevent the propagation of `MDC

[PR] Make statistics on the AsyncAppender's queue length available [logging-log4cxx]

2024-04-25 Thread via GitHub
swebb2066 opened a new pull request, #374: URL: https://github.com/apache/logging-log4cxx/pull/374 This PR addresses the user's problem of determining whether the application produces logging events faster than the background thread is able to process. -- This is an automated message from

Re: [PR] Use DateTimeFormatter.formatTo to directly append to StringBuilder (logging-log4j2)

2024-04-25 Thread via GitHub
vy commented on PR #2515: URL: https://github.com/apache/logging-log4j2/pull/2515#issuecomment-2078705571 @michaelbraun, thanks so much! :bow: Please keep these contributions coming! :pray: -- This is an automated message from the Apache Git Service. To respond to the message, please lo

Re: [PR] Use DateTimeFormatter.formatTo to directly append to StringBuilder (logging-log4j2)

2024-04-25 Thread via GitHub
vy merged PR #2515: URL: https://github.com/apache/logging-log4j2/pull/2515 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@lo

Re: [PR] Use DateTimeFormatter.formatTo to directly append to StringBuilder (logging-log4j2)

2024-04-25 Thread via GitHub
vy commented on code in PR #2515: URL: https://github.com/apache/logging-log4j2/pull/2515#discussion_r1580526446 ## src/changelog/.2.x.x/2515_datetimeformatter_formatto.xml: ## @@ -0,0 +1,8 @@ + +http://www.w3.org/2001/XMLSchema-instance"; + xmlns="https://logging.apache.o

Re: [I] Delay/pause/crash in LogManager::shutdown() [logging-log4cxx]

2024-04-25 Thread via GitHub
rm5248 commented on issue #373: URL: https://github.com/apache/logging-log4cxx/issues/373#issuecomment-2078328839 It sounds like your other threads are not being shutdown before the main thread is exiting. That does lead to undefined behavior. The only safe way to exit is to stop al

Re: [I] Consider removing accessors from `MDC <-> ThreadContext` bridges (logging-log4j2)

2024-04-25 Thread via GitHub
jvz commented on issue #2499: URL: https://github.com/apache/logging-log4j2/issues/2499#issuecomment-2078002975 This is a solid proposal I think. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[I] Delay/pause/crash in LogManager::shutdown() [logging-log4cxx]

2024-04-25 Thread via GitHub
hordi opened a new issue, #373: URL: https://github.com/apache/logging-log4cxx/issues/373 Can't provide any simple app to reproduce the issue, but getting it frequently enough in production multi-thread code during LogManager::shutdown() call before main.cpp exit (nothing is running at thi

[I] Logger precision formats in PatternLayout do not match documentation (logging-log4j2)

2024-04-25 Thread via GitHub
jvz opened a new issue, #2522: URL: https://github.com/apache/logging-log4j2/issues/2522 ## Description In the docs at https://logging.apache.org/log4j/2.x/manual/layouts.html#patterns it gives an example pattern `%c{1.2.*}` that should transform something like `org.apache.commons.t

Re: [PR] Prevent `log4j2.isWebapp` from overriding other constants (logging-log4j2)

2024-04-25 Thread via GitHub
ppkarwasz commented on code in PR #2517: URL: https://github.com/apache/logging-log4j2/pull/2517#discussion_r1579825873 ## src/site/antora/modules/ROOT/pages/manual/json-template-layout.adoc: ## @@ -1085,7 +1085,7 @@ Resolves `logEvent.getMessage().getParameters()`. Regarding g

Re: [I] log4j-slf4j[2]-impl: Misleading and unclear names/descriptions (logging-log4j2)

2024-04-25 Thread via GitHub
vy commented on issue #1462: URL: https://github.com/apache/logging-log4j2/issues/1462#issuecomment-2077584998 Fixed in f37af11c0f5bab4264665230f0d9a7e2d46b8bdc (`2.x`) and 935231cdbd79c59de9b1e63b256c2c3786c646cb (`main`). -- This is an automated message from the Apache Git Service. To

Re: [I] log4j-slf4j[2]-impl: Misleading and unclear names/descriptions (logging-log4j2)

2024-04-25 Thread via GitHub
vy closed issue #1462: log4j-slf4j[2]-impl: Misleading and unclear names/descriptions URL: https://github.com/apache/logging-log4j2/issues/1462 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

Re: [PR] Prevent `log4j2.isWebapp` from overriding other constants (logging-log4j2)

2024-04-25 Thread via GitHub
ppkarwasz commented on code in PR #2517: URL: https://github.com/apache/logging-log4j2/pull/2517#discussion_r1579671128 ## log4j-api/src/main/java/org/apache/logging/log4j/util/Constants.java: ## @@ -16,31 +16,56 @@ */ package org.apache.logging.log4j.util; +import org.apac

[I] Revamp the `Architecture` page (logging-log4j2)

2024-04-25 Thread via GitHub
vy opened a new issue, #2521: URL: https://github.com/apache/logging-log4j2/issues/2521 As agreed in [the site structure document](https://docs.google.com/document/d/10Fu7oqDzdM_D6LbexzwX9arh51Tic7AGvkWTQrL6jjQ/edit), revamp the `Development` page such that - Improve content, formatt

Re: [PR] Prevent `log4j2.isWebapp` from overriding other constants (logging-log4j2)

2024-04-25 Thread via GitHub
vy commented on code in PR #2517: URL: https://github.com/apache/logging-log4j2/pull/2517#discussion_r1579657933 ## src/site/antora/modules/ROOT/pages/manual/json-template-layout.adoc: ## @@ -1085,7 +1085,7 @@ Resolves `logEvent.getMessage().getParameters()`. Regarding garbage

[I] Create a `Development` page (logging-log4j2)

2024-04-25 Thread via GitHub
vy opened a new issue, #2520: URL: https://github.com/apache/logging-log4j2/issues/2520 As agreed in [the site structure document](https://docs.google.com/document/d/10Fu7oqDzdM_D6LbexzwX9arh51Tic7AGvkWTQrL6jjQ/edit), create a _"Development"_ page such that - Outline: - Source r

Re: [I] The `log4j2.messageFactory` property is ignored since 2.23.0 (logging-log4j2)

2024-04-25 Thread via GitHub
vy closed issue #2379: The `log4j2.messageFactory` property is ignored since 2.23.0 URL: https://github.com/apache/logging-log4j2/issues/2379 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [PR] Fix handling of `log4j2.messageFactory` and `log4j2.flowMessageFactory` properties (logging-log4j2)

2024-04-25 Thread via GitHub
vy merged PR #2505: URL: https://github.com/apache/logging-log4j2/pull/2505 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@lo

Re: [PR] Prevent `log4j2.isWebapp` from overriding other constants (logging-log4j2)

2024-04-25 Thread via GitHub
ppkarwasz commented on code in PR #2517: URL: https://github.com/apache/logging-log4j2/pull/2517#discussion_r1579566800 ## src/site/antora/modules/ROOT/pages/manual/json-template-layout.adoc: ## @@ -1085,7 +1085,7 @@ Resolves `logEvent.getMessage().getParameters()`. Regarding g

Re: [PR] Prevent `log4j2.isWebapp` from overriding other constants (logging-log4j2)

2024-04-25 Thread via GitHub
vy commented on code in PR #2517: URL: https://github.com/apache/logging-log4j2/pull/2517#discussion_r1579538084 ## log4j-api/src/main/java/org/apache/logging/log4j/spi/Provider.java: ## Review Comment: Can you explain how the thread-local toggling property is taken into ac

Re: [PR] Use DateTimeFormatter.formatTo to directly append to StringBuilder (logging-log4j2)

2024-04-25 Thread via GitHub
vy commented on code in PR #2515: URL: https://github.com/apache/logging-log4j2/pull/2515#discussion_r1579481610 ## log4j-api/src/main/java/org/apache/logging/log4j/status/StatusData.java: ## @@ -167,9 +167,9 @@ public Throwable getThrowable() { @SuppressWarnings("DefaultCh

Re: [PR] Use DateTimeFormatter.formatTo to directly append to StringBuilder (logging-log4j2)

2024-04-25 Thread via GitHub
vy commented on code in PR #2515: URL: https://github.com/apache/logging-log4j2/pull/2515#discussion_r1579473335 ## log4j-api/src/main/java/org/apache/logging/log4j/status/StatusData.java: ## @@ -167,9 +167,9 @@ public Throwable getThrowable() { @SuppressWarnings("DefaultCh

Re: [PR] Use DateTimeFormatter.formatTo to directly append to StringBuilder (logging-log4j2)

2024-04-25 Thread via GitHub
vy commented on code in PR #2515: URL: https://github.com/apache/logging-log4j2/pull/2515#discussion_r1579473335 ## log4j-api/src/main/java/org/apache/logging/log4j/status/StatusData.java: ## @@ -167,9 +167,9 @@ public Throwable getThrowable() { @SuppressWarnings("DefaultCh

Re: [I] JsonTemplateLayout: java.lang.OutOfMemoryError: Java heap space java.lang.OutOfMemoryError: Java heap space (logging-log4j2)

2024-04-25 Thread via GitHub
vy commented on issue #2516: URL: https://github.com/apache/logging-log4j2/issues/2516#issuecomment-2077170486 @PassiveIncomeMachine, could you share the following information too, please? 1. A complete stack trace (pointing to some line numbers in the `org.apache.logging.log4j` pack

Re: [I] PatternLayout unsuitable for production purposes (logging-log4j2)

2024-04-25 Thread via GitHub
ppkarwasz commented on issue #2518: URL: https://github.com/apache/logging-log4j2/issues/2518#issuecomment-2077155374 Hi @marcelhoelscher, Sure, we should probably change the wording on the security page: * `PatternLayout` **can** be use in production, * but `PatternLayout`

[I] PatternLayout unsuitable for production purposes (logging-log4j2)

2024-04-25 Thread via GitHub
marcelhoelscher opened a new issue, #2518: URL: https://github.com/apache/logging-log4j2/issues/2518 Hello, I came across the following statement on the Log4J security page (https://logging.apache.org/security.html#reporting): ![image](https://github.com/apache/logging-log4j2/

Re: [PR] Prevent `log4j2.isWebapp` from overriding other constants (logging-log4j2)

2024-04-25 Thread via GitHub
ppkarwasz commented on code in PR #2517: URL: https://github.com/apache/logging-log4j2/pull/2517#discussion_r1579370783 ## log4j-api/src/main/java/org/apache/logging/log4j/spi/Provider.java: ## @@ -326,12 +326,10 @@ public String getThreadContextMap() { return threa

Re: [PR] Prevent `log4j2.isWebapp` from overriding other constants (logging-log4j2)

2024-04-25 Thread via GitHub
ppkarwasz commented on code in PR #2517: URL: https://github.com/apache/logging-log4j2/pull/2517#discussion_r1579370783 ## log4j-api/src/main/java/org/apache/logging/log4j/spi/Provider.java: ## @@ -326,12 +326,10 @@ public String getThreadContextMap() { return threa

[PR] Prevent `log4j2.isWebapp` from overriding other constants (logging-log4j2)

2024-04-25 Thread via GitHub
ppkarwasz opened a new pull request, #2517: URL: https://github.com/apache/logging-log4j2/pull/2517 Currently, if `log4j2.isWebapp` is enabled, the effective values of the following system properties: * `log4j2.enableThreadlocals`, * `log4j2.garbagefreeThreadLocalMap`, * `log4j2

[I] Add an `Installation` page and rework the `Download` page (logging-log4net)

2024-04-25 Thread via GitHub
vy opened a new issue, #146: URL: https://github.com/apache/logging-log4net/issues/146 _[**Disclaimer:** I am not a .NET developer. Apologies in advance if I say something nonsense.]_ Currently, in the Log4Net website, I am not able to quickly answer the following questions: *

Re: [PR] Bump dependabot/fetch-metadata from 2.0.0 to 2.1.0 [logging-parent]

2024-04-25 Thread via GitHub
github-actions[bot] merged PR #166: URL: https://github.com/apache/logging-parent/pull/166 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications