Re: [PR] Prefer std::lock_guard when std::unique_lock features are not required [logging-log4cxx]

2024-04-22 Thread via GitHub
swebb2066 merged PR #369: URL: https://github.com/apache/logging-log4cxx/pull/369 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr

Re: [I] Use Logging Services common pages [logging-log4cxx]

2024-04-22 Thread via GitHub
swebb2066 commented on issue #370: URL: https://github.com/apache/logging-log4cxx/issues/370#issuecomment-2071282144 As far as I can see, those three pages do not seem to have anything that is relevant to a Log4cxx user. I notice the links to these pages are available from the [Apach

Re: [PR] Add trace context fields to GcpLayout.json (logging-log4j2)

2024-04-22 Thread via GitHub
aabmass commented on PR #2498: URL: https://github.com/apache/logging-log4j2/pull/2498#issuecomment-2070891282 > I would also really appreciate it if you can create a `src/changelog/.2.x.x/add_GcpLayout_tracing_support.xml` changelog entry file. Added -- This is an automated messag

Re: [PR] Add trace context fields to GcpLayout.json (logging-log4j2)

2024-04-22 Thread via GitHub
aabmass commented on PR #2498: URL: https://github.com/apache/logging-log4j2/pull/2498#issuecomment-2070792509 > A quick question just before merging it: If `trace_id` and/or `span_id` MDC values are missing, `logging.googleapis.com/trace_sampled` will still be set to `true` without `loggin

Re: [PR] Add trace context fields to GcpLayout.json (logging-log4j2)

2024-04-22 Thread via GitHub
aabmass commented on PR #2498: URL: https://github.com/apache/logging-log4j2/pull/2498#issuecomment-2070784374 Thanks for the quick review! > A quick question just before merging it: If `trace_id` and/or `span_id` MDC values are missing, `logging.googleapis.com/trace_sampled` will sti

[PR] Add trace context fields to GcpLayout.json (logging-log4j2)

2024-04-22 Thread via GitHub
aabmass opened a new pull request, #2498: URL: https://github.com/apache/logging-log4j2/pull/2498 This PR adds a few tracing related JSON fields to the included `GcpLayout.json` event template which are documented in the [Cloud Logging docs](https://cloud.google.com/logging/docs/structured-

[jira] [Work logged] (LOG4J2-3023) Create a wrapper layout compressing the output of the delegate

2024-04-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3023?focusedWorklogId=915789&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-915789 ] ASF GitHub Bot logged work on LOG4J2-3023: -- Author: ASF GitHub Bot

Re: [I] Wrapper layout compressing the output of a delegate (LOG4J2-3023) (logging-log4j2)

2024-04-22 Thread via GitHub
ppkarwasz commented on issue #2496: URL: https://github.com/apache/logging-log4j2/issues/2496#issuecomment-2069148758 I marked [LOG4J2-3023](https://issues.apache.org/jira/browse/LOG4J2-3023) as duplicate of this issue, so we don't need to use JIRA any more. -- This is an automated messa

[jira] [Resolved] (LOG4J2-3023) Create a wrapper layout compressing the output of the delegate

2024-04-22 Thread Piotr Karwasz (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3023?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Karwasz resolved LOG4J2-3023. --- Resolution: Duplicate I am closing this as a duplicate of GitHub issue: [https://github.com

[jira] [Work logged] (LOG4J2-3023) Create a wrapper layout compressing the output of the delegate

2024-04-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3023?focusedWorklogId=915788&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-915788 ] ASF GitHub Bot logged work on LOG4J2-3023: -- Author: ASF GitHub Bot

Re: [PR] Bump actions/checkout from 4.1.2 to 4.1.3 (logging-log4j2)

2024-04-22 Thread via GitHub
github-actions[bot] merged PR #2497: URL: https://github.com/apache/logging-log4j2/pull/2497 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

Re: [PR] Port new Download and Installation pages to `2.x` (logging-log4j2)

2024-04-22 Thread via GitHub
vy merged PR #2487: URL: https://github.com/apache/logging-log4j2/pull/2487 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@lo

[jira] [Work logged] (LOG4J2-3023) Create a wrapper layout compressing the output of the delegate

2024-04-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3023?focusedWorklogId=915780&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-915780 ] ASF GitHub Bot logged work on LOG4J2-3023: -- Author: ASF GitHub Bot

Re: [I] Wrapper layout compressing the output of a delegate (LOG4J2-3023) (logging-log4j2)

2024-04-22 Thread via GitHub
der-eismann commented on issue #2496: URL: https://github.com/apache/logging-log4j2/issues/2496#issuecomment-2069078162 I'm kinda interested, but my Java knowledge is very basic and I'm not sure if my help is really useful here :see_no_evil: -- This is an automated message from the Apac

Re: [PR] Bump actions/checkout from 4.1.2 to 4.1.3 [logging-parent]

2024-04-22 Thread via GitHub
github-actions[bot] merged PR #163: URL: https://github.com/apache/logging-parent/pull/163 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications

[PR] Bump actions/checkout from 4.1.2 to 4.1.3 [logging-parent]

2024-04-22 Thread via GitHub
dependabot[bot] opened a new pull request, #163: URL: https://github.com/apache/logging-parent/pull/163 Bumps [actions/checkout](https://github.com/actions/checkout) from 4.1.2 to 4.1.3. Release notes Sourced from https://github.com/actions/checkout/releases";>actions/checkout's r

Re: [I] Add compression option for JSON Template Layout (logging-log4j2)

2024-04-22 Thread via GitHub
vy commented on issue #2496: URL: https://github.com/apache/logging-log4j2/issues/2496#issuecomment-2068999593 Instead adding compression support to ``, we better create a wrapper layout that compresses the output of another layout. This issue has already been discussed in [LOG4J2-3023](h

Re: [PR] Use Logging Services common pages #144 (logging-log4net)

2024-04-22 Thread via GitHub
vy commented on PR #145: URL: https://github.com/apache/logging-log4net/pull/145#issuecomment-2068986300 @FreeAndNil, thanks so much! :heart_eyes: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [I] Use Logging Services common pages (logging-log4net)

2024-04-22 Thread via GitHub
FreeAndNil closed issue #144: Use Logging Services common pages URL: https://github.com/apache/logging-log4net/issues/144 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] Use Logging Services common pages #144 (logging-log4net)

2024-04-22 Thread via GitHub
FreeAndNil merged PR #145: URL: https://github.com/apache/logging-log4net/pull/145 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubsc

Re: [PR] Use Logging Services common pages #144 (logging-log4net)

2024-04-22 Thread via GitHub
vy commented on code in PR #145: URL: https://github.com/apache/logging-log4net/pull/145#discussion_r1574480904 ## src/site/site.xml: ## @@ -28,8 +28,8 @@ - - + + Review Comment: ```suggestion https://logging.apache.org/downlo

Re: [PR] Use Logging Services common pages #144 (logging-log4net)

2024-04-22 Thread via GitHub
FreeAndNil commented on code in PR #145: URL: https://github.com/apache/logging-log4net/pull/145#discussion_r1574417000 ## src/site/site.xml: ## @@ -28,8 +28,8 @@ Review Comment: As I understand, the root points to `logging.[staged.]apache.org/log4net` --

Re: [I] Use Logging Services common pages (logging-log4net)

2024-04-22 Thread via GitHub
vy commented on issue #144: URL: https://github.com/apache/logging-log4net/issues/144#issuecomment-2068751933 @FreeAndNil @LaurentDardenne Removed `README.html` and `KEYS` symlink from the https://dist.apache.org/repos/dist/dev/logging/log4net Subversion folder. https://archive.apach

Re: [PR] Use Logging Services common pages #144 (logging-log4net)

2024-04-22 Thread via GitHub
vy commented on code in PR #145: URL: https://github.com/apache/logging-log4net/pull/145#discussion_r1574292042 ## src/site/site.xml: ## @@ -28,8 +28,8 @@ Review Comment: @FreeAndNil, how does this work at all? The root points to `logging.[staged.]apache.org