Re: [PR] Add 'persist-credentials: false' to all Github checkout actions [logging-log4cxx]

2024-04-10 Thread via GitHub
swebb2066 commented on PR #367: URL: https://github.com/apache/logging-log4cxx/pull/367#issuecomment-2048943481 Not sure this is actually necessary. There seems to be a mismatch bewteen the [documentated default](https://github.com/actions/checkout/blob/cd7d8d697e10461458bc61a30d094dc601a8b

[PR] Add 'persist-credentials: false' to all Github checkout actions [logging-log4cxx]

2024-04-10 Thread via GitHub
swebb2066 opened a new pull request, #367: URL: https://github.com/apache/logging-log4cxx/pull/367 This PR applies a [policy recommended by Apache InfraStructure](https://cwiki.apache.org/confluence/display/BUILDS/GitHub+Actions+status#GitHubActionsstatus-Mitigations) -- This is an automa

Re: [PR] Raman Gupta: correct timezone (logging-log4j2)

2024-04-10 Thread via GitHub
rocketraman commented on PR #2463: URL: https://github.com/apache/logging-log4j2/pull/2463#issuecomment-2047373711 > @rocketraman, come on, we don't need a PR for these kind of changes. 😅 Just push it to `2.x`, `main`, etc. next time, please. Ok! :-) -- This is an automated message

Re: [PR] Bump com.github.spotbugs:spotbugs-maven-plugin from 4.8.3.1 to 4.8.4.0 [logging-parent]

2024-04-10 Thread via GitHub
github-actions[bot] merged PR #156: URL: https://github.com/apache/logging-parent/pull/156 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications

[PR] Bump com.github.spotbugs:spotbugs-maven-plugin from 4.8.3.1 to 4.8.4.0 [logging-parent]

2024-04-10 Thread via GitHub
dependabot[bot] opened a new pull request, #156: URL: https://github.com/apache/logging-parent/pull/156 Bumps [com.github.spotbugs:spotbugs-maven-plugin](https://github.com/spotbugs/spotbugs-maven-plugin) from 4.8.3.1 to 4.8.4.0. Release notes Sourced from https://github.com/spotb

Re: [I] New Feature: Add stacktrace package-name filtering for JsonTemplateLayout like it exists for PatternLayout (logging-log4j2)

2024-04-10 Thread via GitHub
vy commented on issue #1941: URL: https://github.com/apache/logging-log4j2/issues/1941#issuecomment-2046733323 @abhijit911turbo, @takanuva15, sorry to break it to you, but if you need this feature from Log4j, which I presume is deployed at an organization helping you to pay your bills at t

Re: [PR] Raman Gupta: correct timezone (logging-log4j2)

2024-04-10 Thread via GitHub
vy merged PR #2463: URL: https://github.com/apache/logging-log4j2/pull/2463 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@lo

Re: [I] Lambda expressions compiled with a previous version of `org.apache.logging.log4j.util.Supplier.java` or `MessageSupplier` fail to generate (logging-log4j2)

2024-04-10 Thread via GitHub
vy commented on issue #2449: URL: https://github.com/apache/logging-log4j2/issues/2449#issuecomment-2046702649 I am not strongly opinionated, but I suggest reverting the `MessageSupplier` change and only keeping the `@FunctionalInterface`. It increases complexity, brings marginal benefit,