[PR] Rg/raman gupta correct timezone (logging-log4j2)

2024-04-09 Thread via GitHub
rocketraman opened a new pull request, #2463: URL: https://github.com/apache/logging-log4j2/pull/2463 Correct my time zone. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [I] New Feature: Add stacktrace package-name filtering for JsonTemplateLayout like it exists for PatternLayout (logging-log4j2)

2024-04-09 Thread via GitHub
takanuva15 commented on issue #1941: URL: https://github.com/apache/logging-log4j2/issues/1941#issuecomment-2046107677 @abhijit911turbo It's still under development on my fork; been distracted with other things that life has thrown on me lol. No definite ETA I can give you at this point

Re: [I] Lambda expressions compiled with a previous version of `org.apache.logging.log4j.util.Supplier.java` or `MessageSupplier` fail to generate (logging-log4j2)

2024-04-09 Thread via GitHub
ppkarwasz commented on issue #2449: URL: https://github.com/apache/logging-log4j2/issues/2449#issuecomment-2045959561 > * I could have bought this plan as a twilight state until we get rid off `MessageSupplier`, but we all know that removing stuff from `log4j-api` is a _"pipe dream"_.

Re: [I] Lambda expressions compiled with a previous version of `org.apache.logging.log4j.util.Supplier.java` or `MessageSupplier` fail to generate (logging-log4j2)

2024-04-09 Thread via GitHub
vy commented on issue #2449: URL: https://github.com/apache/logging-log4j2/issues/2449#issuecomment-2045930917 @jvz, @ppkarwasz, as I understand from Piotr's explanation, the rationale behind this change is to allow several `MessageSupplier` usages in `log4j-core` to switch to `Supplier` i

Re: [PR] Migrate site infrastructure to Antora [logging-parent]

2024-04-09 Thread via GitHub
vy merged PR #155: URL: https://github.com/apache/logging-parent/pull/155 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logg

Re: [PR] Migrate site infrastructure to Antora [logging-parent]

2024-04-09 Thread via GitHub
vy commented on PR #155: URL: https://github.com/apache/logging-parent/pull/155#issuecomment-2045868015 > Since all this PR does is modifying Github Actions can you stage the website after merging this PR to confirm that it works as required? I will do that in my follow up PR, where I

Re: [PR] Migrate site infrastructure to Antora [logging-parent]

2024-04-09 Thread via GitHub
vy commented on code in PR #155: URL: https://github.com/apache/logging-parent/pull/155#discussion_r1558139173 ## src/site/antora/.antora.yml: ## @@ -0,0 +1,54 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the

Re: [I] Provide a programmatic way to enable/disable log4j2 JMX beans creation (logging-log4j2)

2024-04-09 Thread via GitHub
ppkarwasz commented on issue #2462: URL: https://github.com/apache/logging-log4j2/issues/2462#issuecomment-2045848752 We accept such behavioral changes in minor releases. Users can always revert it through a system property. -- This is an automated message from the Apache Git Service. To

Re: [I] Provide a programmatic way to enable/disable log4j2 JMX beans creation (logging-log4j2)

2024-04-09 Thread via GitHub
sdavids commented on issue #2462: URL: https://github.com/apache/logging-log4j2/issues/2462#issuecomment-2045832021 Yeah, it would be a good idea from a security standpoint also. I am not sure about backward compatibility though … -- This is an automated message from the Apache Git

Re: [I] Provide a programmatic way to enable/disable log4j2 JMX beans creation (logging-log4j2)

2024-04-09 Thread via GitHub
ppkarwasz commented on issue #2462: URL: https://github.com/apache/logging-log4j2/issues/2462#issuecomment-2045821938 @sdavids, Would disabling JMX by default work for you (cf. #1229)? We are open to PRs in that direction. -- This is an automated message from the Apache Git Servic

Re: [I] Lambda expressions compiled with a previous version of `org.apache.logging.log4j.util.Supplier.java` or `MessageSupplier` fail to generate (logging-log4j2)

2024-04-09 Thread via GitHub
ppkarwasz commented on issue #2449: URL: https://github.com/apache/logging-log4j2/issues/2449#issuecomment-2045801954 I did some more testing and what happened is that in `3.0.0-beta2` we redefined `MessageSupplier` as: ```java public interface MessageSupplier extends Supplier {}

Re: [I] Lambda expressions compiled with a previous version of `org.apache.logging.log4j.util.Supplier.java` or `MessageSupplier` fail to generate (logging-log4j2)

2024-04-09 Thread via GitHub
ppkarwasz closed issue #2449: Lambda expressions compiled with a previous version of `org.apache.logging.log4j.util.Supplier.java` or `MessageSupplier` fail to generate URL: https://github.com/apache/logging-log4j2/issues/2449 -- This is an automated message from the Apache Git Service. To r

[I] Provide a programmatic way to enable/disable log4j2 JMX beans creation (logging-log4j2)

2024-04-09 Thread via GitHub
sdavids opened a new issue, #2462: URL: https://github.com/apache/logging-log4j2/issues/2462 [JUnit 5 - Disable Log4J JMX beans creation in tests](https://github.com/junit-team/junit5/pull/3753#issuecomment-2045573225) [Spring Boot - Do not create log4j2 JMX beans if spring.jmx.enabl

Re: [PR] Bump commons-io:commons-io from 2.16.0 to 2.16.1 [logging-log4j-audit]

2024-04-09 Thread via GitHub
github-actions[bot] merged PR #137: URL: https://github.com/apache/logging-log4j-audit/pull/137 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifica

Re: [PR] Bump commons-io:commons-io from 2.16.0 to 2.16.1 [logging-log4j-audit]

2024-04-09 Thread via GitHub
github-actions[bot] merged PR #137: URL: https://github.com/apache/logging-log4j-audit/pull/137 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifica

[PR] Bump commons-io:commons-io from 2.16.0 to 2.16.1 [logging-log4j-audit]

2024-04-09 Thread via GitHub
dependabot[bot] opened a new pull request, #137: URL: https://github.com/apache/logging-log4j-audit/pull/137 Bumps commons-io:commons-io from 2.16.0 to 2.16.1. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=com

Re: [I] New Feature: Add stacktrace package-name filtering for JsonTemplateLayout like it exists for PatternLayout (logging-log4j2)

2024-04-09 Thread via GitHub
abhijit911turbo commented on issue #1941: URL: https://github.com/apache/logging-log4j2/issues/1941#issuecomment-2045600664 Hello, Any ETA on this enhancement? Would really love to have this released -- This is an automated message from the Apache Git Service. To respond to the message, p

Re: [I] Lambda expressions compiled with a previous version of `org.apache.logging.log4j.util.Supplier.java` or `MessageSupplier` fail to generate (logging-log4j2)

2024-04-09 Thread via GitHub
jvz commented on issue #2449: URL: https://github.com/apache/logging-log4j2/issues/2449#issuecomment-2045575558 BND might not have noticed because it's a strange edge case involving type erasure and default methods. I think we should revert the `MessageSupplier` changes since the API

[I] Remove `log4j-1.2-api` from 3.x (logging-log4j2)

2024-04-09 Thread via GitHub
ppkarwasz opened a new issue, #2461: URL: https://github.com/apache/logging-log4j2/issues/2461 As discussed in [this `dev@logging` thread](https://lists.apache.org/thread/dvmtok2wxfskw94d8pv0bq73yom8sq74) it should be safe to remove `log4j-1.2-api` from the 3.x release. **Remark**

Re: [I] Lambda expressions compiled with a previous version of `org.apache.logging.log4j.util.Supplier.java` or `MessageSupplier` fail to generate (logging-log4j2)

2024-04-09 Thread via GitHub
ppkarwasz commented on issue #2449: URL: https://github.com/apache/logging-log4j2/issues/2449#issuecomment-2045090142 @ritzow, Thank you for pointing out this problem. I was sure I left a comment two days ago, but AJAX must have eaten it. We did two apparently backward compati

[PR] Clean up `PropertyEnvironment` (logging-log4j2)

2024-04-09 Thread via GitHub
ppkarwasz opened a new pull request, #2460: URL: https://github.com/apache/logging-log4j2/pull/2460 We clean up `PropertyEnvironment` from all the unused public methods. Since all the classes should only use `getProperty(Class)`, the other converter methods are not necessary. We keep

Re: [PR] Migrate site infrastructure to Antora [logging-parent]

2024-04-09 Thread via GitHub
ppkarwasz commented on PR #155: URL: https://github.com/apache/logging-parent/pull/155#issuecomment-2044825724 Since all this PR does is modifying Github Actions can you stage the website after merging this PR to confirm that it works as required? -- This is an automated message from the

Re: [PR] Migrate site infrastructure to Antora [logging-parent]

2024-04-09 Thread via GitHub
ppkarwasz commented on code in PR #155: URL: https://github.com/apache/logging-parent/pull/155#discussion_r1557476256 ## .github/workflows/deploy-release-reusable.yaml: ## @@ -264,18 +280,16 @@ jobs: # Checkout the SVN repository export SVN_DIR="/tmp/svn-re

Re: [PR] Migrate site infrastructure to Antora [logging-parent]

2024-04-09 Thread via GitHub
ppkarwasz commented on code in PR #155: URL: https://github.com/apache/logging-parent/pull/155#discussion_r1557475697 ## .github/workflows/build-reusable.yaml: ## @@ -69,9 +69,34 @@ jobs: -DinstallAtEnd=true \ clean install + # Node.js cache is n

Re: [PR] Migrate site infrastructure to Antora [logging-parent]

2024-04-09 Thread via GitHub
ppkarwasz commented on code in PR #155: URL: https://github.com/apache/logging-parent/pull/155#discussion_r1557474903 ## src/site/antora/.antora.yml: ## @@ -0,0 +1,54 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements.

Re: [PR] Bump org.apache.groovy:groovy-bom from 4.0.20 to 4.0.21 (logging-log4j2)

2024-04-09 Thread via GitHub
github-actions[bot] merged PR #2457: URL: https://github.com/apache/logging-log4j2/pull/2457 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

Re: [PR] Bump com.palantir.javaformat:palantir-java-format from 2.42.0 to 2.43.0 [logging-parent]

2024-04-09 Thread via GitHub
github-actions[bot] merged PR #154: URL: https://github.com/apache/logging-parent/pull/154 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications

Re: [PR] Bump com.palantir.javaformat:palantir-java-format from 2.42.0 to 2.43.0 [logging-parent]

2024-04-09 Thread via GitHub
github-actions[bot] merged PR #154: URL: https://github.com/apache/logging-parent/pull/154 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications

Re: [PR] Migrate site infrastructure to Antora [logging-parent]

2024-04-09 Thread via GitHub
vy commented on code in PR #155: URL: https://github.com/apache/logging-parent/pull/155#discussion_r1557460646 ## .github/workflows/deploy-release-reusable.yaml: ## @@ -264,18 +280,16 @@ jobs: # Checkout the SVN repository export SVN_DIR="/tmp/svn-repo"

Re: [PR] Migrate site infrastructure to Antora [logging-parent]

2024-04-09 Thread via GitHub
vy commented on code in PR #155: URL: https://github.com/apache/logging-parent/pull/155#discussion_r1557457799 ## .github/workflows/deploy-release-reusable.yaml: ## @@ -28,10 +28,6 @@ on: description: Identifier used in the distribution artifact and Subversion reposito

[PR] Bump com.palantir.javaformat:palantir-java-format from 2.42.0 to 2.43.0 [logging-parent]

2024-04-09 Thread via GitHub
dependabot[bot] opened a new pull request, #154: URL: https://github.com/apache/logging-parent/pull/154 Bumps [com.palantir.javaformat:palantir-java-format](https://github.com/palantir/palantir-java-format) from 2.42.0 to 2.43.0. Release notes Sourced from https://github.com/palan

Re: [PR] Migrate site infrastructure to Antora [logging-parent]

2024-04-09 Thread via GitHub
vy commented on code in PR #155: URL: https://github.com/apache/logging-parent/pull/155#discussion_r1557457799 ## .github/workflows/deploy-release-reusable.yaml: ## @@ -28,10 +28,6 @@ on: description: Identifier used in the distribution artifact and Subversion reposito

Re: [PR] Bump co.elastic.clients:elasticsearch-java from 8.13.1 to 8.13.2 (logging-log4j2)

2024-04-09 Thread via GitHub
github-actions[bot] merged PR #2458: URL: https://github.com/apache/logging-log4j2/pull/2458 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

Re: [PR] Migrate site infrastructure to Antora [logging-parent]

2024-04-09 Thread via GitHub
vy commented on code in PR #155: URL: https://github.com/apache/logging-parent/pull/155#discussion_r1557452855 ## .github/workflows/build-reusable.yaml: ## @@ -69,9 +69,34 @@ jobs: -DinstallAtEnd=true \ clean install + # Node.js cache is needed f

[PR] Migrate site infrastructure to Antora [logging-parent]

2024-04-09 Thread via GitHub
vy opened a new pull request, #155: URL: https://github.com/apache/logging-parent/pull/155 apache/logging-log4j2#2427 migrated Log4j 2 to Antora. apache/logging-log4j2#2443 cloned this work for Log4j 3. This PR clones the very same work to `logging-parent` to streamline it for all projects

Re: [PR] Bump commons-io:commons-io from 2.16.0 to 2.16.1 (logging-log4j2)

2024-04-09 Thread via GitHub
github-actions[bot] merged PR #2459: URL: https://github.com/apache/logging-log4j2/pull/2459 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

Re: [PR] Backport part of #2062 to `2.x` branch. (logging-log4j2)

2024-04-09 Thread via GitHub
ppkarwasz commented on PR #2454: URL: https://github.com/apache/logging-log4j2/pull/2454#issuecomment-2044511229 I also included a fix for [`LOG4J2-3618`](https://issues.apache.org/jira/browse/LOG4J2-3618) in this PR, which caused the original test case to fail. If your prefer to spl

Re: [I] After modularization of Log4j2, loading the plugin (PluginManager. addPackage) fails (logging-log4j2)

2024-04-09 Thread via GitHub
ppkarwasz closed issue #2434: After modularization of Log4j2, loading the plugin (PluginManager. addPackage) fails URL: https://github.com/apache/logging-log4j2/issues/2434 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] Backport part of #2062 to `2.x` branch. (logging-log4j2)

2024-04-09 Thread via GitHub
ppkarwasz commented on PR #2454: URL: https://github.com/apache/logging-log4j2/pull/2454#issuecomment-2044346990 Closes #2453 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [I] spring boot 3.2.4 + spring-boot-starter-log4j2 + spring-boot-starter-undertow (logging-log4j2)

2024-04-09 Thread via GitHub
ppkarwasz commented on issue #2453: URL: https://github.com/apache/logging-log4j2/issues/2453#issuecomment-2044346028 This is due to spring-projects/spring-boot#33450. A partial fix was already applied to the 3.x branch in #1799 and is available in version `3.0.0-beta1`. I backported

Re: [PR] Bump commons-io:commons-io from 2.16.0 to 2.16.1 [logging-log4j-tools]

2024-04-09 Thread via GitHub
github-actions[bot] merged PR #114: URL: https://github.com/apache/logging-log4j-tools/pull/114 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifica

[PR] Backport part of #2062 to `2.x` branch. (logging-log4j2)

2024-04-09 Thread via GitHub
ppkarwasz opened a new pull request, #2454: URL: https://github.com/apache/logging-log4j2/pull/2454 This backports the part of PR #2062 that concerns spring-projects/spring-boot#33450 to the `2.x` branch. It contains two sets of changes: - it catches exceptions thrown by proper

[PR] Bump commons-io:commons-io from 2.16.0 to 2.16.1 [logging-log4j-tools]

2024-04-09 Thread via GitHub
dependabot[bot] opened a new pull request, #114: URL: https://github.com/apache/logging-log4j-tools/pull/114 Bumps commons-io:commons-io from 2.16.0 to 2.16.1. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=com

Re: [PR] Restore support for legacy 2.x property names (logging-log4j2)

2024-04-09 Thread via GitHub
ppkarwasz merged PR #2436: URL: https://github.com/apache/logging-log4j2/pull/2436 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubsc

Re: [I] After modularization of Log4j2, loading the plugin (PluginManager. addPackage) fails (logging-log4j2)

2024-04-09 Thread via GitHub
zeimao77 commented on issue #2434: URL: https://github.com/apache/logging-log4j2/issues/2434#issuecomment-2044291392 You were right and successfully solved my problem; The current method of parsing plugins at compile time is much better than the PluginManager method; And it avoids the