Re: [PR] Improve release process repeatability [logging-log4cxx]

swebb2066 commented on PR #363: URL: https://github.com/apache/logging-log4cxx/pull/363#issuecomment-2041324707 > Note: the APACHE_MAINTAINER flag does this already: Using CPack would be acceptable if it supported a white-list instead of an ignore-list. At this time, packaging source

Re: [PR] Improve release process repeatability [logging-log4cxx]

rm5248 commented on PR #363: URL: https://github.com/apache/logging-log4cxx/pull/363#issuecomment-2041068413 Note: the `APACHE_MAINTAINER` flag does this already: https://github.com/apache/logging-log4cxx/blob/ac7eda0d371a2812a3973b817bba9b6f95c968db/CMakeLists.txt#L265 The one thing

Re: [PR] Scoped context (logging-log4j2)

ppkarwasz commented on code in PR #2438: URL: https://github.com/apache/logging-log4j2/pull/2438#discussion_r1554553683 ## log4j-api/src/main/java/org/apache/logging/log4j/spi/internal/DefaultScopedContextProvider.java: ## @@ -0,0 +1,399 @@ +/* + * Licensed to the Apache Softwar

Re: [PR] Scoped context (logging-log4j2)

ppkarwasz commented on code in PR #2438: URL: https://github.com/apache/logging-log4j2/pull/2438#discussion_r1554553444 ## log4j-api/src/main/java/org/apache/logging/log4j/spi/internal/DefaultScopedContextProvider.java: ## @@ -0,0 +1,399 @@ +/* + * Licensed to the Apache Softwar

Re: [PR] Scoped context (logging-log4j2)

ppkarwasz commented on code in PR #2438: URL: https://github.com/apache/logging-log4j2/pull/2438#discussion_r1554551301 ## log4j-api/src/main/java/org/apache/logging/log4j/spi/internal/DefaultScopedContextProvider.java: ## @@ -0,0 +1,421 @@ +/* + * Licensed to the Apache Softwar

Re: [PR] Scoped context (logging-log4j2)

rgoers commented on PR #2438: URL: https://github.com/apache/logging-log4j2/pull/2438#issuecomment-2041000281 At this point I am very happy with where this is and am prepared to merge. If you have technical reasons as to why you would veto the commit please let me know. -- This is an a

Re: [PR] Scoped context (logging-log4j2)

rgoers commented on code in PR #2438: URL: https://github.com/apache/logging-log4j2/pull/2438#discussion_r1554540229 ## log4j-api/src/main/java/org/apache/logging/log4j/spi/internal/DefaultScopedContextProvider.java: ## @@ -0,0 +1,399 @@ +/* + * Licensed to the Apache Software F

Re: [PR] Scoped context (logging-log4j2)

rgoers commented on code in PR #2438: URL: https://github.com/apache/logging-log4j2/pull/2438#discussion_r1554539914 ## log4j-api/src/main/java/org/apache/logging/log4j/spi/internal/DefaultScopedContextProvider.java: ## @@ -0,0 +1,399 @@ +/* + * Licensed to the Apache Software F