[PR] Improve release process repeatability [logging-log4cxx]

2024-04-05 Thread via GitHub
swebb2066 opened a new pull request, #363: URL: https://github.com/apache/logging-log4cxx/pull/363 This PR aims to make the release process more repeatable by using a scripted job run by CI to generate the release files . -- This is an automated message from the Apache Git Service

Re: [PR] #124 fixed more nullable Warnings when targeting net8.0 (logging-log4net)

2024-04-05 Thread via GitHub
FreeAndNil commented on PR #141: URL: https://github.com/apache/logging-log4net/pull/141#issuecomment-2040632651 @erikmav thanks for your feedback. I adjusted the files. I'm definitely thinking about adding .net8 as target. I had the same idea for interpolated strings (especially for th

Re: [I] Enable parallel releases in reusable workflows [logging-parent]

2024-04-05 Thread via GitHub
vy closed issue #139: Enable parallel releases in reusable workflows URL: https://github.com/apache/logging-parent/issues/139 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Create metrics API proof of concept (logging-log4j2)

2024-04-05 Thread via GitHub
jvz commented on PR #1943: URL: https://github.com/apache/logging-log4j2/pull/1943#issuecomment-2040478427 I think that's a good idea. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Create metrics API proof of concept (logging-log4j2)

2024-04-05 Thread via GitHub
jvz closed pull request #1943: Create metrics API proof of concept URL: https://github.com/apache/logging-log4j2/pull/1943 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] Migrate `3.x` website to Antora (logging-log4j2)

2024-04-05 Thread via GitHub
vy merged PR #2443: URL: https://github.com/apache/logging-log4j2/pull/2443 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@lo

Re: [PR] Scoped context (logging-log4j2)

2024-04-05 Thread via GitHub
ppkarwasz commented on code in PR #2438: URL: https://github.com/apache/logging-log4j2/pull/2438#discussion_r1554047173 ## log4j-api/src/main/java/org/apache/logging/log4j/spi/internal/DefaultScopedContextProvider.java: ## @@ -0,0 +1,399 @@ +/* + * Licensed to the Apache Softwar

Re: [I] Threads contention because of OutputStreamManager.writeBytes (logging-log4j2)

2024-04-05 Thread via GitHub
jvz commented on issue #2447: URL: https://github.com/apache/logging-log4j2/issues/2447#issuecomment-2040314637 Does this deadlock coincide with the hourly log file rollover you configured? I wonder if there's a race condition here between incoming log events and the rollover process. --

Re: [PR] #124 fixed more nullable Warnings when targeting net8.0 (logging-log4net)

2024-04-05 Thread via GitHub
erikmav commented on code in PR #141: URL: https://github.com/apache/logging-log4net/pull/141#discussion_r1554000115 ## src/log4net/Core/DefaultRepositorySelector.cs: ## @@ -755,17 +712,12 @@ private void LoadPlugins(Assembly assembly, ILoggerRepository repository) ///

Re: [PR] Scoped context (logging-log4j2)

2024-04-05 Thread via GitHub
ppkarwasz commented on code in PR #2438: URL: https://github.com/apache/logging-log4j2/pull/2438#discussion_r155402 ## log4j-api/src/main/java/org/apache/logging/log4j/ScopedContext.java: ## @@ -0,0 +1,225 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] #124 fixed more nullable Warnings when targeting net8.0 (logging-log4net)

2024-04-05 Thread via GitHub
erikmav commented on PR #141: URL: https://github.com/apache/logging-log4net/pull/141#issuecomment-2040286940 To aid understanding - are you considering adding net8.0 as a target for the 3.0 package? I kind of like it as there are perf optimizations that can be added like avoiding `params o

Re: [PR] Scoped context (logging-log4j2)

2024-04-05 Thread via GitHub
ppkarwasz commented on code in PR #2438: URL: https://github.com/apache/logging-log4j2/pull/2438#discussion_r1554003929 ## log4j-api/src/main/java/org/apache/logging/log4j/spi/internal/DefaultScopedContextProvider.java: ## @@ -0,0 +1,399 @@ +/* + * Licensed to the Apache Softwar

Re: [PR] Scoped context (logging-log4j2)

2024-04-05 Thread via GitHub
rgoers commented on code in PR #2438: URL: https://github.com/apache/logging-log4j2/pull/2438#discussion_r1553773527 ## log4j-api/src/main/java/org/apache/logging/log4j/message/package-info.java: ## @@ -20,7 +20,7 @@ */ @Export /** - * Bumped to 2.22.0, since FormattedMessag

Re: [PR] Scoped context (logging-log4j2)

2024-04-05 Thread via GitHub
rgoers commented on code in PR #2438: URL: https://github.com/apache/logging-log4j2/pull/2438#discussion_r1553771392 ## log4j-api/src/main/java/org/apache/logging/log4j/ScopedContext.java: ## @@ -0,0 +1,225 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

Re: [PR] Scoped context (logging-log4j2)

2024-04-05 Thread via GitHub
rgoers commented on code in PR #2438: URL: https://github.com/apache/logging-log4j2/pull/2438#discussion_r1553757235 ## log4j-api/src/main/java/org/apache/logging/log4j/spi/internal/DefaultScopedContextProvider.java: ## @@ -0,0 +1,399 @@ +/* + * Licensed to the Apache Software F

Re: [PR] Scoped context (logging-log4j2)

2024-04-05 Thread via GitHub
rgoers commented on code in PR #2438: URL: https://github.com/apache/logging-log4j2/pull/2438#discussion_r1553754256 ## log4j-api/src/main/java/org/apache/logging/log4j/spi/internal/DefaultScopedContextProvider.java: ## @@ -0,0 +1,399 @@ +/* + * Licensed to the Apache Software F

Re: [PR] Scoped context (logging-log4j2)

2024-04-05 Thread via GitHub
rgoers commented on code in PR #2438: URL: https://github.com/apache/logging-log4j2/pull/2438#discussion_r1553745339 ## log4j-api/src/main/java/org/apache/logging/log4j/ScopedContext.java: ## @@ -0,0 +1,225 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

Re: [PR] Scoped context (logging-log4j2)

2024-04-05 Thread via GitHub
rgoers commented on code in PR #2438: URL: https://github.com/apache/logging-log4j2/pull/2438#discussion_r1553746082 ## log4j-api/src/main/java/org/apache/logging/log4j/ScopedContext.java: ## @@ -0,0 +1,225 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

Re: [PR] Scoped context (logging-log4j2)

2024-04-05 Thread via GitHub
rgoers commented on code in PR #2438: URL: https://github.com/apache/logging-log4j2/pull/2438#discussion_r1553740141 ## log4j-api-test/src/test/java/org/apache/logging/log4j/ResourceLoggerTest.java: ## @@ -0,0 +1,143 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

Re: [PR] Scoped context (logging-log4j2)

2024-04-05 Thread via GitHub
rgoers commented on code in PR #2438: URL: https://github.com/apache/logging-log4j2/pull/2438#discussion_r1553739209 ## log4j-api/src/main/java/org/apache/logging/log4j/message/package-info.java: ## @@ -20,7 +20,7 @@ */ @Export /** - * Bumped to 2.22.0, since FormattedMessag

Re: [PR] Delegate `ScopedContext` functionality to interface (logging-log4j2)

2024-04-05 Thread via GitHub
rgoers commented on PR #2445: URL: https://github.com/apache/logging-log4j2/pull/2445#issuecomment-2039916880 I disagree with your premise. SimpleLogger has always supported logging the ThreadContext. Including the ScopedContext as well makes sense since they can be interchangeably used. Yo

Re: [I] Threads contention because of OutputStreamManager.writeBytes (logging-log4j2)

2024-04-05 Thread via GitHub
tcmot commented on issue #2447: URL: https://github.com/apache/logging-log4j2/issues/2447#issuecomment-2039705734 I think this is a deadlock. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] #124 fixed more nullable Warnings when targeting net8.0 (logging-log4net)

2024-04-05 Thread via GitHub
FreeAndNil commented on PR #141: URL: https://github.com/apache/logging-log4net/pull/141#issuecomment-2039604820 @erikmav can you take a look? - LoggingEventTest wasn't successful in CEST - fixed more nullable Warnings when targeting net8.0 api -- This is an automated message from th

[PR] #124 fixed more nullable Warnings when targeting net8.0 (logging-log4net)

2024-04-05 Thread via GitHub
FreeAndNil opened a new pull request, #141: URL: https://github.com/apache/logging-log4net/pull/141 - fixed LoggingEventTest for execution in CE(S)T or SAST - added missing nullable attributes from net6-8 - added Log4NetAssert - fixed more nullable Warnings when targeting net8.0

[PR] 3.0.0 preview.1 (logging-log4net)

2024-04-05 Thread via GitHub
FreeAndNil opened a new pull request, #140: URL: https://github.com/apache/logging-log4net/pull/140 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

Re: [I] Error building log4cxx with cmake and APR_STATIC option [logging-log4cxx]

2024-04-05 Thread via GitHub
clobotorre commented on issue #362: URL: https://github.com/apache/logging-log4cxx/issues/362#issuecomment-2039568083 Thank you so much. Solved!! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] Bump com.github.luben:zstd-jni from 1.5.6-1 to 1.5.6-2 (logging-log4j2)

2024-04-05 Thread via GitHub
github-actions[bot] merged PR #2446: URL: https://github.com/apache/logging-log4j2/pull/2446 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

Re: [PR] Create metrics API proof of concept (logging-log4j2)

2024-04-05 Thread via GitHub
ppkarwasz commented on PR #1943: URL: https://github.com/apache/logging-log4j2/pull/1943#issuecomment-2039486315 @jvz, I think we could choose an approach similar to [`RxJavaHooks`](https://github.com/ReactiveX/RxJava/wiki/Plugins) to provide instrumentation hooks **without** affecti

[I] Threads contention because of OutputStreamManager.writeBytes (logging-log4j2)

2024-04-05 Thread via GitHub
bharathchandrathakkallapally-cpi opened a new issue, #2447: URL: https://github.com/apache/logging-log4j2/issues/2447 ## Description We are using the RollingFileAppender with below configuration ``` appender.file.type=RollingFile appender.file.name=LOGFILE appender.file.fileNa

Re: [PR] Bump org.apache.maven.plugins:maven-artifact-plugin from 3.5.0 to 3.5.1 [logging-parent]

2024-04-05 Thread via GitHub
github-actions[bot] merged PR #149: URL: https://github.com/apache/logging-parent/pull/149 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications

[PR] Bump org.apache.maven.plugins:maven-artifact-plugin from 3.5.0 to 3.5.1 [logging-parent]

2024-04-05 Thread via GitHub
dependabot[bot] opened a new pull request, #149: URL: https://github.com/apache/logging-parent/pull/149 Bumps [org.apache.maven.plugins:maven-artifact-plugin](https://github.com/apache/maven-artifact-plugin) from 3.5.0 to 3.5.1. Commits https://github.com/apache/maven-artifact

Re: [PR] Scoped context (logging-log4j2)

2024-04-05 Thread via GitHub
ppkarwasz commented on code in PR #2438: URL: https://github.com/apache/logging-log4j2/pull/2438#discussion_r1553097482 ## log4j-api/src/main/java/org/apache/logging/log4j/message/package-info.java: ## @@ -20,7 +20,7 @@ */ @Export /** - * Bumped to 2.22.0, since FormattedMes

Re: [PR] Migrate `3.x` website to Antora (logging-log4j2)

2024-04-05 Thread via GitHub
vy commented on code in PR #2443: URL: https://github.com/apache/logging-log4j2/pull/2443#discussion_r1553190265 ## src/site/resources/.htaccess: ## @@ -1,5 +1,4 @@ -#!/bin/sh -# +# Review Comment:

Re: [PR] Migrate `3.x` website to Antora (logging-log4j2)

2024-04-05 Thread via GitHub
vy commented on code in PR #2443: URL: https://github.com/apache/logging-log4j2/pull/2443#discussion_r1553169012 ## src/site/resources/.htaccess: ## @@ -8,13 +7,16 @@ # "License"); you may not use this file except in compliance # with the License. You may obtain a copy of the

Re: [PR] Delegate `ScopedContext` functionality to interface (logging-log4j2)

2024-04-05 Thread via GitHub
ppkarwasz commented on PR #2445: URL: https://github.com/apache/logging-log4j2/pull/2445#issuecomment-2039157328 > I have a question though. I just noticed that you made the default ThreadContext provider a no-op. How did that manage to pass unit tests? Why does it need to be a no-op. For o