rgoers commented on PR #2445:
URL: https://github.com/apache/logging-log4j2/pull/2445#issuecomment-2039035897
Rats. I didn't mean to but I merged my changes to this branch by mistake.
They are now in the ScopedContext branch as well.
--
This is an automated message from the Apache Git Ser
rgoers merged PR #2445:
URL: https://github.com/apache/logging-log4j2/pull/2445
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr..
ppkarwasz commented on PR #2438:
URL: https://github.com/apache/logging-log4j2/pull/2438#issuecomment-2038901414
> Looking a second time at your example I now see what you are attempting to
do but I don't think you even need to modify ThreadContextMap to do that. I
could just do:
>
>
ppkarwasz commented on PR #2445:
URL: https://github.com/apache/logging-log4j2/pull/2445#issuecomment-203842
> I took a look at this again. I missed some things the first time through
it. I like most of this but will want to change it a bit.
Feel free to directly modify this branc
rgoers commented on PR #2445:
URL: https://github.com/apache/logging-log4j2/pull/2445#issuecomment-2038564972
AFter thinking about this a bit more I think you are on to something but
this implementation isn't it. I will work on my PR tonight to see what I can do.
--
This is an automated m
rgoers commented on PR #2438:
URL: https://github.com/apache/logging-log4j2/pull/2438#issuecomment-2038466681
@ppkarwasz
No. See my comments there. Unless you can demonstrate a valid reason why I
would want another implementation I don't see the point of uglifying the usage.
--
This
rgoers commented on PR #2445:
URL: https://github.com/apache/logging-log4j2/pull/2445#issuecomment-2038461264
I might buy this if I could envision multiple implementations. But why would
I need more than this? For example, lets pretend SLF4J provided an equivalent
API. Because I have access
rgoers commented on PR #2438:
URL: https://github.com/apache/logging-log4j2/pull/2438#issuecomment-2038446381
@ppkarwasz
> Would you consider merging
https://github.com/apache/logging-log4j2/pull/2445 into this PR?
No, for two reasons:
1. As I showed above it isn't necessar
swebb2066 commented on issue #362:
URL:
https://github.com/apache/logging-log4cxx/issues/362#issuecomment-2038443183
The distro provied apr and apr-util static libraries are built without -fPIC
(probably assuming everthing will be statically linked if anything is
statically linked).
ppkarwasz commented on PR #2444:
URL: https://github.com/apache/logging-log4j2/pull/2444#issuecomment-2038343517
OpenRewrite is **very** active project and the `rewrite` Maven profile is
**not** part of our standard build.
That is why we disabled Dependabot updates on these plugins. I
ppkarwasz closed pull request #2444: Bump rewrite-maven-plugin and recipes
URL: https://github.com/apache/logging-log4j2/pull/2444
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment
ppkarwasz commented on PR #2438:
URL: https://github.com/apache/logging-log4j2/pull/2438#issuecomment-2038331405
Would you consider merging #2445 into this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
ppkarwasz opened a new pull request, #2445:
URL: https://github.com/apache/logging-log4j2/pull/2445
To provide more configurability for the `ScopedContext` service, this PR
moves its implementation details to `log4j-core` and replaces it with a
`ScopedContextProvider` interface.
In L
rgoers commented on PR #2438:
URL: https://github.com/apache/logging-log4j2/pull/2438#issuecomment-2037862545
@ppkarwasz
I looked at the Open Telemetry proposal. While the naming might give the
impression it is similar to ScopedContext they are really unrelated. The Open
Telemetry propo
clobotorre opened a new issue, #362:
URL: https://github.com/apache/logging-log4cxx/issues/362
Steps to reproduce:
```
# curl -L -O
https://dlcdn.apache.org/logging/log4cxx/1.2.0/apache-log4cxx-1.2.0.tar.gz
# tar xzvf apache-log4cxx-1.2.0.tar.gz
# a
github-actions[bot] merged PR #2439:
URL: https://github.com/apache/logging-log4j2/pull/2439
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notificatio
ppkarwasz commented on code in PR #2443:
URL: https://github.com/apache/logging-log4j2/pull/2443#discussion_r1551736197
##
src/site/resources/.htaccess:
##
@@ -8,13 +7,16 @@
# "License"); you may not use this file except in compliance
# with the License. You may obtain a copy
vy opened a new pull request, #2443:
URL: https://github.com/apache/logging-log4j2/pull/2443
This work ports #2427 to `main`, i.e., Log4j 3.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
github-actions[bot] merged PR #2441:
URL: https://github.com/apache/logging-log4j2/pull/2441
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notificatio
ppkarwasz commented on PR #2438:
URL: https://github.com/apache/logging-log4j2/pull/2438#issuecomment-2036848158
@rgoers,
Can you look at #2442? I think that your `ScopedContext#runWhere`
implementation could be replaced by calls to the new `ThreadContextMap#restore`
and `ThreadConte
ppkarwasz commented on issue #2384:
URL:
https://github.com/apache/logging-log4j2/issues/2384#issuecomment-2036850995
> So, I believe Spring Boot has defined it in their ``
section. And if they remove it in version 3.x, Maven will raise an error when
it tries to resolve dependencies.
>
ppkarwasz opened a new pull request, #2442:
URL: https://github.com/apache/logging-log4j2/pull/2442
Adds a new `ExtendedThreadContext` SPI class to help external libraries with
an efficient propagation of the `ThreadContextMap`.
Currently integrators can retrieve and set the context m
9you commented on issue #2384:
URL:
https://github.com/apache/logging-log4j2/issues/2384#issuecomment-2036700488
In Spring 2.x, we use the following declaration (without specifying the
version):
`
org.apache.logging.log4j
log4j-spring-boot
`
So, I believe Spring Boo
FreeAndNil commented on issue #139:
URL:
https://github.com/apache/logging-log4net/issues/139#issuecomment-2036658286
## Breaking Changes
### Framework Support
**Attention:** Starting with 3.0.0 we only support the following target
frameworks
- net462
- netstandard2.0
The
ppkarwasz commented on issue #2384:
URL:
https://github.com/apache/logging-log4j2/issues/2384#issuecomment-2036565176
@9you,
Does any Spring Boot 3.x artifact or starter depend on `log4j-spring-boot`?
If you know such an example, you should probably [submit an issue
report](https://
FreeAndNil closed pull request #137: #124 LoggingEvent.Level not nullable
URL: https://github.com/apache/logging-log4net/pull/137
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
9you commented on issue #2384:
URL:
https://github.com/apache/logging-log4j2/issues/2384#issuecomment-2036388621
Spring Boot should remove log4j-spring-boot from their
declaration. It will cause errors to be reported
immediately when upgrading the Spring Boot version from 2.x to 3.x.
--
lukasalexanderweber commented on issue #2331:
URL:
https://github.com/apache/logging-log4j2/issues/2331#issuecomment-2036387491
great! Till now we used
[ContextDataInjector](https://logging.apache.org/log4j/2.x/javadoc/log4j-core/org/apache/logging/log4j/core/ContextDataInjector.html)
to c
github-actions[bot] merged PR #113:
URL: https://github.com/apache/logging-log4j-tools/pull/113
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifica
dependabot[bot] opened a new pull request, #113:
URL: https://github.com/apache/logging-log4j-tools/pull/113
Bumps
[org.apache.maven.plugin-tools:maven-plugin-annotations](https://github.com/apache/maven-plugin-tools)
from 3.11.0 to 3.12.0.
Release notes
Sourced from https://githu
vy merged PR #2427:
URL: https://github.com/apache/logging-log4j2/pull/2427
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@lo
31 matches
Mail list logo