ppkarwasz commented on PR #2402:
URL: https://github.com/apache/logging-log4j2/pull/2402#issuecomment-2028556859
Nothing to be worried about: there must be a race condition in the way
Github interprets the CI script actions. The script:
1. modifies the PR branch,
1. calls `git pus
garydgregory commented on PR #2402:
URL: https://github.com/apache/logging-log4j2/pull/2402#issuecomment-2028506271
What happened?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
github-actions[bot] closed pull request #2402: Bump
commons-logging:commons-logging from 1.3.0 to 1.3.1
URL: https://github.com/apache/logging-log4j2/pull/2402
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
github-actions[bot] merged PR #2432:
URL: https://github.com/apache/logging-log4j2/pull/2432
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notificatio
github-actions[bot] merged PR #2409:
URL: https://github.com/apache/logging-log4j2/pull/2409
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notificatio
github-actions[bot] merged PR #2433:
URL: https://github.com/apache/logging-log4j2/pull/2433
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notificatio
ppkarwasz merged PR #2425:
URL: https://github.com/apache/logging-log4j2/pull/2425
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubsc
ppkarwasz merged PR #2426:
URL: https://github.com/apache/logging-log4j2/pull/2426
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubsc
ppkarwasz commented on PR #2402:
URL: https://github.com/apache/logging-log4j2/pull/2402#issuecomment-2028486688
@dependabot rebase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
ppkarwasz commented on PR #2431:
URL: https://github.com/apache/logging-log4j2/pull/2431#issuecomment-2028485018
@dependabot recreate
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
ppkarwasz closed pull request #2431: Bump log4j-api.version from
2.24.0-SNAPSHOT to 3.0.0-beta2
URL: https://github.com/apache/logging-log4j2/pull/2431
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
ppkarwasz commented on PR #2431:
URL: https://github.com/apache/logging-log4j2/pull/2431#issuecomment-2028483230
@dependabot recreate
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
ppkarwasz commented on PR #2431:
URL: https://github.com/apache/logging-log4j2/pull/2431#issuecomment-2028482589
@dependabot recreate
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
ppkarwasz commented on PR #2431:
URL: https://github.com/apache/logging-log4j2/pull/2431#issuecomment-2028482438
@dependabot rebase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
ppkarwasz commented on PR #2409:
URL: https://github.com/apache/logging-log4j2/pull/2409#issuecomment-2028476718
@dependabot recreate
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
rgoers commented on issue #2331:
URL:
https://github.com/apache/logging-log4j2/issues/2331#issuecomment-2028149070
I am going to go one further. This is NOT a bug. The purpose of
ContextDataProvider is to inject data into LogEvents. That is documented
clearly in the [Extending
Log4j](htt
rgoers closed issue #2331: ContextDataInjector ignores custom
ContextDataProvider
URL: https://github.com/apache/logging-log4j2/issues/2331
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
ppkarwasz commented on PR #2419:
URL: https://github.com/apache/logging-log4j2/pull/2419#issuecomment-2028035321
@rgoers,
In your edited comment you make a lot of good points. Let us discuss in a
video call after the holidays.
--
This is an automated message from the Apache Git Ser
rgoers commented on PR #2419:
URL: https://github.com/apache/logging-log4j2/pull/2419#issuecomment-2028028153
@ppkarwasz
As I said in my edited comment above, that can't be done without exposing
ThreadContextMap to breakage.
--
This is an automated message from the Apache Git Service.
ppkarwasz commented on PR #2419:
URL: https://github.com/apache/logging-log4j2/pull/2419#issuecomment-2028027525
> OK. Since you are -1 on ScopedContext I will close this PR.
I would be OK with an implementation based on `ThreadContextMap` that does
not introduce new `ThreadLocal`s.
rgoers closed pull request #2419: Scoped context
URL: https://github.com/apache/logging-log4j2/pull/2419
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
rgoers commented on PR #2419:
URL: https://github.com/apache/logging-log4j2/pull/2419#issuecomment-2028019689
OK. Since you are -1 on ScopedContext I will close this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
ppkarwasz commented on code in PR #2419:
URL: https://github.com/apache/logging-log4j2/pull/2419#discussion_r1545237304
##
log4j-api/src/main/java/org/apache/logging/log4j/message/ParameterizedMapMessage.java:
##
@@ -0,0 +1,38 @@
+/*
+ * Licensed to the Apache Software Foundatio
rgoers commented on code in PR #2419:
URL: https://github.com/apache/logging-log4j2/pull/2419#discussion_r1545166863
##
log4j-api/src/main/java/org/apache/logging/log4j/message/ParameterizedMapMessage.java:
##
@@ -0,0 +1,38 @@
+/*
+ * Licensed to the Apache Software Foundation (
ppkarwasz commented on code in PR #2419:
URL: https://github.com/apache/logging-log4j2/pull/2419#discussion_r1545235864
##
log4j-api/src/main/java/org/apache/logging/log4j/ScopedContext.java:
##
@@ -0,0 +1,558 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
ppkarwasz commented on PR #2419:
URL: https://github.com/apache/logging-log4j2/pull/2419#issuecomment-2027966002
> @ppkarwasz You have flagged this as "Changes Requested". It isn't really
clear what you have requested. If it is to remove ScopedContext that isn't
going to happen so we will h
26 matches
Mail list logo
