Re: [PR] Scoped context (logging-log4j2)

2024-03-29 Thread via GitHub
rgoers commented on code in PR #2419: URL: https://github.com/apache/logging-log4j2/pull/2419#discussion_r1545166863 ## log4j-api/src/main/java/org/apache/logging/log4j/message/ParameterizedMapMessage.java: ## @@ -0,0 +1,38 @@ +/* + * Licensed to the Apache Software Foundation (

Re: [PR] Scoped context (logging-log4j2)

2024-03-29 Thread via GitHub
rgoers commented on code in PR #2419: URL: https://github.com/apache/logging-log4j2/pull/2419#discussion_r1545163907 ## log4j-api/src/main/java/org/apache/logging/log4j/ScopedContext.java: ## @@ -0,0 +1,558 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

Re: [PR] Scoped context (logging-log4j2)

2024-03-29 Thread via GitHub
rgoers commented on code in PR #2419: URL: https://github.com/apache/logging-log4j2/pull/2419#discussion_r1545163907 ## log4j-api/src/main/java/org/apache/logging/log4j/ScopedContext.java: ## @@ -0,0 +1,558 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

Re: [PR] Scoped context (logging-log4j2)

2024-03-29 Thread via GitHub
rgoers commented on PR #2419: URL: https://github.com/apache/logging-log4j2/pull/2419#issuecomment-2027934747 @ppkarwasz You have flagged this as "Changes Requested". It isn't really clear what you have requested. If it is to remove ScopedContext that isn't going to happen so we will ha

Re: [PR] Bump commons-logging:commons-logging from 1.3.0 to 1.3.1 [logging-log4j-transform]

2024-03-29 Thread via GitHub
github-actions[bot] merged PR #90: URL: https://github.com/apache/logging-log4j-transform/pull/90 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifi

Re: [PR] Bump commons-logging:commons-logging from 1.3.0 to 1.3.1 [logging-log4j-transform]

2024-03-29 Thread via GitHub
github-actions[bot] merged PR #90: URL: https://github.com/apache/logging-log4j-transform/pull/90 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifi

Re: [PR] Bump commons-io:commons-io from 2.15.1 to 2.16.0 [logging-log4j-transform]

2024-03-29 Thread via GitHub
github-actions[bot] merged PR #91: URL: https://github.com/apache/logging-log4j-transform/pull/91 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifi

Re: [PR] Scoped context (logging-log4j2)

2024-03-29 Thread via GitHub
ppkarwasz commented on PR #2419: URL: https://github.com/apache/logging-log4j2/pull/2419#issuecomment-2027684082 > @rocketraman I have modified the PR so that ResourceLogger uses ScopedContext and behaves the way you requested. @ppkarwasz I have no idea why the PR system lets me reply to so

[PR] Bump commons-io:commons-io from 2.15.1 to 2.16.0 [logging-log4j-transform]

2024-03-29 Thread via GitHub
dependabot[bot] opened a new pull request, #91: URL: https://github.com/apache/logging-log4j-transform/pull/91 Bumps commons-io:commons-io from 2.15.1 to 2.16.0. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=c

Re: [PR] Scoped context (logging-log4j2)

2024-03-29 Thread via GitHub
ppkarwasz commented on code in PR #2419: URL: https://github.com/apache/logging-log4j2/pull/2419#discussion_r1544820856 ## log4j-api/src/main/java/org/apache/logging/log4j/message/ParameterizedMapMessage.java: ## @@ -0,0 +1,38 @@ +/* + * Licensed to the Apache Software Foundatio

Re: [PR] Scoped context (logging-log4j2)

2024-03-29 Thread via GitHub
ppkarwasz commented on code in PR #2419: URL: https://github.com/apache/logging-log4j2/pull/2419#discussion_r1544808343 ## log4j-api/src/main/java/org/apache/logging/log4j/ScopedContext.java: ## @@ -0,0 +1,558 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Scoped context (logging-log4j2)

2024-03-29 Thread via GitHub
jvz commented on code in PR #2419: URL: https://github.com/apache/logging-log4j2/pull/2419#discussion_r1544765859 ## log4j-api/src/main/java/org/apache/logging/log4j/ScopedContext.java: ## @@ -0,0 +1,558 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or mo

Re: [PR] Scoped context (logging-log4j2)

2024-03-29 Thread via GitHub
rgoers commented on code in PR #2419: URL: https://github.com/apache/logging-log4j2/pull/2419#discussion_r1544757312 ## log4j-api/src/main/java/org/apache/logging/log4j/message/ParameterizedMapMessage.java: ## @@ -0,0 +1,38 @@ +/* + * Licensed to the Apache Software Foundation (

Re: [PR] Scoped context (logging-log4j2)

2024-03-29 Thread via GitHub
rgoers commented on code in PR #2419: URL: https://github.com/apache/logging-log4j2/pull/2419#discussion_r1544756837 ## log4j-api/src/main/java/org/apache/logging/log4j/internal/ScopedContextAnchor.java: ## @@ -0,0 +1,69 @@ +/* + * Licensed to the Apache Software Foundation (ASF

Re: [PR] Scoped context (logging-log4j2)

2024-03-29 Thread via GitHub
rgoers commented on code in PR #2419: URL: https://github.com/apache/logging-log4j2/pull/2419#discussion_r1544753833 ## log4j-api/src/main/java/org/apache/logging/log4j/ScopedContext.java: ## @@ -0,0 +1,558 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

Re: [PR] Scoped context (logging-log4j2)

2024-03-29 Thread via GitHub
jvz commented on code in PR #2419: URL: https://github.com/apache/logging-log4j2/pull/2419#discussion_r1544699049 ## log4j-api-test/src/test/java/org/apache/logging/log4j/ResourceLoggerTest.java: ## @@ -0,0 +1,136 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] Scoped context (logging-log4j2)

2024-03-29 Thread via GitHub
jvz commented on code in PR #2419: URL: https://github.com/apache/logging-log4j2/pull/2419#discussion_r1544697051 ## log4j-api/src/main/java/org/apache/logging/log4j/ScopedContext.java: ## @@ -0,0 +1,558 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or mo

Re: [PR] Bump commons-io:commons-io from 2.15.1 to 2.16.0 [logging-log4j-audit]

2024-03-29 Thread via GitHub
github-actions[bot] merged PR #134: URL: https://github.com/apache/logging-log4j-audit/pull/134 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifica

[PR] Bump commons-io:commons-io from 2.15.1 to 2.16.0 [logging-log4j-audit]

2024-03-29 Thread via GitHub
dependabot[bot] opened a new pull request, #134: URL: https://github.com/apache/logging-log4j-audit/pull/134 Bumps commons-io:commons-io from 2.15.1 to 2.16.0. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=com

Re: [PR] Scoped context (logging-log4j2)

2024-03-29 Thread via GitHub
rgoers commented on code in PR #2419: URL: https://github.com/apache/logging-log4j2/pull/2419#discussion_r1544596128 ## log4j-api/src/main/java/org/apache/logging/log4j/ScopedContext.java: ## @@ -0,0 +1,558 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

Re: [PR] Scoped context (logging-log4j2)

2024-03-29 Thread via GitHub
rgoers commented on code in PR #2419: URL: https://github.com/apache/logging-log4j2/pull/2419#discussion_r1544596128 ## log4j-api/src/main/java/org/apache/logging/log4j/ScopedContext.java: ## @@ -0,0 +1,558 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

Re: [PR] Bump io.netty:netty-bom from 4.1.107.Final to 4.1.108.Final (logging-log4j2)

2024-03-29 Thread via GitHub
github-actions[bot] merged PR #2397: URL: https://github.com/apache/logging-log4j2/pull/2397 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

Re: [PR] Bump commons-io:commons-io from 2.15.1 to 2.16.0 (logging-log4j2)

2024-03-29 Thread via GitHub
github-actions[bot] merged PR #2430: URL: https://github.com/apache/logging-log4j2/pull/2430 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

Re: [PR] Scoped context (logging-log4j2)

2024-03-29 Thread via GitHub
rgoers commented on PR #2419: URL: https://github.com/apache/logging-log4j2/pull/2419#issuecomment-2027370520 @rocketraman I have modified the PR so that ResourceLogger uses ScopedContext and behaves the way you requested. @ppkarwasz I have no idea why the PR system lets me reply to some

Re: [PR] Scoped context (logging-log4j2)

2024-03-29 Thread via GitHub
rgoers commented on code in PR #2419: URL: https://github.com/apache/logging-log4j2/pull/2419#discussion_r1544606640 ## log4j-api/src/main/java/org/apache/logging/log4j/ResourceLogger.java: ## @@ -0,0 +1,276 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one o

Re: [PR] Scoped context (logging-log4j2)

2024-03-29 Thread via GitHub
rgoers commented on code in PR #2419: URL: https://github.com/apache/logging-log4j2/pull/2419#discussion_r1544600596 ## log4j-api/src/main/java/org/apache/logging/log4j/message/ParameterizedMapMessage.java: ## @@ -0,0 +1,38 @@ +/* + * Licensed to the Apache Software Foundation (

Re: [PR] Scoped context (logging-log4j2)

2024-03-29 Thread via GitHub
rgoers commented on code in PR #2419: URL: https://github.com/apache/logging-log4j2/pull/2419#discussion_r1544596128 ## log4j-api/src/main/java/org/apache/logging/log4j/ScopedContext.java: ## @@ -0,0 +1,558 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

Re: [PR] Bump commons-logging:commons-logging from 1.3.0 to 1.3.1 (logging-log4j2)

2024-03-29 Thread via GitHub
ppkarwasz commented on PR #2402: URL: https://github.com/apache/logging-log4j2/pull/2402#issuecomment-2027340194 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] Bump io.netty:netty-bom from 4.1.107.Final to 4.1.108.Final (logging-log4j2)

2024-03-29 Thread via GitHub
ppkarwasz commented on PR #2397: URL: https://github.com/apache/logging-log4j2/pull/2397#issuecomment-2027339889 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] Remove `o.a.l.l.c.a.r.a.Duration` class (logging-log4j2)

2024-03-29 Thread via GitHub
ppkarwasz commented on code in PR #2426: URL: https://github.com/apache/logging-log4j2/pull/2426#discussion_r1544583487 ## log4j-core/src/main/java/org/apache/logging/log4j/core/appender/rolling/action/IfLastModified.java: ## @@ -97,17 +91,24 @@ public String toString() {

Re: [PR] Deprecate `o.a.l.l.c.a.r.a.Duration` class for removal (logging-log4j2)

2024-03-29 Thread via GitHub
ppkarwasz commented on code in PR #2425: URL: https://github.com/apache/logging-log4j2/pull/2425#discussion_r1544575754 ## log4j-core/src/main/java/org/apache/logging/log4j/core/config/plugins/convert/TypeConverters.java: ## @@ -224,11 +224,26 @@ public Double convert(final Stri

Re: [PR] Add logging to `PropertiesUtil` and fix `Duration` parser (logging-log4j2)

2024-03-29 Thread via GitHub
ppkarwasz commented on code in PR #2424: URL: https://github.com/apache/logging-log4j2/pull/2424#discussion_r1544550920 ## log4j-api/src/main/java/org/apache/logging/log4j/util/PropertiesUtil.java: ## @@ -64,6 +68,8 @@ public final class PropertiesUtil { private static fina

Re: [PR] Add logging to `PropertiesUtil` and fix `Duration` parser (logging-log4j2)

2024-03-29 Thread via GitHub
ppkarwasz commented on code in PR #2424: URL: https://github.com/apache/logging-log4j2/pull/2424#discussion_r1544546233 ## log4j-api/src/main/java/org/apache/logging/log4j/util/PropertiesUtil.java: ## @@ -649,45 +674,57 @@ public static Map partitionOnCommonPrefixes( * @r

Re: [PR] Merge `feature/log4j-sdk` into `main` (logging-log4j2)

2024-03-29 Thread via GitHub
ppkarwasz merged PR #2428: URL: https://github.com/apache/logging-log4j2/pull/2428 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubsc

Re: [PR] Scoped context (logging-log4j2)

2024-03-29 Thread via GitHub
ppkarwasz commented on PR #2419: URL: https://github.com/apache/logging-log4j2/pull/2419#issuecomment-2027253194 @rgoers, Could you review my #2381 PR that introduces another `MessageFactory` to deal with Logback's throwable semantics? Maybe we should really consider creating a `log4

Re: [PR] Scoped context (logging-log4j2)

2024-03-29 Thread via GitHub
ppkarwasz commented on PR #2419: URL: https://github.com/apache/logging-log4j2/pull/2419#issuecomment-2027242392 @rgoers, > It is worth repeating that resource Loggers should **NEVER** be added to the LoggerRegistry. Resource Loggers need to have the same lifetime as the resource. Logger

Re: [PR] Scoped context (logging-log4j2)

2024-03-29 Thread via GitHub
ppkarwasz commented on code in PR #2419: URL: https://github.com/apache/logging-log4j2/pull/2419#discussion_r1544402118 ## log4j-api/src/main/java/org/apache/logging/log4j/message/ParameterizedMapMessage.java: ## @@ -0,0 +1,38 @@ +/* + * Licensed to the Apache Software Foundatio

Re: [PR] Bump commons-io:commons-io from 2.15.1 to 2.16.0 (logging-log4j2)

2024-03-29 Thread via GitHub
github-actions[bot] merged PR #2429: URL: https://github.com/apache/logging-log4j2/pull/2429 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

Re: [PR] Bump commons-io:commons-io from 2.15.1 to 2.16.0 [logging-log4j-tools]

2024-03-29 Thread via GitHub
github-actions[bot] merged PR #112: URL: https://github.com/apache/logging-log4j-tools/pull/112 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifica

Re: [PR] Bump commons-io:commons-io from 2.15.1 to 2.16.0 [logging-log4j-tools]

2024-03-29 Thread via GitHub
github-actions[bot] merged PR #112: URL: https://github.com/apache/logging-log4j-tools/pull/112 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifica

[PR] Bump commons-io:commons-io from 2.15.1 to 2.16.0 [logging-log4j-tools]

2024-03-29 Thread via GitHub
dependabot[bot] opened a new pull request, #112: URL: https://github.com/apache/logging-log4j-tools/pull/112 Bumps commons-io:commons-io from 2.15.1 to 2.16.0. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=com