[PR] Remove Log4j API 3.x (logging-log4j2)

2024-03-25 Thread via GitHub
ppkarwasz opened a new pull request, #2411: URL: https://github.com/apache/logging-log4j2/pull/2411 This PR is based on #2410. Since the Log4j API 3.x modules are no longer used, they are simply deleted. -- This is an automated message from the Apache Git Service. To respond to

[PR] Rebase Log4j Core 3.x on Log4j API 2.x (logging-log4j2)

2024-03-25 Thread via GitHub
ppkarwasz opened a new pull request, #2410: URL: https://github.com/apache/logging-log4j2/pull/2410 This PR depends on #2400 being accepted. We rebase Log4j Core 3.x and its submodules on top of Log4j API 2.x, which concludes #2290. ## Main changes - Classes moved to Lo

Re: [PR] Bump io.fabric8:kubernetes-client-bom from 6.9.2 to 6.10.0 [logging-log4j-samples]

2024-03-25 Thread via GitHub
dependabot[bot] closed pull request #106: Bump io.fabric8:kubernetes-client-bom from 6.9.2 to 6.10.0 URL: https://github.com/apache/logging-log4j-samples/pull/106 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

Re: [PR] Bump io.fabric8:kubernetes-client-bom from 6.9.2 to 6.10.0 [logging-log4j-samples]

2024-03-25 Thread via GitHub
dependabot[bot] commented on PR #106: URL: https://github.com/apache/logging-log4j-samples/pull/106#issuecomment-2019174806 Superseded by #120. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[PR] Bump io.fabric8:kubernetes-client-bom from 6.9.2 to 6.11.0 [logging-log4j-samples]

2024-03-25 Thread via GitHub
dependabot[bot] opened a new pull request, #120: URL: https://github.com/apache/logging-log4j-samples/pull/120 Bumps [io.fabric8:kubernetes-client-bom](https://github.com/fabric8io/kubernetes-client) from 6.9.2 to 6.11.0. Release notes Sourced from https://github.com/fabric8io/kub

Re: [I] Pass `LogEvent` to `NoSqlConnection#insertObject` (logging-log4j2)

2024-03-25 Thread via GitHub
tonycody closed issue #2389: Pass `LogEvent` to `NoSqlConnection#insertObject` URL: https://github.com/apache/logging-log4j2/issues/2389 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [I] Pass `LogEvent` to `NoSqlConnection#insertObject` (logging-log4j2)

2024-03-25 Thread via GitHub
tonycody commented on issue #2389: URL: https://github.com/apache/logging-log4j2/issues/2389#issuecomment-2019057713 👌Thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

Re: [PR] Remove `log4j-kubernetes` in version 3.x (logging-log4j2)

2024-03-25 Thread via GitHub
ppkarwasz commented on PR #2408: URL: https://github.com/apache/logging-log4j2/pull/2408#issuecomment-2018945436 > This looks good to me. Should it be dropped in 2.x as well? I guess we can also drop it from 2.x. -- This is an automated message from the Apache Git Service. To respon

Re: [PR] Bump commons-logging:commons-logging from 1.3.0 to 1.3.1 [logging-log4j-jakarta]

2024-03-25 Thread via GitHub
github-actions[bot] closed pull request #25: Bump commons-logging:commons-logging from 1.3.0 to 1.3.1 URL: https://github.com/apache/logging-log4j-jakarta/pull/25 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

Re: [PR] Add auto-generated plugin reference to the `3.x` site (logging-log4j2)

2024-03-25 Thread via GitHub
ppkarwasz commented on code in PR #2407: URL: https://github.com/apache/logging-log4j2/pull/2407#discussion_r1538172830 ## log4j-parent/pom.xml: ## @@ -1028,6 +1031,118 @@ + + + + plugin-processing + + + + + .log4j-pl

Re: [PR] Bump org.ow2.asm:asm-bom from 9.6 to 9.7 [logging-log4j-transform]

2024-03-25 Thread via GitHub
github-actions[bot] merged PR #89: URL: https://github.com/apache/logging-log4j-transform/pull/89 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifi

[PR] Bump commons-logging:commons-logging from 1.3.0 to 1.3.1 [logging-log4j-transform]

2024-03-25 Thread via GitHub
dependabot[bot] opened a new pull request, #90: URL: https://github.com/apache/logging-log4j-transform/pull/90 Bumps commons-logging:commons-logging from 1.3.0 to 1.3.1. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependenc

[PR] Bump org.ow2.asm:asm-bom from 9.6 to 9.7 [logging-log4j-transform]

2024-03-25 Thread via GitHub
dependabot[bot] opened a new pull request, #89: URL: https://github.com/apache/logging-log4j-transform/pull/89 Bumps org.ow2.asm:asm-bom from 9.6 to 9.7. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=org.ow2.a

Re: [PR] Add auto-generated plugin reference to the `3.x` site (logging-log4j2)

2024-03-25 Thread via GitHub
vy commented on code in PR #2407: URL: https://github.com/apache/logging-log4j2/pull/2407#discussion_r1538142217 ## log4j-parent/pom.xml: ## @@ -1028,6 +1031,118 @@ + + + + plugin-processing + + + + + .log4j-plugin-pr

Re: [PR] Add auto-generated plugin reference to the `3.x` site (logging-log4j2)

2024-03-25 Thread via GitHub
vy commented on code in PR #2407: URL: https://github.com/apache/logging-log4j2/pull/2407#discussion_r1538142217 ## log4j-parent/pom.xml: ## @@ -1028,6 +1031,118 @@ + + + + plugin-processing + + + + + .log4j-plugin-pr

Re: [PR] Adds new `NoSqlConnection#insertObject()` accepting `LogEvent` (logging-log4j2)

2024-03-25 Thread via GitHub
vy closed pull request #2391: Adds new `NoSqlConnection#insertObject()` accepting `LogEvent` URL: https://github.com/apache/logging-log4j2/pull/2391 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

Re: [PR] Bump commons-logging:commons-logging from 1.3.0 to 1.3.1 [logging-log4j-audit]

2024-03-25 Thread via GitHub
github-actions[bot] merged PR #132: URL: https://github.com/apache/logging-log4j-audit/pull/132 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifica

Re: [PR] Bump org.aspectj:aspectjweaver from 1.9.21.2 to 1.9.22 [logging-log4j-audit]

2024-03-25 Thread via GitHub
github-actions[bot] merged PR #133: URL: https://github.com/apache/logging-log4j-audit/pull/133 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifica

Re: [PR] Bump org.aspectj:aspectjweaver from 1.9.21.2 to 1.9.22 [logging-log4j-audit]

2024-03-25 Thread via GitHub
github-actions[bot] merged PR #133: URL: https://github.com/apache/logging-log4j-audit/pull/133 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifica

[PR] Bump org.aspectj:aspectjweaver from 1.9.21.2 to 1.9.22 [logging-log4j-audit]

2024-03-25 Thread via GitHub
dependabot[bot] opened a new pull request, #133: URL: https://github.com/apache/logging-log4j-audit/pull/133 Bumps [org.aspectj:aspectjweaver](https://github.com/eclipse/org.aspectj) from 1.9.21.2 to 1.9.22. Release notes Sourced from https://github.com/eclipse/org.aspectj/releases

[PR] Bump commons-logging:commons-logging from 1.3.0 to 1.3.1 [logging-log4j-audit]

2024-03-25 Thread via GitHub
dependabot[bot] opened a new pull request, #132: URL: https://github.com/apache/logging-log4j-audit/pull/132 Bumps commons-logging:commons-logging from 1.3.0 to 1.3.1. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-

[PR] Part 5 of nullable and modernization (logging-log4net)

2024-03-25 Thread via GitHub
erikmav opened a new pull request, #131: URL: https://github.com/apache/logging-log4net/pull/131 Enable nullable for the whole repo, including enabling some disabled XML tests and adding more test coverage. For #124 . -- This is an automated message from the Apache Git Service. To respon

Re: [I] NullRefException from shutdown in 2.0.16 (logging-log4net)

2024-03-25 Thread via GitHub
andreycha commented on issue #118: URL: https://github.com/apache/logging-log4net/issues/118#issuecomment-2018333051 @FreeAndNil thanks a lot! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [I] NullRefException from shutdown in 2.0.16 (logging-log4net)

2024-03-25 Thread via GitHub
FreeAndNil commented on issue #118: URL: https://github.com/apache/logging-log4net/issues/118#issuecomment-2018303353 @andreycha https://github.com/apache/logging-log4net/releases/tag/rel%2F2.0.17 https://www.nuget.org/packages/log4net/2.0.17 -- This is an automated message from the

Re: [PR] Update version for 2.0.17 (logging-log4net)

2024-03-25 Thread via GitHub
fluffynuts merged PR #121: URL: https://github.com/apache/logging-log4net/pull/121 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubsc

Re: [PR] Adds new `NoSqlConnection#insertObject()` accepting `LogEvent` (logging-log4j2)

2024-03-25 Thread via GitHub
ppkarwasz commented on PR #2391: URL: https://github.com/apache/logging-log4j2/pull/2391#issuecomment-2017998260 @vy, @garydgregory, As I explained in #2389, I am for closing this PR and look for a different way to solve that issue. -- This is an automated message from the Apache G

Re: [PR] Add auto-generated plugin reference to the `3.x` site (logging-log4j2)

2024-03-25 Thread via GitHub
ppkarwasz commented on code in PR #2407: URL: https://github.com/apache/logging-log4j2/pull/2407#discussion_r1537565796 ## log4j-parent/pom.xml: ## @@ -1028,6 +1031,118 @@ + + + + plugin-processing + + + + + .log4j-pl

[PR] Remove `log4j-kubernetes` in version 3.x (logging-log4j2)

2024-03-25 Thread via GitHub
ppkarwasz opened a new pull request, #2408: URL: https://github.com/apache/logging-log4j2/pull/2408 Due to differences in the lifecycle of Log4j Core and Kubernetes Client, we remove `log4j-kubernetes` from the 3.x release and redirect users to Fabric8's own `kubernetes-log4j` artifact intr

[PR] Add auto-generated plugin reference to the `3.x` site (logging-log4j2)

2024-03-25 Thread via GitHub
vy opened a new pull request, #2407: URL: https://github.com/apache/logging-log4j2/pull/2407 This PR ports #2404 from `2.x` to `main` for Log4j 3. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [I] Add profile to generate a coverage report [logging-parent]

2024-03-25 Thread via GitHub
ppkarwasz closed issue #140: Add profile to generate a coverage report URL: https://github.com/apache/logging-parent/issues/140 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] Add test coverage profile [logging-parent]

2024-03-25 Thread via GitHub
ppkarwasz merged PR #141: URL: https://github.com/apache/logging-parent/pull/141 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr.

Re: [PR] Add auto-generated plugin reference to the `2.x` site (logging-log4j2)

2024-03-25 Thread via GitHub
ppkarwasz commented on code in PR #2404: URL: https://github.com/apache/logging-log4j2/pull/2404#discussion_r1537484589 ## log4j-api/pom.xml: ## @@ -28,7 +28,7 @@ Apache Log4j API The Apache Log4j API -false +false Review Comment: No, it is just a note for

Re: [PR] Add auto-generated plugin reference to the `2.x` site (logging-log4j2)

2024-03-25 Thread via GitHub
vy commented on code in PR #2404: URL: https://github.com/apache/logging-log4j2/pull/2404#discussion_r1537481147 ## log4j-core-test/src/test/java/org/apache/logging/log4j/core/config/xml/XmlSchemaTest.java: ## @@ -1,103 +0,0 @@ -/* - * Licensed to the Apache Software Foundation

Re: [PR] Bump commons-logging:commons-logging from 1.3.0 to 1.3.1 (logging-log4j2)

2024-03-25 Thread via GitHub
github-actions[bot] merged PR #2405: URL: https://github.com/apache/logging-log4j2/pull/2405 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

Re: [PR] Add auto-generated plugin reference to the `2.x` site (logging-log4j2)

2024-03-25 Thread via GitHub
vy commented on code in PR #2404: URL: https://github.com/apache/logging-log4j2/pull/2404#discussion_r1537472842 ## log4j-core-java9/pom.xml: ## @@ -30,6 +30,8 @@ 9 true +true Review Comment: Made it `./mvnw install`able again in a4851854936aea9ebc862b12e4

Re: [PR] Add auto-generated plugin reference to the `2.x` site (logging-log4j2)

2024-03-25 Thread via GitHub
vy commented on code in PR #2404: URL: https://github.com/apache/logging-log4j2/pull/2404#discussion_r1537473129 ## log4j-core/pom.xml: ## @@ -222,40 +233,61 @@ + maven-compiler-plugin - - - + +

Re: [I] Clean up after next `cyclonedx-maven-plugin` upgrade [logging-parent]

2024-03-25 Thread via GitHub
ppkarwasz closed issue #105: Clean up after next `cyclonedx-maven-plugin` upgrade URL: https://github.com/apache/logging-parent/issues/105 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

Re: [PR] Replace `process-sbom` script with CycloneDX configuration [logging-parent]

2024-03-25 Thread via GitHub
ppkarwasz merged PR #147: URL: https://github.com/apache/logging-parent/pull/147 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr.

Re: [PR] Add auto-generated plugin reference to the `2.x` site (logging-log4j2)

2024-03-25 Thread via GitHub
ppkarwasz commented on code in PR #2404: URL: https://github.com/apache/logging-log4j2/pull/2404#discussion_r1537394035 ## log4j-core-java9/pom.xml: ## @@ -30,6 +30,8 @@ 9 true +true Review Comment: The `log4j-core-java9` artifact was intentionally "install

Re: [PR] Add auto-generated plugin reference to the `2.x` site (logging-log4j2)

2024-03-25 Thread via GitHub
vy commented on code in PR #2404: URL: https://github.com/apache/logging-log4j2/pull/2404#discussion_r1537396203 ## log4j-api/pom.xml: ## @@ -28,7 +28,7 @@ Apache Log4j API The Apache Log4j API -false +false Review Comment: Yes, and this is in line with `ma

Re: [PR] Add test coverage profile [logging-parent]

2024-03-25 Thread via GitHub
vy commented on code in PR #141: URL: https://github.com/apache/logging-parent/pull/141#discussion_r1537393539 ## pom.xml: ## @@ -1659,6 +1667,49 @@ import org.apache.commons.codec.digest.*; + + + + coverage + + + + + +o

Re: [PR] Add test coverage profile [logging-parent]

2024-03-25 Thread via GitHub
vy commented on code in PR #141: URL: https://github.com/apache/logging-parent/pull/141#discussion_r1537393539 ## pom.xml: ## @@ -1659,6 +1667,49 @@ import org.apache.commons.codec.digest.*; + + + + coverage + + + + + +o

Re: [PR] Add auto-generated plugin reference to the `2.x` site (logging-log4j2)

2024-03-25 Thread via GitHub
ppkarwasz commented on code in PR #2404: URL: https://github.com/apache/logging-log4j2/pull/2404#discussion_r1537388385 ## log4j-api/pom.xml: ## @@ -28,7 +28,7 @@ Apache Log4j API The Apache Log4j API -false +false Review Comment: This PR also replaces our

[PR] Add auto-generated plugin reference to the `2.x` site (logging-log4j2)

2024-03-25 Thread via GitHub
vy opened a new pull request, #2404: URL: https://github.com/apache/logging-log4j2/pull/2404 This PR adds the following new steps to the project build. 1. At `compile` phase, auto-generate plugin descriptors using an annotation processor 2. At `site` phase, using the generated plug

Re: [PR] Move `Recycler` to `log4j-kit` (logging-log4j2)

2024-03-25 Thread via GitHub
ppkarwasz commented on PR #2400: URL: https://github.com/apache/logging-log4j2/pull/2400#issuecomment-2017657169 > > Since the only current user of `Recycler` is Log4j Core 3.x, we removed the static recycler registry and replaced it with an entry in `DefaultBundle`. > > This is not c

Re: [PR] Move `Recycler` to `log4j-kit` (logging-log4j2)

2024-03-25 Thread via GitHub
ppkarwasz commented on code in PR #2400: URL: https://github.com/apache/logging-log4j2/pull/2400#discussion_r1537344241 ## log4j-kit/src/main/java/org/apache/logging/log4j/kit/recycler/internal/ThreadLocalRecyclerFactoryProvider.java: ## Review Comment: This remark certainl

[I] Consider direct transfer of `MutableLogEvent` between threads 3.x (logging-log4j2)

2024-03-25 Thread via GitHub
ppkarwasz opened a new issue, #2401: URL: https://github.com/apache/logging-log4j2/issues/2401 Currently instances of `MutableLogEvent` are prevented from traveling between threads. In 2.x the reason was simple: the event was bound to a `ThreadLocal` and was cleared upon the return from the

Re: [PR] Move `Recycler` to `log4j-kit` (logging-log4j2)

2024-03-25 Thread via GitHub
vy commented on PR #2400: URL: https://github.com/apache/logging-log4j2/pull/2400#issuecomment-2017490303 > Since the only current user of `Recycler` is Log4j Core 3.x, we removed the static recycler registry and replaced it with an entry in `DefaultBundle`. This is not correct. There

Re: [PR] Move `Recycler` to `log4j-kit` (logging-log4j2)

2024-03-25 Thread via GitHub
vy commented on code in PR #2400: URL: https://github.com/apache/logging-log4j2/pull/2400#discussion_r1537183163 ## log4j-api/src/main/java/org/apache/logging/log4j/spi/MessageFactory2Adapter.java: ## @@ -0,0 +1,157 @@ +/* + * Licensed to the Apache Software Foundation (ASF) und

Re: [PR] Remove Log4j API 3.x (logging-log4j2)

2024-03-25 Thread via GitHub
ppkarwasz closed pull request #2325: Remove Log4j API 3.x URL: https://github.com/apache/logging-log4j2/pull/2325 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe

Re: [PR] Fix issue #2380: Log messages with insufficient parameters should not throw exception. (logging-log4j2)

2024-03-25 Thread via GitHub
ppkarwasz commented on PR #2393: URL: https://github.com/apache/logging-log4j2/pull/2393#issuecomment-2017413301 @SeasonPanPan Thank you for your contribution. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [I] Log messages with partially missing parameters (logging-log4j2)

2024-03-25 Thread via GitHub
ppkarwasz closed issue #2380: Log messages with partially missing parameters URL: https://github.com/apache/logging-log4j2/issues/2380 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

Re: [PR] Fix issue #2380: Log messages with insufficient parameters should not throw exception. (logging-log4j2)

2024-03-25 Thread via GitHub
ppkarwasz merged PR #2393: URL: https://github.com/apache/logging-log4j2/pull/2393 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubsc