Re: [PR] Part 4 of nullable and modernization (logging-log4net)

2024-03-22 Thread via GitHub
FreeAndNil merged PR #129: URL: https://github.com/apache/logging-log4net/pull/129 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubsc

Re: [I] Most links in the documentation are broken (logging-log4net)

2024-03-22 Thread via GitHub
FreeAndNil closed issue #130: Most links in the documentation are broken URL: https://github.com/apache/logging-log4net/issues/130 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

Re: [I] Most links in the documentation are broken (logging-log4net)

2024-03-22 Thread via GitHub
FreeAndNil commented on issue #130: URL: https://github.com/apache/logging-log4net/issues/130#issuecomment-2015887248 @marcel-landman thanks for reporting. I discovered the same yesterday 😉. A fix (https://github.com/apache/logging-log4net/pull/121/commits/61e28326da40646161fe5167905f

Re: [PR] Update version for 2.0.17 (logging-log4net)

2024-03-22 Thread via GitHub
FreeAndNil commented on PR #121: URL: https://github.com/apache/logging-log4net/pull/121#issuecomment-2015886339 Fixes #130 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[I] Most links in the documentation are broken (logging-log4net)

2024-03-22 Thread via GitHub
marcel-landman opened a new issue, #130: URL: https://github.com/apache/logging-log4net/issues/130 This is where we are told the documentation is: https://logging.apache.org/log4net/ All the top level links work, but as soon as you click through to a second level, the link is broke

Re: [I] NullRefException from shutdown in 2.0.16 (logging-log4net)

2024-03-22 Thread via GitHub
FreeAndNil commented on issue #118: URL: https://github.com/apache/logging-log4net/issues/118#issuecomment-2015577460 @andreycha definitely next week. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

Re: [I] NullRefException from shutdown in 2.0.16 (logging-log4net)

2024-03-22 Thread via GitHub
andreycha commented on issue #118: URL: https://github.com/apache/logging-log4net/issues/118#issuecomment-2015536188 Hi @FreeAndNil any ETA when 2.0.17 stable version is going to be released? I need some changed from 2.0.16 but don't want to upgrade without this hotfix. -- This is an aut

Re: [PR] Part 4 of nullable and modernization (logging-log4net)

2024-03-22 Thread via GitHub
erikmav commented on code in PR #129: URL: https://github.com/apache/logging-log4net/pull/129#discussion_r1535848543 ## src/log4net.Tests/DateFormatter/DateTimeDateFormatterTest.cs: ## @@ -0,0 +1,59 @@ +#region Apache License +// +// Licensed to the Apache Software Foundation (A

Re: [PR] Fix issue #2380: Log messages with insufficient parameters should not throw exception. (logging-log4j2)

2024-03-22 Thread via GitHub
SeasonPanPan commented on code in PR #2393: URL: https://github.com/apache/logging-log4j2/pull/2393#discussion_r1535761095 ## log4j-api/src/main/java/org/apache/logging/log4j/message/ParameterFormatter.java: ## @@ -240,12 +244,14 @@ static void formatMessage( return

Re: [PR] Backport some Log4j API 3.x features (logging-log4j2)

2024-03-22 Thread via GitHub
ppkarwasz commented on PR #2392: URL: https://github.com/apache/logging-log4j2/pull/2392#issuecomment-2015218299 @vy, I am merging this PR in order to be able to use `2.24.0-SNAPSHOT` versions in the PRs concerning the `main` branch. Please let me know if you find something els

Re: [PR] Backport some Log4j API 3.x features (logging-log4j2)

2024-03-22 Thread via GitHub
ppkarwasz merged PR #2392: URL: https://github.com/apache/logging-log4j2/pull/2392 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubsc

Re: [PR] Bump io.netty:netty-bom from 4.1.107.Final to 4.1.108.Final (logging-log4j2)

2024-03-22 Thread via GitHub
github-actions[bot] merged PR #2399: URL: https://github.com/apache/logging-log4j2/pull/2399 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

Re: [PR] Fix issue #2380: Log messages with insufficient parameters should not throw exception. (logging-log4j2)

2024-03-22 Thread via GitHub
ppkarwasz commented on code in PR #2393: URL: https://github.com/apache/logging-log4j2/pull/2393#discussion_r1535402688 ## log4j-api/src/main/java/org/apache/logging/log4j/message/ParameterFormatter.java: ## @@ -240,12 +244,14 @@ static void formatMessage( return;

Re: [PR] Backport some Log4j API 3.x features (logging-log4j2)

2024-03-22 Thread via GitHub
ppkarwasz commented on code in PR #2392: URL: https://github.com/apache/logging-log4j2/pull/2392#discussion_r1535393114 ## log4j-api-test/src/main/java/org/apache/logging/log4j/test/junit/Resources.java: ## @@ -20,11 +20,36 @@ /** * Constants to use the {@link ResourceLock}

Re: [PR] Bump dependabot/fetch-metadata from 1.6.0 to 2.0.0 [logging-parent]

2024-03-22 Thread via GitHub
github-actions[bot] merged PR #144: URL: https://github.com/apache/logging-parent/pull/144 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications

[PR] Bump dependabot/fetch-metadata from 1.6.0 to 2.0.0 [logging-parent]

2024-03-22 Thread via GitHub
dependabot[bot] opened a new pull request, #144: URL: https://github.com/apache/logging-parent/pull/144 Bumps [dependabot/fetch-metadata](https://github.com/dependabot/fetch-metadata) from 1.6.0 to 2.0.0. Release notes Sourced from https://github.com/dependabot/fetch-metadata/rele

[PR] Bump github/codeql-action from 3.24.8 to 3.24.9 [logging-parent]

2024-03-22 Thread via GitHub
dependabot[bot] opened a new pull request, #143: URL: https://github.com/apache/logging-parent/pull/143 Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.24.8 to 3.24.9. Commits https://github.com/github/codeql-action/commit/1b1aada464948af03b950897e5

Re: [PR] Backport some Log4j API 3.x features (logging-log4j2)

2024-03-22 Thread via GitHub
ppkarwasz commented on code in PR #2392: URL: https://github.com/apache/logging-log4j2/pull/2392#discussion_r1535369617 ## log4j-api/src/main/java/org/apache/logging/log4j/message/DefaultFlowMessageFactory.java: ## @@ -51,17 +52,22 @@ public DefaultFlowMessageFactory() { *

Re: [PR] Backport some Log4j API 3.x features (logging-log4j2)

2024-03-22 Thread via GitHub
ppkarwasz commented on code in PR #2392: URL: https://github.com/apache/logging-log4j2/pull/2392#discussion_r1535371587 ## log4j-api/src/main/java/org/apache/logging/log4j/util/Strings.java: ## @@ -288,6 +289,19 @@ public static String trimToNull(final String str) { ret

Re: [PR] Backport some Log4j API 3.x features (logging-log4j2)

2024-03-22 Thread via GitHub
ppkarwasz commented on code in PR #2392: URL: https://github.com/apache/logging-log4j2/pull/2392#discussion_r1535345909 ## log4j-api/src/main/java/org/apache/logging/log4j/util/OsgiServiceLocator.java: ## @@ -57,29 +58,53 @@ public static Stream loadServices(final Class servic

Re: [PR] Backport some Log4j API 3.x features (logging-log4j2)

2024-03-22 Thread via GitHub
ppkarwasz commented on code in PR #2392: URL: https://github.com/apache/logging-log4j2/pull/2392#discussion_r1535345909 ## log4j-api/src/main/java/org/apache/logging/log4j/util/OsgiServiceLocator.java: ## @@ -57,29 +58,53 @@ public static Stream loadServices(final Class servic

Re: [PR] Backport some Log4j API 3.x features (logging-log4j2)

2024-03-22 Thread via GitHub
ppkarwasz commented on code in PR #2392: URL: https://github.com/apache/logging-log4j2/pull/2392#discussion_r1535343429 ## log4j-api/pom.xml: ## @@ -36,6 +36,10 @@ true org.apache.logging.log4j + + + !sun.reflect + Review Comment: A `sun.re

Re: [PR] Fix issue #2380: Log messages with insufficient parameters should not throw exception. (logging-log4j2)

2024-03-22 Thread via GitHub
SeasonPanPan commented on code in PR #2393: URL: https://github.com/apache/logging-log4j2/pull/2393#discussion_r1535280162 ## log4j-api-test/src/test/java/org/apache/logging/log4j/message/ParameterizedMessageTest.java: ## @@ -185,16 +185,73 @@ void testSerializable(final Object

Re: [PR] Fix issue #2380: Log messages with insufficient parameters should not throw exception. (logging-log4j2)

2024-03-22 Thread via GitHub
SeasonPanPan commented on code in PR #2393: URL: https://github.com/apache/logging-log4j2/pull/2393#discussion_r1535279242 ## log4j-api/src/main/java/org/apache/logging/log4j/message/ParameterFormatter.java: ## @@ -240,12 +244,14 @@ static void formatMessage( return

Re: [PR] Fix issue #2380: Log messages with insufficient parameters should not throw exception. (logging-log4j2)

2024-03-22 Thread via GitHub
SeasonPanPan commented on code in PR #2393: URL: https://github.com/apache/logging-log4j2/pull/2393#discussion_r1535270832 ## log4j-api/src/main/java/org/apache/logging/log4j/message/ParameterFormatter.java: ## @@ -240,12 +244,14 @@ static void formatMessage( return

Re: [PR] Fix issue #2380: Log messages with insufficient parameters should not throw exception. (logging-log4j2)

2024-03-22 Thread via GitHub
ppkarwasz commented on code in PR #2393: URL: https://github.com/apache/logging-log4j2/pull/2393#discussion_r1535235106 ## log4j-api-test/src/test/java/org/apache/logging/log4j/message/ParameterizedMessageTest.java: ## @@ -185,16 +185,73 @@ void testSerializable(final Object arg