SeasonPanPan commented on PR #2393:
URL: https://github.com/apache/logging-log4j2/pull/2393#issuecomment-2014332510
@vy @ppkarwasz Done, and added some test cases with the following scenarios:
* 1. The placeholders are greater than the count of arguments.
* 2. Th
ppkarwasz merged PR #2374:
URL: https://github.com/apache/logging-log4j2/pull/2374
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubsc
ppkarwasz opened a new pull request, #2396:
URL: https://github.com/apache/logging-log4j2/pull/2396
This replaces `PropertiesUtil` with `PropertyEnvironment` in modules that
depend on Log4j Core.
It also ensures that every logger context has a different version of
`PropertyEnvironmen
FreeAndNil commented on code in PR #129:
URL: https://github.com/apache/logging-log4net/pull/129#discussion_r1534615314
##
src/log4net.Tests/DateFormatter/DateTimeDateFormatterTest.cs:
##
@@ -0,0 +1,59 @@
+#region Apache License
+//
+// Licensed to the Apache Software Foundation
dependabot[bot] opened a new pull request, #27:
URL: https://github.com/apache/logging-chainsaw/pull/27
Bumps org.apache.commons:commons-configuration2 from 2.9.0 to 2.10.1.
[
{
if (IsDebugEnabled)
{
-
erikmav commented on code in PR #129:
URL: https://github.com/apache/logging-log4net/pull/129#discussion_r1534403615
##
src/log4net/Appender/BufferingAppenderSkeleton.cs:
##
@@ -459,59 +411,59 @@ protected override void Append(LoggingEvent loggingEvent)
// sent immediatel
jvz commented on PR #2366:
URL: https://github.com/apache/logging-log4j2/pull/2366#issuecomment-2013112488
Sounds good to me!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
FreeAndNil commented on code in PR #129:
URL: https://github.com/apache/logging-log4net/pull/129#discussion_r1532722957
##
src/log4net/Appender/AppenderCollection.cs:
##
@@ -292,8 +234,11 @@ public virtual void Clear()
/// A new with a shallow copy of
the collection data.
SeasonPanPan commented on code in PR #2393:
URL: https://github.com/apache/logging-log4j2/pull/2393#discussion_r1533870019
##
log4j-api-test/src/test/java/org/apache/logging/log4j/message/ParameterFormatterTest.java:
##
@@ -68,15 +67,12 @@ void test_pattern_analysis(
}
vy commented on code in PR #2393:
URL: https://github.com/apache/logging-log4j2/pull/2393#discussion_r1533763183
##
log4j-api-test/src/test/java/org/apache/logging/log4j/message/ParameterFormatterTest.java:
##
@@ -68,15 +67,12 @@ void test_pattern_analysis(
}
}
-
vy commented on code in PR #2393:
URL: https://github.com/apache/logging-log4j2/pull/2393#discussion_r1533763183
##
log4j-api-test/src/test/java/org/apache/logging/log4j/message/ParameterFormatterTest.java:
##
@@ -68,15 +67,12 @@ void test_pattern_analysis(
}
}
-
ppkarwasz commented on code in PR #2393:
URL: https://github.com/apache/logging-log4j2/pull/2393#discussion_r1533621077
##
log4j-api-test/src/test/java/org/apache/logging/log4j/message/ParameterFormatterTest.java:
##
@@ -68,15 +67,12 @@ void test_pattern_analysis(
}
ppkarwasz commented on issue #2389:
URL:
https://github.com/apache/logging-log4j2/issues/2389#issuecomment-2011855640
> We have considered this scenario, but this scenario means that the user
must use a custom Layout! Essentially, adding LogEvent to an interface or
NoSqlObject to be passed
tonycody commented on issue #2389:
URL:
https://github.com/apache/logging-log4j2/issues/2389#issuecomment-2011722823
> > My scenario is to write the stack information resolved by the method
java.lang.Throwable#lockedPrintStackTrace to the NoSql data source. Therefore,
I need to get the Thr
ppkarwasz commented on issue #2389:
URL:
https://github.com/apache/logging-log4j2/issues/2389#issuecomment-2011689567
> My scenario is to write the stack information resolved by the method
java.lang.Throwable#lockedPrintStackTrace to the NoSql data source. Therefore,
I need to get the Thro
tonycody commented on issue #2389:
URL:
https://github.com/apache/logging-log4j2/issues/2389#issuecomment-2011629770
> @tonycody,
>
> I think we hit an [XY problem](https://en.wikipedia.org/wiki/XY_problem)
in this discussion. Could you explain plainly (without technical details) wha
ppkarwasz commented on issue #2389:
URL:
https://github.com/apache/logging-log4j2/issues/2389#issuecomment-2011610932
@tonycody,
I think we hit an [XY problem](https://en.wikipedia.org/wiki/XY_problem) in
this discussion. Could you explain plainly (without technical details) what are
19 matches
Mail list logo