Re: [PR] Fix issue #2380: Log messages with insufficient parameters should not throw exception. (logging-log4j2)

2024-03-21 Thread via GitHub
SeasonPanPan commented on PR #2393: URL: https://github.com/apache/logging-log4j2/pull/2393#issuecomment-2014332510 @vy @ppkarwasz Done, and added some test cases with the following scenarios: * 1. The placeholders are greater than the count of arguments. * 2. Th

Re: [PR] Centralize initialization in `Provider` class (logging-log4j2)

2024-03-21 Thread via GitHub
ppkarwasz merged PR #2374: URL: https://github.com/apache/logging-log4j2/pull/2374 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubsc

[PR] Replace `PropertiesUtil` with `PropertyEnvironment` (logging-log4j2)

2024-03-21 Thread via GitHub
ppkarwasz opened a new pull request, #2396: URL: https://github.com/apache/logging-log4j2/pull/2396 This replaces `PropertiesUtil` with `PropertyEnvironment` in modules that depend on Log4j Core. It also ensures that every logger context has a different version of `PropertyEnvironmen

Re: [PR] Part 4 of nullable and modernization (logging-log4net)

2024-03-21 Thread via GitHub
FreeAndNil commented on code in PR #129: URL: https://github.com/apache/logging-log4net/pull/129#discussion_r1534615314 ## src/log4net.Tests/DateFormatter/DateTimeDateFormatterTest.cs: ## @@ -0,0 +1,59 @@ +#region Apache License +// +// Licensed to the Apache Software Foundation

[PR] Bump org.apache.commons:commons-configuration2 from 2.9.0 to 2.10.1 [logging-chainsaw]

2024-03-21 Thread via GitHub
dependabot[bot] opened a new pull request, #27: URL: https://github.com/apache/logging-chainsaw/pull/27 Bumps org.apache.commons:commons-configuration2 from 2.9.0 to 2.10.1. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?depen

Re: [PR] Part 4 of nullable and modernization (logging-log4net)

2024-03-21 Thread via GitHub
erikmav commented on code in PR #129: URL: https://github.com/apache/logging-log4net/pull/129#discussion_r1534448073 ## src/log4net/DateFormatter/AbsoluteTimeDateFormatter.cs: ## @@ -95,78 +87,52 @@ protected virtual void FormatDateWithoutMillis(DateTime dateToFormat, StringBui

Re: [PR] Part 4 of nullable and modernization (logging-log4net)

2024-03-21 Thread via GitHub
erikmav commented on code in PR #129: URL: https://github.com/apache/logging-log4net/pull/129#discussion_r1534412278 ## src/log4net/Core/LogImpl.cs: ## @@ -247,7 +241,7 @@ public virtual void DebugFormat(string format, object arg0) { if (IsDebugEnabled) { -

Re: [PR] Part 4 of nullable and modernization (logging-log4net)

2024-03-21 Thread via GitHub
erikmav commented on code in PR #129: URL: https://github.com/apache/logging-log4net/pull/129#discussion_r1534403615 ## src/log4net/Appender/BufferingAppenderSkeleton.cs: ## @@ -459,59 +411,59 @@ protected override void Append(LoggingEvent loggingEvent) // sent immediatel

Re: [PR] Generalize DI usage (logging-log4j2)

2024-03-21 Thread via GitHub
jvz commented on PR #2366: URL: https://github.com/apache/logging-log4j2/pull/2366#issuecomment-2013112488 Sounds good to me! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] Part 4 of nullable and modernization (logging-log4net)

2024-03-21 Thread via GitHub
FreeAndNil commented on code in PR #129: URL: https://github.com/apache/logging-log4net/pull/129#discussion_r1532722957 ## src/log4net/Appender/AppenderCollection.cs: ## @@ -292,8 +234,11 @@ public virtual void Clear() /// A new with a shallow copy of the collection data.

Re: [PR] Fix issue #2380: Log messages with insufficient parameters should not throw exception. (logging-log4j2)

2024-03-21 Thread via GitHub
SeasonPanPan commented on code in PR #2393: URL: https://github.com/apache/logging-log4j2/pull/2393#discussion_r1533870019 ## log4j-api-test/src/test/java/org/apache/logging/log4j/message/ParameterFormatterTest.java: ## @@ -68,15 +67,12 @@ void test_pattern_analysis( }

Re: [PR] Fix issue #2380: Log messages with insufficient parameters should not throw exception. (logging-log4j2)

2024-03-21 Thread via GitHub
vy commented on code in PR #2393: URL: https://github.com/apache/logging-log4j2/pull/2393#discussion_r1533763183 ## log4j-api-test/src/test/java/org/apache/logging/log4j/message/ParameterFormatterTest.java: ## @@ -68,15 +67,12 @@ void test_pattern_analysis( } } -

Re: [PR] Fix issue #2380: Log messages with insufficient parameters should not throw exception. (logging-log4j2)

2024-03-21 Thread via GitHub
vy commented on code in PR #2393: URL: https://github.com/apache/logging-log4j2/pull/2393#discussion_r1533763183 ## log4j-api-test/src/test/java/org/apache/logging/log4j/message/ParameterFormatterTest.java: ## @@ -68,15 +67,12 @@ void test_pattern_analysis( } } -

Re: [PR] Fix issue #2380: Log messages with insufficient parameters should not throw exception. (logging-log4j2)

2024-03-21 Thread via GitHub
ppkarwasz commented on code in PR #2393: URL: https://github.com/apache/logging-log4j2/pull/2393#discussion_r1533621077 ## log4j-api-test/src/test/java/org/apache/logging/log4j/message/ParameterFormatterTest.java: ## @@ -68,15 +67,12 @@ void test_pattern_analysis( }

Re: [I] Pass `LogEvent` to `NoSqlConnection#insertObject` (logging-log4j2)

2024-03-21 Thread via GitHub
ppkarwasz commented on issue #2389: URL: https://github.com/apache/logging-log4j2/issues/2389#issuecomment-2011855640 > We have considered this scenario, but this scenario means that the user must use a custom Layout! Essentially, adding LogEvent to an interface or NoSqlObject to be passed

Re: [I] Pass `LogEvent` to `NoSqlConnection#insertObject` (logging-log4j2)

2024-03-21 Thread via GitHub
tonycody commented on issue #2389: URL: https://github.com/apache/logging-log4j2/issues/2389#issuecomment-2011722823 > > My scenario is to write the stack information resolved by the method java.lang.Throwable#lockedPrintStackTrace to the NoSql data source. Therefore, I need to get the Thr

Re: [I] Pass `LogEvent` to `NoSqlConnection#insertObject` (logging-log4j2)

2024-03-21 Thread via GitHub
ppkarwasz commented on issue #2389: URL: https://github.com/apache/logging-log4j2/issues/2389#issuecomment-2011689567 > My scenario is to write the stack information resolved by the method java.lang.Throwable#lockedPrintStackTrace to the NoSql data source. Therefore, I need to get the Thro

Re: [I] Pass `LogEvent` to `NoSqlConnection#insertObject` (logging-log4j2)

2024-03-21 Thread via GitHub
tonycody commented on issue #2389: URL: https://github.com/apache/logging-log4j2/issues/2389#issuecomment-2011629770 > @tonycody, > > I think we hit an [XY problem](https://en.wikipedia.org/wiki/XY_problem) in this discussion. Could you explain plainly (without technical details) wha

Re: [I] Pass `LogEvent` to `NoSqlConnection#insertObject` (logging-log4j2)

2024-03-21 Thread via GitHub
ppkarwasz commented on issue #2389: URL: https://github.com/apache/logging-log4j2/issues/2389#issuecomment-2011610932 @tonycody, I think we hit an [XY problem](https://en.wikipedia.org/wiki/XY_problem) in this discussion. Could you explain plainly (without technical details) what are