rgoers commented on code in PR #2385:
URL: https://github.com/apache/logging-log4j2/pull/2385#discussion_r1533312285
##
log4j-api/src/main/java/org/apache/logging/log4j/internal/ScopedContextAnchor.java:
##
@@ -0,0 +1,69 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
rgoers commented on code in PR #2385:
URL: https://github.com/apache/logging-log4j2/pull/2385#discussion_r1533312285
##
log4j-api/src/main/java/org/apache/logging/log4j/internal/ScopedContextAnchor.java:
##
@@ -0,0 +1,69 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
tonycody commented on issue #2389:
URL:
https://github.com/apache/logging-log4j2/issues/2389#issuecomment-2011325316
@vy I looked at the log4j redis Appender mentioned above, and it's actually
a different scenario. The implementation mentioned above is based on Appender,
which also uses Lo
rgoers commented on code in PR #2385:
URL: https://github.com/apache/logging-log4j2/pull/2385#discussion_r1533312285
##
log4j-api/src/main/java/org/apache/logging/log4j/internal/ScopedContextAnchor.java:
##
@@ -0,0 +1,69 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
rgoers commented on code in PR #2385:
URL: https://github.com/apache/logging-log4j2/pull/2385#discussion_r1533312285
##
log4j-api/src/main/java/org/apache/logging/log4j/internal/ScopedContextAnchor.java:
##
@@ -0,0 +1,69 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
rgoers commented on code in PR #2385:
URL: https://github.com/apache/logging-log4j2/pull/2385#discussion_r1533312285
##
log4j-api/src/main/java/org/apache/logging/log4j/internal/ScopedContextAnchor.java:
##
@@ -0,0 +1,69 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
rgoers commented on code in PR #2385:
URL: https://github.com/apache/logging-log4j2/pull/2385#discussion_r1533310760
##
log4j-api/src/main/java/org/apache/logging/log4j/ScopedContext.java:
##
@@ -0,0 +1,264 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
tonycody commented on issue #2389:
URL:
https://github.com/apache/logging-log4j2/issues/2389#issuecomment-2011270792
@vy
e.g.
```java
@Override
public void insertObject(LogEvent event, NoSqlObject> object) {
LogMetaData logMeta=
LogMapper.INSTANCE.mapping(build
tonycody commented on issue #2389:
URL:
https://github.com/apache/logging-log4j2/issues/2389#issuecomment-2011260228
> I am not keen on adding new methods based on speculative functionality.
Could you give a more concrete example demonstrating without a new
`insertObject(LogEvent,Entity)`,
erikmav commented on PR #129:
URL: https://github.com/apache/logging-log4net/pull/129#issuecomment-200492
For #124
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To u
erikmav opened a new pull request, #129:
URL: https://github.com/apache/logging-log4net/pull/129
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe
FreeAndNil merged PR #126:
URL: https://github.com/apache/logging-log4net/pull/126
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubsc
vy commented on code in PR #2393:
URL: https://github.com/apache/logging-log4j2/pull/2393#discussion_r1532298634
##
log4j-api/src/main/java/org/apache/logging/log4j/message/ParameterFormatter.java:
##
@@ -240,14 +240,6 @@ static void formatMessage(
return;
vy commented on issue #2389:
URL:
https://github.com/apache/logging-log4j2/issues/2389#issuecomment-2009826857
I am not keen on adding new methods based on speculative functionality.
Could you give a more concrete example demonstrating without a new
`insertObject(LogEvent,Entity)`, it is r
vy commented on code in PR #2392:
URL: https://github.com/apache/logging-log4j2/pull/2392#discussion_r1532245841
##
log4j-api/pom.xml:
##
@@ -36,6 +36,10 @@
true
org.apache.logging.log4j
+
+
+ !sun.reflect
+
Review Comment:
Has this problem
tonycody commented on issue #2389:
URL:
https://github.com/apache/logging-log4j2/issues/2389#issuecomment-2009772986
> > I'm implementing a NoSqlConnection where the received data is written to
Redis. I need the original thrown object so that I can use
java.lang.Throwable#printStackTrace(j
vy commented on issue #2389:
URL:
https://github.com/apache/logging-log4j2/issues/2389#issuecomment-2009763272
> I'm implementing a NoSqlConnection where the received data is written to
Redis. I need the original thrown object so that I can use
java.lang.Throwable#printStackTrace(java.io.P
SeasonPanPan commented on code in PR #2393:
URL: https://github.com/apache/logging-log4j2/pull/2393#discussion_r1532212085
##
log4j-api/src/main/java/org/apache/logging/log4j/message/ParameterFormatter.java:
##
@@ -240,14 +240,6 @@ static void formatMessage(
return;
tonycody commented on issue #2389:
URL:
https://github.com/apache/logging-log4j2/issues/2389#issuecomment-2009739402
> @tonycody, the request sounds legit to me. Would you mind providing a bit
more context, please?
>
> 1. Which Log4j version are you using?
> 2. Which appender are
ppkarwasz commented on PR #2366:
URL: https://github.com/apache/logging-log4j2/pull/2366#issuecomment-2009724271
@jvz,
I am closing this as "partially reviewed", but I am waiting patiently to
replace the 3 fully-fledged and configured `InstanceFactory`s with a nifty use
of scopes.
vy commented on code in PR #2391:
URL: https://github.com/apache/logging-log4j2/pull/2391#discussion_r1532199636
##
log4j-core-test/src/test/java/org/apache/logging/log4j/core/appender/nosql/NoSqlDatabaseManagerTest.java:
##
@@ -143,6 +143,7 @@ public void testWriteInternal01()
ppkarwasz merged PR #2366:
URL: https://github.com/apache/logging-log4j2/pull/2366
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubsc
vy commented on issue #2389:
URL:
https://github.com/apache/logging-log4j2/issues/2389#issuecomment-2009704798
@tonycody, the request sounds legit to me. Would you mind providing a bit
more context, please?
1. Which Log4j version are you using?
2. Which appender are you using? (If it
vy commented on code in PR #2385:
URL: https://github.com/apache/logging-log4j2/pull/2385#discussion_r1531758006
##
log4j-api/src/main/java/org/apache/logging/log4j/internal/ScopedContextAnchor.java:
##
@@ -0,0 +1,69 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) un
ppkarwasz commented on issue #2395:
URL:
https://github.com/apache/logging-log4j2/issues/2395#issuecomment-2009487454
@leaner1000,
Log4j 1.2 has reached end-of-life in 2015 (see
[announcement](https://news.apache.org/foundation/entry/apache_logging_services_project_announces)).
ppkarwasz closed issue #2395: The log file opening flag changed after the log
was rotated.
URL: https://github.com/apache/logging-log4j2/issues/2395
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
github-actions[bot] merged PR #2394:
URL: https://github.com/apache/logging-log4j2/pull/2394
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notificatio
leaner1000 opened a new issue, #2395:
URL: https://github.com/apache/logging-log4j2/issues/2395
## Description
The open flag of the log file changes after log dumping, because the
"append" parameter in the code is fixed to false instead of the actual
configuration value, which may ca
vy commented on issue #2383:
URL:
https://github.com/apache/logging-log4j2/issues/2383#issuecomment-2009086859
I would be in favor of creating a new `log4j-config-xml` module. A very big
part of our users use `log4j2.yaml` and `log4j2.properties`. When they migrate
to Log4j 3, they will di
vy opened a new issue, #109:
URL: https://github.com/apache/logging-log4j-tools/issues/109
`AsciiDocConverter` (used by `DescriptorGenerator`) cannot convert `{@link
Encoder Encoder}` Javadoc.
--
This is an automated message from the Apache Git Service.
To respond to the message
vy commented on issue #85:
URL:
https://github.com/apache/logging-log4j-tools/issues/85#issuecomment-2009064717
I am closing the issue due to lack of interest. Please feel free to re-open
it when you submit a PR.
--
This is an automated message from the Apache Git Service.
To respond to
vy closed issue #85: log4j-changelog is too chatty by default
URL: https://github.com/apache/logging-log4j-tools/issues/85
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To u
ppkarwasz closed issue #93: Evaluate `-jpms-multi-release` BND parameter
URL: https://github.com/apache/logging-parent/issues/93
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
33 matches
Mail list logo