Re: [PR] 2214 - Add support for ScopedContext (logging-log4j2)

2024-03-20 Thread via GitHub
rgoers commented on code in PR #2385: URL: https://github.com/apache/logging-log4j2/pull/2385#discussion_r1533312285 ## log4j-api/src/main/java/org/apache/logging/log4j/internal/ScopedContextAnchor.java: ## @@ -0,0 +1,69 @@ +/* + * Licensed to the Apache Software Foundation (ASF

Re: [PR] 2214 - Add support for ScopedContext (logging-log4j2)

2024-03-20 Thread via GitHub
rgoers commented on code in PR #2385: URL: https://github.com/apache/logging-log4j2/pull/2385#discussion_r1533312285 ## log4j-api/src/main/java/org/apache/logging/log4j/internal/ScopedContextAnchor.java: ## @@ -0,0 +1,69 @@ +/* + * Licensed to the Apache Software Foundation (ASF

Re: [I] Pass `LogEvent` to `NoSqlConnection#insertObject` (logging-log4j2)

2024-03-20 Thread via GitHub
tonycody commented on issue #2389: URL: https://github.com/apache/logging-log4j2/issues/2389#issuecomment-2011325316 @vy I looked at the log4j redis Appender mentioned above, and it's actually a different scenario. The implementation mentioned above is based on Appender, which also uses Lo

Re: [PR] 2214 - Add support for ScopedContext (logging-log4j2)

2024-03-20 Thread via GitHub
rgoers commented on code in PR #2385: URL: https://github.com/apache/logging-log4j2/pull/2385#discussion_r1533312285 ## log4j-api/src/main/java/org/apache/logging/log4j/internal/ScopedContextAnchor.java: ## @@ -0,0 +1,69 @@ +/* + * Licensed to the Apache Software Foundation (ASF

Re: [PR] 2214 - Add support for ScopedContext (logging-log4j2)

2024-03-20 Thread via GitHub
rgoers commented on code in PR #2385: URL: https://github.com/apache/logging-log4j2/pull/2385#discussion_r1533312285 ## log4j-api/src/main/java/org/apache/logging/log4j/internal/ScopedContextAnchor.java: ## @@ -0,0 +1,69 @@ +/* + * Licensed to the Apache Software Foundation (ASF

Re: [PR] 2214 - Add support for ScopedContext (logging-log4j2)

2024-03-20 Thread via GitHub
rgoers commented on code in PR #2385: URL: https://github.com/apache/logging-log4j2/pull/2385#discussion_r1533312285 ## log4j-api/src/main/java/org/apache/logging/log4j/internal/ScopedContextAnchor.java: ## @@ -0,0 +1,69 @@ +/* + * Licensed to the Apache Software Foundation (ASF

Re: [PR] 2214 - Add support for ScopedContext (logging-log4j2)

2024-03-20 Thread via GitHub
rgoers commented on code in PR #2385: URL: https://github.com/apache/logging-log4j2/pull/2385#discussion_r1533310760 ## log4j-api/src/main/java/org/apache/logging/log4j/ScopedContext.java: ## @@ -0,0 +1,264 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

Re: [I] Pass `LogEvent` to `NoSqlConnection#insertObject` (logging-log4j2)

2024-03-20 Thread via GitHub
tonycody commented on issue #2389: URL: https://github.com/apache/logging-log4j2/issues/2389#issuecomment-2011270792 @vy e.g. ```java @Override public void insertObject(LogEvent event, NoSqlObject> object) { LogMetaData logMeta= LogMapper.INSTANCE.mapping(build

Re: [I] Pass `LogEvent` to `NoSqlConnection#insertObject` (logging-log4j2)

2024-03-20 Thread via GitHub
tonycody commented on issue #2389: URL: https://github.com/apache/logging-log4j2/issues/2389#issuecomment-2011260228 > I am not keen on adding new methods based on speculative functionality. Could you give a more concrete example demonstrating without a new `insertObject(LogEvent,Entity)`,

Re: [PR] Part 4 of nullable and modernization (logging-log4net)

2024-03-20 Thread via GitHub
erikmav commented on PR #129: URL: https://github.com/apache/logging-log4net/pull/129#issuecomment-200492 For #124 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

[PR] Part 4 of nullable and modernization (logging-log4net)

2024-03-20 Thread via GitHub
erikmav opened a new pull request, #129: URL: https://github.com/apache/logging-log4net/pull/129 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe

Re: [PR] Nullability and modernization updates, part 3 (logging-log4net)

2024-03-20 Thread via GitHub
FreeAndNil merged PR #126: URL: https://github.com/apache/logging-log4net/pull/126 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubsc

Re: [PR] Fix issue #2380: Log messages with insufficient parameters should not throw exception. (logging-log4j2)

2024-03-20 Thread via GitHub
vy commented on code in PR #2393: URL: https://github.com/apache/logging-log4j2/pull/2393#discussion_r1532298634 ## log4j-api/src/main/java/org/apache/logging/log4j/message/ParameterFormatter.java: ## @@ -240,14 +240,6 @@ static void formatMessage( return;

Re: [I] Pass `LogEvent` to `NoSqlConnection#insertObject` (logging-log4j2)

2024-03-20 Thread via GitHub
vy commented on issue #2389: URL: https://github.com/apache/logging-log4j2/issues/2389#issuecomment-2009826857 I am not keen on adding new methods based on speculative functionality. Could you give a more concrete example demonstrating without a new `insertObject(LogEvent,Entity)`, it is r

Re: [PR] Backport some Log4j API 3.x features (logging-log4j2)

2024-03-20 Thread via GitHub
vy commented on code in PR #2392: URL: https://github.com/apache/logging-log4j2/pull/2392#discussion_r1532245841 ## log4j-api/pom.xml: ## @@ -36,6 +36,10 @@ true org.apache.logging.log4j + + + !sun.reflect + Review Comment: Has this problem

Re: [I] Pass `LogEvent` to `NoSqlConnection#insertObject` (logging-log4j2)

2024-03-20 Thread via GitHub
tonycody commented on issue #2389: URL: https://github.com/apache/logging-log4j2/issues/2389#issuecomment-2009772986 > > I'm implementing a NoSqlConnection where the received data is written to Redis. I need the original thrown object so that I can use java.lang.Throwable#printStackTrace(j

Re: [I] Pass `LogEvent` to `NoSqlConnection#insertObject` (logging-log4j2)

2024-03-20 Thread via GitHub
vy commented on issue #2389: URL: https://github.com/apache/logging-log4j2/issues/2389#issuecomment-2009763272 > I'm implementing a NoSqlConnection where the received data is written to Redis. I need the original thrown object so that I can use java.lang.Throwable#printStackTrace(java.io.P

Re: [PR] Fix issue #2380: Log messages with insufficient parameters should not throw exception. (logging-log4j2)

2024-03-20 Thread via GitHub
SeasonPanPan commented on code in PR #2393: URL: https://github.com/apache/logging-log4j2/pull/2393#discussion_r1532212085 ## log4j-api/src/main/java/org/apache/logging/log4j/message/ParameterFormatter.java: ## @@ -240,14 +240,6 @@ static void formatMessage( return;

Re: [I] Pass `LogEvent` to `NoSqlConnection#insertObject` (logging-log4j2)

2024-03-20 Thread via GitHub
tonycody commented on issue #2389: URL: https://github.com/apache/logging-log4j2/issues/2389#issuecomment-2009739402 > @tonycody, the request sounds legit to me. Would you mind providing a bit more context, please? > > 1. Which Log4j version are you using? > 2. Which appender are

Re: [PR] Generalize DI usage (logging-log4j2)

2024-03-20 Thread via GitHub
ppkarwasz commented on PR #2366: URL: https://github.com/apache/logging-log4j2/pull/2366#issuecomment-2009724271 @jvz, I am closing this as "partially reviewed", but I am waiting patiently to replace the 3 fully-fledged and configured `InstanceFactory`s with a nifty use of scopes.

Re: [PR] Adds new `NoSqlConnection#insertObject()` accepting `LogEvent` (logging-log4j2)

2024-03-20 Thread via GitHub
vy commented on code in PR #2391: URL: https://github.com/apache/logging-log4j2/pull/2391#discussion_r1532199636 ## log4j-core-test/src/test/java/org/apache/logging/log4j/core/appender/nosql/NoSqlDatabaseManagerTest.java: ## @@ -143,6 +143,7 @@ public void testWriteInternal01()

Re: [PR] Generalize DI usage (logging-log4j2)

2024-03-20 Thread via GitHub
ppkarwasz merged PR #2366: URL: https://github.com/apache/logging-log4j2/pull/2366 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubsc

Re: [I] Pass `LogEvent` to `NoSqlConnection#insertObject` (logging-log4j2)

2024-03-20 Thread via GitHub
vy commented on issue #2389: URL: https://github.com/apache/logging-log4j2/issues/2389#issuecomment-2009704798 @tonycody, the request sounds legit to me. Would you mind providing a bit more context, please? 1. Which Log4j version are you using? 2. Which appender are you using? (If it

Re: [PR] 2214 - Add support for ScopedContext (logging-log4j2)

2024-03-20 Thread via GitHub
vy commented on code in PR #2385: URL: https://github.com/apache/logging-log4j2/pull/2385#discussion_r1531758006 ## log4j-api/src/main/java/org/apache/logging/log4j/internal/ScopedContextAnchor.java: ## @@ -0,0 +1,69 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

Re: [I] The log file opening flag changed after the log was rotated. (logging-log4j2)

2024-03-20 Thread via GitHub
ppkarwasz commented on issue #2395: URL: https://github.com/apache/logging-log4j2/issues/2395#issuecomment-2009487454 @leaner1000, Log4j 1.2 has reached end-of-life in 2015 (see [announcement](https://news.apache.org/foundation/entry/apache_logging_services_project_announces)).

Re: [I] The log file opening flag changed after the log was rotated. (logging-log4j2)

2024-03-20 Thread via GitHub
ppkarwasz closed issue #2395: The log file opening flag changed after the log was rotated. URL: https://github.com/apache/logging-log4j2/issues/2395 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

Re: [PR] Bump org.graalvm.truffle:truffle-api from 23.1.2 to 24.0.0 (logging-log4j2)

2024-03-20 Thread via GitHub
github-actions[bot] merged PR #2394: URL: https://github.com/apache/logging-log4j2/pull/2394 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

[I] The log file opening flag changed after the log was rotated. (logging-log4j2)

2024-03-20 Thread via GitHub
leaner1000 opened a new issue, #2395: URL: https://github.com/apache/logging-log4j2/issues/2395 ## Description The open flag of the log file changes after log dumping, because the "append" parameter in the code is fixed to false instead of the actual configuration value, which may ca

Re: [I] Split off XML configuration into its own module or internal package (logging-log4j2)

2024-03-20 Thread via GitHub
vy commented on issue #2383: URL: https://github.com/apache/logging-log4j2/issues/2383#issuecomment-2009086859 I would be in favor of creating a new `log4j-config-xml` module. A very big part of our users use `log4j2.yaml` and `log4j2.properties`. When they migrate to Log4j 3, they will di

[I] `log4j-docgen` cannot parse `{@link Encoder Encoder<LogEvent>}` Javadoc [logging-log4j-tools]

2024-03-20 Thread via GitHub
vy opened a new issue, #109: URL: https://github.com/apache/logging-log4j-tools/issues/109 `AsciiDocConverter` (used by `DescriptorGenerator`) cannot convert `{@link Encoder Encoder}` Javadoc. -- This is an automated message from the Apache Git Service. To respond to the message

Re: [I] log4j-changelog is too chatty by default [logging-log4j-tools]

2024-03-20 Thread via GitHub
vy commented on issue #85: URL: https://github.com/apache/logging-log4j-tools/issues/85#issuecomment-2009064717 I am closing the issue due to lack of interest. Please feel free to re-open it when you submit a PR. -- This is an automated message from the Apache Git Service. To respond to

Re: [I] log4j-changelog is too chatty by default [logging-log4j-tools]

2024-03-20 Thread via GitHub
vy closed issue #85: log4j-changelog is too chatty by default URL: https://github.com/apache/logging-log4j-tools/issues/85 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

Re: [I] Evaluate `-jpms-multi-release` BND parameter [logging-parent]

2024-03-20 Thread via GitHub
ppkarwasz closed issue #93: Evaluate `-jpms-multi-release` BND parameter URL: https://github.com/apache/logging-parent/issues/93 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.