Re: [PR] 2214 - Add support for ScopedContext (logging-log4j2)

2024-03-19 Thread via GitHub
rgoers commented on PR #2385: URL: https://github.com/apache/logging-log4j2/pull/2385#issuecomment-2008087231 @garydgregory It is modeled after https://docs.oracle.com/en/java/javase/21/docs/api/java.base/java/lang/ScopedValue.html. Obviously it is not the same API but it is similar enough

Re: [PR] Enable building log4net with docker container #127 (logging-log4net)

2024-03-19 Thread via GitHub
FreeAndNil merged PR #128: URL: https://github.com/apache/logging-log4net/pull/128 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubsc

Re: [PR] Bump io.swagger:swagger-annotations from 1.6.13 to 1.6.14 [logging-log4j-audit]

2024-03-19 Thread via GitHub
github-actions[bot] merged PR #131: URL: https://github.com/apache/logging-log4j-audit/pull/131 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifica

[PR] Bump io.swagger:swagger-annotations from 1.6.13 to 1.6.14 [logging-log4j-audit]

2024-03-19 Thread via GitHub
dependabot[bot] opened a new pull request, #131: URL: https://github.com/apache/logging-log4j-audit/pull/131 Bumps io.swagger:swagger-annotations from 1.6.13 to 1.6.14. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency

Re: [PR] Fix issue #2380: Log messages with insufficient parameters should not throw exception. (logging-log4j2)

2024-03-19 Thread via GitHub
ppkarwasz commented on code in PR #2393: URL: https://github.com/apache/logging-log4j2/pull/2393#discussion_r1530679565 ## log4j-api/src/main/java/org/apache/logging/log4j/message/ParameterFormatter.java: ## @@ -240,14 +240,6 @@ static void formatMessage( return;

Re: [PR] Fix issue #2380: Log messages with insufficient parameters should not throw exception. (logging-log4j2)

2024-03-19 Thread via GitHub
ppkarwasz commented on code in PR #2393: URL: https://github.com/apache/logging-log4j2/pull/2393#discussion_r1530679565 ## log4j-api/src/main/java/org/apache/logging/log4j/message/ParameterFormatter.java: ## @@ -240,14 +240,6 @@ static void formatMessage( return;

[PR] Fix issue #2380: Log messages with insufficient parameters should not throw exception. (logging-log4j2)

2024-03-19 Thread via GitHub
SeasonPanPan opened a new pull request, #2393: URL: https://github.com/apache/logging-log4j2/pull/2393 Fix issue #2380: Log messages with insufficient parameters should not throw exception. In this PR, I modified the class `org.apache.logging.log4j.message.ParameterFormatter`. I d

Re: [PR] Backport some Log4j API 3.x features (logging-log4j2)

2024-03-19 Thread via GitHub
ppkarwasz commented on PR #2392: URL: https://github.com/apache/logging-log4j2/pull/2392#issuecomment-2007217633 As a curiosity, when working with GraalVM and either `log4j-to-jul` or `log4j-to-slf4j` (i.e. **without** Log4j Core) I get this nice warning from GraalVM: ``` Warning: The

[PR] Backport some Log4j API 3.x features (logging-log4j2)

2024-03-19 Thread via GitHub
ppkarwasz opened a new pull request, #2392: URL: https://github.com/apache/logging-log4j2/pull/2392 We move some features found in the `main` branch of `log4j-api` back to `2.x`: - It adds a `ServiceLoaderUtil#safeStream` method that takes an instance of `ServiceLoader` as a paramete

Re: [PR] Centralize initialization in `Provider` class (logging-log4j2)

2024-03-19 Thread via GitHub
ppkarwasz commented on code in PR #2374: URL: https://github.com/apache/logging-log4j2/pull/2374#discussion_r1530270173 ## log4j-api/src/main/java/org/apache/logging/log4j/util/ProviderUtil.java: ## @@ -163,6 +172,88 @@ static void lazyInit() { } } +/** +

Re: [PR] Centralize initialization in `Provider` class (logging-log4j2)

2024-03-19 Thread via GitHub
ppkarwasz commented on code in PR #2374: URL: https://github.com/apache/logging-log4j2/pull/2374#discussion_r1530267750 ## log4j-api/src/main/java/org/apache/logging/log4j/spi/Provider.java: ## @@ -97,127 +217,266 @@ public String getVersions() { /** * Gets the prio

Re: [PR] Centralize initialization in `Provider` class (logging-log4j2)

2024-03-19 Thread via GitHub
ppkarwasz commented on code in PR #2374: URL: https://github.com/apache/logging-log4j2/pull/2374#discussion_r1530265806 ## log4j-api/src/main/java/org/apache/logging/log4j/spi/Provider.java: ## @@ -20,39 +20,135 @@ import java.net.URL; import java.util.Properties; import org.

Re: [PR] Bump github/codeql-action from 3.24.6 to 3.24.8 (logging-log4j2)

2024-03-19 Thread via GitHub
github-actions[bot] merged PR #2390: URL: https://github.com/apache/logging-log4j2/pull/2390 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

Re: [PR] Enable building log4net with docker container #127 (logging-log4net)

2024-03-19 Thread via GitHub
FreeAndNil commented on code in PR #128: URL: https://github.com/apache/logging-log4net/pull/128#discussion_r1530152161 ## Dockerfile: ## @@ -0,0 +1,35 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE fil

Re: [PR] Enable building log4net with docker container #127 (logging-log4net)

2024-03-19 Thread via GitHub
FreeAndNil commented on code in PR #128: URL: https://github.com/apache/logging-log4net/pull/128#discussion_r1530151594 ## package.json: ## Review Comment: Good point. Changed. -- This is an automated message from the Apache Git Service. To respond to the message, pleas

Re: [PR] NoSqlConnection.insertObject supports passing the LogEvent interface. (logging-log4j2)

2024-03-19 Thread via GitHub
tonycody commented on PR #2391: URL: https://github.com/apache/logging-log4j2/pull/2391#issuecomment-2006852184 @garydgregory Done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] ✨ NoSqlConnection.insertObject supports passing the LogEvent interface. (logging-log4j2)

2024-03-19 Thread via GitHub
tonycody commented on PR #2391: URL: https://github.com/apache/logging-log4j2/pull/2391#issuecomment-2006810557 > Hello @tonycody This PR is missing unit tests. Okay, I'll fill it in later. -- This is an automated message from the Apache Git Service. To respond to the message, pleas

Re: [PR] ✨ NoSqlConnection.insertObject supports passing the LogEvent interface. (logging-log4j2)

2024-03-19 Thread via GitHub
garydgregory commented on PR #2391: URL: https://github.com/apache/logging-log4j2/pull/2391#issuecomment-2006805175 Hello @tonycody This PR is missing unit tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[PR] ✨ NoSqlConnection.insertObject supports passing the LogEvent interface. (logging-log4j2)

2024-03-19 Thread via GitHub
tonycody opened a new pull request, #2391: URL: https://github.com/apache/logging-log4j2/pull/2391 [A clear and concise description of what the pull request is for along with a reference to the associated issue IDs, if they exist.] ## Checklist * Base your changes on `2.x` bran

Re: [PR] Bump github/codeql-action from 3.24.7 to 3.24.8 [logging-parent]

2024-03-19 Thread via GitHub
github-actions[bot] merged PR #142: URL: https://github.com/apache/logging-parent/pull/142 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications

[PR] Bump github/codeql-action from 3.24.7 to 3.24.8 [logging-parent]

2024-03-19 Thread via GitHub
dependabot[bot] opened a new pull request, #142: URL: https://github.com/apache/logging-parent/pull/142 Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.24.7 to 3.24.8. Changelog Sourced from https://github.com/github/codeql-action/blob/main/CHANGELOG.md

Re: [PR] Enable building log4net with docker container #127 (logging-log4net)

2024-03-19 Thread via GitHub
vy commented on code in PR #128: URL: https://github.com/apache/logging-log4net/pull/128#discussion_r1530070505 ## package.json: ## Review Comment: Doesn't `repository.url` need to be updated in this file? ## Dockerfile: ## @@ -0,0 +1,35 @@ +# Licensed to

[PR] Add test coverage profile [logging-parent]

2024-03-19 Thread via GitHub
ppkarwasz opened a new pull request, #141: URL: https://github.com/apache/logging-parent/pull/141 We add a `coverage` Maven profile that can be used whenever we need test coverage data. **Remark**: Due to the somehow strange order of the `` children, I reordered it alphabetically.

[I] Add profile to generate a coverage report [logging-parent]

2024-03-19 Thread via GitHub
ppkarwasz opened a new issue, #140: URL: https://github.com/apache/logging-parent/issues/140 While we don't check test coverage very often, it is sometimes useful to generate a coverage report, when evaluating PRs. -- This is an automated message from the Apache Git Service. To respond to

[I] Enable concurrent releases in reusable workflows [logging-parent]

2024-03-19 Thread via GitHub
vy opened a new issue, #139: URL: https://github.com/apache/logging-parent/issues/139 Currently, reusable workflows upload the distribution to `` folder. This is problematic when a project wants to do multiple releases simultaneously, e.g., Log4j 2 and Log4j 3. Upload the distribution to `

Re: [I] [MS9] Schema and documentation generation from source code (logging-log4j2)

2024-03-19 Thread via GitHub
grobmeier commented on issue #1954: URL: https://github.com/apache/logging-log4j2/issues/1954#issuecomment-2006326517 Looks good to me, thanks for all the hard work! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [I] [MS9] Schema and documentation generation from source code (logging-log4j2)

2024-03-19 Thread via GitHub
grobmeier closed issue #1954: [MS9] Schema and documentation generation from source code URL: https://github.com/apache/logging-log4j2/issues/1954 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[I] NoSqlDatabaseManager createObject Extended Support (logging-log4j2)

2024-03-19 Thread via GitHub
tonycody opened a new issue, #2389: URL: https://github.com/apache/logging-log4j2/issues/2389 org.apache.logging.log4j.core.appender.nosql.NoSqlConnection#createObject This interface method, currently does not pass down the LogEvent from NoSqlDatabaseManager, and in practice, certain

Re: [PR] 2214 - Add support for ScopedContext (logging-log4j2)

2024-03-19 Thread via GitHub
garydgregory commented on PR #2385: URL: https://github.com/apache/logging-log4j2/pull/2385#issuecomment-2006051680 Hi all, The "where" API name is a terrible IMO. The Javadoc stays that the method "Adds ..." so why not call it that? The method delegates to an "add..." method. The pa