erikmav commented on PR #126:
URL: https://github.com/apache/logging-log4net/pull/126#issuecomment-2005755352
Could be done under another issue. The change is to change from class to
struct (or readonly struct, depending) for ReadOnlyPropertiesDictionary, then
derive PropertiesDictionary fr
FreeAndNil commented on PR #126:
URL: https://github.com/apache/logging-log4net/pull/126#issuecomment-2004768377
> Also note that to avoid a double-indirection it would be ideal to change
both to structs.
@erikmav can you explain how you would implement this? Maybe as separate
issue?
FreeAndNil commented on code in PR #126:
URL: https://github.com/apache/logging-log4net/pull/126#discussion_r1529138434
##
src/log4net/Core/LoggingEvent.cs:
##
@@ -826,11 +825,10 @@ private static string TryReadWindowsIdentityUserName()
{
try
{
-
rocketraman commented on issue #71:
URL:
https://github.com/apache/logging-log4j-kotlin/issues/71#issuecomment-2004683273
> I understand your example but I am not sure how it works in practice. I
have to presume that the Connection class can operate on multiple Connection
instances. A Logg
rgoers commented on issue #71:
URL:
https://github.com/apache/logging-log4j-kotlin/issues/71#issuecomment-2004657515
@rocketraman I understand your example but I am not sure how it works in
practice. I have to presume that the Connection class can operate on multiple
Connection instances.
rocketraman commented on issue #71:
URL:
https://github.com/apache/logging-log4j-kotlin/issues/71#issuecomment-2004452537
> OK. Personally, I see little value in adding context data to a logger.
That simply wouldn't fit with any use cases I work with. However, it might if
Logger names were
rgoers commented on issue #71:
URL:
https://github.com/apache/logging-log4j-kotlin/issues/71#issuecomment-2004436472
OK. Personally, I see little value in adding context data to a logger. That
simply wouldn't fit with any use cases I work with. However, it might if
Logger names were more
rocketraman commented on issue #71:
URL:
https://github.com/apache/logging-log4j-kotlin/issues/71#issuecomment-2004426105
> Again, I don't understand. ScopedContext IS a builder.
Its a builder for the context. I was talking about a builder for the logger.
The thread that @ppkarwasz s
FreeAndNil commented on code in PR #126:
URL: https://github.com/apache/logging-log4net/pull/126#discussion_r1528410182
##
src/log4net/Core/LoggingEvent.cs:
##
@@ -840,44 +800,41 @@ private string TryGetCurrentUserName()
}
}
-private string _cachedWindowsIdenti
jengebr commented on PR #2330:
URL: https://github.com/apache/logging-log4j2/pull/2330#issuecomment-2003953702
Thank you for your encouragement! I hope this helps other as much as it'll
help us.
--
This is an automated message from the Apache Git Service.
To respond to the message, pleas
fluffynuts commented on PR #128:
URL: https://github.com/apache/logging-log4net/pull/128#issuecomment-2003723969
lgtm, tho I'm no docker expert, so as long as it works, which I assume it
does (I'm nowhere near a PC rn), then I give it 👍👍
--
This is an automated message from the Apache Git
github-actions[bot] merged PR #2388:
URL: https://github.com/apache/logging-log4j2/pull/2388
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notificatio
FreeAndNil commented on PR #128:
URL: https://github.com/apache/logging-log4net/pull/128#issuecomment-2003614301
@vy I've updated the dockerfile, the scripts and
https://github.com/apache/logging-log4net/blob/Feature/127-docker-build/doc/BUILDING.md
Please take a look.
@fluffyn
github-actions[bot] merged PR #2386:
URL: https://github.com/apache/logging-log4j2/pull/2386
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notificatio
github-actions[bot] merged PR #2387:
URL: https://github.com/apache/logging-log4j2/pull/2387
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notificatio
FreeAndNil commented on code in PR #128:
URL: https://github.com/apache/logging-log4net/pull/128#discussion_r152831
##
Dockerfile:
##
@@ -0,0 +1,35 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE fil
ppkarwasz commented on code in PR #2385:
URL: https://github.com/apache/logging-log4j2/pull/2385#discussion_r1528224543
##
log4j-api/src/main/java/org/apache/logging/log4j/ScopedContext.java:
##
@@ -0,0 +1,224 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
ppkarwasz commented on PR #2385:
URL: https://github.com/apache/logging-log4j2/pull/2385#issuecomment-2003350474
I think we should discuss it in `dev@logging`. I started a [thread dedicated
to this
subject](https://lists.apache.org/thread/ossk8ckz4yy59z88l8hhbb3k87hbbk0r).
--
This is an
ppkarwasz commented on issue #71:
URL:
https://github.com/apache/logging-log4j-kotlin/issues/71#issuecomment-2003349991
I think we should discuss it in `dev@logging`. I started a [thread dedicated
to this
subject](https://lists.apache.org/thread/ossk8ckz4yy59z88l8hhbb3k87hbbk0r).
--
Thi
19 matches
Mail list logo
