Re: [PR] 2214 - Add support for ScopedContext (logging-log4j2)

2024-03-17 Thread via GitHub
rgoers commented on code in PR #2385: URL: https://github.com/apache/logging-log4j2/pull/2385#discussion_r1527909612 ## log4j-api/src/main/java/org/apache/logging/log4j/ScopedContext.java: ## @@ -0,0 +1,224 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

Re: [I] log4j-spring-boot gives error (logging-log4j2)

2024-03-17 Thread via GitHub
JyotiSathe closed issue #2384: log4j-spring-boot gives error URL: https://github.com/apache/logging-log4j2/issues/2384 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

Re: [I] log4j-spring-boot gives error (logging-log4j2)

2024-03-17 Thread via GitHub
JyotiSathe commented on issue #2384: URL: https://github.com/apache/logging-log4j2/issues/2384#issuecomment-2003015836 Yes after removing log4j-spring-boot and renaming log4j-spring.xml issue is resolved. Thanks for the help. -- This is an automated message from the Apache Git Service. T

Re: [PR] 2214 - Add support for ScopedContext (logging-log4j2)

2024-03-17 Thread via GitHub
rgoers commented on code in PR #2385: URL: https://github.com/apache/logging-log4j2/pull/2385#discussion_r1527643984 ## log4j-api/src/main/java/org/apache/logging/log4j/ScopedContext.java: ## @@ -0,0 +1,224 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

Re: [PR] 2214 - Add support for ScopedContext (logging-log4j2)

2024-03-17 Thread via GitHub
rgoers commented on code in PR #2385: URL: https://github.com/apache/logging-log4j2/pull/2385#discussion_r1527643984 ## log4j-api/src/main/java/org/apache/logging/log4j/ScopedContext.java: ## @@ -0,0 +1,224 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

Re: [PR] 2214 - Add support for ScopedContext (logging-log4j2)

2024-03-17 Thread via GitHub
ppkarwasz commented on code in PR #2385: URL: https://github.com/apache/logging-log4j2/pull/2385#discussion_r1527614991 ## log4j-api/src/main/java/org/apache/logging/log4j/ScopedContext.java: ## @@ -0,0 +1,224 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] 2214 - Add support for ScopedContext (logging-log4j2)

2024-03-17 Thread via GitHub
rgoers commented on code in PR #2385: URL: https://github.com/apache/logging-log4j2/pull/2385#discussion_r1527630234 ## log4j-api/src/main/java/org/apache/logging/log4j/ScopedContext.java: ## @@ -0,0 +1,224 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

Re: [PR] 2214 - Add support for ScopedContext (logging-log4j2)

2024-03-17 Thread via GitHub
rgoers commented on PR #2385: URL: https://github.com/apache/logging-log4j2/pull/2385#issuecomment-2002643187 @ppkarwasz For some reason I cannot reply to your original comment directly. > At a first glance, I would probably prefer to see a wrapper like this: > > public class Co

Re: [PR] 2214 - Add support for ScopedContext (logging-log4j2)

2024-03-17 Thread via GitHub
rgoers commented on code in PR #2385: URL: https://github.com/apache/logging-log4j2/pull/2385#discussion_r1527630234 ## log4j-api/src/main/java/org/apache/logging/log4j/ScopedContext.java: ## @@ -0,0 +1,224 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

Re: [PR] 2214 - Add support for ScopedContext (logging-log4j2)

2024-03-17 Thread via GitHub
rgoers commented on code in PR #2385: URL: https://github.com/apache/logging-log4j2/pull/2385#discussion_r1527626489 ## log4j-api/src/main/java/org/apache/logging/log4j/ScopedContext.java: ## @@ -0,0 +1,224 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

Re: [PR] 2214 - Add support for ScopedContext (logging-log4j2)

2024-03-17 Thread via GitHub
ppkarwasz commented on code in PR #2385: URL: https://github.com/apache/logging-log4j2/pull/2385#discussion_r1527614991 ## log4j-api/src/main/java/org/apache/logging/log4j/ScopedContext.java: ## @@ -0,0 +1,224 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Enable building log4net with docker container #127 (logging-log4net)

2024-03-17 Thread via GitHub
vy commented on code in PR #128: URL: https://github.com/apache/logging-log4net/pull/128#discussion_r1527612300 ## Dockerfile: ## @@ -0,0 +1,35 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# dis

Re: [I] Improve logging context integration [logging-log4j-kotlin]

2024-03-17 Thread via GitHub
rgoers commented on issue #71: URL: https://github.com/apache/logging-log4j-kotlin/issues/71#issuecomment-2002582832 @rocketraman Again, I don't understand. ScopedContext IS a builder. Each where method adds a new key/value pair to the context. The run and call methods are, in essence, the

Re: [I] Improve logging context integration [logging-log4j-kotlin]

2024-03-17 Thread via GitHub
rocketraman commented on issue #71: URL: https://github.com/apache/logging-log4j-kotlin/issues/71#issuecomment-2002565293 @rgoers Yes, in my original post I proposed a method `withContextMap` that would be used in Kotlin the same way as `ScopedContext` (though its a bit nicer in Kotlin).

Re: [I] Improve logging context integration [logging-log4j-kotlin]

2024-03-17 Thread via GitHub
rgoers commented on issue #71: URL: https://github.com/apache/logging-log4j-kotlin/issues/71#issuecomment-2002548717 @rocketraman I guess I am not grasping at all what you want. With my PR you can now do: ``` class T { private static final Logger log = LogManger.getLogger(T.

[PR] Enable building log4net with docker container #127 (logging-log4net)

2024-03-17 Thread via GitHub
FreeAndNil opened a new pull request, #128: URL: https://github.com/apache/logging-log4net/pull/128 Enable building log4net with docker container #127 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[I] Enable building log4net with docker container (logging-log4net)

2024-03-17 Thread via GitHub
FreeAndNil opened a new issue, #127: URL: https://github.com/apache/logging-log4net/issues/127 Provide the following convenience for PMC members to review the project: ``` git checkout docker build -t log4net-builder . docker run log4net-builder ``` That is, a convenience t

Re: [I] Log messages with partially missing parameters (logging-log4j2)

2024-03-17 Thread via GitHub
ppkarwasz commented on issue #2380: URL: https://github.com/apache/logging-log4j2/issues/2380#issuecomment-2002453940 Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [I] Improve logging context integration [logging-log4j-kotlin]

2024-03-17 Thread via GitHub
rocketraman commented on issue #71: URL: https://github.com/apache/logging-log4j-kotlin/issues/71#issuecomment-2002452904 @rgoers I think you missed the class-scoped (*not* thread-scoped) context in my example. @ppkarwasz Ah interesting -- if I could bind `Property` dynamically then

Re: [I] Log messages with partially missing parameters (logging-log4j2)

2024-03-17 Thread via GitHub
SeasonPanPan commented on issue #2380: URL: https://github.com/apache/logging-log4j2/issues/2380#issuecomment-2002451427 I will work on this issue #2380 . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [I] Add Logback's throwable-consuming semantics as an option (logging-log4j2)

2024-03-17 Thread via GitHub
ppkarwasz commented on issue #2363: URL: https://github.com/apache/logging-log4j2/issues/2363#issuecomment-2002444711 Not sure how this works on Github. Maybe you need to comment on the issue, for me to be able to assign it to you. -- This is an automated message from the Apache Git Serv

Re: [I] Add Logback's throwable-consuming semantics as an option (logging-log4j2)

2024-03-17 Thread via GitHub
SeasonPanPan commented on issue #2363: URL: https://github.com/apache/logging-log4j2/issues/2363#issuecomment-2002400761 > @SeasonPanPan, > > Thank you for your proposal. #2379 might be a little bit Log4j specific, but I can assign you #2380 if it interests you. @ppkarwasz OK,

Re: [I] Improve logging context integration [logging-log4j-kotlin]

2024-03-17 Thread via GitHub
ppkarwasz commented on issue #71: URL: https://github.com/apache/logging-log4j-kotlin/issues/71#issuecomment-2002375125 > If you look back at my example, logging in `R` is not (only) _thread-scoped_, it is both _thread-scoped_ AND _class-scoped_. In other words, I want all logging in `R` t