Re: [PR] Bump org.springframework:spring-framework-bom from 5.3.31 to 5.3.32 [logging-log4j-samples]

2024-03-14 Thread via GitHub
dependabot[bot] closed pull request #116: Bump org.springframework:spring-framework-bom from 5.3.31 to 5.3.32 URL: https://github.com/apache/logging-log4j-samples/pull/116 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

Re: [PR] Bump org.springframework:spring-framework-bom from 5.3.31 to 5.3.32 [logging-log4j-samples]

2024-03-14 Thread via GitHub
dependabot[bot] commented on PR #116: URL: https://github.com/apache/logging-log4j-samples/pull/116#issuecomment-1998707018 Superseded by #119. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[PR] Bump org.springframework:spring-framework-bom from 5.3.31 to 5.3.33 [logging-log4j-samples]

2024-03-14 Thread via GitHub
dependabot[bot] opened a new pull request, #119: URL: https://github.com/apache/logging-log4j-samples/pull/119 Bumps [org.springframework:spring-framework-bom](https://github.com/spring-projects/spring-framework) from 5.3.31 to 5.3.33. Release notes Sourced from https://github.com

Re: [PR] Bump org.springframework:spring-framework-bom from 6.1.4 to 6.1.5 [logging-log4j-jakarta]

2024-03-14 Thread via GitHub
github-actions[bot] merged PR #24: URL: https://github.com/apache/logging-log4j-jakarta/pull/24 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifica

Re: [PR] Make location computation and message formatting more lazy (logging-log4j2)

2024-03-14 Thread via GitHub
ppkarwasz merged PR #2329: URL: https://github.com/apache/logging-log4j2/pull/2329 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubsc

Re: [PR] Make location computation and message formatting more lazy (logging-log4j2)

2024-03-14 Thread via GitHub
ppkarwasz commented on PR #2329: URL: https://github.com/apache/logging-log4j2/pull/2329#issuecomment-1998305974 > 1. Since the `Message` is already populated with a `loggerFqcn` and that is enough to resolve the `location` in the `LogEvent`, we don't need to resolve the location in `Ab

Re: [PR] Centralize initialization in `Provider` class (logging-log4j2)

2024-03-14 Thread via GitHub
vy commented on code in PR #2374: URL: https://github.com/apache/logging-log4j2/pull/2374#discussion_r1525322283 ## log4j-api-test/src/test/java/org/apache/logging/log4j/spi/ThreadContextMapTest.java: ## @@ -0,0 +1,76 @@ +/* + * Licensed to the Apache Software Foundation (ASF) u

Re: [PR] Make location computation and message formatting more lazy (logging-log4j2)

2024-03-14 Thread via GitHub
ppkarwasz commented on code in PR #2329: URL: https://github.com/apache/logging-log4j2/pull/2329#discussion_r1525347314 ## log4j-core/src/main/java/org/apache/logging/log4j/core/impl/MementoLogEvent.java: ## @@ -72,50 +73,37 @@ public MementoLogEvent(final LogEvent event) {

Re: [PR] Make location computation and message formatting more lazy (logging-log4j2)

2024-03-14 Thread via GitHub
ppkarwasz commented on code in PR #2329: URL: https://github.com/apache/logging-log4j2/pull/2329#discussion_r1525347864 ## log4j-core/src/main/java/org/apache/logging/log4j/core/impl/MementoLogEvent.java: ## @@ -72,50 +73,37 @@ public MementoLogEvent(final LogEvent event) {

Re: [I] Improve logging context integration [logging-log4j-kotlin]

2024-03-14 Thread via GitHub
rocketraman commented on issue #71: URL: https://github.com/apache/logging-log4j-kotlin/issues/71#issuecomment-1998067762 I think the ideal solution for this would look something like this, and could leverage the solution we come up with for https://github.com/apache/logging-log4j-kotlin/i

Re: [I] Improve logging context integration [logging-log4j-kotlin]

2024-03-14 Thread via GitHub
rocketraman commented on issue #71: URL: https://github.com/apache/logging-log4j-kotlin/issues/71#issuecomment-1998055009 > Am I missing something? @vy Yes, I think so. Or I am :-) If you look back at my example, logging in `R` is not (only) *thread-scoped*, it is both *thread

Re: [PR] Make location computation and message formatting more lazy (logging-log4j2)

2024-03-14 Thread via GitHub
vy commented on code in PR #2329: URL: https://github.com/apache/logging-log4j2/pull/2329#discussion_r1525178892 ## log4j-1.2-api/src/main/java/org/apache/log4j/bridge/LogEventWrapper.java: ## @@ -109,12 +110,17 @@ public Instant getInstant() { } @Override -publi

[jira] [Comment Edited] (LOG4J2-3681) NoClassDefFoundError for org.xml.sax.SAXException after jlink app with log4j 3 beta2

2024-03-14 Thread Volkan Yazici (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17827037#comment-17827037 ] Volkan Yazici edited comment on LOG4J2-3681 at 3/14/24 5:46 PM: --

[jira] [Closed] (LOG4J2-3681) NoClassDefFoundError for org.xml.sax.SAXException after jlink app with log4j 3 beta2

2024-03-14 Thread Volkan Yazici (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3681?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Volkan Yazici closed LOG4J2-3681. - Assignee: Volkan Yazici Resolution: Not A Problem > NoClassDefFoundError for org.xml.sax.S

Re: [PR] Bump com.google.guava:guava from 33.0.0-jre to 33.1.0-jre [logging-log4j-audit]

2024-03-14 Thread via GitHub
github-actions[bot] merged PR #129: URL: https://github.com/apache/logging-log4j-audit/pull/129 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifica

[PR] Bump com.google.guava:guava from 33.0.0-jre to 33.1.0-jre [logging-log4j-audit]

2024-03-14 Thread via GitHub
dependabot[bot] opened a new pull request, #129: URL: https://github.com/apache/logging-log4j-audit/pull/129 Bumps [com.google.guava:guava](https://github.com/google/guava) from 33.0.0-jre to 33.1.0-jre. Release notes Sourced from https://github.com/google/guava/releases";>com.goog

[I] Remove deprecated code for 3.0 (logging-log4net)

2024-03-14 Thread via GitHub
erikmav opened a new issue, #125: URL: https://github.com/apache/logging-log4net/issues/125 There are numerous parts of the code that are marked with [Deprecated] attributes. Additionally there is code that may or may not any longer be in use, such as NDC (src/log4net/NDC.cs). Ideally with

Re: [I] Improve logging context integration [logging-log4j-kotlin]

2024-03-14 Thread via GitHub
vy commented on issue #71: URL: https://github.com/apache/logging-log4j-kotlin/issues/71#issuecomment-1997814563 @rocketraman, AFAIC, the problem is the lack of a dynamically scoped variable (you might be familiar with this concept if you have ever used a Lisp dialect), and hence, we use t

Re: [I] Improve logging context integration [logging-log4j-kotlin]

2024-03-14 Thread via GitHub
rocketraman commented on issue #71: URL: https://github.com/apache/logging-log4j-kotlin/issues/71#issuecomment-1997613964 > I think this is related to [[apache/logging-log4j2#2213](https://github.com/apache/logging-log4j2/issues/2213)]. @vy It seems so, but I'm unsatisfied by the an

Re: [PR] Bump org.springframework:spring-framework-bom from 5.3.32 to 5.3.33 [logging-log4j-audit-sample]

2024-03-14 Thread via GitHub
github-actions[bot] merged PR #43: URL: https://github.com/apache/logging-log4j-audit-sample/pull/43 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: not

Re: [I] Add Logback's throwable-consuming semantics as an option (logging-log4j2)

2024-03-14 Thread via GitHub
ppkarwasz commented on issue #2363: URL: https://github.com/apache/logging-log4j2/issues/2363#issuecomment-1997240044 @SeasonPanPan, As Volkan mentioned, solving your migration issues require 3 ingredients that we will try to incorporate into `2.24.0`: - [ ] #2381 - [ ] #2

Re: [PR] Bump guava.version from 33.0.0-jre to 33.1.0-jre (logging-log4j2)

2024-03-14 Thread via GitHub
github-actions[bot] merged PR #2377: URL: https://github.com/apache/logging-log4j2/pull/2377 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

[PR] Bump org.springframework:spring-framework-bom from 5.3.32 to 5.3.33 [logging-log4j-audit-sample]

2024-03-14 Thread via GitHub
dependabot[bot] opened a new pull request, #43: URL: https://github.com/apache/logging-log4j-audit-sample/pull/43 Bumps [org.springframework:spring-framework-bom](https://github.com/spring-projects/spring-framework) from 5.3.32 to 5.3.33. Release notes Sourced from https://github.

[PR] Add Logback's throwable-consuming semantics as an option (logging-log4j2)

2024-03-14 Thread via GitHub
ppkarwasz opened a new pull request, #2381: URL: https://github.com/apache/logging-log4j2/pull/2381 The semantics used to determine the `Throwable` attached to a log event changed in Logback 1.1.0 (in the fix to [LOGBACK-873](https://jira.qos.ch/browse/LOGBACK-873)). When there are n

Re: [PR] Bump spring-framework.version from 5.3.32 to 5.3.33 (logging-log4j2)

2024-03-14 Thread via GitHub
github-actions[bot] merged PR #2378: URL: https://github.com/apache/logging-log4j2/pull/2378 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

Re: [PR] Bump guava.version from 33.0.0-jre to 33.1.0-jre (logging-log4j2)

2024-03-14 Thread via GitHub
github-actions[bot] closed pull request #2375: Bump guava.version from 33.0.0-jre to 33.1.0-jre URL: https://github.com/apache/logging-log4j2/pull/2375 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

Re: [PR] Bump org.apache.groovy:groovy-bom from 4.0.19 to 4.0.20 (logging-log4j2)

2024-03-14 Thread via GitHub
github-actions[bot] merged PR #2376: URL: https://github.com/apache/logging-log4j2/pull/2376 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

[I] Log messages with partially missing parameters (logging-log4j2)

2024-03-14 Thread via GitHub
ppkarwasz opened a new issue, #2380: URL: https://github.com/apache/logging-log4j2/issues/2380 Log4j version `2.20.0` did also log messages with missing parameters. A call like: ```java logger.info("{}, {} and {}", 1, 2); ``` resulted in a partially replaced message: `1,

Re: [PR] Bump com.palantir.javaformat:palantir-java-format from 2.40.0 to 2.41.0 [logging-parent]

2024-03-14 Thread via GitHub
github-actions[bot] merged PR #136: URL: https://github.com/apache/logging-parent/pull/136 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications

[PR] Bump com.palantir.javaformat:palantir-java-format from 2.40.0 to 2.41.0 [logging-parent]

2024-03-14 Thread via GitHub
dependabot[bot] opened a new pull request, #136: URL: https://github.com/apache/logging-parent/pull/136 Bumps [com.palantir.javaformat:palantir-java-format](https://github.com/palantir/palantir-java-format) from 2.40.0 to 2.41.0. Release notes Sourced from https://github.com/palan

Re: [PR] Bump actions/setup-java from 4.1.0 to 4.2.0 [logging-parent]

2024-03-14 Thread via GitHub
github-actions[bot] merged PR #135: URL: https://github.com/apache/logging-parent/pull/135 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications

[PR] Bump actions/setup-java from 4.1.0 to 4.2.0 [logging-parent]

2024-03-14 Thread via GitHub
dependabot[bot] opened a new pull request, #135: URL: https://github.com/apache/logging-parent/pull/135 Bumps [actions/setup-java](https://github.com/actions/setup-java) from 4.1.0 to 4.2.0. Release notes Sourced from https://github.com/actions/setup-java/releases";>actions/setup-j

[jira] [Commented] (LOG4J2-3681) NoClassDefFoundError for org.xml.sax.SAXException after jlink app with log4j 3 beta2

2024-03-14 Thread Volkan Yazici (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17827037#comment-17827037 ] Volkan Yazici commented on LOG4J2-3681: --- [~singingbush], thanks for the report! As

Re: [I] [BUG] Exception stack works ok with logback , but a lot of the exception stack is gone with log4j2. (logging-log4j2)

2024-03-14 Thread via GitHub
vy commented on issue #2363: URL: https://github.com/apache/logging-log4j2/issues/2363#issuecomment-1997032784 @SeasonPanPan, thanks so much for the report. This issue is more convoluted than it meets the eye: 1. `formatTo()` behaviour of `ParameterizedMessage` and `ReusableParamete

Re: [I] Improve logging context integration [logging-log4j-kotlin]

2024-03-14 Thread via GitHub
vy commented on issue #71: URL: https://github.com/apache/logging-log4j-kotlin/issues/71#issuecomment-1997010610 I think this is related to [apache/logging-log4j2#2213]. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use