Re: [I] [BUG] Exception stack works ok with logback , but a lot of the exception stack is gone with log4j2. (logging-log4j2)

2024-03-13 Thread via GitHub
rgoers commented on issue #2363: URL: https://github.com/apache/logging-log4j2/issues/2363#issuecomment-1996359179 @ppkarwasz @vy I agree that the below is not ideal or what I would recommend but the exception does need to log it as a parameter. Changing this behavior now under the cov

[I] Improve logging context integration [logging-log4j-kotlin]

2024-03-13 Thread via GitHub
rocketraman opened a new issue, #71: URL: https://github.com/apache/logging-log4j-kotlin/issues/71 Using log4j2 context kind of sucks. The assumption that context will always be set at the Thread or coroutine level is IMO false, and sometimes we just want to set context for a particular blo

Re: [PR] Nullable and modernization part 2 (logging-log4net)

2024-03-13 Thread via GitHub
FreeAndNil commented on PR #123: URL: https://github.com/apache/logging-log4net/pull/123#issuecomment-1995977044 @erikmav @fluffynuts I've created issue #124 for those improvements. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

Re: [PR] Nullable and modernization part 2 (logging-log4net)

2024-03-13 Thread via GitHub
FreeAndNil commented on PR #123: URL: https://github.com/apache/logging-log4net/pull/123#issuecomment-1995964665 @erikmav Thank you very much (especially for adding the tests). After adding the one missing test (RemoveAppender(IAppender) we are ready to merge. -- This is an automated m

Re: [PR] Nullable and modernization part 2 (logging-log4net)

2024-03-13 Thread via GitHub
FreeAndNil commented on code in PR #123: URL: https://github.com/apache/logging-log4net/pull/123#discussion_r1523959729 ## src/log4net/Repository/Hierarchy/Logger.cs: ## @@ -329,12 +306,12 @@ public virtual void RemoveAllAppenders() /// on the appender removed. ///

Re: [PR] Nullable and modernization part 2 (logging-log4net)

2024-03-13 Thread via GitHub
erikmav commented on code in PR #123: URL: https://github.com/apache/logging-log4net/pull/123#discussion_r1523826184 ## src/log4net/Repository/Hierarchy/Logger.cs: ## @@ -329,12 +306,12 @@ public virtual void RemoveAllAppenders() /// on the appender removed. ///

Re: [I] [MS10] Log4j API generalization #1 (logging-log4j2)

2024-03-13 Thread via GitHub
grobmeier commented on issue #2273: URL: https://github.com/apache/logging-log4j2/issues/2273#issuecomment-1994980963 Confirmed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

Re: [I] [MS10] Log4j API generalization #1 (logging-log4j2)

2024-03-13 Thread via GitHub
grobmeier closed issue #2273: [MS10] Log4j API generalization #1 URL: https://github.com/apache/logging-log4j2/issues/2273 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] Bump org.aspectj:aspectjweaver from 1.9.21.1 to 1.9.21.2 [logging-log4j-audit]

2024-03-13 Thread via GitHub
github-actions[bot] merged PR #128: URL: https://github.com/apache/logging-log4j-audit/pull/128 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifica

[PR] Bump org.aspectj:aspectjweaver from 1.9.21.1 to 1.9.21.2 [logging-log4j-audit]

2024-03-13 Thread via GitHub
dependabot[bot] opened a new pull request, #128: URL: https://github.com/apache/logging-log4j-audit/pull/128 Bumps [org.aspectj:aspectjweaver](https://github.com/eclipse/org.aspectj) from 1.9.21.1 to 1.9.21.2. Release notes Sourced from https://github.com/eclipse/org.aspectj/releas

[jira] [Assigned] (LOG4J2-2931) Configuring CompositeFilter via properties will generate error due to invalid arguments

2024-03-13 Thread Piotr Karwasz (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-2931?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Karwasz reassigned LOG4J2-2931: - Assignee: Piotr Karwasz > Configuring CompositeFilter via properties will generate erro

[PR] Centralize initialization in `Provider` class (logging-log4j2)

2024-03-13 Thread via GitHub
ppkarwasz opened a new pull request, #2374: URL: https://github.com/apache/logging-log4j2/pull/2374 We move the code responsible for the instantiation of `LoggerContextFactory` and `ThreadContextMap` from the static entry points to the logging system (`LogManager` and `ThreadContext`) to th

Re: [I] [BUG] Exception stack works ok with logback , but a lot of the exception stack is gone with log4j2. (logging-log4j2)

2024-03-13 Thread via GitHub
SeasonPanPan commented on issue #2363: URL: https://github.com/apache/logging-log4j2/issues/2363#issuecomment-1994533100 @ppkarwasz I really appreciate your professional and rigorous way of coding. I'm inclined to the last method you mentioned about keep the **status logger** error message

[I] Initialization deadlock on JaveEE server startup (logging-log4j2)

2024-03-13 Thread via GitHub
FelixStuebner opened a new issue, #2373: URL: https://github.com/apache/logging-log4j2/issues/2373 ## Description In our project we are using OpenLiberty as application server with JavaEE 7 feature enabled and discovered a dead lock together with log4j. Our aim is to log every

Re: [PR] Bump actions/checkout from 4.1.1 to 4.1.2 (logging-log4j2)

2024-03-13 Thread via GitHub
github-actions[bot] merged PR #2370: URL: https://github.com/apache/logging-log4j2/pull/2370 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

[jira] [Created] (LOG4J2-3681) NoClassDefFoundError for org.xml.sax.SAXException after jlink app with log4j 3 beta2

2024-03-13 Thread Samael Bate (Jira)
Samael Bate created LOG4J2-3681: --- Summary: NoClassDefFoundError for org.xml.sax.SAXException after jlink app with log4j 3 beta2 Key: LOG4J2-3681 URL: https://issues.apache.org/jira/browse/LOG4J2-3681 Pr

Re: [PR] Bump com.fasterxml.jackson:jackson-bom from 2.16.2 to 2.17.0 (logging-log4j2)

2024-03-13 Thread via GitHub
github-actions[bot] merged PR #2371: URL: https://github.com/apache/logging-log4j2/pull/2371 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

Re: [PR] Bump com.fasterxml.jackson:jackson-bom from 2.16.2 to 2.17.0 (logging-log4j2)

2024-03-13 Thread via GitHub
github-actions[bot] merged PR #2372: URL: https://github.com/apache/logging-log4j2/pull/2372 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

[PR] Bump com.fasterxml.jackson:jackson-bom from 2.16.2 to 2.17.0 [logging-log4j-audit-sample]

2024-03-13 Thread via GitHub
dependabot[bot] opened a new pull request, #42: URL: https://github.com/apache/logging-log4j-audit-sample/pull/42 Bumps [com.fasterxml.jackson:jackson-bom](https://github.com/FasterXML/jackson-bom) from 2.16.2 to 2.17.0. Commits https://github.com/FasterXML/jackson-bom/commit/

Re: [PR] Bump com.google.errorprone:error_prone_core from 2.26.0 to 2.26.1 [logging-parent]

2024-03-13 Thread via GitHub
github-actions[bot] merged PR #134: URL: https://github.com/apache/logging-parent/pull/134 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications

[PR] Bump com.google.errorprone:error_prone_core from 2.26.0 to 2.26.1 [logging-parent]

2024-03-13 Thread via GitHub
dependabot[bot] opened a new pull request, #134: URL: https://github.com/apache/logging-parent/pull/134 Bumps [com.google.errorprone:error_prone_core](https://github.com/google/error-prone) from 2.26.0 to 2.26.1. Release notes Sourced from https://github.com/google/error-prone/rel

[jira] [Commented] (LOG4J2-2931) Configuring CompositeFilter via properties will generate error due to invalid arguments

2024-03-13 Thread Jira
[ https://issues.apache.org/jira/browse/LOG4J2-2931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17825999#comment-17825999 ] Jörg Delker commented on LOG4J2-2931: - After 3,5 years passed, I would like to give

Re: [PR] Bump github/codeql-action from 3.24.6 to 3.24.7 [logging-parent]

2024-03-13 Thread via GitHub
github-actions[bot] closed pull request #133: Bump github/codeql-action from 3.24.6 to 3.24.7 URL: https://github.com/apache/logging-parent/pull/133 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

Re: [PR] Bump actions/checkout from 4.1.1 to 4.1.2 [logging-parent]

2024-03-13 Thread via GitHub
github-actions[bot] merged PR #132: URL: https://github.com/apache/logging-parent/pull/132 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications

[PR] Bump github/codeql-action from 3.24.6 to 3.24.7 [logging-parent]

2024-03-13 Thread via GitHub
dependabot[bot] opened a new pull request, #133: URL: https://github.com/apache/logging-parent/pull/133 Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.24.6 to 3.24.7. Changelog Sourced from https://github.com/github/codeql-action/blob/main/CHANGELOG.md

[PR] Bump actions/checkout from 4.1.1 to 4.1.2 [logging-parent]

2024-03-13 Thread via GitHub
dependabot[bot] opened a new pull request, #132: URL: https://github.com/apache/logging-parent/pull/132 Bumps [actions/checkout](https://github.com/actions/checkout) from 4.1.1 to 4.1.2. Release notes Sourced from https://github.com/actions/checkout/releases";>actions/checkout's r

Re: [PR] Enable nullable for FileAppender, RollingFileAppender, and unit tests (logging-log4net)

2024-03-13 Thread via GitHub
FreeAndNil commented on PR #122: URL: https://github.com/apache/logging-log4net/pull/122#issuecomment-1993988753 > @FreeAndNil I was expanding nullable and strongly typed data structures in the code yesterday. Would it make sense for me to send it along incrementally with new PRs against th

Re: [PR] Nullable and modernization part 2 (logging-log4net)

2024-03-13 Thread via GitHub
FreeAndNil commented on code in PR #123: URL: https://github.com/apache/logging-log4net/pull/123#discussion_r1522718935 ## src/log4net/Repository/Hierarchy/Logger.cs: ## @@ -329,12 +306,12 @@ public virtual void RemoveAllAppenders() /// on the appender removed. ///

Re: [I] [BUG] Exception stack works ok with logback , but a lot of the exception stack is gone with log4j2. (logging-log4j2)

2024-03-13 Thread via GitHub
ppkarwasz commented on issue #2363: URL: https://github.com/apache/logging-log4j2/issues/2363#issuecomment-1993767405 @SeasonPanPan, Today there is an increasing amount of tools to check or reformat logging code: - Palantir's [`LoggerInterpolationConsumesThrowable`](https://