Re: [I] [MS8] Branch `main` overhaul #3 (logging-log4j2)

2024-02-06 Thread via GitHub
grobmeier closed issue #2163: [MS8] Branch `main` overhaul #3 URL: https://github.com/apache/logging-log4j2/issues/2163 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

Re: [I] [MS8] Branch `main` overhaul #3 (logging-log4j2)

2024-02-06 Thread via GitHub
grobmeier commented on issue #2163: URL: https://github.com/apache/logging-log4j2/issues/2163#issuecomment-1930805385 Checked and considered complete. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[PR] Repair or remove ineffective tests (logging-log4j2)

2024-02-06 Thread via GitHub
vy opened a new pull request, #2266: URL: https://github.com/apache/logging-log4j2/pull/2266 This PR tries to repair, and if cannot, removes ineffective tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

Re: [PR] Bump org.slf4j:slf4j-api from 2.0.11 to 2.0.12 [logging-log4j-transform]

2024-02-06 Thread via GitHub
github-actions[bot] closed pull request #84: Bump org.slf4j:slf4j-api from 2.0.11 to 2.0.12 URL: https://github.com/apache/logging-log4j-transform/pull/84 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[PR] Bump org.slf4j:slf4j-api from 2.0.11 to 2.0.12 [logging-log4j-transform]

2024-02-06 Thread via GitHub
dependabot[bot] opened a new pull request, #84: URL: https://github.com/apache/logging-log4j-transform/pull/84 Bumps org.slf4j:slf4j-api from 2.0.11 to 2.0.12. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=org

Re: [I] Avoid a slow exception catch in JdkMapAdapterStringMap constructor (logging-log4j2)

2024-02-06 Thread via GitHub
jdgenerix commented on issue #2238: URL: https://github.com/apache/logging-log4j2/issues/2238#issuecomment-1930297586 @ppkarwasz Thank you. I did a test and it looks fine to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

Re: [PR] Bump org.json:json from 20231013 to 20240205 [logging-log4j-audit]

2024-02-06 Thread via GitHub
github-actions[bot] merged PR #119: URL: https://github.com/apache/logging-log4j-audit/pull/119 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifica

[PR] Bump org.json:json from 20231013 to 20240205 [logging-log4j-audit]

2024-02-06 Thread via GitHub
dependabot[bot] opened a new pull request, #119: URL: https://github.com/apache/logging-log4j-audit/pull/119 Bumps [org.json:json](https://github.com/douglascrockford/JSON-java) from 20231013 to 20240205. Release notes Sourced from https://github.com/douglascrockford/JSON-java/rele

Re: [PR] Add Javadoc to Asciidoc converter [logging-log4j-tools]

2024-02-06 Thread via GitHub
ppkarwasz commented on code in PR #101: URL: https://github.com/apache/logging-log4j-tools/pull/101#discussion_r1479626919 ## log4j-docgen/src/test/resources/expected/processor/JavadocExample.adoc: ## @@ -0,0 +1,105 @@ + +Licensed to the Apache Software Foundation (ASF) und

Re: [PR] Add Javadoc to Asciidoc converter [logging-log4j-tools]

2024-02-06 Thread via GitHub
ppkarwasz commented on code in PR #101: URL: https://github.com/apache/logging-log4j-tools/pull/101#discussion_r1479624420 ## log4j-docgen/src/main/java/org/apache/logging/log4j/docgen/processor/internal/DocumentImpl.java: ## @@ -0,0 +1,123 @@ +/* + * Licensed to the Apache Sof

Re: [PR] Add Javadoc to Asciidoc converter [logging-log4j-tools]

2024-02-06 Thread via GitHub
ppkarwasz commented on code in PR #101: URL: https://github.com/apache/logging-log4j-tools/pull/101#discussion_r1479618784 ## log4j-docgen/src/main/java/org/apache/logging/log4j/docgen/processor/AsciidocData.java: ## Review Comment: I guess it is a matter of style, they ar

Re: [PR] Add Javadoc to Asciidoc converter [logging-log4j-tools]

2024-02-06 Thread via GitHub
ppkarwasz commented on code in PR #101: URL: https://github.com/apache/logging-log4j-tools/pull/101#discussion_r1479602109 ## log4j-docgen/pom.xml: ## @@ -27,6 +27,7 @@ log4j-docgen +17 Review Comment: The `log4j-plugins` artifact is a **required** dependency (

Re: [I] [MS9] Schema and documentation generation from source code (logging-log4j2)

2024-02-06 Thread via GitHub
ppkarwasz commented on issue #1954: URL: https://github.com/apache/logging-log4j2/issues/1954#issuecomment-1929293548 1. Absolutely. It is easier to output a different Asciidoc document per plugin, but it will probably look better as a single page or a couple of pages. 2. This is due to

Re: [I] [MS9] Schema and documentation generation from source code (logging-log4j2)

2024-02-06 Thread via GitHub
vy commented on issue #1954: URL: https://github.com/apache/logging-log4j2/issues/1954#issuecomment-1929270262 Great work Piotr! :100: :clap: Some remarks: 1. I see many pages are hardly filled. Shall we collapse the entire reference to a single page? WDYT? That is, one page per [Mave

Re: [I] [MS9] Schema and documentation generation from source code (logging-log4j2)

2024-02-06 Thread via GitHub
ppkarwasz commented on issue #1954: URL: https://github.com/apache/logging-log4j2/issues/1954#issuecomment-1929209213 The descriptions are taken from Javadoc comments, which shows us how many Javadoc comments are missing. Also the links in the _descriptions_ (which are taken from `{@

Re: [PR] Bump actions/upload-artifact from 4.3.0 to 4.3.1 [logging-parent]

2024-02-06 Thread via GitHub
github-actions[bot] merged PR #114: URL: https://github.com/apache/logging-parent/pull/114 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications

Re: [I] [MS9] Schema and documentation generation from source code (logging-log4j2)

2024-02-06 Thread via GitHub
ppkarwasz commented on issue #1954: URL: https://github.com/apache/logging-log4j2/issues/1954#issuecomment-1929200674 I have published a preview of a documentation generated from real data. Interesting pages: * [Configuration](https://logging.staged.apache.org/log4j/3.x/ref/Core/org

[PR] Bump actions/upload-artifact from 4.3.0 to 4.3.1 [logging-parent]

2024-02-06 Thread via GitHub
dependabot[bot] opened a new pull request, #114: URL: https://github.com/apache/logging-parent/pull/114 Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 4.3.0 to 4.3.1. Release notes Sourced from https://github.com/actions/upload-artifact/releases";>

Re: [PR] Add Javadoc to Asciidoc converter [logging-log4j-tools]

2024-02-06 Thread via GitHub
vy commented on code in PR #101: URL: https://github.com/apache/logging-log4j-tools/pull/101#discussion_r1478880319 ## log4j-docgen/pom.xml: ## @@ -27,6 +27,7 @@ log4j-docgen +17 Review Comment: Why is this necessary? ## log4j-docgen/src/main/java/or