Re: [PR] Integrate proguard rules for api lib (logging-log4j2)

2024-01-11 Thread via GitHub
Goooler commented on PR #2182: URL: https://github.com/apache/logging-log4j2/pull/2182#issuecomment-1888345401 > I really don’t want to be in the position where we start adding customizations for every tool a user might be using. Approve your points, I'll update the doc. -- This i

Re: [PR] Make the FallbackErrorHandler more usable in unit tests [logging-log4cxx]

2024-01-11 Thread via GitHub
swebb2066 merged PR #331: URL: https://github.com/apache/logging-log4cxx/pull/331 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr

Re: [PR] Fix 1799 and Spring 33450 (logging-log4j2)

2024-01-11 Thread via GitHub
rgoers commented on code in PR #2062: URL: https://github.com/apache/logging-log4j2/pull/2062#discussion_r1449326348 ## log4j-core/src/main/java/org/apache/logging/log4j/core/impl/internal/InternalLoggerContext.java: ## @@ -0,0 +1,290 @@ +/* + * Licensed to the Apache Software F

Re: [PR] Fix 1799 and Spring 33450 (logging-log4j2)

2024-01-11 Thread via GitHub
rgoers commented on code in PR #2062: URL: https://github.com/apache/logging-log4j2/pull/2062#discussion_r1449323508 ## log4j-core/src/main/java/org/apache/logging/log4j/core/impl/Log4jContextFactory.java: ## @@ -146,8 +149,12 @@ public LoggerContext getContext( if (ext

Re: [PR] Fix 1799 and Spring 33450 (logging-log4j2)

2024-01-11 Thread via GitHub
rgoers commented on code in PR #2062: URL: https://github.com/apache/logging-log4j2/pull/2062#discussion_r1449306179 ## log4j-core/src/main/java/org/apache/logging/log4j/core/config/ConfigurationFactory.java: ## @@ -118,6 +121,15 @@ protected boolean isActive() { return

Re: [PR] Fix 1799 and Spring 33450 (logging-log4j2)

2024-01-11 Thread via GitHub
rgoers commented on code in PR #2062: URL: https://github.com/apache/logging-log4j2/pull/2062#discussion_r1449305327 ## log4j-api/src/main/java/org/apache/logging/log4j/util/PropertiesUtil.java: ## @@ -746,6 +758,22 @@ public String getStringProperty(final String key) {

Re: [PR] Integrate proguard rules for api lib (logging-log4j2)

2024-01-11 Thread via GitHub
vy commented on PR #2182: URL: https://github.com/apache/logging-log4j2/pull/2182#issuecomment-1887763417 @Goooler, thanks so much for the contribution. Since this implies a change to the `log4j-api`, [I have shared this with other maintainers in the mailing list](https://lists.apache.org/t

Re: [PR] Optimize the parameter passing and lambda creation. (logging-log4j2)

2024-01-11 Thread via GitHub
vy merged PR #2183: URL: https://github.com/apache/logging-log4j2/pull/2183 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@lo

Re: [PR] Optimize the parameter passing and lambda creation. (logging-log4j2)

2024-01-11 Thread via GitHub
vy commented on PR #2183: URL: https://github.com/apache/logging-log4j2/pull/2183#issuecomment-1887652188 @RocMarshal, thanks! :bow: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[PR] Bump org.apache.maven.plugin-tools:maven-plugin-annotations from 3.10.2 to 3.11.0 [logging-log4j-audit]

2024-01-11 Thread via GitHub
dependabot[bot] opened a new pull request, #113: URL: https://github.com/apache/logging-log4j-audit/pull/113 Bumps [org.apache.maven.plugin-tools:maven-plugin-annotations](https://github.com/apache/maven-plugin-tools) from 3.10.2 to 3.11.0. Release notes Sourced from https://githu

[PR] Bump org.apache.maven.plugin-tools:maven-plugin-tools-api from 3.10.2 to 3.11.0 [logging-log4j-audit]

2024-01-11 Thread via GitHub
dependabot[bot] opened a new pull request, #112: URL: https://github.com/apache/logging-log4j-audit/pull/112 Bumps [org.apache.maven.plugin-tools:maven-plugin-tools-api](https://github.com/apache/maven-plugin-tools) from 3.10.2 to 3.11.0. Release notes Sourced from https://github.

[PR] Optimize the condition switch and lambda creation. (logging-log4j2)

2024-01-11 Thread via GitHub
RocMarshal opened a new pull request, #2183: URL: https://github.com/apache/logging-log4j2/pull/2183 [A clear and concise description of what the pull request is for along with a reference to the associated issue IDs, if they exist.] ## Checklist * Base your changes on `2.x` br

Re: [I] Log4j incompatible with recent kubernetes-client (logging-log4j2)

2024-01-11 Thread via GitHub
ppkarwasz commented on issue #2151: URL: https://github.com/apache/logging-log4j2/issues/2151#issuecomment-1887084583 @Amya28, If you don't use the `KubernetesLookup` (i.e. you don't have `${k8s:...}` placeholders in your config file), you can remove the `log4j-kubernetes` dependenc

Re: [I] Log4j incompatible with recent kubernetes-client (logging-log4j2)

2024-01-11 Thread via GitHub
Amya28 commented on issue #2151: URL: https://github.com/apache/logging-log4j2/issues/2151#issuecomment-1887037647 @ppkarwasz @vy There's no KubernetesLookup. In our case, we are working with spring boot and through Spring cloud the kubernetes version is set to latest 6.9.2 by fra

[PR] Integrate proguard rules for api lib (logging-log4j2)

2024-01-11 Thread via GitHub
Goooler opened a new pull request, #2182: URL: https://github.com/apache/logging-log4j2/pull/2182 I'm using a lib depends on Log4j with ProGuard enabled, throwing some errors like: ``` Exception in thread "main" java.lang.ExceptionInInitializerError at org.apache.logging.log4j.L

Re: [I] [3.0.0-beta1] reflect.TargetInvocationReflection when run from uber jar (logging-log4j2)

2024-01-11 Thread via GitHub
ppkarwasz closed issue #2179: [3.0.0-beta1] reflect.TargetInvocationReflection when run from uber jar URL: https://github.com/apache/logging-log4j2/issues/2179 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [I] [3.0.0-beta1] reflect.TargetInvocationReflection when run from uber jar (logging-log4j2)

2024-01-11 Thread via GitHub
riwarek commented on issue #2179: URL: https://github.com/apache/logging-log4j2/issues/2179#issuecomment-1886950022 FACEPALM Damn - you are right! How could I miss it?! This solves the issue with 3.0.0. Now I can runn app with success. Anyway we can state that for jar-in-jar fro

Re: [PR] Bump co.elastic.clients:elasticsearch-java from 8.11.3 to 8.11.4 (logging-log4j2)

2024-01-11 Thread via GitHub
github-actions[bot] closed pull request #2180: Bump co.elastic.clients:elasticsearch-java from 8.11.3 to 8.11.4 URL: https://github.com/apache/logging-log4j2/pull/2180 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

Re: [PR] Bump co.elastic.clients:elasticsearch-java from 8.11.3 to 8.11.4 (logging-log4j2)

2024-01-11 Thread via GitHub
github-actions[bot] commented on PR #2180: URL: https://github.com/apache/logging-log4j2/pull/2180#issuecomment-1886912833 Changes are applied by CI in e82746cd3b9b7bfebbcc1a81354a471712437e74 -- This is an automated message from the Apache Git Service. To respond to the message, please lo

Re: [I] [3.0.0-beta1] reflect.TargetInvocationReflection when run from uber jar (logging-log4j2)

2024-01-11 Thread via GitHub
ppkarwasz commented on issue #2179: URL: https://github.com/apache/logging-log4j2/issues/2179#issuecomment-1886911419 @riwarek, You have a typo in your script: ```xml ``` should be: ```xml ``` -- This is an automated message from the Apache Git Se

Re: [I] [3.0.0-beta1] reflect.TargetInvocationReflection when run from uber jar (logging-log4j2)

2024-01-11 Thread via GitHub
riwarek commented on issue #2179: URL: https://github.com/apache/logging-log4j2/issues/2179#issuecomment-1886802848 This is my jar-in-jar-loader.zip [jar-in-jar-loader.zip](https://github.com/apache/logging-log4j2/files/13901788/jar-in-jar-loader.zip) -- This is an automated messa

Re: [I] [3.0.0-beta1] reflect.TargetInvocationReflection when run from uber jar (logging-log4j2)

2024-01-11 Thread via GitHub
riwarek commented on issue #2179: URL: https://github.com/apache/logging-log4j2/issues/2179#issuecomment-1886789121 Just for clarification, earlier I used this pattern with uberjar and I had proper results. It worked with configuration log4j-api-2.2 and oracle jdk1.8 -- This is an aut

Re: [I] [3.0.0-beta1] reflect.TargetInvocationReflection when run from uber jar (logging-log4j2)

2024-01-11 Thread via GitHub
riwarek commented on issue #2179: URL: https://github.com/apache/logging-log4j2/issues/2179#issuecomment-1886782621 @ppkarwasz No this is ok. This is part of my ant script: `

Re: [I] Clean up Apache RAT configuration [logging-parent]

2024-01-11 Thread via GitHub
ppkarwasz closed issue #92: Clean up Apache RAT configuration URL: https://github.com/apache/logging-parent/issues/92 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

Re: [PR] Clean up residual `module-info.class` before compilation [logging-parent]

2024-01-11 Thread via GitHub
ppkarwasz merged PR #97: URL: https://github.com/apache/logging-parent/pull/97 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...

Re: [I] Ban wildcard imports [logging-parent]

2024-01-11 Thread via GitHub
ppkarwasz closed issue #63: Ban wildcard imports URL: https://github.com/apache/logging-parent/issues/63 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Add `jspecify` to dependency management [logging-parent]

2024-01-11 Thread via GitHub
ppkarwasz merged PR #95: URL: https://github.com/apache/logging-parent/pull/95 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...

Re: [PR] Ban wildcard imports [logging-parent]

2024-01-11 Thread via GitHub
ppkarwasz merged PR #94: URL: https://github.com/apache/logging-parent/pull/94 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...

Re: [I] Evaluate `-jpms-multi-release` BND parameter [logging-parent]

2024-01-11 Thread via GitHub
ppkarwasz closed issue #93: Evaluate `-jpms-multi-release` BND parameter URL: https://github.com/apache/logging-parent/issues/93 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [I] Add JSpecify annotations to defaults [logging-parent]

2024-01-11 Thread via GitHub
ppkarwasz closed issue #88: Add JSpecify annotations to defaults URL: https://github.com/apache/logging-parent/issues/88 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] Disable `-jpms-multi-release` BND option [logging-parent]

2024-01-11 Thread via GitHub
ppkarwasz merged PR #96: URL: https://github.com/apache/logging-parent/pull/96 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...

Re: [I] [3.0.0-beta1] reflect.TargetInvocationReflection when run from uber jar (logging-log4j2)

2024-01-11 Thread via GitHub
ppkarwasz commented on issue #2179: URL: https://github.com/apache/logging-log4j2/issues/2179#issuecomment-1886706915 @riwarek, I can not reproduce the issue. I created a `2179_log4j_3.x` in [copernik-eu/bug-reproducibility/eclipse-jar-in-jar](https://github.com/copernik-eu/bug-repro

Re: [I] Clean up Apache RAT configuration [logging-parent]

2024-01-11 Thread via GitHub
vy commented on issue #92: URL: https://github.com/apache/logging-parent/issues/92#issuecomment-1886694083 @ppkarwasz, instead of waiting for the next `org.apache:apache` release, we can 1. override the `org.apache.rat:apache-rat-plugin` version ourselves 1. create an issue to remo

Re: [PR] Disable `-jpms-multi-release` BND option [logging-parent]

2024-01-11 Thread via GitHub
vy commented on code in PR #96: URL: https://github.com/apache/logging-parent/pull/96#discussion_r1448531180 ## pom.xml: ## @@ -970,9 +970,6 @@ import org.apache.commons.codec.digest.*; # Allow each project to override the `Multi-Release` header: Multi-

Re: [I] Evaluate `-jpms-multi-release` BND parameter [logging-parent]

2024-01-11 Thread via GitHub
ppkarwasz commented on issue #93: URL: https://github.com/apache/logging-parent/issues/93#issuecomment-1886627757 Yes, `log4j-api-java9` and `log4j-core-java9` are the only modules affected by this setting. If we remove the setting `META-INF/versions/9/module-info.class` and `META-IN

Re: [PR] Fix 1799 and Spring 33450 (logging-log4j2)

2024-01-11 Thread via GitHub
ppkarwasz commented on code in PR #2062: URL: https://github.com/apache/logging-log4j2/pull/2062#discussion_r1448453168 ## log4j-core/src/main/java/org/apache/logging/log4j/core/config/ConfigurationFactory.java: ## @@ -118,6 +121,15 @@ protected boolean isActive() { ret