Re: [I] %d{UNIX_MILLIS} is printing 0 as timestamp in log file (logging-log4j2)

2024-01-05 Thread via GitHub
vy commented on issue #2167: URL: https://github.com/apache/logging-log4j2/issues/2167#issuecomment-1879352574 @AnushaGHerale, thanks so much for the report. We would really appreciate it if you can share a very very minimal example that we can use to reproduce the issue ourselves. That is

Re: [I] %d{UNIX_MILLIS} is printing 0 as timestamp in log file (logging-log4j2)

2024-01-05 Thread via GitHub
jvz commented on issue #2167: URL: https://github.com/apache/logging-log4j2/issues/2167#issuecomment-1879182380 Looking at your log file, I see that some debug logs do indeed have the unix milliseconds timestamp, but others don't, and that seems odd. The use of `%F` is also a little concer

Re: [PR] Remove Jackson dependency from `MutableThreadContextMapFilter` (logging-log4j2)

2024-01-05 Thread via GitHub
ppkarwasz closed pull request #2155: Remove Jackson dependency from `MutableThreadContextMapFilter` URL: https://github.com/apache/logging-log4j2/pull/2155 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] Remove Jackson dependency from `MutableThreadContextMapFilter` (logging-log4j2)

2024-01-05 Thread via GitHub
ppkarwasz commented on PR #2155: URL: https://github.com/apache/logging-log4j2/pull/2155#issuecomment-1879081638 Inadvertedly I merged it, when merging the YAML config: 8803ecbd1d5d556c0e94cb2cdef561c5e7ea4606 Feel free to revert the commit if you disagree with the change. -- This

Re: [PR] Split off YAML configuration into its own module (logging-log4j2)

2024-01-05 Thread via GitHub
ppkarwasz commented on PR #2142: URL: https://github.com/apache/logging-log4j2/pull/2142#issuecomment-1879019342 This has actually been successfully merged. I just deleted the branch too soon. -- This is an automated message from the Apache Git Service. To respond to the message, please l

Re: [PR] Split off YAML configuration into its own module (logging-log4j2)

2024-01-05 Thread via GitHub
ppkarwasz closed pull request #2142: Split off YAML configuration into its own module URL: https://github.com/apache/logging-log4j2/pull/2142 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [PR] Split off YAML configuration into its own module (logging-log4j2)

2024-01-05 Thread via GitHub
ppkarwasz commented on code in PR #2142: URL: https://github.com/apache/logging-log4j2/pull/2142#discussion_r1443147645 ## log4j-config-yaml/pom.xml: ## @@ -0,0 +1,71 @@ + + +http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; xsi:schemaL

Re: [PR] Clean up `log4j-spring-cloud-config-client` dependencies (logging-log4j2)

2024-01-05 Thread via GitHub
ppkarwasz commented on PR #2166: URL: https://github.com/apache/logging-log4j2/pull/2166#issuecomment-1878844886 @vy, I moved the Spring dependencies back to `log4j-parent`, because I managed to remove [`spring-boot-dependencies`](https://mvnrepository.com/artifact/org.springframewor

Re: [PR] Clean up `log4j-spring-cloud-config-client` dependencies (logging-log4j2)

2024-01-05 Thread via GitHub
ppkarwasz commented on code in PR #2166: URL: https://github.com/apache/logging-log4j2/pull/2166#discussion_r1443002673 ## log4j-spring-cloud-config-client/pom.xml: ## @@ -120,33 +86,21 @@ - org.junit.vintage - junit-vintage-engine + org.apache.loggi

Re: [PR] Port `log4j-jul` changes from `2.x` (logging-log4j2)

2024-01-05 Thread via GitHub
ppkarwasz merged PR #2160: URL: https://github.com/apache/logging-log4j2/pull/2160 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubsc

Re: [PR] Port `log4j-slf4j-impl` changes from `2.x` (logging-log4j2)

2024-01-05 Thread via GitHub
ppkarwasz merged PR #2156: URL: https://github.com/apache/logging-log4j2/pull/2156 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubsc

Re: [PR] Port `log4j-to-jul` changes from `2.x` (logging-log4j2)

2024-01-05 Thread via GitHub
ppkarwasz merged PR #2150: URL: https://github.com/apache/logging-log4j2/pull/2150 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubsc

Re: [PR] Port `log4j-script` changes from `2.x` (logging-log4j2)

2024-01-05 Thread via GitHub
ppkarwasz merged PR #2159: URL: https://github.com/apache/logging-log4j2/pull/2159 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubsc

Re: [PR] Port `log4j-slf4j2-impl` changes from `2.x` (logging-log4j2)

2024-01-05 Thread via GitHub
ppkarwasz merged PR #2158: URL: https://github.com/apache/logging-log4j2/pull/2158 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubsc

Re: [PR] Port `log4j-mongodb4` changes from `2.x` (logging-log4j2)

2024-01-05 Thread via GitHub
ppkarwasz merged PR #2164: URL: https://github.com/apache/logging-log4j2/pull/2164 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubsc

Re: [I] Log4j incompatible with recent kubernetes-client (logging-log4j2)

2024-01-05 Thread via GitHub
vy commented on issue #2151: URL: https://github.com/apache/logging-log4j2/issues/2151#issuecomment-1878804058 @ppkarwasz, yes, I have seen fabric8io/kubernetes-client#5682 discussion. Thanks for reporting the issue to the upstream. I agree that if `kubernetes-client` wants to adopt `log4j

Re: [I] Log4j incompatible with recent kubernetes-client (logging-log4j2)

2024-01-05 Thread via GitHub
ppkarwasz commented on issue #2151: URL: https://github.com/apache/logging-log4j2/issues/2151#issuecomment-1878791937 @vy, After the explanations provided by @manusa in fabric8io/kubernetes-client#5682, I think that the best solution would be to either move `log4j-kubernetes` to a F

Re: [I] log4j-core >= 2.22.0: Missing spotbugs-annotations dependency (logging-log4j2)

2024-01-05 Thread via GitHub
ppkarwasz commented on issue #2144: URL: https://github.com/apache/logging-log4j2/issues/2144#issuecomment-1878783454 > > You can disable the compiler warnings with `-Xlint:all,-classFile` > > I think we should not tell users striving for `-Xlint:all`-grade quality to relax their mea

Re: [I] Skip `bnd-maven-plugin` configuration when `bnd.skip` is present [logging-parent]

2024-01-05 Thread via GitHub
vy commented on issue #34: URL: https://github.com/apache/logging-parent/issues/34#issuecomment-1878779795 Indirectly fixed by #69. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [I] Skip `bnd-maven-plugin` configuration when `bnd.skip` is present [logging-parent]

2024-01-05 Thread via GitHub
vy closed issue #34: Skip `bnd-maven-plugin` configuration when `bnd.skip` is present URL: https://github.com/apache/logging-parent/issues/34 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [I] Switch from `bnd:jar` to `bnd:bnd-process` [logging-parent]

2024-01-05 Thread via GitHub
vy closed issue #69: Switch from `bnd:jar` to `bnd:bnd-process` URL: https://github.com/apache/logging-parent/issues/69 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

Re: [PR] Fix dead link to release notes and support on index.adoc (logging-log4j2)

2024-01-05 Thread via GitHub
vy merged PR #2168: URL: https://github.com/apache/logging-log4j2/pull/2168 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@lo

Re: [I] https://logging.apache.org/log4j/2.x/ has a broken link (logging-log4j2)

2024-01-05 Thread via GitHub
vy closed issue #2149: https://logging.apache.org/log4j/2.x/ has a broken link URL: https://github.com/apache/logging-log4j2/issues/2149 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [PR] Fix dead link to release notes and support on index.adoc (logging-log4j2)

2024-01-05 Thread via GitHub
vy commented on PR #2168: URL: https://github.com/apache/logging-log4j2/pull/2168#issuecomment-1878713027 They should have been `xref:release-notes.adoc`, but `link:release-notes.html` is okay too. Thanks for the fix! -- This is an automated message from the Apache Git Service. To respond

Re: [PR] Clean up `log4j-spring-cloud-config-client` dependencies (logging-log4j2)

2024-01-05 Thread via GitHub
vy commented on code in PR #2166: URL: https://github.com/apache/logging-log4j2/pull/2166#discussion_r1442915435 ## log4j-spring-cloud-config-client/pom.xml: ## @@ -120,33 +86,21 @@ - org.junit.vintage - junit-vintage-engine + org.apache.logging.log4

Re: [PR] Clean up `log4j-spring-cloud-config-client` dependencies (logging-log4j2)

2024-01-05 Thread via GitHub
raffig commented on PR #2166: URL: https://github.com/apache/logging-log4j2/pull/2166#issuecomment-1878666076 It seems to be OK, however from my personal point of view I would say that Spring related properties should not be in `log4j-parent/pom.xml`, because in general log4j has nothing to

Re: [I] Log4j incompatible with recent kubernetes-client (logging-log4j2)

2024-01-05 Thread via GitHub
vy commented on issue #2151: URL: https://github.com/apache/logging-log4j2/issues/2151#issuecomment-1878659536 @Amya28, are there any particular reasons you choose `KubernetesLookup` over exporting associated Kubernetes configuration to environment variables and accessing them using `Envir

Re: [I] log4j-core >= 2.22.0: Missing spotbugs-annotations dependency (logging-log4j2)

2024-01-05 Thread via GitHub
vy commented on issue #2144: URL: https://github.com/apache/logging-log4j2/issues/2144#issuecomment-1878638226 > You can disable the compiler warnings with `-Xlint:all,-classFile` I think we should not tell users striving for `-Xlint:all`-grade quality to relax their measures when it

Re: [I] log4j-core >= 2.22.0: Missing spotbugs-annotations dependency (logging-log4j2)

2024-01-05 Thread via GitHub
vy closed issue #2144: log4j-core >= 2.22.0: Missing spotbugs-annotations dependency URL: https://github.com/apache/logging-log4j2/issues/2144 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

Re: [PR] Add an XML schema generator [logging-log4j-tools]

2024-01-05 Thread via GitHub
vy commented on code in PR #92: URL: https://github.com/apache/logging-log4j-tools/pull/92#discussion_r1442794428 ## log4j-docgen/src/main/java/org/apache/logging/log4j/docgen/internal/DefaultSchemaGenerator.java: ## @@ -0,0 +1,306 @@ +/* + * Licensed to the Apache Software Fou

Re: [I] Clean-up `target/classes` directory before compilation [logging-parent]

2024-01-05 Thread via GitHub
ppkarwasz commented on issue #90: URL: https://github.com/apache/logging-parent/issues/90#issuecomment-1878513640 A minimal reproducible example of the bug can be found here: https://github.com/copernik-eu/bug-reproducibility/tree/main/javac-module-info-bug -- This is an automated

[jira] [Created] (LOG4NET-695) LoggingEvent - ThreadName calculated incorrectly in .net8

2024-01-05 Thread Michal Rakoczy (Jira)
Michal Rakoczy created LOG4NET-695: -- Summary: LoggingEvent - ThreadName calculated incorrectly in .net8 Key: LOG4NET-695 URL: https://issues.apache.org/jira/browse/LOG4NET-695 Project: Log4net

[I] Clean-up `target/classes` directory before compilation [logging-parent]

2024-01-05 Thread via GitHub
ppkarwasz opened a new issue, #90: URL: https://github.com/apache/logging-parent/issues/90 The `javac` compiler starts behaving differently if it finds `module-info.class` file from a previous compilation in the target directory: it tries to resolve the modules, but it fails since the modul

Re: [PR] Split off YAML configuration into its own module (logging-log4j2)

2024-01-05 Thread via GitHub
vy commented on code in PR #2142: URL: https://github.com/apache/logging-log4j2/pull/2142#discussion_r1442728067 ## src/changelog/.3.x.x/create_config_yaml.xml: ## @@ -0,0 +1,9 @@ + +http://www.w3.org/2001/XMLSchema-instance"; + xmlns="http://logging.apache.org/log4j/chang

Re: [I] JsonLogEventParser can not parse json log string with extendedStackTrace (logging-log4j2)

2024-01-05 Thread via GitHub
ppkarwasz commented on issue #2162: URL: https://github.com/apache/logging-log4j2/issues/2162#issuecomment-1878418556 For completeness' sake, the parser didn't disappear, it was moved to samples: [`log4j-samples-parser`](https://github.com/apache/logging-log4j-samples/tree/main/log4j-sampl

Re: [I] JsonLogEventParser can not parse json log string with extendedStackTrace (logging-log4j2)

2024-01-05 Thread via GitHub
vy commented on issue #2162: URL: https://github.com/apache/logging-log4j2/issues/2162#issuecomment-1878414012 @sanova, I recommend you to indeed roll out your own parser. Back in the days when `JsonLayout` was the only JSON-formatted layout, it was possible to provide Jackson-annota

Re: [I] %d{UNIX_MILLIS} is printing 0 as timestamp in log file (logging-log4j2)

2024-01-05 Thread via GitHub
AnushaGHerale commented on issue #2167: URL: https://github.com/apache/logging-log4j2/issues/2167#issuecomment-1878331502 [default.log](https://github.com/apache/logging-log4j2/files/13839902/default.log) -- This is an automated message from the Apache Git Service. To respond

[PR] Fix dead link to release notes and support on index.adoc (logging-log4j2)

2024-01-05 Thread via GitHub
Gospel-c opened a new pull request, #2168: URL: https://github.com/apache/logging-log4j2/pull/2168 Fixes #2149 This pull request addresses the issue where the hyperlinks to the release notes and support was incorrect on the documentation page. The link was pointing to release-notes.a

[I] %d{UNIX_MILLIS} is printing 0 as timestamp in log file (logging-log4j2)

2024-01-05 Thread via GitHub
AnushaGHerale opened a new issue, #2167: URL: https://github.com/apache/logging-log4j2/issues/2167 ## Description We have upgrade from log4j1.x to log4j2.18. After this upgrade in our log file we are seeing few log statement are recoded with correct system time . But few are loggi