Re: [PR] Work towards supporting Java 17 builds (logging-log4j2)

2023-11-22 Thread via GitHub
ppkarwasz commented on PR #1964: URL: https://github.com/apache/logging-log4j2/pull/1964#issuecomment-1823926687 @jvz, I'll cherry-pick some changes from here to provide a minimal fix to tests on JRE 17. -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] MDC and NDC availablity no longer depend on APR thread support [logging-log4cxx]

2023-11-22 Thread via GitHub
swebb2066 merged PR #299: URL: https://github.com/apache/logging-log4cxx/pull/299 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr

Re: [PR] Work towards supporting Java 17 builds (logging-log4j2)

2023-11-22 Thread via GitHub
jvz closed pull request #1964: Work towards supporting Java 17 builds URL: https://github.com/apache/logging-log4j2/pull/1964 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Work towards supporting Java 17 builds (logging-log4j2)

2023-11-22 Thread via GitHub
jvz commented on PR #1964: URL: https://github.com/apache/logging-log4j2/pull/1964#issuecomment-1823597273 I'm working on the main branch; this PR is a draft of ideas needed to get Java 17 working for tests. I won't be making more changes to this branch as I don't have the time. -- This

Re: [PR] Work towards supporting Java 17 builds (logging-log4j2)

2023-11-22 Thread via GitHub
jvz commented on code in PR #1964: URL: https://github.com/apache/logging-log4j2/pull/1964#discussion_r1402775588 ## log4j-api/src/main/java/org/apache/logging/log4j/util/Constants.java: ## @@ -120,4 +115,44 @@ static int getMajorVersion(final String version) { retu

Re: [I] Custom ConfigurationFactory implementation added to the classpath are not loaded (logging-log4j2)

2023-11-22 Thread via GitHub
ppkarwasz commented on issue #1997: URL: https://github.com/apache/logging-log4j2/issues/1997#issuecomment-1823542666 @thejas-stripe, In order to be automatically detected, plugins must be compiled with the annotation processor present in `log4j-core`. In your project you explicitly

Re: [I] Remove module/features in `3.x` (logging-log4j2)

2023-11-22 Thread via GitHub
vy commented on issue #1951: URL: https://github.com/apache/logging-log4j2/issues/1951#issuecomment-1823483939 This issue is addressed by #1981 and #1985. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [I] Remove module/features in `3.x` (logging-log4j2)

2023-11-22 Thread via GitHub
vy closed issue #1951: Remove module/features in `3.x` URL: https://github.com/apache/logging-log4j2/issues/1951 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] Bump org.elasticsearch.client:elasticsearch-rest-high-level-client from 7.17.14 to 7.17.15 (logging-log4j2)

2023-11-22 Thread via GitHub
github-actions[bot] closed pull request #1996: Bump org.elasticsearch.client:elasticsearch-rest-high-level-client from 7.17.14 to 7.17.15 URL: https://github.com/apache/logging-log4j2/pull/1996 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] Bump org.elasticsearch.client:elasticsearch-rest-high-level-client from 7.17.14 to 7.17.15 (logging-log4j2)

2023-11-22 Thread via GitHub
github-actions[bot] commented on PR #1996: URL: https://github.com/apache/logging-log4j2/pull/1996#issuecomment-1823380722 Changes are applied by CI in e310a00c229e4d7315e16347da327fcc5a561c4f -- This is an automated message from the Apache Git Service. To respond to the message, please lo

Re: [PR] Bump org.jctools:jctools-core from 3.3.0 to 4.0.2 (logging-log4j2)

2023-11-22 Thread via GitHub
github-actions[bot] closed pull request #1995: Bump org.jctools:jctools-core from 3.3.0 to 4.0.2 URL: https://github.com/apache/logging-log4j2/pull/1995 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] Bump org.jctools:jctools-core from 3.3.0 to 4.0.2 (logging-log4j2)

2023-11-22 Thread via GitHub
github-actions[bot] commented on PR #1995: URL: https://github.com/apache/logging-log4j2/pull/1995#issuecomment-1823361904 Changes are applied by CI in 845576458ba829586e8d82e86129dabc3c762b56 -- This is an automated message from the Apache Git Service. To respond to the message, please lo

Re: [PR] Bump org.springframework:spring-test from 5.3.29 to 5.3.31 (logging-log4j2)

2023-11-22 Thread via GitHub
github-actions[bot] closed pull request #1992: Bump org.springframework:spring-test from 5.3.29 to 5.3.31 URL: https://github.com/apache/logging-log4j2/pull/1992 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

Re: [PR] Bump org.springframework:spring-test from 5.3.29 to 5.3.31 (logging-log4j2)

2023-11-22 Thread via GitHub
github-actions[bot] commented on PR #1992: URL: https://github.com/apache/logging-log4j2/pull/1992#issuecomment-1823302854 Changes are applied by CI in 4a34801f758f971d7ed13369645b3b9adedb0b56 -- This is an automated message from the Apache Git Service. To respond to the message, please lo

Re: [PR] Bump mongodb.version from 4.11.0 to 4.11.1 (logging-log4j2)

2023-11-22 Thread via GitHub
github-actions[bot] closed pull request #1991: Bump mongodb.version from 4.11.0 to 4.11.1 URL: https://github.com/apache/logging-log4j2/pull/1991 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Bump mongodb.version from 4.11.0 to 4.11.1 (logging-log4j2)

2023-11-22 Thread via GitHub
github-actions[bot] commented on PR #1991: URL: https://github.com/apache/logging-log4j2/pull/1991#issuecomment-1823293750 Changes are applied by CI in 34a19d7d26e4f2152bc3771f7f804ba0d253c5d2 -- This is an automated message from the Apache Git Service. To respond to the message, please lo

Re: [PR] Bump junit-jupiter.version from 5.10.0 to 5.10.1 (logging-log4j2)

2023-11-22 Thread via GitHub
github-actions[bot] closed pull request #1993: Bump junit-jupiter.version from 5.10.0 to 5.10.1 URL: https://github.com/apache/logging-log4j2/pull/1993 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

Re: [PR] Bump junit-jupiter.version from 5.10.0 to 5.10.1 (logging-log4j2)

2023-11-22 Thread via GitHub
github-actions[bot] commented on PR #1993: URL: https://github.com/apache/logging-log4j2/pull/1993#issuecomment-1823263011 Changes are applied by CI in 008a261e83ca28a4723f855392c28dd4f9b7f41e -- This is an automated message from the Apache Git Service. To respond to the message, please lo

Re: [PR] Bump org.mockito:mockito-bom from 5.5.0 to 5.7.0 (logging-log4j2)

2023-11-22 Thread via GitHub
github-actions[bot] commented on PR #1987: URL: https://github.com/apache/logging-log4j2/pull/1987#issuecomment-1823236343 Changes are applied by CI in 30b9694dd7373cfa4d979945229d06938db5562b -- This is an automated message from the Apache Git Service. To respond to the message, please lo

Re: [PR] Bump org.mockito:mockito-bom from 5.5.0 to 5.7.0 (logging-log4j2)

2023-11-22 Thread via GitHub
github-actions[bot] closed pull request #1987: Bump org.mockito:mockito-bom from 5.5.0 to 5.7.0 URL: https://github.com/apache/logging-log4j2/pull/1987 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

Re: [PR] Bump com.vlkan.log4j2:log4j2-logstash-layout from 0.18 to 1.0.5 (logging-log4j2)

2023-11-22 Thread via GitHub
ppkarwasz commented on PR #1586: URL: https://github.com/apache/logging-log4j2/pull/1586#issuecomment-1823210104 I am converting this PR into an issue: #1990 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[I] Allow old plugins to work with 3.x (logging-log4j2)

2023-11-22 Thread via GitHub
ppkarwasz opened a new issue, #1990: URL: https://github.com/apache/logging-log4j2/issues/1990 The changes in 3.x broke some old 2.x external plugins like [log4j2-logstash-layout](https://github.com/vy/log4j2-logstash-layout) (cf. #1586). We should consider maintaining binary compati

Re: [PR] Bump com.vlkan.log4j2:log4j2-logstash-layout from 0.18 to 1.0.5 (logging-log4j2)

2023-11-22 Thread via GitHub
ppkarwasz closed pull request #1586: Bump com.vlkan.log4j2:log4j2-logstash-layout from 0.18 to 1.0.5 URL: https://github.com/apache/logging-log4j2/pull/1586 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] Bump com.github.luben:zstd-jni from 1.5.5-7 to 1.5.5-10 (logging-log4j2)

2023-11-22 Thread via GitHub
github-actions[bot] closed pull request #1989: Bump com.github.luben:zstd-jni from 1.5.5-7 to 1.5.5-10 URL: https://github.com/apache/logging-log4j2/pull/1989 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] Bump com.github.luben:zstd-jni from 1.5.5-7 to 1.5.5-10 (logging-log4j2)

2023-11-22 Thread via GitHub
github-actions[bot] commented on PR #1989: URL: https://github.com/apache/logging-log4j2/pull/1989#issuecomment-1823203859 Changes are applied by CI in 78d5a1bae661d26b5cb4734ae3c0036a62c5c09d -- This is an automated message from the Apache Git Service. To respond to the message, please lo

Re: [PR] Bump org.mockito:mockito-bom from 5.5.0 to 5.7.0 (logging-log4j2)

2023-11-22 Thread via GitHub
ppkarwasz commented on PR #1987: URL: https://github.com/apache/logging-log4j2/pull/1987#issuecomment-1823178131 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] Bump flapdoodle-embed.version from 4.8.1 to 4.10.1 (logging-log4j2)

2023-11-22 Thread via GitHub
ppkarwasz commented on PR #1988: URL: https://github.com/apache/logging-log4j2/pull/1988#issuecomment-1823178724 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] Bump org.junit-pioneer:junit-pioneer from 2.0.1 to 2.2.0 (logging-log4j2)

2023-11-22 Thread via GitHub
github-actions[bot] commented on PR #1986: URL: https://github.com/apache/logging-log4j2/pull/1986#issuecomment-1823174424 Changes are applied by CI in 678270e0af80c5b32fb0cb7b9058ea4cc4d58500 -- This is an automated message from the Apache Git Service. To respond to the message, please lo

Re: [PR] Bump org.junit-pioneer:junit-pioneer from 2.0.1 to 2.2.0 (logging-log4j2)

2023-11-22 Thread via GitHub
github-actions[bot] closed pull request #1986: Bump org.junit-pioneer:junit-pioneer from 2.0.1 to 2.2.0 URL: https://github.com/apache/logging-log4j2/pull/1986 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] Bump com.github.luben:zstd-jni from 1.5.5-7 to 1.5.5-10 (logging-log4j2)

2023-11-22 Thread via GitHub
ppkarwasz commented on PR #1989: URL: https://github.com/apache/logging-log4j2/pull/1989#issuecomment-1823102469 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] Bump org.apache.commons:commons-lang3 from 3.13.0 to 3.14.0 [logging-log4j-audit]

2023-11-22 Thread via GitHub
github-actions[bot] commented on PR #93: URL: https://github.com/apache/logging-log4j-audit/pull/93#issuecomment-1823098937 Changes are applied by CI in d0671f24cc49b1ff3da6173b717ffbf31eaba117 -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] Bump org.apache.commons:commons-lang3 from 3.13.0 to 3.14.0 [logging-log4j-audit]

2023-11-22 Thread via GitHub
dependabot[bot] commented on PR #93: URL: https://github.com/apache/logging-log4j-audit/pull/93#issuecomment-1823099038 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor ver

Re: [PR] Bump org.apache.commons:commons-lang3 from 3.13.0 to 3.14.0 [logging-log4j-audit]

2023-11-22 Thread via GitHub
github-actions[bot] closed pull request #93: Bump org.apache.commons:commons-lang3 from 3.13.0 to 3.14.0 URL: https://github.com/apache/logging-log4j-audit/pull/93 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[PR] Bump org.apache.commons:commons-lang3 from 3.13.0 to 3.14.0 [logging-log4j-audit]

2023-11-22 Thread via GitHub
dependabot[bot] opened a new pull request, #93: URL: https://github.com/apache/logging-log4j-audit/pull/93 Bumps org.apache.commons:commons-lang3 from 3.13.0 to 3.14.0. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency

Re: [PR] Remove deprecated modules (logging-log4j2)

2023-11-22 Thread via GitHub
vy merged PR #1985: URL: https://github.com/apache/logging-log4j2/pull/1985 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@lo

Re: [PR] Remove deprecated modules (logging-log4j2)

2023-11-22 Thread via GitHub
vy commented on code in PR #1985: URL: https://github.com/apache/logging-log4j2/pull/1985#discussion_r1402224874 ## log4j-layout-template-json/src/main/java/org/apache/logging/log4j/layout/template/json/JsonTemplateLayout.java: ## @@ -249,6 +250,11 @@ public Map getContentFormat

Re: [PR] Remove deprecated modules (logging-log4j2)

2023-11-22 Thread via GitHub
ppkarwasz commented on code in PR #1985: URL: https://github.com/apache/logging-log4j2/pull/1985#discussion_r1402179397 ## log4j-layout-template-json/src/main/java/org/apache/logging/log4j/layout/template/json/JsonTemplateLayout.java: ## @@ -249,6 +250,11 @@ public Map getConten

Re: [PR] Remove deprecated modules (logging-log4j2)

2023-11-22 Thread via GitHub
ppkarwasz commented on code in PR #1985: URL: https://github.com/apache/logging-log4j2/pull/1985#discussion_r1402162868 ## log4j-layout-template-json/src/main/java/org/apache/logging/log4j/layout/template/json/JsonTemplateLayout.java: ## @@ -249,6 +250,11 @@ public Map getConten

Re: [PR] Remove deprecated modules (logging-log4j2)

2023-11-22 Thread via GitHub
ppkarwasz commented on code in PR #1985: URL: https://github.com/apache/logging-log4j2/pull/1985#discussion_r1402144869 ## log4j-core-its/src/test/java/org/apache/logging/log4j/core/appender/SocketAppenderTest.java: ## @@ -37,17 +41,13 @@ import org.apache.logging.log4j.Level;

Re: [PR] Remove deprecated modules (logging-log4j2)

2023-11-22 Thread via GitHub
vy commented on code in PR #1985: URL: https://github.com/apache/logging-log4j2/pull/1985#discussion_r1402143652 ## log4j-layout-template-json/src/main/java/org/apache/logging/log4j/layout/template/json/JsonTemplateLayout.java: ## @@ -249,6 +250,11 @@ public Map getContentFormat

Re: [PR] Remove deprecated modules (logging-log4j2)

2023-11-22 Thread via GitHub
vy commented on code in PR #1985: URL: https://github.com/apache/logging-log4j2/pull/1985#discussion_r1402138597 ## log4j-core-test/src/main/java/org/apache/logging/log4j/core/test/categories/Appenders.java: ## @@ -24,13 +24,5 @@ interface AsyncConversant {} interface Asy

Re: [PR] Remove deprecated modules (logging-log4j2)

2023-11-22 Thread via GitHub
vy commented on code in PR #1985: URL: https://github.com/apache/logging-log4j2/pull/1985#discussion_r1402137299 ## log4j-distribution/pom.xml: ## @@ -63,11 +63,6 @@ snappy-java ${snappy.version} - Review Comment: I will, but not in this PR, w

Re: [PR] Remove deprecated modules (logging-log4j2)

2023-11-22 Thread via GitHub
ppkarwasz commented on PR #1985: URL: https://github.com/apache/logging-log4j2/pull/1985#issuecomment-1822857869 I also think that the reparenting of `log4j-spring-cloud-config-client` (commit 0121847af4fbba60a84eb52bc27e49a781cd4e71) should be backported to 2.x. Do you mind doing the cherr

Re: [PR] Remove deprecated modules (logging-log4j2)

2023-11-22 Thread via GitHub
vy commented on code in PR #1985: URL: https://github.com/apache/logging-log4j2/pull/1985#discussion_r1402134734 ## log4j-core-its/src/test/java/org/apache/logging/log4j/core/appender/SocketAppenderTest.java: ## @@ -37,17 +41,13 @@ import org.apache.logging.log4j.Level; import

Re: [PR] Remove deprecated modules (logging-log4j2)

2023-11-22 Thread via GitHub
ppkarwasz commented on code in PR #1985: URL: https://github.com/apache/logging-log4j2/pull/1985#discussion_r1402076017 ## log4j-core-test/src/main/java/org/apache/logging/log4j/core/test/categories/Appenders.java: ## @@ -24,13 +24,5 @@ interface AsyncConversant {} interf

Re: [I] [MS9] Schema and documentation generation from source code (logging-log4j2)

2023-11-22 Thread via GitHub
vy commented on issue #1954: URL: https://github.com/apache/logging-log4j2/issues/1954#issuecomment-1822837910 Note that `XmlSchemaTest` needs to be removed and its functionality should ideally be replaced with a `xml-maven-plugin` validation that can take place at the Maven `validation` p

[PR] Remove deprecated modules (logging-log4j2)

2023-11-22 Thread via GitHub
vy opened a new pull request, #1985: URL: https://github.com/apache/logging-log4j2/pull/1985 This PR removes the following features/modules: - `GelfLayout` - `log4j-cassandra` - `log4j-couchdb` - `log4j-jeromq` - `log4j-kafka` - `log4j-layout-jackson-json` - `log4j-la

Re: [PR] Bump org.jctools:jctools-core from 4.0.1 to 4.0.2 (logging-log4j2)

2023-11-22 Thread via GitHub
github-actions[bot] commented on PR #1984: URL: https://github.com/apache/logging-log4j2/pull/1984#issuecomment-1822650383 Changes are applied by CI in b1d4a2a3cf8cabf87e760f0692fdc865453418c3 -- This is an automated message from the Apache Git Service. To respond to the message, please lo

Re: [PR] Bump org.jctools:jctools-core from 4.0.1 to 4.0.2 (logging-log4j2)

2023-11-22 Thread via GitHub
github-actions[bot] closed pull request #1984: Bump org.jctools:jctools-core from 4.0.1 to 4.0.2 URL: https://github.com/apache/logging-log4j2/pull/1984 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] Work towards supporting Java 17 builds (logging-log4j2)

2023-11-22 Thread via GitHub
ppkarwasz commented on code in PR #1964: URL: https://github.com/apache/logging-log4j2/pull/1964#discussion_r1401860900 ## log4j-api/src/main/java/org/apache/logging/log4j/util/Constants.java: ## @@ -120,4 +115,44 @@ static int getMajorVersion(final String version) {