[GitHub] [logging-log4j2] alex-dubrouski commented on pull request #1214: This change fixes incorrect behavior of stack elements cache.

2023-01-19 Thread GitBox
alex-dubrouski commented on PR #1214: URL: https://github.com/apache/logging-log4j2/pull/1214#issuecomment-1397742320 > Yes, I would expect the class that called `StackLocatorUtil` at the lowest index (or at least near the top), while the class that initiated execution on the thread (JUnit?

[GitHub] [logging-log4j2] ppkarwasz commented on pull request #1214: This change fixes incorrect behavior of stack elements cache.

2023-01-19 Thread GitBox
ppkarwasz commented on PR #1214: URL: https://github.com/apache/logging-log4j2/pull/1214#issuecomment-1397550671 Yes, I would expect the class that called `StackLocatorUtil` at the lowest index (or at least near the top), while the class that initiated execution on the thread (JUnit?) at th

[GitHub] [logging-log4j2] alex-dubrouski commented on pull request #1214: This change fixes incorrect behavior of stack elements cache.

2023-01-19 Thread GitBox
alex-dubrouski commented on PR #1214: URL: https://github.com/apache/logging-log4j2/pull/1214#issuecomment-1397333970 > Are you sure calling class should be the first? Screenshots from test project I attached before have calling class as the last element (index 26) -- This is an a

[GitHub] [logging-log4cxx] timcoleman commented on issue #180: SetThreadDescription and GetThreadDescription are not properly linked on Windows

2023-01-19 Thread GitBox
timcoleman commented on issue #180: URL: https://github.com/apache/logging-log4cxx/issues/180#issuecomment-1397141508 This bit in threadutility.cpp causes an error: #if LOG4CXX_HAS_SETTHREADDESCRIPTION #include #include #endif Aside from that, it seems good

[GitHub] [logging-log4cxx] timcoleman commented on issue #180: SetThreadDescription and GetThreadDescription are not properly linked on Windows

2023-01-19 Thread GitBox
timcoleman commented on issue #180: URL: https://github.com/apache/logging-log4cxx/issues/180#issuecomment-1397100265 Hang on. I still think the code looks good, but I might have goofed something. Not enough coffee yet. -- This is an automated message from the Apache Git Service

[GitHub] [logging-log4cxx] timcoleman commented on issue #180: SetThreadDescription and GetThreadDescription are not properly linked on Windows

2023-01-19 Thread GitBox
timcoleman commented on issue #180: URL: https://github.com/apache/logging-log4cxx/issues/180#issuecomment-1397095671 Yes, I built it and it is working for me. Logs are being written, and the dependency walker doesn't show a missing dependency anymore. Thanks, Tim --