[GitHub] [logging-log4cxx] swebb2066 commented on issue #180: SetThreadDescription and GetThreadDescription are not properly linked on Windows

2023-01-18 Thread GitBox
swebb2066 commented on issue #180: URL: https://github.com/apache/logging-log4cxx/issues/180#issuecomment-1396526543 Could you tell me if the windows_server_issue branch resolves this issue on your Windows server version please? -- This is an automated message from the Apache Git Service

[GitHub] [logging-log4cxx] swebb2066 opened a new pull request, #181: Allow use on Window Server 2016 (issue #180).

2023-01-18 Thread GitBox
swebb2066 opened a new pull request, #181: URL: https://github.com/apache/logging-log4cxx/pull/181 Put more than the first character of thread name into the event log on Windows. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [logging-log4j2] ppkarwasz commented on pull request #1214: This change fixes incorrect behavior of stack elements cache.

2023-01-18 Thread GitBox
ppkarwasz commented on PR #1214: URL: https://github.com/apache/logging-log4j2/pull/1214#issuecomment-1396467725 @alex-dubrouski, Feel free to change `private` methods to package access. I think that we just need to test that `StackLocatorUtil#getCurrentStackTrace()` returns a `Deque

[GitHub] [logging-log4j2] alex-dubrouski commented on pull request #1214: This change fixes incorrect behavior of stack elements cache.

2023-01-18 Thread GitBox
alex-dubrouski commented on PR #1214: URL: https://github.com/apache/logging-log4j2/pull/1214#issuecomment-1396276897 I had quite hard time developing unit test for this class as it contains only static and private static methods. Final test verifies items in cache after executing "toExtend

[GitHub] [logging-log4cxx] timcoleman opened a new issue, #180: SetThreadDescription and GetThreadDescription are not properly linked on Windows

2023-01-18 Thread GitBox
timcoleman opened a new issue, #180: URL: https://github.com/apache/logging-log4cxx/issues/180 In order to be used on Windows Server, the SetThreadDescription() and GetThreadDescription() functions need to be linked at run time, instead of at load time. The code as implemented works

[GitHub] [logging-log4j2] rgoers commented on pull request #1215: Fix cron expression get a wrong previous fire time

2023-01-18 Thread GitBox
rgoers commented on PR #1215: URL: https://github.com/apache/logging-log4j2/pull/1215#issuecomment-1387265885 You can now create an issue in GitHub for this. We have a new changelog format so you can also add a changelog entry that references that issue. -- This is an automated message fr

[GitHub] [logging-log4j2] ppkarwasz opened a new issue, #1216: Refresh CONTRIBUTING.md

2023-01-18 Thread GitBox
ppkarwasz opened a new issue, #1216: URL: https://github.com/apache/logging-log4j2/issues/1216 The [`CONTRIBUTING.md`](https://github.com/apache/logging-log4j2/blob/release-2.x/CONTRIBUTING.md) file needs some updates. E.g. the requirement for "minimal updates" needs to be more precise: Sp

[GitHub] [logging-log4j-tools] vy opened a new issue, #19: FreeMarker integration is broken on Windows due to path issues

2023-01-18 Thread GitBox
vy opened a new issue, #19: URL: https://github.com/apache/logging-log4j-tools/issues/19 As [this failed CI run](/apache/logging-log4j2/actions/runs/3943007132/jobs/6747337526) indicates: ``` java.lang.RuntimeException: failed exporting release from directory `D:\a\logging-log4j2\logg

[GitHub] [logging-log4j2] miracle-tree closed pull request #1215: Fix cron expression get a wrong previous fire time

2023-01-18 Thread GitBox
miracle-tree closed pull request #1215: Fix cron expression get a wrong previous fire time URL: https://github.com/apache/logging-log4j2/pull/1215 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [logging-log4j2] ppkarwasz commented on pull request #1214: This change fixes incorrect behavior of stack elements cache.

2023-01-18 Thread GitBox
ppkarwasz commented on PR #1214: URL: https://github.com/apache/logging-log4j2/pull/1214#issuecomment-1386639067 `StackLocator` is a complex feature with several different paths, so maybe I'll add a cheatsheet for the unity tests: * the [`StackLocator#getCurrentStackTrace`](https://