[GitHub] [logging-log4j2] ppkarwasz commented on a diff in pull request #1214: This change fixes incorrect behavior of stack elements cache.

2023-01-17 Thread GitBox
ppkarwasz commented on code in PR #1214: URL: https://github.com/apache/logging-log4j2/pull/1214#discussion_r1073100498 ## log4j-core/src/main/java/org/apache/logging/log4j/core/impl/ThrowableProxyHelper.java: ## @@ -85,7 +85,7 @@ static ExtendedStackTraceElement[] toExtendedSta

[GitHub] [logging-log4j2] miracle-tree opened a new pull request, #1215: Fix cron expression get a wrong previous fire time

2023-01-17 Thread GitBox
miracle-tree opened a new pull request, #1215: URL: https://github.com/apache/logging-log4j2/pull/1215 For the method `CronExpression#getPrevFireTime`, currently only the minimum increment within a cycle is considered, and the cross-cycle situation is not involved, resulting in differences

[GitHub] [logging-log4cxx] swebb2066 merged pull request #178: Prevent compilation error in a MSYS2 environment using GCC

2023-01-17 Thread GitBox
swebb2066 merged PR #178: URL: https://github.com/apache/logging-log4cxx/pull/178 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr

[GitHub] [logging-log4j2] alex-dubrouski commented on a diff in pull request #1214: This change fixes incorrect behavior of stack elements cache.

2023-01-17 Thread GitBox
alex-dubrouski commented on code in PR #1214: URL: https://github.com/apache/logging-log4j2/pull/1214#discussion_r1072928929 ## log4j-core/src/main/java/org/apache/logging/log4j/core/impl/ThrowableProxyHelper.java: ## @@ -85,7 +85,7 @@ static ExtendedStackTraceElement[] toExtend

[GitHub] [logging-log4j2] alex-dubrouski commented on a diff in pull request #1214: This change fixes incorrect behavior of stack elements cache.

2023-01-17 Thread GitBox
alex-dubrouski commented on code in PR #1214: URL: https://github.com/apache/logging-log4j2/pull/1214#discussion_r1072928929 ## log4j-core/src/main/java/org/apache/logging/log4j/core/impl/ThrowableProxyHelper.java: ## @@ -85,7 +85,7 @@ static ExtendedStackTraceElement[] toExtend

[GitHub] [logging-log4j2] alex-dubrouski commented on a diff in pull request #1214: This change fixes incorrect behavior of stack elements cache.

2023-01-17 Thread GitBox
alex-dubrouski commented on code in PR #1214: URL: https://github.com/apache/logging-log4j2/pull/1214#discussion_r1072914968 ## log4j-core/src/main/java/org/apache/logging/log4j/core/impl/ThrowableProxyHelper.java: ## @@ -85,7 +85,7 @@ static ExtendedStackTraceElement[] toExtend

[GitHub] [logging-log4j2] ppkarwasz commented on a diff in pull request #1214: This change fixes incorrect behavior of stack elements cache.

2023-01-17 Thread GitBox
ppkarwasz commented on code in PR #1214: URL: https://github.com/apache/logging-log4j2/pull/1214#discussion_r1072880845 ## log4j-core/src/main/java/org/apache/logging/log4j/core/impl/ThrowableProxyHelper.java: ## @@ -85,7 +85,7 @@ static ExtendedStackTraceElement[] toExtendedSta

[GitHub] [logging-log4j2] sudheerv commented on pull request #1214: This change fixes incorrect behavior of stack elements cache.

2023-01-17 Thread GitBox
sudheerv commented on PR #1214: URL: https://github.com/apache/logging-log4j2/pull/1214#issuecomment-1385887173 👍 Thanks @alex-dubrouski for finding the bug and providing the fix! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [logging-log4j2] alex-dubrouski opened a new pull request, #1214: This change fixes incorrect behavior of stack elements cache.

2023-01-17 Thread GitBox
alex-dubrouski opened a new pull request, #1214: URL: https://github.com/apache/logging-log4j2/pull/1214 Change of data structure from Stack to Deque (LIFO to FIFO) in this commit https://github.com/apache/logging-log4j2/commit/97f3153b73ab071a69c2e61e0130fd0104d45407 broke cache logic. Thi

[GitHub] [logging-log4j-tools] ppkarwasz closed issue #18: Og

2023-01-17 Thread GitBox
ppkarwasz closed issue #18: Og URL: https://github.com/apache/logging-log4j-tools/issues/18 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notification

[GitHub] [logging-log4j2] ppkarwasz merged pull request #1205: Converter warning

2023-01-17 Thread GitBox
ppkarwasz merged PR #1205: URL: https://github.com/apache/logging-log4j2/pull/1205 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubsc

[GitHub] [logging-log4j2] ppkarwasz closed issue #1202: Pattern including PatternLayout Parameter disableAnsi=false emits a warning

2023-01-17 Thread GitBox
ppkarwasz closed issue #1202: Pattern including PatternLayout Parameter disableAnsi=false emits a warning URL: https://github.com/apache/logging-log4j2/issues/1202 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a