swebb2066 opened a new pull request #105:
URL: https://github.com/apache/logging-log4cxx/pull/105
This PR is further work towards fixing LOGCXX-532.
I believe localstatics are thread safe since C++11
--
This is an automated message from the Apache Git Service.
To respond to the mes
[
https://issues.apache.org/jira/browse/LOGCXX-532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17476994#comment-17476994
]
Stephen Webb commented on LOGCXX-532:
-
Some tests SegFault on Windows (using Visual S
ams-tschoening commented on a change in pull request #102:
URL: https://github.com/apache/logging-log4cxx/pull/102#discussion_r785672563
##
File path: src/main/cpp/rollingpolicybase.cpp
##
@@ -38,6 +39,7 @@ IMPLEMENT_LOG4CXX_OBJECT(RollingPolicyBase)
RollingPolicyBase::Rolli
swebb2066 edited a comment on pull request #103:
URL: https://github.com/apache/logging-log4cxx/pull/103#issuecomment-1014152730
It occurred to me I should hande both types of find result.
If this is OK I will cherry-pick to a master destined PR.
--
This is an automated message fro
swebb2066 commented on pull request #103:
URL: https://github.com/apache/logging-log4cxx/pull/103#issuecomment-1014152730
It occurred to me I should hande bot types of find result.
If this is OK I will cherry-pick to a master destined PR.
--
This is an automated message from the Ap
[
https://issues.apache.org/jira/browse/LOG4J2-3341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17476950#comment-17476950
]
Duo Zhang commented on LOG4J2-3341:
---
Skimmed the code, I guess first we could introduc
[
https://issues.apache.org/jira/browse/LOG4J2-3341?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Duo Zhang updated LOG4J2-3341:
--
Component/s: Configuration
> Support passing something like '-Dlog4j.rootLogger=INFO,Console' from com
rm5248 commented on pull request #103:
URL: https://github.com/apache/logging-log4cxx/pull/103#issuecomment-1014095458
Would it make more sense to merge this into master instead of next_stable?
Otherwise it looks good to me.
--
This is an automated message from the Apache Git Servi
swebb2066 opened a new pull request #103:
URL: https://github.com/apache/logging-log4cxx/pull/103
Currently, the examples use ${XMLLIB_LIBRARIES} while tests and the log4cxx
library use EXPAT::EXPAT.
This PR aims to localise in the top level CMakeLists.txt the expat library
referenc
ppkarwasz commented on pull request #704:
URL: https://github.com/apache/logging-log4j2/pull/704#issuecomment-1013999717
I split this PR into 6 smaller ones: #706, #707, #708, #709, #710, #711.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
ppkarwasz opened a new pull request #711:
URL: https://github.com/apache/logging-log4j2/pull/711
The Log4j 1.x bridge should arguably use the `Log4j1XmlLayout` instead of
the Log4j 2.x specific `XmlLayout`. That is also the layout used by the older
`Log4j1ConfigurationFactory`.
This
ppkarwasz opened a new pull request #710:
URL: https://github.com/apache/logging-log4j2/pull/710
The Log4j 1.x bridge incorrectly sets the pattern of the rolling file
appenders. Moreover the `RollingFileAppender` did not have a time based
triggering policy in the original Log4j 1.x.
ppkarwasz opened a new pull request #709:
URL: https://github.com/apache/logging-log4j2/pull/709
The default values used by `TTCCLayoutBuilder` were different from those
used by Log4j 1.x.
This PR fixes the tests concerning the `TTCCLayout` from #706.
--
This is an automated messa
ppkarwasz opened a new pull request #708:
URL: https://github.com/apache/logging-log4j2/pull/708
Since not all Log4j 1.x component builders extend `AbstractBuilder`,
`BuilderManager#createBuilder` throws a `ClassCastException` when instantiating
some of them.
For example using a `Si
ppkarwasz opened a new pull request #707:
URL: https://github.com/apache/logging-log4j2/pull/707
Log4j 1.x allows for both capitalized (`InfoLocation`) and Java-style
(`infoLocation`) component property names (`PropertySetter` calls
`Introspector.decapitalize`). This PR allows for Java-sty
ppkarwasz opened a new pull request #706:
URL: https://github.com/apache/logging-log4j2/pull/706
`Log4j1ConfigurationFactoryTest` contains many interesting tests that fail
if we apply them to the `PropertiesConfigurationFactory` and
`XmlConfigurationFactory` that replaced `Log4j1Configurat
ppkarwasz closed pull request #704:
URL: https://github.com/apache/logging-log4j2/pull/704
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notific
ppkarwasz commented on a change in pull request #704:
URL: https://github.com/apache/logging-log4j2/pull/704#discussion_r785540531
##
File path:
log4j-1.2-api/src/main/java/org/apache/log4j/builders/AbstractBuilder.java
##
@@ -86,12 +86,25 @@ protected String getNameAttribute(
ppkarwasz commented on a change in pull request #704:
URL: https://github.com/apache/logging-log4j2/pull/704#discussion_r785540531
##
File path:
log4j-1.2-api/src/main/java/org/apache/log4j/builders/AbstractBuilder.java
##
@@ -86,12 +86,25 @@ protected String getNameAttribute(
rgoers commented on pull request #704:
URL: https://github.com/apache/logging-log4j2/pull/704#issuecomment-1013972910
Yeah - I would appreciate this being split into a series of PRs. I got part
of that through and didn't see anything terribly concerning but I also did dig
as deep as I woul
ppkarwasz commented on a change in pull request #704:
URL: https://github.com/apache/logging-log4j2/pull/704#discussion_r785539228
##
File path:
log4j-1.2-api/src/main/java/org/apache/log4j/builders/AbstractBuilder.java
##
@@ -86,12 +86,25 @@ protected String getNameAttribute(
garydgregory commented on a change in pull request #704:
URL: https://github.com/apache/logging-log4j2/pull/704#discussion_r785534352
##
File path:
log4j-1.2-api/src/main/java/org/apache/log4j/builders/AbstractBuilder.java
##
@@ -86,12 +86,25 @@ protected String getNameAttribu
ppkarwasz edited a comment on pull request #704:
URL: https://github.com/apache/logging-log4j2/pull/704#issuecomment-1013950184
Sorry @garydgregory,
I didn't plan to provide a fix to LOG4J2-3328 at first, but some of the
tests I copied from `Log4j1ConfigurationFactoryTest` were fail
ppkarwasz commented on pull request #704:
URL: https://github.com/apache/logging-log4j2/pull/704#issuecomment-1013950184
Sorry @garydgregory,
I didn't plan to provide a fix to LOG4J2-3328 at first, but some of the
tests the I copied from `Log4j1ConfigurationFactoryTest` were failing
ppkarwasz commented on pull request #705:
URL: https://github.com/apache/logging-log4j2/pull/705#issuecomment-1013945398
Sorry, I wanted to modify #704 instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
ppkarwasz closed pull request #705:
URL: https://github.com/apache/logging-log4j2/pull/705
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notific
[
https://issues.apache.org/jira/browse/LOG4J2-3205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gary D. Gregory closed LOG4J2-3205.
---
Resolution: Not A Bug
Closing as not a bug.
> OutputStreamManager.flushBuffer throw NoSuchM
garydgregory merged pull request #702:
URL: https://github.com/apache/logging-log4j2/pull/702
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: noti
[
https://issues.apache.org/jira/browse/LOG4J2-3199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17476838#comment-17476838
]
Gary D. Gregory commented on LOG4J2-3199:
-
Hi [~jacob2221]
Can you try this wi
garydgregory commented on pull request #704:
URL: https://github.com/apache/logging-log4j2/pull/704#issuecomment-1013915115
Hello @ppkarwasz
Thank you for your PR. You must have missed in Jira that the ticket
https://issues.apache.org/jira/browse/LOG4J2-3328 was assigned to me, so we
w
[
https://issues.apache.org/jira/browse/LOG4J2-3328?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gary D. Gregory resolved LOG4J2-3328.
-
Fix Version/s: 2.17.2
Resolution: Fixed
Hello [~paulcooper]
I fixed this issue
[
https://issues.apache.org/jira/browse/LOG4J2-3330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17476834#comment-17476834
]
ASF subversion and git services commented on LOG4J2-3330:
-
Commi
[
https://issues.apache.org/jira/browse/LOG4J2-3328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17476833#comment-17476833
]
ASF subversion and git services commented on LOG4J2-3328:
-
Commi
[
https://issues.apache.org/jira/browse/LOG4J2-3328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17476831#comment-17476831
]
ASF subversion and git services commented on LOG4J2-3328:
-
Commi
[
https://issues.apache.org/jira/browse/LOG4J2-3328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17476830#comment-17476830
]
ASF subversion and git services commented on LOG4J2-3328:
-
Commi
[
https://issues.apache.org/jira/browse/LOG4J2-3328?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gary D. Gregory updated LOG4J2-3328:
Summary: Log4j 1.2 bridge does not support system properties in log4j.xml
(was: Log4j bri
rm5248 commented on a change in pull request #102:
URL: https://github.com/apache/logging-log4cxx/pull/102#discussion_r785460548
##
File path: src/main/cpp/rollingpolicybase.cpp
##
@@ -38,6 +39,7 @@ IMPLEMENT_LOG4CXX_OBJECT(RollingPolicyBase)
RollingPolicyBase::RollingPolicy
strugerk commented on a change in pull request #703:
URL: https://github.com/apache/logging-log4j2/pull/703#discussion_r785426539
##
File path:
log4j-core/src/main/java/org/apache/logging/log4j/core/appender/rolling/action/AbstractPathAction.java
##
@@ -103,7 +103,15 @@ public
ams-tschoening commented on a change in pull request #102:
URL: https://github.com/apache/logging-log4cxx/pull/102#discussion_r785426142
##
File path: src/main/cpp/rollingpolicybase.cpp
##
@@ -38,6 +39,7 @@ IMPLEMENT_LOG4CXX_OBJECT(RollingPolicyBase)
RollingPolicyBase::Rolli
[
https://issues.apache.org/jira/browse/LOG4J2-3340?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Vorburger updated LOG4J2-3340:
--
Description:
I would like to see the warn log from {{LogManager}} re. which implementa
40 matches
Mail list logo
