atulpendse edited a comment on pull request #683:
URL: https://github.com/apache/logging-log4j2/pull/683#issuecomment-1008543504
@vy
Thanks for taking time to review the PR.
Here are my thoughts about questions you raised.
> I am also not sure if a `timestampPrecision` argument
atulpendse commented on pull request #683:
URL: https://github.com/apache/logging-log4j2/pull/683#issuecomment-1008543504
@vy
Thanks for taking time to review the PR.
Here are my thoughts about questions you raised.
> I am also not sure if a `timestampPrecision` argument of typ
[
https://issues.apache.org/jira/browse/LOGCXX-546?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Middleton resolved LOGCXX-546.
-
Resolution: Fixed
> Multi threaded applications run at single threaded speed
> --
[
https://issues.apache.org/jira/browse/LOGCXX-546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17471625#comment-17471625
]
Stephen Webb commented on LOGCXX-546:
-
Yes, it can be set as resolved when a new vers
[
https://issues.apache.org/jira/browse/LOG4J2-3323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17471619#comment-17471619
]
Ralph Goers commented on LOG4J2-3323:
-
Sorry, I have to disagree. Anyone wanting to
[
https://issues.apache.org/jira/browse/LOG4J2-3323?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ralph Goers reopened LOG4J2-3323:
-
> Breaking change in AbstractManager
> --
>
> Key: L
[
https://issues.apache.org/jira/browse/LOG4J2-3298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17471603#comment-17471603
]
Matt Pavlovich commented on LOG4J2-3298:
[~vy] not really. the mdc approach with
[
https://issues.apache.org/jira/browse/LOG4J2-3298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17471603#comment-17471603
]
Matt Pavlovich edited comment on LOG4J2-3298 at 1/9/22, 11:01 PM:
vy edited a comment on pull request #683:
URL: https://github.com/apache/logging-log4j2/pull/683#issuecomment-1008421459
Fantastic work @atulpendse! Thanks so much!
Mind adding `SyslogAppender` tests ~~and a `changes.xml` entry~~, please?
I am also not sure if a `timestampPreci
vy commented on pull request #683:
URL: https://github.com/apache/logging-log4j2/pull/683#issuecomment-1008432086
IMHO, cherry-picking to `master` is almost already impossible. Nevertheless,
I will rephrase my comment to exclude the `changes.xml` part.
--
This is an automated message fro
[
https://issues.apache.org/jira/browse/LOG4J2-3323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17471555#comment-17471555
]
Volkan Yazici commented on LOG4J2-3323:
---
I tend to agree with [~ggregory]. Marking
[
https://issues.apache.org/jira/browse/LOG4J2-3323?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Volkan Yazici resolved LOG4J2-3323.
---
Resolution: Won't Fix
> Breaking change in AbstractManager
> ---
vy merged pull request #688:
URL: https://github.com/apache/logging-log4j2/pull/688
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-
[
https://issues.apache.org/jira/browse/LOG4J2-3215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Volkan Yazici resolved LOG4J2-3215.
---
Resolution: Fixed
> Gradle instructions for adding log4j as a dependency are outdated
>
garydgregory commented on pull request #683:
URL: https://github.com/apache/logging-log4j2/pull/683#issuecomment-1008430785
I would NOT update changes.xml, this makes cherry-picking the commit to
master impossible.
--
This is an automated message from the Apache Git Service.
To respond
[
https://issues.apache.org/jira/browse/LOG4J2-3215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Volkan Yazici closed LOG4J2-3215.
-
> Gradle instructions for adding log4j as a dependency are outdated
> --
[
https://issues.apache.org/jira/browse/LOG4J2-3215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17471547#comment-17471547
]
Volkan Yazici commented on LOG4J2-3215:
---
Thanks so much [~quapka]! Replaced {{comp
[
https://issues.apache.org/jira/browse/LOG4J2-3215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Volkan Yazici updated LOG4J2-3215:
--
Fix Version/s: 2.17.2
> Gradle instructions for adding log4j as a dependency are outdated
> --
vy commented on pull request #624:
URL: https://github.com/apache/logging-log4j2/pull/624#issuecomment-1008430513
Thanks so much @quapka! Applied your changes to both `release-2.x` and
`master`.
--
This is an automated message from the Apache Git Service.
To respond to the message, pleas
[
https://issues.apache.org/jira/browse/LOG4J2-3215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17471546#comment-17471546
]
ASF subversion and git services commented on LOG4J2-3215:
-
Commi
[
https://issues.apache.org/jira/browse/LOG4J2-3323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17471545#comment-17471545
]
Gary D. Gregory commented on LOG4J2-3323:
-
IMO, this is too deep in the log4j co
[
https://issues.apache.org/jira/browse/LOG4J2-3215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17471544#comment-17471544
]
ASF subversion and git services commented on LOG4J2-3215:
-
Commi
Robert Middleton created LOGCXX-549:
---
Summary: Make networking classes independent of implementation
Key: LOGCXX-549
URL: https://issues.apache.org/jira/browse/LOGCXX-549
Project: Log4cxx
I
vy commented on pull request #690:
URL: https://github.com/apache/logging-log4j2/pull/690#issuecomment-1008423615
> Looks good. Could potentially note that the vote happens on the security
list or something.
Good point @jvz! Done.
--
This is an automated message from the Apache Gi
vy commented on pull request #671:
URL: https://github.com/apache/logging-log4j2/pull/671#issuecomment-1008422800
@ramananravi, I will do my best to pick this up as soon as possible, unless
another committer steps up.
--
This is an automated message from the Apache Git Service.
To respon
vy commented on pull request #688:
URL: https://github.com/apache/logging-log4j2/pull/688#issuecomment-1008422111
These are great additions! Thanks so much @avandeursen! I will merge the
changes as soon as build succeeds.
--
This is an automated message from the Apache Git Service.
To re
vy commented on pull request #683:
URL: https://github.com/apache/logging-log4j2/pull/683#issuecomment-1008421459
Fantastic work @atulpendse! Thanks so much!
Mind adding `SyslogAppender` tests and a `changes.xml` entry, please?
I am also not sure if a `timestampPrecision` argum
vy merged pull request #687:
URL: https://github.com/apache/logging-log4j2/pull/687
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-
vy commented on pull request #687:
URL: https://github.com/apache/logging-log4j2/pull/687#issuecomment-1008379470
Thanks so much @Arthur-Milchior! Keep these corrections coming!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
[
https://issues.apache.org/jira/browse/LOG4J2-3298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17471502#comment-17471502
]
Volkan Yazici commented on LOG4J2-3298:
---
[~mattrpav], would the following work for
[
https://issues.apache.org/jira/browse/LOG4J2-3323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17471494#comment-17471494
]
Volkan Yazici commented on LOG4J2-3323:
---
Judging from the changes incorporated in
[
https://issues.apache.org/jira/browse/LOG4J2-3321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Volkan Yazici closed LOG4J2-3321.
-
Assignee: Volkan Yazici
> Log4j complains invalid element or attribute "JsonTemplateLayout"
> --
rm5248 commented on pull request #86:
URL: https://github.com/apache/logging-log4cxx/pull/86#issuecomment-1008363348
I don't think that would provide enough value to be worth it. This at least
provides the information; clients can do what they want with the information.
Part of this
rm5248 opened a new pull request #100:
URL: https://github.com/apache/logging-log4cxx/pull/100
Implement parsing of the options for the rolling file appender.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
jmdavison46 commented on pull request #86:
URL: https://github.com/apache/logging-log4cxx/pull/86#issuecomment-1008346079
For run-time version information, what do you think of the approach taken by
OpenSSL (https://www.openssl.org), i.e. providing a function that provides the
run-time val
ramananravi commented on pull request #671:
URL: https://github.com/apache/logging-log4j2/pull/671#issuecomment-1008336846
> > @ramananravi, we think there are a few more places in the code where a
similar improvement might be handy. Mind creating a JIRA ticket for this
change, please?
[
https://issues.apache.org/jira/browse/LOGCXX-546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17471379#comment-17471379
]
Robert Middleton commented on LOGCXX-546:
-
I believe that this has been resolved,
[
https://issues.apache.org/jira/browse/LOGCXX-546?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Middleton updated LOGCXX-546:
Fix Version/s: 0.13.0
> Multi threaded applications run at single threaded speed
>
rm5248 merged pull request #86:
URL: https://github.com/apache/logging-log4cxx/pull/86
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notificatio
[
https://issues.apache.org/jira/browse/LOGCXX-548?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Middleton resolved LOGCXX-548.
-
Resolution: Fixed
> Doxygen documentation is not reproducible
> -
rm5248 merged pull request #99:
URL: https://github.com/apache/logging-log4cxx/pull/99
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notificatio
41 matches
Mail list logo
