[GitHub] [logging-log4cxx] coldtobi edited a comment on pull request #99: [LOG4CXX-548] Reproducible Doxygen doc generation

coldtobi edited a comment on pull request #99: URL: https://github.com/apache/logging-log4cxx/pull/99#issuecomment-1008185839 > The patch as given requires CMake 3.20+, but doesn't update the minimum required version. I'd like to not have to bump the CMake version if possible. Ack.

[GitHub] [logging-log4cxx] coldtobi commented on pull request #99: [LOG4CXX-548] Reproducible Doxygen doc generation

coldtobi commented on pull request #99: URL: https://github.com/apache/logging-log4cxx/pull/99#issuecomment-1008185839 > The patch as given requires CMake 3.20+, but doesn't update the minimum required version. I'd like to not have to bump the CMake version if possible. Ack. >

[jira] [Resolved] (LOGCXX-547) Allow for hiding of location data

[ https://issues.apache.org/jira/browse/LOGCXX-547?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Middleton resolved LOGCXX-547. - Resolution: Fixed Documentation and tests have been added in order to make it easy to com

[GitHub] [logging-log4cxx] rm5248 commented on pull request #99: [LOG4CXX-548] Reproducible Doxygen doc generation

rm5248 commented on pull request #99: URL: https://github.com/apache/logging-log4cxx/pull/99#issuecomment-1008162731 The patch as given requires CMake 3.20+, but doesn't update the minimum required version. I'd like to not have to bump the CMake version if possible. I changed the `c

[jira] [Updated] (LOGCXX-548) Doxygen documentation is not reproducible

[ https://issues.apache.org/jira/browse/LOGCXX-548?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Middleton updated LOGCXX-548: Fix Version/s: 0.13.0 > Doxygen documentation is not reproducible > ---

[jira] [Comment Edited] (LOG4J2-3321) Log4j complains invalid element or attribute "JsonTemplateLayout"

[ https://issues.apache.org/jira/browse/LOG4J2-3321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17471194#comment-17471194 ] Vibin Ramakrishnan edited comment on LOG4J2-3321 at 1/8/22, 9:18 PM: -

[jira] [Resolved] (LOG4J2-3321) Log4j complains invalid element or attribute "JsonTemplateLayout"

[ https://issues.apache.org/jira/browse/LOG4J2-3321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vibin Ramakrishnan resolved LOG4J2-3321. Fix Version/s: 2.17.1 Resolution: Workaround > Log4j complains invalid elem

[jira] [Comment Edited] (LOG4J2-3321) Log4j complains invalid element or attribute "JsonTemplateLayout"

[ https://issues.apache.org/jira/browse/LOG4J2-3321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17471194#comment-17471194 ] Vibin Ramakrishnan edited comment on LOG4J2-3321 at 1/8/22, 9:15 PM: -

[jira] [Comment Edited] (LOG4J2-3321) Log4j complains invalid element or attribute "JsonTemplateLayout"

[ https://issues.apache.org/jira/browse/LOG4J2-3321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17471194#comment-17471194 ] Vibin Ramakrishnan edited comment on LOG4J2-3321 at 1/8/22, 6:17 PM: -

[jira] [Comment Edited] (LOG4J2-3321) Log4j complains invalid element or attribute "JsonTemplateLayout"

[ https://issues.apache.org/jira/browse/LOG4J2-3321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17471194#comment-17471194 ] Vibin Ramakrishnan edited comment on LOG4J2-3321 at 1/8/22, 6:16 PM: -

[jira] [Commented] (LOG4J2-3321) Log4j complains invalid element or attribute "JsonTemplateLayout"

[ https://issues.apache.org/jira/browse/LOG4J2-3321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17471194#comment-17471194 ] Vibin Ramakrishnan commented on LOG4J2-3321: [~ggregory] , [~vy] , When swit

[jira] [Comment Edited] (LOG4J2-3321) Log4j complains invalid element or attribute "JsonTemplateLayout"

[ https://issues.apache.org/jira/browse/LOG4J2-3321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17470677#comment-17470677 ] Vibin Ramakrishnan edited comment on LOG4J2-3321 at 1/8/22, 6:09 PM: -

[jira] [Commented] (LOG4J2-3310) maybe some log4j-api-scala methods should be changed back to being macros

[ https://issues.apache.org/jira/browse/LOG4J2-3310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17471140#comment-17471140 ] PJ Fanning commented on LOG4J2-3310: [~mattsicker] thanks for merging the PR. I thin

[GitHub] [logging-log4cxx] coldtobi opened a new pull request #99: [LOG4CXX-548] Reproducible Doxygen doc generation

coldtobi opened a new pull request #99: URL: https://github.com/apache/logging-log4cxx/pull/99 The way the doxygen documenation is generated with CMake, it is unfortunatly not reproducible (as in https://reproducible-builds.org/). This is a regression as log4cxx has been previously

[jira] [Created] (LOGCXX-548) Doxygen documentation is not reproducible

Tobias Frost created LOGCXX-548: --- Summary: Doxygen documentation is not reproducible Key: LOGCXX-548 URL: https://issues.apache.org/jira/browse/LOGCXX-548 Project: Log4cxx Issue Type: Improveme

[GitHub] [logging-log4j2] garydgregory commented on pull request #689: [LOG4J2-3319] Add support for log4j 1.2 API bundle in Eclipse IDE

garydgregory commented on pull request #689: URL: https://github.com/apache/logging-log4j2/pull/689#issuecomment-1007870825 Should other modules include this type of change? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [logging-log4j2] vorburger commented on pull request #686: Use apache-rat-plugin's consoleOutput (and upgrade straggler versions)

vorburger commented on pull request #686: URL: https://github.com/apache/logging-log4j2/pull/686#issuecomment-1007384817 > I thought the RAT version was set in the parent POM through a property? I don't think we want to override it, do we? This PR does not override it. If you look at

[GitHub] [logging-log4j2] garydgregory commented on pull request #680: [LOG4J2-3326] Fix parsing filters from Log4j 1.2 properties configuration file

garydgregory commented on pull request #680: URL: https://github.com/apache/logging-log4j2/pull/680#issuecomment-1007372996 Hi @benjaminr-ps Thank you for your PR. Would you add a test please? Without a test there is no way to see that this fixes anything or that the undoing

[GitHub] [logging-log4j2] vorburger commented on a change in pull request #653: Release 2.x log4j-to-jul JDK Logging Bridge (LOG4J2-3282)

vorburger commented on a change in pull request #653: URL: https://github.com/apache/logging-log4j2/pull/653#discussion_r780541889 ## File path: log4j-to-jul/src/main/java/org/apache/logging/log4j/tojul/JULLogger.java ## @@ -0,0 +1,267 @@ +/* + * Licensed to the Apache Softwar

[GitHub] [logging-log4j2] carterkozak commented on a change in pull request #653: Release 2.x log4j-to-jul JDK Logging Bridge (LOG4J2-3282)

carterkozak commented on a change in pull request #653: URL: https://github.com/apache/logging-log4j2/pull/653#discussion_r780541031 ## File path: log4j-to-jul/src/main/java/org/apache/logging/log4j/tojul/JULLogger.java ## @@ -0,0 +1,267 @@ +/* + * Licensed to the Apache Softw

[GitHub] [logging-log4j2] carterkozak commented on pull request #653: Release 2.x log4j-to-jul JDK Logging Bridge (LOG4J2-3282)

carterkozak commented on pull request #653: URL: https://github.com/apache/logging-log4j2/pull/653#issuecomment-1007756608 I think this is ready to merge once level agreement is fixed :-) Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [logging-log4j2] MariusVolkhart commented on pull request #681: Fix StatusLogger Javadoc

MariusVolkhart commented on pull request #681: URL: https://github.com/apache/logging-log4j2/pull/681#issuecomment-1007435350 Yes please. It has not yet been changed there. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [logging-log4j2] garydgregory commented on pull request #686: Use apache-rat-plugin's consoleOutput (and upgrade straggler versions)

garydgregory commented on pull request #686: URL: https://github.com/apache/logging-log4j2/pull/686#issuecomment-1007365746 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [logging-log4j2] carterkozak merged pull request #653: Release 2.x log4j-to-jul JDK Logging Bridge (LOG4J2-3282)

carterkozak merged pull request #653: URL: https://github.com/apache/logging-log4j2/pull/653 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notif

[GitHub] [logging-log4j2] carterkozak commented on pull request #681: Fix StatusLogger Javadoc

carterkozak commented on pull request #681: URL: https://github.com/apache/logging-log4j2/pull/681#issuecomment-1007441197 I've handled the cherry-pick -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [logging-log4j2] vy merged pull request #681: Fix StatusLogger Javadoc

vy merged pull request #681: URL: https://github.com/apache/logging-log4j2/pull/681 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-

[GitHub] [logging-log4j2] vorburger commented on pull request #653: Release 2.x log4j-to-jul JDK Logging Bridge (LOG4J2-3282)

vorburger commented on pull request #653: URL: https://github.com/apache/logging-log4j2/pull/653#issuecomment-1007291907 > The `JULLogger` class could be package private, as the type itself is never exposed directly, only used as a cast target in tests. This would give us leniency for futu

[GitHub] [logging-log4j2] garydgregory commented on pull request #681: Fix StatusLogger Javadoc

garydgregory commented on pull request #681: URL: https://github.com/apache/logging-log4j2/pull/681#issuecomment-1007386837 Does this need to be cherry-picked to master? Gary On Fri, Jan 7, 2022, 07:53 Volkan Yazıcı ***@***.***> wrote: > Merged #681