ams-tschoening commented on a change in pull request #95:
URL: https://github.com/apache/logging-log4cxx/pull/95#discussion_r777873523
##
File path: src/main/cpp/locationinfo.cpp
##
@@ -45,16 +45,35 @@ LocationInfo::LocationInfo( const char* const fileName1,
int lineNum
[
https://issues.apache.org/jira/browse/LOG4J2-3298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17468374#comment-17468374
]
Ralph Goers commented on LOG4J2-3298:
-
This only makes sense when the referenced dat
rm5248 merged pull request #98:
URL: https://github.com/apache/logging-log4cxx/pull/98
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notificatio
swebb2066 commented on pull request #96:
URL: https://github.com/apache/logging-log4cxx/pull/96#issuecomment-1004441759
To copy a shared_ptr the reference count must be incremented, for which a
lock must be acquired.
By returning a const reference, the caller can decide whether to co
rm5248 merged pull request #97:
URL: https://github.com/apache/logging-log4cxx/pull/97
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notificatio
rm5248 merged pull request #96:
URL: https://github.com/apache/logging-log4cxx/pull/96
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notificatio
rm5248 commented on pull request #96:
URL: https://github.com/apache/logging-log4cxx/pull/96#issuecomment-1004427963
Looks good to me.
The ABI failure is not due to this change, but due to some of the other
changes that you've made(e.g. returning a reference instead of the
`shared_p
rm5248 commented on a change in pull request #95:
URL: https://github.com/apache/logging-log4cxx/pull/95#discussion_r44337
##
File path: src/main/include/log4cxx/spi/location/locationinfo.h
##
@@ -132,9 +152,28 @@ class LOG4CXX_EXPORT LocationInfo
#if !defined(__LOG4CXX_FU
[
https://issues.apache.org/jira/browse/LOG4J2-3306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ralph Goers closed LOG4J2-3306.
---
Resolution: Fixed
> OptionConverter can get a StackOverflowError.
>
rm5248 commented on a change in pull request #95:
URL: https://github.com/apache/logging-log4cxx/pull/95#discussion_r36412
##
File path: src/main/cpp/locationinfo.cpp
##
@@ -45,16 +45,35 @@ LocationInfo::LocationInfo( const char* const fileName1,
int lineNumber1 )
[
https://issues.apache.org/jira/browse/LOG4J2-3306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17468241#comment-17468241
]
ASF subversion and git services commented on LOG4J2-3306:
-
Commi
[
https://issues.apache.org/jira/browse/LOG4J2-3306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17468240#comment-17468240
]
ASF subversion and git services commented on LOG4J2-3306:
-
Commi
rm5248 commented on pull request #86:
URL: https://github.com/apache/logging-log4cxx/pull/86#issuecomment-1004401456
> The utility of LOG4CXX_VERSION_GET_{MAJOR,MINOR,PATCH,TWEAK} would be more
obvious if we were to add a version identifier object (i.e. an externally
visible integer value)
[
https://issues.apache.org/jira/browse/LOG4J2-2903?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matt Sicker updated LOG4J2-2903:
Fix Version/s: (was: Scala 12.0)
> Cannot log to HDFS with a custom appender?
> --
[
https://issues.apache.org/jira/browse/LOG4J2-3184?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matt Sicker updated LOG4J2-3184:
Fix Version/s: Scala 12.1
(was: Scala 12.0)
> Support Scala 3
> ---
[
https://issues.apache.org/jira/browse/LOG4J2-3184?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matt Sicker updated LOG4J2-3184:
Fix Version/s: Scala 12.0
(was: Scala 13.0)
> Support Scala 3
> ---
jvz merged pull request #11:
URL: https://github.com/apache/logging-log4j-scala/pull/11
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notificati
jvz merged pull request #12:
URL: https://github.com/apache/logging-log4j-scala/pull/12
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notificati
[
https://issues.apache.org/jira/browse/LOG4J2-3298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matt Pavlovich updated LOG4J2-3298:
---
Description:
Currently, if a JSON string is pushed to ThreadContext, it will be escaped. It
[
https://issues.apache.org/jira/browse/LOG4J2-3298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matt Pavlovich updated LOG4J2-3298:
---
Description:
Currently, if a JSON string is pushed to ThreadContext, it will be escaped. It
[
https://issues.apache.org/jira/browse/LOG4J2-3298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matt Pavlovich updated LOG4J2-3298:
---
Description:
Currently, if a JSON string is pushed to ThreadContext, it will be escaped. It
[
https://issues.apache.org/jira/browse/LOG4J2-3293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17468135#comment-17468135
]
Ralph Goers edited comment on LOG4J2-3293 at 1/3/22, 6:15 PM:
[
https://issues.apache.org/jira/browse/LOG4J2-3293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17468135#comment-17468135
]
Ralph Goers commented on LOG4J2-3293:
-
There are two cases:
# Someone can modify yo
[
https://issues.apache.org/jira/browse/LOG4J2-3281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17468103#comment-17468103
]
Gary D. Gregory commented on LOG4J2-3281:
-
[~coredumped]
Well, crud, I am so sor
[
https://issues.apache.org/jira/browse/LOG4J2-3293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17468049#comment-17468049
]
Eric Everman edited comment on LOG4J2-3293 at 1/3/22, 3:05 PM:
---
[
https://issues.apache.org/jira/browse/LOG4J2-3293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17468049#comment-17468049
]
Eric Everman commented on LOG4J2-3293:
--
Could someone please clarify this detail in
[
https://issues.apache.org/jira/browse/LOG4J2-3281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17468038#comment-17468038
]
Fábio Constantino commented on LOG4J2-3281:
---
[~ggregory]
Just double checked
[
https://issues.apache.org/jira/browse/LOG4J2-3281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17468005#comment-17468005
]
Gary D. Gregory commented on LOG4J2-3281:
-
If you use Maven to build make sure t
[
https://issues.apache.org/jira/browse/LOG4J2-3298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Volkan Yazici reassigned LOG4J2-3298:
-
Assignee: Volkan Yazici
> Update JSONTemplateFormat to support not escaping certain pay
[
https://issues.apache.org/jira/browse/LOG4J2-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Volkan Yazici reassigned LOG4J2-3303:
-
Assignee: Volkan Yazici
> Add support for FileSize in TB
>
[
https://issues.apache.org/jira/browse/LOG4J2-3302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17467962#comment-17467962
]
Volkan Yazici commented on LOG4J2-3302:
---
Thanks so much for the report [~nielsull]
Volkan Yazici created LOG4J2-3308:
-
Summary: Replace JsonTemplateLayout test-JAR with a separate module
Key: LOG4J2-3308
URL: https://issues.apache.org/jira/browse/LOG4J2-3308
Project: Log4j 2
[
https://issues.apache.org/jira/browse/LOG4J2-3281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17467926#comment-17467926
]
Fábio Constantino edited comment on LOG4J2-3281 at 1/3/22, 10:54 AM:
-
[
https://issues.apache.org/jira/browse/LOG4J2-3281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17467926#comment-17467926
]
Fábio Constantino commented on LOG4J2-3281:
---
[~ggregory]
Just tested working
ams-tschoening commented on a change in pull request #95:
URL: https://github.com/apache/logging-log4cxx/pull/95#discussion_r777344076
##
File path: src/main/cpp/locationinfo.cpp
##
@@ -45,16 +45,35 @@ LocationInfo::LocationInfo( const char* const fileName1,
int lineNum
35 matches
Mail list logo
