[jira] [Commented] (LOG4J2-3301) Please merge PR#18 to logging-log4j1

[ https://issues.apache.org/jira/browse/LOG4J2-3301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17467557#comment-17467557 ] ASF subversion and git services commented on LOG4J2-3301: - Commi

[GitHub] [logging-log4j2] rgoers merged pull request #677: Log4 j2 3306

rgoers merged pull request #677: URL: https://github.com/apache/logging-log4j2/pull/677 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificati

[GitHub] [logging-log4cxx] swebb2066 commented on pull request #94: LOGCXX-546] Prevent serialization of a multi-threaded application

swebb2066 commented on pull request #94: URL: https://github.com/apache/logging-log4cxx/pull/94#issuecomment-1003669899 I believe this also fixes https://issues.apache.org/jira/browse/LOGCXX-532 -- This is an automated message from the Apache Git Service. To respond to the message, please

[jira] [Commented] (LOGCXX-532) Static objects and deleting

[ https://issues.apache.org/jira/browse/LOGCXX-532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17467552#comment-17467552 ] Stephen Webb commented on LOGCXX-532: - I believe this is fixed by https://github.com/

[jira] [Commented] (LOGCXX-532) Static objects and deleting

[ https://issues.apache.org/jira/browse/LOGCXX-532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17467551#comment-17467551 ] Stephen Webb commented on LOGCXX-532: - Using std::call_once to guard the exit(0) call

[jira] [Comment Edited] (LOGCXX-532) Static objects and deleting

[ https://issues.apache.org/jira/browse/LOGCXX-532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17467538#comment-17467538 ] Stephen Webb edited comment on LOGCXX-532 at 1/2/22, 5:40 AM: -

[jira] [Commented] (LOGCXX-430) LogManager::getRootLogger is not thread-safe

[ https://issues.apache.org/jira/browse/LOGCXX-430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17467550#comment-17467550 ] Stephen Webb commented on LOGCXX-430: - I believe [https://github.com/apache/logging-

[jira] [Commented] (LOG4J2-3307) Move scripting to its own module

[ https://issues.apache.org/jira/browse/LOG4J2-3307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17467549#comment-17467549 ] ASF subversion and git services commented on LOG4J2-3307: - Commi

[jira] [Created] (LOG4J2-3307) Move scripting to its own module

Ralph Goers created LOG4J2-3307: --- Summary: Move scripting to its own module Key: LOG4J2-3307 URL: https://issues.apache.org/jira/browse/LOG4J2-3307 Project: Log4j 2 Issue Type: Improvement

[jira] [Commented] (LOGCXX-532) Static objects and deleting

[ https://issues.apache.org/jira/browse/LOGCXX-532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17467545#comment-17467545 ] Stephen Webb commented on LOGCXX-532: - Running multithreadtest repeatedly on Windows

[GitHub] [logging-log4cxx] rm5248 commented on a change in pull request #90: [LOGCXX-546] Prevent unnecessary locking when determining the logging level

rm5248 commented on a change in pull request #90: URL: https://github.com/apache/logging-log4cxx/pull/90#discussion_r777157888 ## File path: src/main/include/log4cxx/logger.h ## @@ -617,13 +617,13 @@ class LOG4CXX_EXPORT Logger : @throws RuntimeException if al

[GitHub] [logging-log4cxx] swebb2066 commented on a change in pull request #90: [LOGCXX-546] Prevent unnecessary locking when determining the logging level

swebb2066 commented on a change in pull request #90: URL: https://github.com/apache/logging-log4cxx/pull/90#discussion_r777156662 ## File path: src/main/include/log4cxx/logger.h ## @@ -617,13 +617,13 @@ class LOG4CXX_EXPORT Logger : @throws RuntimeException if

[GitHub] [logging-log4cxx] rm5248 commented on a change in pull request #90: [LOGCXX-546] Prevent unnecessary locking when determining the logging level

rm5248 commented on a change in pull request #90: URL: https://github.com/apache/logging-log4cxx/pull/90#discussion_r777156521 ## File path: src/main/include/log4cxx/logger.h ## @@ -617,13 +617,13 @@ class LOG4CXX_EXPORT Logger : @throws RuntimeException if al

[GitHub] [logging-log4cxx] rm5248 commented on a change in pull request #90: [LOGCXX-546] Prevent unnecessary locking when determining the logging level

rm5248 commented on a change in pull request #90: URL: https://github.com/apache/logging-log4cxx/pull/90#discussion_r777156489 ## File path: src/main/include/log4cxx/logger.h ## @@ -617,13 +617,13 @@ class LOG4CXX_EXPORT Logger : @throws RuntimeException if al

[jira] [Comment Edited] (LOGCXX-532) Static objects and deleting

[ https://issues.apache.org/jira/browse/LOGCXX-532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17467538#comment-17467538 ] Stephen Webb edited comment on LOGCXX-532 at 1/2/22, 1:44 AM: -

[jira] [Commented] (LOGCXX-532) Static objects and deleting

[ https://issues.apache.org/jira/browse/LOGCXX-532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17467538#comment-17467538 ] Stephen Webb commented on LOGCXX-532: - Running multithreadtest repeatedly eventually

[jira] [Created] (LOGCXX-547) Allow for hiding of location data

Robert Middleton created LOGCXX-547: --- Summary: Allow for hiding of location data Key: LOGCXX-547 URL: https://issues.apache.org/jira/browse/LOGCXX-547 Project: Log4cxx Issue Type: Improveme

[GitHub] [logging-log4cxx] swebb2066 commented on a change in pull request #90: [LOGCXX-546] Prevent unnecessary locking when determining the logging level

swebb2066 commented on a change in pull request #90: URL: https://github.com/apache/logging-log4cxx/pull/90#discussion_r777155197 ## File path: src/main/include/log4cxx/logger.h ## @@ -617,13 +617,13 @@ class LOG4CXX_EXPORT Logger : @throws RuntimeException if

[GitHub] [logging-log4cxx] rm5248 commented on a change in pull request #90: [LOGCXX-546] Prevent unnecessary locking when determining the logging level

rm5248 commented on a change in pull request #90: URL: https://github.com/apache/logging-log4cxx/pull/90#discussion_r777154659 ## File path: src/main/include/log4cxx/logger.h ## @@ -617,13 +617,13 @@ class LOG4CXX_EXPORT Logger : @throws RuntimeException if al

[GitHub] [logging-log4cxx] rm5248 commented on a change in pull request #93: Add a unit test for the automatic configuration feature

rm5248 commented on a change in pull request #93: URL: https://github.com/apache/logging-log4cxx/pull/93#discussion_r777154247 ## File path: src/main/cpp/aprinitializer.cpp ## @@ -127,3 +127,21 @@ void APRInitializer::unregisterCleanup(FileWatchdog* watchdog) } } +v

[GitHub] [logging-log4cxx] rm5248 commented on a change in pull request #93: Add a unit test for the automatic configuration feature

rm5248 commented on a change in pull request #93: URL: https://github.com/apache/logging-log4cxx/pull/93#discussion_r777154084 ## File path: src/main/cpp/logmanager.cpp ## @@ -47,28 +47,19 @@ using namespace log4cxx::helpers; IMPLEMENT_LOG4CXX_OBJECT(DefaultRepositorySelector)

[GitHub] [logging-log4cxx] swebb2066 commented on a change in pull request #90: [LOGCXX-546] Prevent unnecessary locking when determining the logging level

swebb2066 commented on a change in pull request #90: URL: https://github.com/apache/logging-log4cxx/pull/90#discussion_r777152029 ## File path: src/main/include/log4cxx/logger.h ## @@ -617,13 +617,13 @@ class LOG4CXX_EXPORT Logger : @throws RuntimeException if

[GitHub] [logging-log4cxx] swebb2066 commented on a change in pull request #90: [LOGCXX-546] Prevent unnecessary locking when determining the logging level

swebb2066 commented on a change in pull request #90: URL: https://github.com/apache/logging-log4cxx/pull/90#discussion_r777152029 ## File path: src/main/include/log4cxx/logger.h ## @@ -617,13 +617,13 @@ class LOG4CXX_EXPORT Logger : @throws RuntimeException if

[GitHub] [logging-log4cxx] swebb2066 commented on pull request #94: LOGCXX-546] Prevent serialization of a multi-threaded application

swebb2066 commented on pull request #94: URL: https://github.com/apache/logging-log4cxx/pull/94#issuecomment-1003641406 To determine the cost of Logger holding a weak pointer instead of a raw pointer as in this PR, I experimently changed m_priv->repository to a std::weak_ptr. The result s

[GitHub] [logging-log4cxx] swebb2066 commented on a change in pull request #93: Add a unit test for the automatic configuration feature

swebb2066 commented on a change in pull request #93: URL: https://github.com/apache/logging-log4cxx/pull/93#discussion_r777150343 ## File path: src/main/cpp/logmanager.cpp ## @@ -47,28 +47,19 @@ using namespace log4cxx::helpers; IMPLEMENT_LOG4CXX_OBJECT(DefaultRepositorySelect

[GitHub] [logging-log4cxx] swebb2066 commented on a change in pull request #93: Add a unit test for the automatic configuration feature

swebb2066 commented on a change in pull request #93: URL: https://github.com/apache/logging-log4cxx/pull/93#discussion_r777150208 ## File path: src/main/cpp/aprinitializer.cpp ## @@ -127,3 +127,21 @@ void APRInitializer::unregisterCleanup(FileWatchdog* watchdog) } }

[GitHub] [logging-log4cxx] swebb2066 commented on a change in pull request #90: [LOGCXX-546] Prevent unnecessary locking when determining the logging level

swebb2066 commented on a change in pull request #90: URL: https://github.com/apache/logging-log4cxx/pull/90#discussion_r777147352 ## File path: src/main/include/log4cxx/logger.h ## @@ -617,13 +617,13 @@ class LOG4CXX_EXPORT Logger : @throws RuntimeException if

[GitHub] [logging-log4cxx] swebb2066 commented on a change in pull request #90: [LOGCXX-546] Prevent unnecessary locking when determining the logging level

swebb2066 commented on a change in pull request #90: URL: https://github.com/apache/logging-log4cxx/pull/90#discussion_r777147352 ## File path: src/main/include/log4cxx/logger.h ## @@ -617,13 +617,13 @@ class LOG4CXX_EXPORT Logger : @throws RuntimeException if

[GitHub] [logging-log4cxx] swebb2066 commented on a change in pull request #90: [LOGCXX-546] Prevent unnecessary locking when determining the logging level

swebb2066 commented on a change in pull request #90: URL: https://github.com/apache/logging-log4cxx/pull/90#discussion_r777147352 ## File path: src/main/include/log4cxx/logger.h ## @@ -617,13 +617,13 @@ class LOG4CXX_EXPORT Logger : @throws RuntimeException if

[GitHub] [logging-log4cxx] swebb2066 commented on a change in pull request #90: [LOGCXX-546] Prevent unnecessary locking when determining the logging level

swebb2066 commented on a change in pull request #90: URL: https://github.com/apache/logging-log4cxx/pull/90#discussion_r777147352 ## File path: src/main/include/log4cxx/logger.h ## @@ -617,13 +617,13 @@ class LOG4CXX_EXPORT Logger : @throws RuntimeException if

[GitHub] [logging-log4cxx] swebb2066 commented on a change in pull request #90: [LOGCXX-546] Prevent unnecessary locking when determining the logging level

swebb2066 commented on a change in pull request #90: URL: https://github.com/apache/logging-log4cxx/pull/90#discussion_r777147352 ## File path: src/main/include/log4cxx/logger.h ## @@ -617,13 +617,13 @@ class LOG4CXX_EXPORT Logger : @throws RuntimeException if

[jira] [Commented] (LOG4J2-3295) Reconfiguration failure with an error

[ https://issues.apache.org/jira/browse/LOG4J2-3295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17467462#comment-17467462 ] Ralph Goers commented on LOG4J2-3295: - Mike, It occurs to me that the reason things

[jira] [Commented] (LOG4J2-3281) PropertiesConfiguration.buildAppender not adding filters to custom appender

[ https://issues.apache.org/jira/browse/LOG4J2-3281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17467443#comment-17467443 ] ASF subversion and git services commented on LOG4J2-3281: - Commi

[GitHub] [logging-log4cxx] rm5248 commented on a change in pull request #90: [LOGCXX-546] Prevent unnecessary locking when determining the logging level

rm5248 commented on a change in pull request #90: URL: https://github.com/apache/logging-log4cxx/pull/90#discussion_r776893142 ## File path: src/main/include/log4cxx/logger.h ## @@ -617,13 +617,13 @@ class LOG4CXX_EXPORT Logger : @throws RuntimeException if al

[GitHub] [logging-log4cxx] rm5248 commented on pull request #93: Add a unit test for the automatic configuration feature

rm5248 commented on pull request #93: URL: https://github.com/apache/logging-log4cxx/pull/93#issuecomment-1003560920 Apparently I forgot to submit my review comments, but those are above. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [logging-log4cxx] rm5248 commented on a change in pull request #86: Update log4cxx.h.in

rm5248 commented on a change in pull request #86: URL: https://github.com/apache/logging-log4cxx/pull/86#discussion_r773494809 ## File path: src/main/include/log4cxx/log4cxx.h.in ## @@ -29,10 +29,14 @@ #define LOG4CXX_VERSION_MINOR @log4cxx_VERSION_MINOR@ #define LOG4CXX_VERS

[GitHub] [logging-log4cxx] rm5248 commented on a change in pull request #93: Add a unit test for the automatic configuration feature

rm5248 commented on a change in pull request #93: URL: https://github.com/apache/logging-log4cxx/pull/93#discussion_r776895762 ## File path: src/main/cpp/aprinitializer.cpp ## @@ -127,3 +127,21 @@ void APRInitializer::unregisterCleanup(FileWatchdog* watchdog) } } +v

[jira] [Commented] (LOG4J2-3267) Getting public access to org.apache.logging.log4j.core.tools.Generate#generate method for automated code generation

[ https://issues.apache.org/jira/browse/LOG4J2-3267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17467424#comment-17467424 ] Gotthard Witsch commented on LOG4J2-3267: - Thanks for implementing this so fast